Clean up bus probe error handling by separating success and error paths.
Signed-off-by: Johan Hovold jo...@kernel.org
---
This one applies on top of the three usb-serial bus probe fixes I just
posted.
drivers/usb/serial/bus.c | 25 ++---
1 file changed, 14 insertions(+),
From 467794e88dc08f61e1068c510c97baa9a12b841d Mon Sep 17 00:00:00 2001
From: Nicolas PLANEL nicolas.pla...@enovance.com
Date: Tue, 17 Feb 2015 00:59:14 -0500
Subject: [PATCH] USB: ch341: set tty baud speed according to tty struct
The ch341_set_baudrate() function initialize the device baud speed
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Tue, Feb 17, 2015 at 11:09:14AM +0100, faivre.laur...@laposte.net wrote:
'cat' works fine in my case on another computer (the device behind only send
data).
With this same device?
It's the
Add missing error handling when registering the tty device at port
probe. This avoids trying to remove an uninitialised character device
when the port device is removed.
Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
Reported-by: Takashi Iwai ti...@suse.de
Cc: stable sta...@vger.kernel.org # v2.6.12
Fix return value in probe error path, which could end up returning
success (0) on errors. This could in turn lead to use-after-free or
double free (e.g. in port_remove) when the port device is removed.
Fixes: c706ebdfc895 (USB: usb-serial: call port_probe and port_remove
at the right times)
Cc:
Fix attribute-creation race with userspace by using the port device
groups field to create the port attributes.
Also use %u when printing the port number, which is unsigned, even
though we do not currently support more than 128 ports per device.
Reported-by: Takashi Iwai ti...@suse.de
On Tue, Feb 17, 2015 at 10:11:55AM -0500, Nicolas PLANEL wrote:
Hi,
According to git log your are currently the two maintainer of the ch341 usb
serial driver.
Thanks to pyserial, that did not initialize the serial port speed like
minicom.
Basically pyserial only set the port speed
On Wed, Feb 18, 2015 at 10:34:50AM +0700, Johan Hovold wrote:
Fix return value in probe error path, which could end up returning
success (0) on errors. This could in turn lead to use-after-free or
double free (e.g. in port_remove) when the port device is removed.
Fixes: c706ebdfc895 (USB:
On Wed, Feb 18, 2015 at 11:32:38AM +0700, Johan Hovold wrote:
On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote:
I believe the fix should be implemented slightly differently however.
Most usb-serial driver call set_termios from open to handle this issue.
It looks like you could
In order to support an older USB cradle by Denso, I added its vendor- and
product-ID to the array of usb_device_id acm_ids. In this way cdc-acm feels
responsible for this cradle. The related /dev/ttyACM node is being created
properly, and the data transfer works.
However, later cradle models
W dniu 17.02.2015 o 22:02, Ruslan Bilovol pisze:
Hi Andrzej,
On Mon, Feb 16, 2015 at 10:07 AM, Andrzej Pietrasiewicz
andrze...@samsung.com wrote:
W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze:
snip
In my opinion all things which you have described are working out-of-box
when you use
On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote:
From 467794e88dc08f61e1068c510c97baa9a12b841d Mon Sep 17 00:00:00 2001
From: Nicolas PLANEL nicolas.pla...@enovance.com
Date: Tue, 17 Feb 2015 00:59:14 -0500
Subject: [PATCH] USB: ch341: set tty baud speed according to tty struct
Fix null-pointer dereference at probe when the device is used as a
console, in which case the tty argument to open will be NULL.
Fixes: ee467a1f2066 (USB: serial: add Moxa UPORT 12XX/14XX/16XX
driver)
Cc: stable sta...@vger.kernel.org # v3.14
Signed-off-by: Johan Hovold jo...@kernel.org
---
On Wed, Feb 18, 2015 at 11:51:07AM +0700, Johan Hovold wrote:
Fix null-pointer dereference at probe when the device is used as a
console, in which case the tty argument to open will be NULL.
Fixes: ee467a1f2066 (USB: serial: add Moxa UPORT 12XX/14XX/16XX
driver)
Cc: stable
temp sha wrote:
Can any one brief me about the concept of default/target product id /vendor
id ?
These are not terms that have a well-known meaning. Where did you hear them?
And what is the actual problem you're trying to solve?
Regards,
Clemens
--
To unsubscribe from this list: send the
Hi,
On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote:
Add usb phy controller for hi6220 platform
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
---
drivers/phy/Kconfig | 9 ++
drivers/phy/Makefile | 1 +
drivers/phy/phy-hi6220-usb.c | 306
On Tue, Feb 17, 2015 at 10:45:11PM -0500, Nicolas PLANEL wrote:
From 467794e88dc08f61e1068c510c97baa9a12b841d Mon Sep 17 00:00:00 2001
From: Nicolas PLANEL nicolas.pla...@enovance.com
Date: Tue, 17 Feb 2015 00:59:14 -0500
Subject: [PATCH] USB: ch341: set tty baud speed according to tty struct
Hi, Kishon
On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote:
Hi,
On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote:
Add usb phy controller for hi6220 platform
Signed-off-by: Zhangfei Gao zhangfei@linaro.org
---
drivers/phy/Kconfig | 9 ++
drivers/phy/Makefile
Hi,
Can any one brief me about the concept of default/target product id /vendor id ?
Or any link explaining the same.
Thanks
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Tue, Feb 17, 2015 at 17:32:40 +0100, Aleksander Morgado wrote:
On Tue, Feb 17, 2015 at 4:32 PM, Sami Farin hvtaifwkbgefb...@gmail.com
wrote:
I have this USB ID 12d1:157d, Sonera Opengate LTE.
It says all is okay but no packets are moving.
With the SIM card in Lumia I get 50/25 Mbit/s.
On Tue, 17 Feb 2015, Felipe Balbi wrote:
On Tue, Feb 17, 2015 at 09:55:21AM -0500, Alan Stern wrote:
On Mon, 16 Feb 2015, Felipe Balbi wrote:
Electrical tests for resume signaling. It failed with a specific hub,
however :-) But it's easy to note with dwc3/musb and a USB sniffer.
On Tue, Feb 17, 2015 at 01:10:40PM +0100, Björn Gerhart wrote:
Hello,
in order to support an older USB cradle by Denso, I added its vendor-
and product-ID to the array of usb_device_id acm_ids. In this way
cdc-acm feels responsible for this cradle. The related /dev/ttyACM
node is being
On Tue, Feb 17, 2015 at 4:32 PM, Sami Farin hvtaifwkbgefb...@gmail.com wrote:
I have this USB ID 12d1:157d, Sonera Opengate LTE.
It says all is okay but no packets are moving.
With the SIM card in Lumia I get 50/25 Mbit/s.
linux 3.19, Fedora 21, usb-modeswitch-2.2.1, usb_modeswitch-data
On Tue, Feb 17, 2015 at 09:55:21AM -0500, Alan Stern wrote:
On Mon, 16 Feb 2015, Felipe Balbi wrote:
Electrical tests for resume signaling. It failed with a specific hub,
however :-) But it's easy to note with dwc3/musb and a USB sniffer.
Sometimes resume signalling is cut before 20ms
I have this USB ID 12d1:157d, Sonera Opengate LTE.
It says all is okay but no packets are moving.
With the SIM card in Lumia I get 50/25 Mbit/s.
linux 3.19, Fedora 21, usb-modeswitch-2.2.1, usb_modeswitch-data 20150115, Asus
P8Z68-V PRO GEN3,
NetworkManager-1.0.0-4.fc22, libmbim-1.12.0-1.fc22,
Hi,
According to git log your are currently the two maintainer of the ch341
usb serial driver.
Thanks to pyserial, that did not initialize the serial port speed like
minicom.
Basically pyserial only set the port speed (calling TIOCSSERIAL ioctl)
if the user request a different value
On Tue, Feb 17, 2015 at 10:06:07AM +, David Laight wrote:
From: Greg KH
+ for (i = 0 ; i urb-actual_length ; i += 2) {
+ tty_flag = TTY_NORMAL;
+
+ if (unlikely(data[i+0] UART_LSR_BRK_ERROR_BITS)) {
Never use unlikely() unless you can prove that it actually
On Mon, 16 Feb 2015, Felipe Balbi wrote:
Electrical tests for resume signaling. It failed with a specific hub,
however :-) But it's easy to note with dwc3/musb and a USB sniffer.
Sometimes resume signalling is cut before 20ms because we had msleep(20)
:-)
Maybe that should be reported to the
Hi there,
I've got a driver which maintains a pool of URBs, properly created via
usb_alloc_urb(). Separately I have a cleanup function which destroys
the pool by looping through the list and calling usb_kill_urb(),
freeing the urb-transfer_buffer, and then calling usb_free_urb().
There are some
Hi,
I have a usb network device where part of functionality is implemented
in firmware. To communicate with the firmware I need to submit bulk
URBs to one of the EPs. Unfortunately when device is being unbound or
the driver is removed from the kernel EPs are disabled before
.disconnect() is
On Tue, Feb 17, 2015 at 01:41:37PM +0800, Sneeker Yeh wrote:
This patch adds support for Synopsis DesignWare USB3 IP Core found
on Fujitsu Socs.
Signed-off-by: Sneeker Yeh sneeker@tw.fujitsu.com
---
.../devicetree/bindings/usb/fujitsu-dwc3.txt | 33
Hi,
On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote:
(3) Platform has 2 USB controllers connected to same port: one for
device and one for host role. D+/- are switched between phys
by GPIO.
so you have discrete mux with a GPIO select signal, like below
Hi,
Adding Mika.
On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote:
Hi,
On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote:
(3) Platform has 2 USB controllers connected to same port: one for
device and one for host role. D+/- are switched between phys
# ethtool -S wwp3s0u1c2
NIC statistics:
tx_reason_ntb_full: 0
tx_reason_ndp_full: 0
tx_reason_timeout: 363
tx_reason_max_datagram: 0
tx_overhead: 71950
tx_ntbs: 363
rx_overhead: 0
rx_ntbs: 0
--
Do what you love because life is too short for anything else.
On Tue, Feb 17, 2015 at 5:50 PM, Sami Farin hvtaifwkbgefb...@gmail.com wrote:
On Tue, Feb 17, 2015 at 17:32:40 +0100, Aleksander Morgado wrote:
On Tue, Feb 17, 2015 at 4:32 PM, Sami Farin hvtaifwkbgefb...@gmail.com
wrote:
I have this USB ID 12d1:157d, Sonera Opengate LTE.
It says all is
Greg KH g...@kroah.com hat am 17. Februar 2015 um 15:55 geschrieben:
On Tue, Feb 17, 2015 at 01:10:40PM +0100, Björn Gerhart wrote:
Hello,
in order to support an older USB cradle by Denso, I added its
vendor-
and product-ID to the array of usb_device_id acm_ids. In this way
Hi Felipe and Linus,
On Thu, Dec 25, 2014 at 10:49:29PM -0600, Felipe Balbi wrote:
Hi,
On Wed, Dec 24, 2014 at 02:43:27PM -0800, David Cohen wrote:
Hi Felipe,
Thanks replying.
On Tue, Dec 23, 2014 at 06:29:04PM -0600, Felipe Balbi wrote:
Hi,
On Mon, Dec 22, 2014 at
Hi Linus,
Thanks for reviewing.
On Thu, Jan 08, 2015 at 08:23:03PM +0100, Linus Walleij wrote:
On Mon, Dec 22, 2014 at 11:43 PM, David Cohen
david.a.co...@linux.intel.com wrote:
Some platforms have an USB OTG port fully (or partially) controlled by
GPIOs:
(1) USB ID is connected
Always read bInterfaceNumber from the current altsetting, not from the first one
available in the altsetting array. This is coming from code review, not related
to any specific bug.
Signed-off-by: Aleksander Morgado aleksan...@aleksander.es
---
drivers/net/usb/hso.c | 13 +
1 file
From: Greg KH
+ for (i = 0 ; i urb-actual_length ; i += 2) {
+ tty_flag = TTY_NORMAL;
+
+ if (unlikely(data[i+0] UART_LSR_BRK_ERROR_BITS)) {
Never use unlikely() unless you can prove that it actually matters if
you use it. Hint, it's almost impossible to prove,
'cat' works fine in my case on another computer (the device behind only
send data).
It's the same result with minicom (I just tried again).
If I use directly the ftdi driver, I can set parameters but I can't read
data, like the serial port was closed.
If I add device id by hand, I can read
On Tue, 17 Feb 2015, Devin Heitmueller wrote:
Hi there,
I've got a driver which maintains a pool of URBs, properly created via
usb_alloc_urb(). Separately I have a cleanup function which destroys
the pool by looping through the list and calling usb_kill_urb(),
freeing the
Hi Andrzej,
On Mon, Feb 16, 2015 at 10:07 AM, Andrzej Pietrasiewicz
andrze...@samsung.com wrote:
W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze:
snip
In my opinion all things which you have described are working out-of-box
when you use configfs interface. It's mostly ready so you may
On Tue, 17 Feb 2015, Jakub Kicinski wrote:
Hi,
I have a usb network device where part of functionality is implemented
in firmware. To communicate with the firmware I need to submit bulk
URBs to one of the EPs. Unfortunately when device is being unbound or
the driver is removed from the
On Tue, 17 Feb 2015 15:58:30 -0500 (EST), Alan Stern wrote:
On Tue, 17 Feb 2015, Jakub Kicinski wrote:
Hi,
I have a usb network device where part of functionality is implemented
in firmware. To communicate with the firmware I need to submit bulk
URBs to one of the EPs. Unfortunately
On Tue, Feb 17, 2015 at 08:18:35PM +0100, Björn Gerhart wrote:
Greg KH g...@kroah.com hat am 17. Februar 2015 um 15:55 geschrieben:
On Tue, Feb 17, 2015 at 01:10:40PM +0100, Björn Gerhart wrote:
Hello,
in order to support an older USB cradle by Denso, I added its
vendor-
This patchset adds independent registration of gadgets
and gadget drivers to udc-core. This is very useful for
built-in modules into kernel case since it's possible
situation that gadget driver is probing at a time
when no gadgets are registered in udc-core.
In this case instead of silently
Now when udc-core supports binding to specific UDC by passing
its name via 'udc_name' member of usb_gadget_driver struct,
switch to this generic approach.
Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com
---
drivers/usb/gadget/configfs.c | 27 ++-
1 file changed, 14
Change behavior during registration of gadgets and
gadget drivers in udc-core. Instead of previous
approach when for successful probe of usb gadget driver
at least one usb gadget should be already registered
use another one where gadget drivers and gadgets
can be registered in udc-core
Introduce new 'udc_name' member to usb_gadget_driver structure.
The 'udc_name' is a name of UDC that usb_gadget_driver should
be bound to. If udc_name is NULL, it will be bound to any
available UDC.
Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com
---
drivers/usb/gadget/udc/udc-core.c | 25
Now when last user of usb_udc_attach_driver() is switched
to passing UDC name via usb_gadget_driver struct, it's safe
to remove this function
Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com
---
drivers/usb/gadget/udc/udc-core.c | 26 --
include/linux/usb/gadget.h
In order to prepare to independent gadgets and
gadget drivers registration in udc-core, some of the
functions can't have __init/__exit attributes (almost
only bind/unbind callbacks are affected)
Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com
---
drivers/usb/gadget/legacy/acm_ms.c |
In order to support an older USB cradle by Denso, I added its vendor-
and product-ID to the array of usb_device_id acm_ids. In this way
cdc-acm feels responsible for this cradle. The related /dev/ttyACM node
is being created properly, and the data transfer works.
However, later cradle models by
On Tue, 17 Feb 2015, Ruslan Bilovol wrote:
Change behavior during registration of gadgets and
gadget drivers in udc-core. Instead of previous
approach when for successful probe of usb gadget driver
at least one usb gadget should be already registered
use another one where gadget drivers and
On Tue, Feb 17, 2015 at 10:43:40PM +0100, Björn Gerhart wrote:
In order to support an older USB cradle by Denso, I added its vendor-
and product-ID to the array of usb_device_id acm_ids. In this way
cdc-acm feels responsible for this cradle. The related /dev/ttyACM node
is being created
On Mon, Feb 16, 2015 at 03:57:54PM +0800, Peter Hung wrote:
The interrupt Endpoint will report current IIR. If we got IIR with MSR Changed
, We will do read MSR with interrupt_work worker to do f81232_read_msr() func.
Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com
---
On Mon, Feb 16, 2015 at 03:57:56PM +0800, Peter Hung wrote:
The original driver had do not any h/w change in driver.
This patch implements with configure H/W for
baud/parity/word length/stop bits functional.
Some init step extract to f81232_port_init(), called once with open().
And refine
On Mon, Feb 16, 2015 at 03:58:00PM +0800, Peter Hung wrote:
When we use RS232 loopback, assume doing RTS change will cause
CTS change, DTR change will cause DCD/DSR change too.
Sometimes we got 7~4 bits of MSR changed but the 3~0 bits of
MSR(delta) maybe not changed when set get MCR
On Mon, Feb 16, 2015 at 03:57:57PM +0800, Peter Hung wrote:
This patch implement relative MCR/MSR function, such like
tiocmget()/tiocmset()/dtr_rts().
The f81232_set_mctrl() replace set_control_lines() to do MCR control
so we clean-up the set_control_lines() function.
Signed-off-by: Peter
On Mon, Feb 16, 2015 at 03:57:59PM +0800, Peter Hung wrote:
It's should compared with UART_MSR_DCD, not UART_DCD.
also we clean-up some non-used define to avoid impropriety use.
Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com
---
drivers/usb/serial/f81232.c | 16 +---
Hello.
On 2/17/2015 4:45 AM, Joseph Kogut wrote:
Signed-off-by: Joseph Kogut joseph.ko...@gmail.com
[...]
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index e63c02a..38cff8f 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2315,6 +2315,8 @@
#define
Hello,
in order to support an older USB cradle by Denso, I added its vendor-
and product-ID to the array of usb_device_id acm_ids. In this way
cdc-acm feels responsible for this cradle. The related /dev/ttyACM
node is being created properly, and the data transfer works.
However, later cradle
On 2/17/2015 3:20 PM, Sergei Shtylyov wrote:
Signed-off-by: Joseph Kogut joseph.ko...@gmail.com
[...]
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index e63c02a..38cff8f 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2315,6 +2315,8 @@
#define
63 matches
Mail list logo
