[PATCH v2] USB: don't build PCI quirks if USB support isn't configured

2015-04-22 Thread Alan Stern
The USB PCI quirks code gets built into the kernel whenever CONFIG_PCI is enabled, even if CONFIG_USB is not set. This can cause unnecessary messages to show up in the kernel log, such as CONFIG_USB_XHCI_HCD is turned off, defaulting to EHCI (which makes no sense when the kernel has been

Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-22 Thread Jan Kaisrlik
2015-04-21 17:51 GMT+00:00 Florian Fainelli f.faine...@gmail.com: On 21/04/15 10:39, Andrew Lunn wrote: I would however say that sysfs is the wrong API. The linux network stack uses netlink for most configuration activities. So i would suggest adding a netlink binding to DSA, and place the

Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-22 Thread Andrew Lunn
On Wed, Apr 22, 2015 at 04:14:33PM +, Jan Kaisrlik wrote: 2015-04-21 17:51 GMT+00:00 Florian Fainelli f.faine...@gmail.com: On 21/04/15 10:39, Andrew Lunn wrote: I would however say that sysfs is the wrong API. The linux network stack uses netlink for most configuration activities. So i

Re: default value of power/wakeup

2015-04-22 Thread Alan Stern
On Wed, 22 Apr 2015, Greg KH wrote: Index: usb-4.0/drivers/hid/hid-logitech-dj.c === --- usb-4.0.orig/drivers/hid/hid-logitech-dj.c +++ usb-4.0/drivers/hid/hid-logitech-dj.c @@ -990,6 +990,7 @@ static int

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Greg Kroah-Hartman
On Wed, Apr 22, 2015 at 04:20:39PM +0200, Johan Hovold wrote: On Wed, Apr 22, 2015 at 02:38:00PM +0200, Greg Kroah-Hartman wrote: On Wed, Apr 22, 2015 at 01:20:38PM +0200, Johan Hovold wrote: On Wed, Apr 22, 2015 at 12:14:05PM +0200, Jason A. Donenfeld wrote: Samsung has just released a

Re: default value of power/wakeup

2015-04-22 Thread Alan Stern
On Wed, 22 Apr 2015, Tom Yan wrote: On 21 April 2015 at 23:51, Alan Stern st...@rowland.harvard.edu wrote: Anyway, you're suggesting that drivers should never override sysfs attribute values. But there doesn't seem to be any other way to implement the kernel's policy that wakeup should be

[PATCH 1/2] pl2303: Remove support for Samsung I330

2015-04-22 Thread Jason A. Donenfeld
This phone is already supported by the visor driver. Signed-off-by: Jason A. Donenfeld ja...@zx2c4.com --- drivers/usb/serial/pl2303.c | 1 - drivers/usb/serial/pl2303.h | 4 2 files changed, 5 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index

[PATCH 2/2] visor: Match I330 phone more precisely

2015-04-22 Thread Jason A. Donenfeld
Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID results in conflicts with the

RE: usb: gadget: g_multi does not work with net2280

2015-04-22 Thread Alan Stern
On Wed, 22 Apr 2015, Praveen Murali wrote: -Original Message- From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] Sent: Tuesday, April 21, 2015 1:33 AM To: Praveen Murali Cc: linux-usb@vger.kernel.org; ba...@ti.com; min...@mina86.com Subject: Re: usb:

[PATCH 1/2] visor: Remove support for Samsung I330

2015-04-22 Thread Jason A. Donenfeld
This phone is actually a pl2303 device, and is already supported there. Signed-off-by: Jason A. Donenfeld ja...@zx2c4.com --- drivers/usb/serial/visor.c | 2 -- drivers/usb/serial/visor.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c

[PATCH 2/2] pl2303: Match I330 phone more precisely

2015-04-22 Thread Jason A. Donenfeld
Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. Its USB ID is 04e8:8001, which unfortunately is already used by the pl2303 driver for the Samsung I330 phone cradle. Having pl2303 pick up this device ID results in conflicts with the usb-storage driver,

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Johan Hovold
On Wed, Apr 22, 2015 at 02:38:00PM +0200, Greg Kroah-Hartman wrote: On Wed, Apr 22, 2015 at 01:20:38PM +0200, Johan Hovold wrote: On Wed, Apr 22, 2015 at 12:14:05PM +0200, Jason A. Donenfeld wrote: Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor.

Re: [PATCH 2/2] visor: Match I330 phone more precisely

2015-04-22 Thread Johan Hovold
On Wed, Apr 22, 2015 at 02:35:09PM +0200, Jason A. Donenfeld wrote: Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the Palm Visor driver for the Samsung I330 phone cradle. Having

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Greg Kroah-Hartman
On Wed, Apr 22, 2015 at 01:20:38PM +0200, Johan Hovold wrote: On Wed, Apr 22, 2015 at 12:14:05PM +0200, Jason A. Donenfeld wrote: Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Greg Kroah-Hartman
On Wed, Apr 22, 2015 at 02:42:20PM +0200, Jason A. Donenfeld wrote: On Wed, Apr 22, 2015 at 2:38 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: I'd bet this is really a pl2303 device, given that the visor driver was just a dumb pipe to the device and the pilot sync tools never

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Johan Hovold
On Wed, Apr 22, 2015 at 04:58:44PM +0200, Greg Kroah-Hartman wrote: On Wed, Apr 22, 2015 at 04:20:39PM +0200, Johan Hovold wrote: On Wed, Apr 22, 2015 at 02:38:00PM +0200, Greg Kroah-Hartman wrote: On Wed, Apr 22, 2015 at 01:20:38PM +0200, Johan Hovold wrote: On Wed, Apr 22, 2015 at

Re: default value of power/wakeup

2015-04-22 Thread Greg KH
On Wed, Apr 22, 2015 at 11:28:29AM -0400, Alan Stern wrote: On Wed, 22 Apr 2015, Tom Yan wrote: On 21 April 2015 at 23:51, Alan Stern st...@rowland.harvard.edu wrote: Anyway, you're suggesting that drivers should never override sysfs attribute values. But there doesn't seem to be any

Re: usb: gadget: g_multi does not work with net2280

2015-04-22 Thread rajeev kumar
Praveen, On Wed, Apr 22, 2015 at 11:19 AM, Praveen Murali pmur...@logicube.com wrote: Hi Rajeev, -Original Message- From: rajeev kumar [mailto:rajeevkumar.li...@gmail.com] Sent: Tuesday, April 21, 2015 10:22 PM To: Praveen Murali Cc: Ricardo Ribalda Delgado;

Re: default value of power/wakeup

2015-04-22 Thread Greg KH
On Wed, Apr 22, 2015 at 12:15:36PM -0400, Alan Stern wrote: On Wed, 22 Apr 2015, Greg KH wrote: Index: usb-4.0/drivers/hid/hid-logitech-dj.c === --- usb-4.0.orig/drivers/hid/hid-logitech-dj.c +++

Re: default value of power/wakeup

2015-04-22 Thread Alan Stern
On Wed, 22 Apr 2015, Greg KH wrote: But this device isn't always a keyboard. For example, mine works with a mouse. It's a universal receiver, you can't know what type of HID device is plugged into it until it connects to it. I don't mind making it auto wakeup, if that works, but

Re: default value of power/wakeup

2015-04-22 Thread Greg KH
On Wed, Apr 22, 2015 at 02:22:44PM -0400, Alan Stern wrote: On Wed, 22 Apr 2015, Greg KH wrote: But this device isn't always a keyboard. For example, mine works with a mouse. It's a universal receiver, you can't know what type of HID device is plugged into it until it connects to

Re: [RFC][PATCH v2 00/13] USB: OTG/DRD Core functionality

2015-04-22 Thread Peter Chen
On Wed, Apr 22, 2015 at 03:42:32PM +0300, Roger Quadros wrote: So we will have a separate drd fsm file, and the CONFIG_USB_OTG and CONFIG_USB_OTG_FSM are not needed to be defined, right? for drd case CONFIG_USB_OTG_FSM is definitely not needed. I'm not sure if we can operate dual-role

RE: default value of power/wakeup

2015-04-22 Thread Peter Chen
Oh, okay, I didn't realize that. Is there a reasonable way to enable wakeup only when the driver learns that a keyboard is connected? Where would the driver do this? I don't know if the driver ever knows this, as you can pair lots of different devices to this same receiver.

Re: [PATCH v2] USB: don't build PCI quirks if USB support isn't configured

2015-04-22 Thread Tal Shorer
Why is drivers/usb/Makefile even read when CONFIG_USB is not set? Won't it make more sense to throw the line obj-$(CONFIG_PCI) += usb/ from drivers/Makfile? On Wed, Apr 22, 2015 at 7:11 PM, Alan Stern st...@rowland.harvard.edu wrote: The USB PCI quirks code gets built into the kernel whenever

[PATCHv3 2/4] phy: core: Add devm_of_phy_get_by_index to phy-core

2015-04-22 Thread Arun Ramamurthy
Some generic drivers, such as ehci, may use multiple phys and for such drivers referencing phy(s) by name(s) does not make sense. Instead of inventing new naming schemes and using custom code to iterate through them, such drivers are better of using nameless phy bindings and using this newly

[PATCHv3 1/4] phy: phy-core: Make GENERIC_PHY an invisible option

2015-04-22 Thread Arun Ramamurthy
Most of the phy providers use select to enable GENERIC_PHY. Since select is only recommended when the config is not visible, GENERIC_PHY is changed an invisible option. To maintain consistency, all phy providers are changed to select GENERIC_PHY and all non-phy drivers use depends on when the phy

[PATCHv3 3/4] usb: ehci-platform: Use devm_of_phy_get_by_index

2015-04-22 Thread Arun Ramamurthy
Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com ---

[PATCHv3 0/4] add devm_of_phy_get_by_index and update platform drivers

2015-04-22 Thread Arun Ramamurthy
This patch set adds a new API to get phy by index when multiple phys are present. This patch is based on discussion with Arnd Bergmann about dt bindings for multiple phys. History: v1: - Removed null pointers on Dmitry's suggestion - Improved documentation in commit messages -

[PATCHv3 4/4] usb: ohci-platform: Use devm_of_phy_get_by_index

2015-04-22 Thread Arun Ramamurthy
Getting phys by index instead of phy names so that we do not have to create a naming scheme when multiple phys are present Signed-off-by: Arun Ramamurthy arun.ramamur...@broadcom.com Reviewed-by: Ray Jui r...@broadcom.com Reviewed-by: Scott Branden sbran...@broadcom.com ---

Re: default value of power/wakeup

2015-04-22 Thread Tom Yan
https://bugs.freedesktop.org/show_bug.cgi?id=90041 Because udev's work would get overrided if there's further manipulation. So if you want your udev rule to work, you have to make sure you run a trigger command after the module is loaded or reloaded. This would happen for all types of devices if

g_ncm.ko: delayed response for lsusb command

2015-04-22 Thread Niranjan H Y
Hello Everyone, I'm newbie to driver development have a question on CDC NCM gadget driver. When I load the module g_ncm.ko on the target board and execute lsusb on host, there is some delay in response. (about 5-10 seconds) However, if I trim the string as shown below (in code changes), lsusb

Re: default value of power/wakeup

2015-04-22 Thread Tom Yan
I'm not saying that the kernel shouldn't initialize the attributes or have a default. But it should only set the default when the attribute is initialized (It doesn't even matter to me whether it's enabled or disabled). It's just there should not be further manipulation from the kernel (e.g.

RE: default value of power/wakeup

2015-04-22 Thread Peter Chen
I'm not saying that the kernel shouldn't initialize the attributes or have a default. But it should only set the default when the attribute is initialized (It doesn't even matter to me whether it's enabled or disabled). It's just there should not be further manipulation from the

Re: [RFC][PATCH v2 00/13] USB: OTG/DRD Core functionality

2015-04-22 Thread Roger Quadros
On 22/04/15 12:22, Peter Chen wrote: On Wed, Apr 22, 2015 at 10:33:24AM +0300, Roger Quadros wrote: On 22/04/15 05:17, Peter Chen wrote: On Tue, Apr 21, 2015 at 10:34:01AM +0300, Roger Quadros wrote: On 21/04/15 09:04, Peter Chen wrote: On 20/04/15 06:05, Peter Chen wrote: On Tue, Apr

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Jason A. Donenfeld
On Wed, Apr 22, 2015 at 2:38 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: I'd bet this is really a pl2303 device, given that the visor driver was just a dumb pipe to the device and the pilot sync tools never cared about baud rates and the like, so odds are the visor entry should be

Re: [PATCH 2/5] usb: xhci: plat: Create both HCDs before adding them

2015-04-22 Thread Maxime Ripard
On Tue, Apr 21, 2015 at 01:46:36PM +0300, Roger Quadros wrote: On 21/04/15 11:08, Maxime Ripard wrote: On Tue, Apr 21, 2015 at 12:49:54PM +0300, Roger Quadros wrote: On 20/04/15 15:35, Mathias Nyman wrote: Hi On 02.04.2015 15:23, Roger Quadros wrote: As xhci_hcd is now allocated by

Re: [RFC][PATCH v2 00/13] USB: OTG/DRD Core functionality

2015-04-22 Thread Roger Quadros
On 22/04/15 05:17, Peter Chen wrote: On Tue, Apr 21, 2015 at 10:34:01AM +0300, Roger Quadros wrote: On 21/04/15 09:04, Peter Chen wrote: On 20/04/15 06:05, Peter Chen wrote: On Tue, Apr 14, 2015 at 01:41:47PM +0300, Roger Quadros wrote: This is an attempt to centralize OTG/Dual-role

Re: [RFC PATCH 2/3] net/dsa: Allow probing dsa from usbnet

2015-04-22 Thread rajeev kumar
On Tue, Apr 21, 2015 at 6:56 PM, Jan Kaisrlik kaisr...@fel.cvut.cz wrote: From: Jan Kaisrlik ja.kaisr...@gmail.com This patch adds a function which helps to connect net device to DSA switch based on mii_bus and netdev. The switch parameters of the switch are configured in

RE: usb: gadget: g_multi does not work with net2280

2015-04-22 Thread Praveen Murali
Hi Rajeev, -Original Message- From: rajeev kumar [mailto:rajeevkumar.li...@gmail.com] Sent: Tuesday, April 21, 2015 10:22 PM To: Praveen Murali Cc: Ricardo Ribalda Delgado; linux-usb@vger.kernel.org; ba...@ti.com; min...@mina86.com Subject: Re: usb: gadget: g_multi does not work

[PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Jason A. Donenfeld
Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone cradle. Having pl2303 or visor pick up this device ID

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Sergei Shtylyov
Hello. On 4/22/2015 1:14 PM, Jason A. Donenfeld wrote: Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the Samsung I330 phone

Re: [PATCH] pl2303, visor: Match I330 phone more precisely

2015-04-22 Thread Johan Hovold
On Wed, Apr 22, 2015 at 12:14:05PM +0200, Jason A. Donenfeld wrote: Samsung has just released a portable USB3 SSD, coming in a very small and nice form factor. It's USB ID is 04e8:8001, which unfortunately is already used by the pl2303 USB serial driver and the Palm Visor driver for the

Re: default value of power/wakeup

2015-04-22 Thread Tom Yan
On 21 April 2015 at 23:51, Alan Stern st...@rowland.harvard.edu wrote: Anyway, you're suggesting that drivers should never override sysfs attribute values. But there doesn't seem to be any other way to implement the kernel's policy that wakeup should be enabled by default for all keyboard

Re: [RFC][PATCH v2 00/13] USB: OTG/DRD Core functionality

2015-04-22 Thread Peter Chen
On Wed, Apr 22, 2015 at 10:33:24AM +0300, Roger Quadros wrote: On 22/04/15 05:17, Peter Chen wrote: On Tue, Apr 21, 2015 at 10:34:01AM +0300, Roger Quadros wrote: On 21/04/15 09:04, Peter Chen wrote: On 20/04/15 06:05, Peter Chen wrote: On Tue, Apr 14, 2015 at 01:41:47PM +0300,

Re: [PATCH] usb: core: add usb3 lpm sysfs

2015-04-22 Thread Zhuang Jin Can
+ Mathias and David. Hi Mathias, Please help to review this patch. Thanks Jincan On Sun, Apr 19, 2015 at 11:46:12AM +0800, Zhuang Jin Can wrote: Some usb3 devices may not support usb3 lpm well. The patch adds a sysfs to enable/disable u1 or u2 of the port.The settings apply to both before