Re: [PATCH 2/2] usb: chipidea: otg: use usb autosuspend to suspend bus for HNP

2015-12-23 Thread Peter Chen
On Tue, Dec 15, 2015 at 06:26:07PM +0800, Li Jun wrote: > Directly manipulate the controller regsiter to suspend the usb bus > for HNP is not the proper way, this should be done through the usbcore > by usb autosuspend. So to start HNP, autosuspend support should be > added for OTG devices

Re: MX28 with hub cannot reset

2015-12-23 Thread Peter Chen
On Wed, Dec 23, 2015 at 6:54 AM, Fabio Estevam wrote: > Hi, > > On a mx28 custom board with a USB hub I can get a USB stick to get > detected after applying this change: > http://marc.info/?l=linux-usb=145079935324339=2 > > Things work fine if I boot without the USB stick

Re: MX28 with hub cannot reset

2015-12-23 Thread Fabio Estevam
Hi Peter, On Wed, Dec 23, 2015 at 7:49 AM, Peter Chen wrote: > Fabio, there is a bug for imx28 usb low power mode, and we have no > good way to implement > workaround using current USB PHY framework, would you please test by > add "usbcore.autosuspend = -1" > at bootargs

Re: [linux-usb-users] g_serial is not working in rx path (K3.14)

2015-12-23 Thread Ramajayam S
On Tue, Dec 22, 2015 at 7:48 PM, Ramajayam S wrote: > On Mon, Dec 14, 2015 at 11:17 PM, Ramajayam S > wrote: >> On Mon, Dec 14, 2015 at 9:50 PM, Felipe Balbi wrote: >>> >>> hi, >>> >>> Ramajayam S

Re: [PATCH 1/2] usb: gadget: f_midi: refactor state machine

2015-12-23 Thread Felipe Ferreri Tonello
Hi Clemens, On 22/12/15 17:10, Clemens Ladisch wrote: > Felipe F. Tonello wrote: >> This refactor includes the following: >> * Cleaner state machine code; > > It does not correctly handle system real time messages inserted between > the status and data bytes of other messages. True, thanks for

[PATCH] BugFix in XHCI controller driver for scatter gather DMA

2015-12-23 Thread Vikas Bansal
From: Sumit Batra Pre-Condition URB with Scatter Gather list is queued to bulk OUT endpoint. Every buffer in scatter gather list is not a multiple of maximum packet size for that endpoint(short packet). CHAIN bit is set for all TRBs in a TD so that the DMA happens to

Re: [PATCH] BugFix in XHCI controller driver for scatter gather DMA

2015-12-23 Thread Mathias Nyman
On 23.12.2015 13:58, Vikas Bansal wrote: From: Sumit Batra Pre-Condition URB with Scatter Gather list is queued to bulk OUT endpoint. Every buffer in scatter gather list is not a multiple of maximum packet size for that endpoint(short packet). CHAIN bit is set for all

[PATCH 3/4] USB: host: use to_platform_device

2015-12-23 Thread Geliang Tang
Use to_platform_device() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/usb/host/ehci-platform.c | 6 ++ drivers/usb/host/ehci-st.c | 6 ++ drivers/usb/host/ohci-platform.c | 6 ++ drivers/usb/host/ohci-st.c | 6 ++ 4 files

[PATCH 1/4] USB: core, devio: use to_usb_device

2015-12-23 Thread Geliang Tang
Use to_usb_device() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/usb/core/devio.c | 2 +- drivers/usb/core/usb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index

[PATCH 2/4] USB: core, wusbcore: use bus_to_hcd

2015-12-23 Thread Geliang Tang
Use bus_to_hcd() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/usb/core/hcd.c| 6 +++--- drivers/usb/core/hub.c| 2 +- drivers/usb/core/usb.c| 2 +- drivers/usb/wusbcore/wusbhc.h | 2 +- 4 files changed, 6 insertions(+), 6

[PATCH 8/9 v2] usb: gadget: rndis: use list_for_each_entry_safe

2015-12-23 Thread Geliang Tang
Use list_for_each_entry_safe() instead of list_for_each_safe() to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/gadget/function/rndis.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/function/rndis.c

[PATCH 4/4] HID: usbhid: use to_usb_device

2015-12-23 Thread Geliang Tang
Use to_usb_device() instead of open-coding it. Signed-off-by: Geliang Tang --- drivers/hid/usbhid/usbhid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/usbhid.h b/drivers/hid/usbhid/usbhid.h index 807922b..fa47d66 100644 ---

Re: xhci list corruption on sysfs removal

2015-12-23 Thread Joe Lawrence
On 12/21/2015 10:07 AM, Mathias Nyman wrote: Hi On 18.12.2015 18:48, Joe Lawrence wrote: Hello Roger and Mathias, Running with slub_debug=FZPU and removing an XHCI host controller via sysfs, I've hit a use-after-free that I've bisected to: 8c24d6d7b09deee3036ddc4f2b81b53b28c8f877 is the

[GIT PULL] USB patches for v4.5

2015-12-23 Thread Felipe Balbi
Hi Greg, Here's the large usb gadget pull request for v4.5. Please consider merging it to your usb-next branch. We have a total 97 non-merge commits this time, so a substantial amount of code. Here's a dirstat to show you where most of changes are: $ git diff --dirstat 9f9499ae8e64 22.5%

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Jun Li
> -Original Message- > From: Ramneek Mehresh [mailto:ramneek.mehr...@freescale.com] > Sent: Wednesday, December 23, 2015 8:20 PM > To: Jun Li ; Felipe Balbi ; linux- > ker...@vger.kernel.org > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org; linux-

[PATCH] staging: android: sync.c: Changed the ways nullptrs were being checked

2015-12-23 Thread Chase Metzger
Removed all checkpatch.pl CHECKs that suggested to check NULL by !obj instead of obj == NULL. Signed-off-by: Chase Metzger --- drivers/staging/android/sync.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-23 Thread Alan Stern
On Wed, 23 Dec 2015, Hayes Wang wrote: > Oliver Neukum [mailto:oneu...@suse.de] > > Sent: Wednesday, December 23, 2015 4:20 PM > [...] > > No, step (2) does not exist. Calls to suspend() and [reset_]resume() > > always balance. Usually a driver shouldn't care about system suspend. > > The way the

Re: MX28 with hub cannot reset

2015-12-23 Thread Peter Chen
On Wed, Dec 23, 2015 at 08:05:13AM -0200, Fabio Estevam wrote: > Hi Peter, > > On Wed, Dec 23, 2015 at 7:49 AM, Peter Chen wrote: > > > Fabio, there is a bug for imx28 usb low power mode, and we have no > > good way to implement > > workaround using current USB PHY

Re: [PATCH net,stable] net: cdc_ncm: avoid changing RX/TX buffers on MTU changes

2015-12-23 Thread David Miller
From: Bjørn Mork Date: Wed, 23 Dec 2015 13:42:43 +0100 > NCM buffer sizes are negotiated with the device independently of > the network device MTU. The RX buffers are allocated by the > usbnet framework based on the rx_urb_size value set by cdc_ncm. A > single RX buffer can hold

Re: [PATCH v5] extcon: add Maxim MAX3355 driver

2015-12-23 Thread Sergei Shtylyov
Hello. On 12/23/2015 05:17 AM, Chanwoo Choi wrote: This patch depend on GPIOLIB configuration as following: I modified it with following diff and applied it. diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig index ba4db7d..3d89e60 100644 --- a/drivers/extcon/Kconfig +++

Re: [PATCH 1/2] usb: gadget: f_midi: refactor state machine

2015-12-23 Thread Clemens Ladisch
Felipe Ferreri Tonello wrote: >> Running status is feature. > >What do you mean by that? That this behavior is intended, and required. > I don't qualify writing a *wrong* MIDI-USB >packet because of a previous MIDI message as a feature. The MIDI Specification qualifies Running Status as a

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Ramneek Mehresh
> -Original Message- > From: Jun Li [mailto:jun...@nxp.com] > Sent: Wednesday, December 23, 2015 10:02 PM > To: Mehresh Ramneek-B31383 ; Felipe > Balbi ; linux-ker...@vger.kernel.org > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;

Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-23 Thread Oliver Neukum
On Wed, 2015-12-23 at 20:32 -0500, Alan Stern wrote: > I don't understand why the wakeup conditions are different. It seems > to me that the choice of which packets will generate a wakeup ought to > depend on the user's selection, not on the kind of suspend. For > instance, if the user says

RE: [PATCH 0/7][v4] Add OTG support for FSL socs

2015-12-23 Thread Ramneek Mehresh
> -Original Message- > From: Jun Li [mailto:jun...@nxp.com] > Sent: Wednesday, December 23, 2015 10:36 AM > To: Felipe Balbi ; Mehresh Ramneek-B31383 > ; linux-ker...@vger.kernel.org > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;

[PATCH net,stable] net: cdc_ncm: avoid changing RX/TX buffers on MTU changes

2015-12-23 Thread Bjørn Mork
NCM buffer sizes are negotiated with the device independently of the network device MTU. The RX buffers are allocated by the usbnet framework based on the rx_urb_size value set by cdc_ncm. A single RX buffer can hold a number of MTU sized packets. The default usbnet change_mtu ndo only modifies

[PATCH v2] usb: gadget: f_midi: refactor state machine

2015-12-23 Thread Felipe F. Tonello
This refactor results in a cleaner state machine code and as a result fixed a bug when packaging a MIDI-USB packet right after a non-conformant MIDI byte stream. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 205

Re: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-23 Thread Oliver Neukum
On Wed, 2015-12-23 at 09:20 +, Hayes Wang wrote: > Oliver Neukum [mailto:oneu...@suse.de] > > Sent: Wednesday, December 23, 2015 4:20 PM > [...] > > No, step (2) does not exist. Calls to suspend() and [reset_]resume() > > always balance. Usually a driver shouldn't care about system suspend. >

RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled

2015-12-23 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] > Sent: Wednesday, December 23, 2015 6:46 PM [...] > That is indeed a problem and I need to think a bit about finding > a good solution. If you are happy with an inelegant solution, you can > use a pm_notifier, which will tell you that the system is going >

Re: [PATCH 1/2] usb: gadget: f_midi: refactor state machine

2015-12-23 Thread Felipe Ferreri Tonello
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Balbi, On 22/12/15 17:49, Felipe Balbi wrote: > > Hi, > > "Felipe F. Tonello" writes: >> This refactor includes the following: * Cleaner state machine >> code; * Reset state if MIDI message parsed is non-conformant; *