Re: [GIT PULL] USB-serial fixes for v4.4-rc8

2016-01-03 Thread Greg Kroah-Hartman
On Thu, Dec 31, 2015 at 11:47:05AM +0100, Johan Hovold wrote: > [ Resend with Subject added... ] > > Hi Greg, > > Here's a device id for 4.4-rc8 unless you prefer to wait until 4.5-rc1. I'd rather just wait, I'll pull this into my -next branch, thanks. greg k-h -- To unsubscribe from this

Re: ftdi_sio bug: setting two custom baud rates in a row fails

2016-01-03 Thread Edwin Olson
Hi Johan et al, Now that I understand the behavior, and know how to work-around the issue, I won't press too hard for functionality changes. But perhaps the documentation can be improved by suggesting that the custom divisor be set before the baud rate is set to B38400. E.g., by just swapping the

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-03 Thread Steinar H. Gunderson
On Mon, Jan 04, 2016 at 01:42:06AM +0100, Markus Rechberger wrote: > Don't expect anyone else seriously testing this interface aside of me > and Steinar. FWIW, I got an email from the OpenKinect people, who are (as far as I know) currently testing the patch together with my libusb-1.0 patch. It

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-03 Thread Markus Rechberger
On Mon, Jan 4, 2016 at 1:06 AM, Greg Kroah-Hartman wrote: > On Mon, Jan 04, 2016 at 12:54:57AM +0100, Markus Rechberger wrote: >> I would appreciate if this thing could speed up a little bit. We have >> implemented our previous mmap support into some embedded systems

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-03 Thread Markus Rechberger
I would appreciate if this thing could speed up a little bit. We have implemented our previous mmap support into some embedded systems however we need to update quite a few systems if we are going to support the current mmap version. It's taking 2 months already for this small change. When I did

Re: [GIT PULL] USB-serial updates for v4.5-rc1

2016-01-03 Thread Greg Kroah-Hartman
On Thu, Dec 31, 2015 at 11:57:02AM +0100, Johan Hovold wrote: > Hi Greg, > > Here are the usb-serial updates for 4.5-rc1. > > These patches have all been in linux-next for a while except for the new > mxu11x0 driver (that has passed the 0-day testing). > > Thanks, > Johan > > > The following

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-03 Thread Greg Kroah-Hartman
On Mon, Jan 04, 2016 at 12:54:57AM +0100, Markus Rechberger wrote: > I would appreciate if this thing could speed up a little bit. We have > implemented our previous mmap support into some embedded systems > however we need to update quite a few systems if we are going to > support the current

Re: [PATCH] Add support for usbfs zerocopy.

2016-01-03 Thread Peter Stuge
Markus Rechberger wrote: > just improve that sloppy situation Dude I don't care who you are, your attitude sucks, and flushes any merit you have down the drain. It makes you look super bad. :) > we're at 3 months now Right, so chill out, watch a movie, go to a party, go to several, have some

[PATCH v7 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-01-03 Thread Baolin Wang
Currently the Linux kernel does not provide any standard integration of this feature that integrates the USB subsystem with the system power regulation provided by PMICs meaning that either vendors must add this in their kernels or USB gadget devices based on Linux (such as mobile phones) may not

[PATCH v7 2/4] gadget: Support for the usb charger framework

2016-01-03 Thread Baolin Wang
For supporting the usb charger, it adds the usb_charger_init() and usb_charger_exit() functions for usb charger initialization and exit. It will report to the usb charger when the gadget state is changed, then the usb charger can do the power things. Introduce a callback 'get_charger_type' which

[PATCH v7 3/4] gadget: Integrate with the usb gadget supporting for usb charger

2016-01-03 Thread Baolin Wang
When the usb gadget supporting for usb charger is ready, the usb charger should get the type by the 'get_charger_type' callback which is implemented by the usb gadget operations, and get the usb charger pointer from struct 'usb_gadget'. Signed-off-by: Baolin Wang ---

[PATCH] cdc_acm: blacklist Samsung Phones in firmware update mode

2016-01-03 Thread Jose Alonso
The program Heimdall (http://glassechidna.com.au/heimdall) is used to flash a new firmware in Samsung Mobile Phones. It uses only the library libusb to access the device. The module "cdc_acm" recognizes it as CDC ACM device, creates a device /dev/ttyACM* and send a USB_CDC_REQ_SET_LINE_CODING.

[PATCH v7 1/4] gadget: Introduce the usb charger framework

2016-01-03 Thread Baolin Wang
This patch introduces the usb charger driver based on usb gadget that makes an enhancement to a power driver. It works well in practice but that requires a system with suitable hardware. The basic conception of the usb charger is that, when one usb charger is added or removed by reporting from

[PATCH v7 4/4] power: wm831x_power: Support USB charger current limit management

2016-01-03 Thread Baolin Wang
Integrate with the newly added USB charger interface to limit the current we draw from the USB input based on the input device configuration identified by the USB stack, allowing us to charge more quickly from high current inputs without drawing more current than specified from others.

Re: [PATCH] cdc_acm: blacklist Samsung Phones in firmware update mode

2016-01-03 Thread Oliver Neukum
On Mon, 2016-01-04 at 12:32 +0700, Lars Melin wrote: > On 2016-01-04 05:00, Jose Alonso wrote: > > > > The program Heimdall (http://glassechidna.com.au/heimdall) is used > > to flash a new firmware in Samsung Mobile Phones. It uses only the > > library libusb to access the device. > > > > The

Re: rndis/cdc_ether usb device causing Oops in 4.4rc1+ with NULL dereference

2016-01-03 Thread Oliver Neukum
On Sun, 2016-01-03 at 20:50 +0100, Bjørn Mork wrote: > > But like you, I cannot find the commit supposed to fix this. There is > no such commit in net, net-next, usb or usb-next AFAICS. And I can't > find any other relevant commit after the one introducing this bug > either. Did you forget to

Re: [PATCH] cdc_acm: blacklist Samsung Phones in firmware update mode

2016-01-03 Thread Oliver Neukum
On Sun, 2016-01-03 at 20:00 -0200, Jose Alonso wrote: > The program Heimdall (http://glassechidna.com.au/heimdall) is used > to flash a new firmware in Samsung Mobile Phones. It uses only the > library libusb to access the device. > > The module "cdc_acm" recognizes it as CDC ACM device, creates

Re: [PATCH v7 4/4] power: wm831x_power: Support USB charger current limit management

2016-01-03 Thread kbuild test robot
Hi Baolin, [auto build test ERROR on v4.4-rc8] [cannot apply to balbi-usb/next usb/usb-testing next-20151231] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url:

Re: [PATCH] cdc_acm: blacklist Samsung Phones in firmware update mode

2016-01-03 Thread Lars Melin
On 2016-01-04 05:00, Jose Alonso wrote: The program Heimdall (http://glassechidna.com.au/heimdall) is used to flash a new firmware in Samsung Mobile Phones. It uses only the library libusb to access the device. The module "cdc_acm" recognizes it as CDC ACM device, creates a device /dev/ttyACM*

[PATCH net] r8152: add reset_resume function

2016-01-03 Thread Hayes Wang
When the reset_resume() is called, the flag of SELECTIVE_SUSPEND should be cleared and reinitialize the device, whether the SELECTIVE_SUSPEND is set or not. If reset_resume() is called, it means the power supply is cut or the device is reset. That is, the device wouldn't be in runtime suspend

[PATCH stable-3.14] usb: gadget: f_ncm: fix skb_clone memleak on error

2016-01-03 Thread Pavitrakumar Managutte
Fixed skb_clone pointer memleak on error path. Since the newly cloned skb is still not added to the list, hence purge list wont free the cloned skb. stable-3.14.y: 5d7b0fcc26 Signed-off-by: Pavitrakumar Managutte --- drivers/usb/gadget/f_ncm.c | 2 ++ 1 file changed, 2

Re: [PATCH] usb: serial: return -ENODEV if disconnected during TIOCMIWAIT

2016-01-03 Thread Johan Hovold
On Mon, Dec 21, 2015 at 02:17:22PM +0100, Oliver Neukum wrote: > Disconnecting a device is not just a hang up. The device is gone. > We should tell user space the truth immediately. I'm not sure about this one. The usb-serial drivers have always returned -EIO on hangup, whatever the reason, and

Re: [PATCH 1/3] USB: mxu11x0: fix memory leak on usb_serial private data

2016-01-03 Thread Johan Hovold
On Sun, Jan 03, 2016 at 03:25:59PM +0100, Mathieu OTHACEHE wrote: > On nominal execution, private data allocated on port_probe and attach > are never freed. Add port_remove and release callbacks to free them > respectively. Ouch. I thought I'd vetted the driver for further memleaks but apparently

Re: [PATCH 2/3] USB: mxu11x0: clean device control commands

2016-01-03 Thread Johan Hovold
On Sun, Jan 03, 2016 at 03:26:00PM +0100, Mathieu OTHACEHE wrote: > Sending OPEN and START commands twice is not necessary for this driver. > Also send STOP command at close. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/mxu11x0.c | 31

Re: [PATCH v6] USB: serial: add Moxa UPORT 11x0 driver

2016-01-03 Thread Mathieu OTHACEHE
Hi Johan, Thanks for merging ! About the follow ups, I have tested the driver on uport 1110 without double OPEN_PORT/START_PORT commands. It is still working fine so, I guess it can be removed. Plus, I sniffed the Windows USB driver for uport 1110 and the commands sent are : OPEN_PORT,

[PATCH 0/3] USB: mxu11x0: fixes and follow ups

2016-01-03 Thread Mathieu OTHACEHE
Hi, Here are the follow up commits proposed during last Johan review of the new mxu11x0 driver. I also patched a memory leak on usb_serial private data. Mathieu Mathieu OTHACEHE (3): USB: mxu11x0: fix memory leak on usb_serial private data USB: mxu11x0: clean device control commands USB:

[PATCH 3/3] USB: mxu11x0: move firmware download and endpoint testing to probe callback

2016-01-03 Thread Mathieu OTHACEHE
Move interrupt in endpoint test and firmware download to a new probe callback. This avoids unnecessary memory allocations done by core before port_probe callback is called. If the device has to be reseted (firmware downloaded) or if the interface is incorrect (no interrupt in endpoint), the probe

[PATCH 2/3] USB: mxu11x0: clean device control commands

2016-01-03 Thread Mathieu OTHACEHE
Sending OPEN and START commands twice is not necessary for this driver. Also send STOP command at close. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/mxu11x0.c | 31 +++ 1 file changed, 7 insertions(+), 24 deletions(-) diff --git

[PATCH 1/3] USB: mxu11x0: fix memory leak on usb_serial private data

2016-01-03 Thread Mathieu OTHACEHE
On nominal execution, private data allocated on port_probe and attach are never freed. Add port_remove and release callbacks to free them respectively. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/mxu11x0.c | 20 1 file changed, 20

Re: [PATCH V7 1/1] usb:serial: Add Fintek F81532/534 driver

2016-01-03 Thread Johan Hovold
On Wed, Dec 02, 2015 at 03:18:59PM +0800, Peter Hung wrote: > This driver is for Fintek F81532/F81534 USB to Serial Ports IC. Do you have a pointer to datasheets and/or information about these devices? Can't seem to find anything on Fintek's homepage. > Features: > 1. F81534 is 1-to-4 & F81532

Re: [PATCH 3/3] USB: mxu11x0: move firmware download and endpoint testing to probe callback

2016-01-03 Thread Johan Hovold
On Sun, Jan 03, 2016 at 03:26:01PM +0100, Mathieu OTHACEHE wrote: > Move interrupt in endpoint test and firmware download to a new probe > callback. This avoids unnecessary memory allocations done by core > before port_probe callback is called. > > If the device has to be reseted (firmware

Re: rndis/cdc_ether usb device causing Oops in 4.4rc1+ with NULL dereference

2016-01-03 Thread Bjørn Mork
Vasily Galkin writes: > I reverted 823bd3433424aa959499e6fd8f2da842430a8d42 and recompiled cdc_ether > module for debian's 4.4rc6. > Device begin working normally as usual, no any Oopses or problems. > > Attaching lsusb output for this kernel. [..] > Interface