Re: [PATCH] USB: whci-hcd: add more checks for dma mapping error

2016-03-25 Thread Vladimir Zapolskiy
On 26.03.2016 00:56, Alexey Khoroshilov wrote: > On 26.03.2016 01:03, Vladimir Zapolskiy wrote: >> On 25.03.2016 22:23, Alexey Khoroshilov wrote: >>> Fixing checks for dma mapping error in qset_fill_page_list(), >>> I have missed two similar problems in qset_add_urb_sg() and >>> in

Re: [PATCH] USB: whci-hcd: add more checks for dma mapping error

2016-03-25 Thread Alexey Khoroshilov
On 26.03.2016 01:03, Vladimir Zapolskiy wrote: On 25.03.2016 22:23, Alexey Khoroshilov wrote: Fixing checks for dma mapping error in qset_fill_page_list(), I have missed two similar problems in qset_add_urb_sg() and in qset_add_urb_sg_linearize(). Found by Linux Driver Verification project

Re: [PATCH] USB: whci-hcd: add more checks for dma mapping error

2016-03-25 Thread Vladimir Zapolskiy
On 25.03.2016 22:23, Alexey Khoroshilov wrote: > Fixing checks for dma mapping error in qset_fill_page_list(), > I have missed two similar problems in qset_add_urb_sg() and > in qset_add_urb_sg_linearize(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by:

[PATCH] USB: whci-hcd: add more checks for dma mapping error

2016-03-25 Thread Alexey Khoroshilov
Fixing checks for dma mapping error in qset_fill_page_list(), I have missed two similar problems in qset_add_urb_sg() and in qset_add_urb_sg_linearize(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov ---

Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-25 Thread Felipe Balbi
Hi, Gregory CLEMENT writes: >> Peter Griffin writes: >>> Otherwise generic-xhci and xhci-platform which have no data get wrongly >>> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is(). >>> >>> This fixes a regression

Re: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP registers.

2016-03-25 Thread Sergei Shtylyov
On 03/25/2016 02:51 AM, David Lechner wrote: We will be using a generic syscon device for the TI DA8XX SoC CFGCHIPx retisters. This will be used by a number of planned drivers including a new USB PHY driver and common clock framework drivers. The same defines are removed from the platform_data

Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-25 Thread Gregory CLEMENT
Hi Felipe, On ven., mars 25 2016, Felipe Balbi wrote: > Hi, > > Peter Griffin writes: >> Otherwise generic-xhci and xhci-platform which have no data get wrongly >> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is(). >> >> This fixes a

Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-25 Thread Felipe Balbi
Hi, Peter Griffin writes: > Otherwise generic-xhci and xhci-platform which have no data get wrongly > detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is(). > > This fixes a regression in v4.5 for STiH407 family SoC's which use the > synopsis dwc3 IP,

Re: [PATCH v3 01/16] dt: davinci: use proper address after @

2016-03-25 Thread Sergei Shtylyov
Hello. On 03/25/2016 06:13 PM, Rob Herring wrote: TI has been using the physical address in DT after the @ in device nodes. The device tree convention is to use the same address that is used for the reg property. This updates all davinci DT files to use the proper convention. Signed-off-by:

Re: unable to handle kernel NULL pointer dereference at usb_audio_probe

2016-03-25 Thread Greg KH
On Fri, Mar 25, 2016 at 12:27:21PM +, Ian T. Jacobsen wrote: > Ok looks like this fixed the dmesg bug report, and the hardware does > now show up in relevant software, but it does not actually work. > arecord reports this > > $ arecord -f cd -D plughw:2,0 -d 20 test.wav > arecord: main:722:

Re: [PATCH v3 01/16] dt: davinci: use proper address after @

2016-03-25 Thread Rob Herring
On Thu, Mar 24, 2016 at 6:51 PM, David Lechner wrote: > TI has been using the physical address in DT after the @ in device nodes. > The device tree convention is to use the same address that is used for > the reg property. This updates all davinci DT files to use the proper

Re: [PATCH v3 01/16] dt: davinci: use proper address after @

2016-03-25 Thread Rob Herring
On Fri, Mar 25, 2016 at 8:29 AM, Sergei Shtylyov wrote: > Hello. > > On 03/25/2016 02:51 AM, David Lechner wrote: > >> TI has been using the physical address in DT after the @ in device nodes. >> The device tree convention is to use the same address that is

[PATCH v2] usb: gadget: fsl_udc_core: Fix pullup status

2016-03-25 Thread Dmitry Osipenko
udc->softconnect should be set regardless of the VBUS state, otherwise the USB peripheral device, connected during suspend, won't be detected since can_pullup() would return false and the UDC won't be enabled. Fixes: 252455c40316 (usb: gadget: fsl driver pullup fix) Signed-off-by: Dmitry Osipenko

[PATCH] usb: xhci: remove duplicate function xhci_urb_to_transfer_ring

2016-03-25 Thread Alexandr Ivanov
Remove duplicate function xhci_urb_to_transfer_ring from xhci.c. We have same function in xhci-ring.c. Signed-off-by: Alexandr Ivanov --- drivers/usb/host/xhci-ring.c | 17 + drivers/usb/host/xhci.c | 41 -

[PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value

2016-03-25 Thread Peter Griffin
Otherwise generic-xhci and xhci-platform which have no data get wrongly detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is(). This fixes a regression in v4.5 for STiH407 family SoC's which use the synopsis dwc3 IP, whereby the disable_clk error path gets taken due to wrongly being

[PATCH 1/2] usb: xhci: fix wild pointers in xhci_mem_cleanup

2016-03-25 Thread Lu Baolu
This patch fixes some wild pointers produced by xhci_mem_cleanup. These wild pointers will cause system crash if xhci_mem_cleanup() is called twice. Reported-and-tested-by: Pengcheng Li Signed-off-by: Lu Baolu Cc: sta...@vger.kernel.org ---

[PATCH 2/2] usb: xhci: remove hardcoded gfp_t in xhci_mem_init

2016-03-25 Thread Lu Baolu
xhci_mem_init() should use @flags, instead of hardcode, for DMA memory allocation. Signed-off-by: Lu Baolu --- drivers/usb/host/xhci-mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c

Re: 答复: 答复: 答复: 答复: 【xhci】suspend and resume core dump problem

2016-03-25 Thread Lu Baolu
Hi, On 03/25/2016 03:39 PM, Lipengcheng wrote: > Hi, >Thanks Baolu very much! >The kernel is 3.10.Before the problem is inevitable emergence. But we fix > patch number:b630d4b9d05ba2e66878ca4614946d0f950d4111 and your suggest. > Then we resume and suspend the seventh and it is ok only if

Re: [PATCH v3 01/16] dt: davinci: use proper address after @

2016-03-25 Thread Sergei Shtylyov
Hello. On 03/25/2016 02:51 AM, David Lechner wrote: TI has been using the physical address in DT after the @ in device nodes. The device tree convention is to use the same address that is used for the reg property. This updates all davinci DT files to use the proper convention. Signed-off-by:

Re: [PATCH] usb: gadget: fsl_udc_core: Fix pullup status

2016-03-25 Thread Dmitry Osipenko
Hello Sergei, 25.03.2016 14:12, Sergei Shtylyov пишет: [snip] udc = container_of(gadget, struct fsl_udc, gadget); +udc->softconnect = (is_on != 0); !!is_on? Parens not needed anyway though. Okay :) I'll change to it in V2 as well as a bit messed up commit message. Thanks

Re: unable to handle kernel NULL pointer dereference at usb_audio_probe

2016-03-25 Thread Ian T. Jacobsen
Ok looks like this fixed the dmesg bug report, and the hardware does now show up in relevant software, but it does not actually work. arecord reports this $ arecord -f cd -D plughw:2,0 -d 20 test.wav arecord: main:722: audio open error: No such device Which does make sense if the extra NULL

Re: [PATCH] usb: gadget: fsl_udc_core: Fix pullup status

2016-03-25 Thread Sergei Shtylyov
Hello. On 3/25/2016 2:14 AM, Dmitry Osipenko wrote: udc->softconnect should be set regardless of the VBUS state, otherwise the USB peripheral device, connected during suspend, won't be detected since can_pullup() would return false the UDC controller won't be enabled. Fixes: 252455c40316

Re: [PATCH] usb: gadget: fix NULL ptr derefer while unlinking functions

2016-03-25 Thread Felipe Balbi
Hi, Winter Wang writes: > Fix NULL pointer dereference while trying to unlink audio_source > in android. > > If unlink audio_source function, got a NULL pointer dereference: > --- > [] *pgd=28ad1831, *pte=, *ppte= > Internal error: Oops:

[PATCH] usb: gadget: fix NULL ptr derefer while unlinking functions

2016-03-25 Thread Winter Wang
Fix NULL pointer dereference while trying to unlink audio_source in android. If unlink audio_source function, got a NULL pointer dereference: --- [] *pgd=28ad1831, *pte=, *ppte= Internal error: Oops: 8007 [#1] PREEMPT SMP ARM Modules linked in: CPU: 1 PID:

RE: Chipidea USB driver on Linux 3.14?

2016-03-25 Thread Peter Chen
> > Hi, > > We're using Linux 3.14.60 and we'd like to use the Chipidea USB driver that > comes with it. > We enabled USB support as "built-in" (ie: not as kernel module): > > CONFIG_USB=y > CONFIG_USB_EHCI_HCD=y > CONFIG_USB_OHCI_HCD=y > CONFIG_USB_STORAGE=y > CONFIG_USB_CHIPIDEA=y >

Re: [PATCH] USB: bcma: use simpler devm helper for getting vcc GPIO

2016-03-25 Thread Rafał Miłecki
On 24 March 2016 at 15:31, Sergei Shtylyov wrote: > On 03/24/2016 05:26 PM, Rafał Miłecki wrote: Thanks to switching to devm_gpiod_get: 1) We don't have to pass fwnode pointer 2) We can request initial GPIO value at getting call

Re: [RFC PATCH 0/4] Implement USB device/host switch for Vybrid

2016-03-25 Thread Peter Chen
On Tue, Mar 15, 2016 at 02:08:26PM +0530, Sanchayan Maity wrote: > Hello Peter, > > The existing usage of extcon in Chipidea driver relies on OTG > registers. In case of SoC with dual role device but not a true > OTG controller, this does not work. Such SoC's should specify > the existing

RE: 答复: 答复: 答复: 答复: 【xhci】suspend and resume core dump problem

2016-03-25 Thread Lipengcheng
Hi, Thanks Baolu very much! The kernel is 3.10.Before the problem is inevitable emergence. But we fix patch number:b630d4b9d05ba2e66878ca4614946d0f950d4111 and your suggest. Then we resume and suspend the seventh and it is ok only if the usb3 can not work. So the changes are effective.

Re: [PATCH v8 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-03-25 Thread Peter Chen
On Thu, Mar 24, 2016 at 08:35:53PM +0800, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their kernels >