RE: [PATCH] usb: ohci-at91: Suspend the ports while USB suspending

2016-05-11 Thread Yang, Wenyou
> -Original Message- > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > Sent: 2016年5月12日 11:53 > To: Yang, Wenyou > Cc: Alan Stern ; Greg Kroah-Hartman > ; Ferre, Nicolas

RE: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-11 Thread Du, Changbin
> On Wed, May 11 2016, Felipe Balbi wrote: > > Also, returning -EOVERFLOW is not exactly correct here, because you'd > > violate POSIX specification of read(), right ? > > Maybe we could piggyback on: > >EINVAL fd was created via a call to timerfd_create(2) and the > wrong

RE: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-11 Thread Du, Changbin
> Hi, > > changbin...@intel.com writes: > > From: "Du, Changbin" > > > > Since the buffer size for req is rounded up to maxpacketsize, > > then we may end up with more data then user space has space > > for. > > only for OUT direction with the controller you're using ;-)

RE: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-11 Thread Yoshihiro Shimoda
Hi, > From: Alan Stern > Sent: Wednesday, May 11, 2016 11:47 PM > > On Wed, 11 May 2016, Roger Quadros wrote: > > > > What I mean is if you have 2 EHCI controllers with 2 companion > > > controllers, don't you need to know which companion goes with which EHCI > > > controller? Just like you do

Re: [PATCH] usb: ohci-at91: Suspend the ports while USB suspending

2016-05-11 Thread Alexandre Belloni
Hi, On 12/05/2016 at 09:05:34 +0800, Wenyou Yang wrote : > In order to get lower consumption, as a workaround, suspend > the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI Interrupt > Configuration Register while OHCI USB suspending. > Why is that a workaround? > This suspend operation

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-05-11 Thread Hongzhou Yang
On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote: > On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > > Hi, > > > > On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > > > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > > > > On Tue, May 10, 2016 at 10:23 AM, Chunfeng

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-05-11 Thread Hongzhou Yang
On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote: > Hi, > > On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > > > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > > > wrote: > > > > > > > the

[PATCH v2] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

2016-05-11 Thread Jiancheng Xue
Some ehci compatible controllers have more than one reset signal lines, e.g., Synopsys DWC USB2.0 Host-AHB Controller has two resets hreset_i_n and phy_rst_i_n. Two more resets are added in this patch in order for this kind of controller to use this driver directly. Signed-off-by: Jiancheng Xue

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-05-11 Thread chunfeng yun
Hi, On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote: > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > > wrote: > > > > > the default mode of GPIO16 pin is gpio, when set EINT16 to > > >

Re: [PATCH 07/15] usb: musb: Handle cable status better for 2430 glue layer

2016-05-11 Thread Tony Lindgren
* Tony Lindgren [160511 17:56]: > We may have drivers loaded but no configured gadgets and MUSB may be in > host mode. If gadgets are configured during host mode, PM runtime will > get confused. ... > @@ -307,6 +350,9 @@ static void omap_musb_set_mailbox(struct omap2430_glue >

[PATCH] usb: ohci-at91: Suspend the ports while USB suspending

2016-05-11 Thread Wenyou Yang
In order to get lower consumption, as a workaround, suspend the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI Interrupt Configuration Register while OHCI USB suspending. This suspend operation must be done before stopping the USB clock, resume after the USB clock enabled. Signed-off-by:

[PATCH 05/15] usb: musb: Remove conditional PM runtime calls for musb_gadget

2016-05-11 Thread Tony Lindgren
The conditional use of PM runtime does not work properly for musb gadget. On cable disconnect we may not get any USB_EVENT_NONE leaving the PM runtime call unpaired. Let's fix the issue by making sure the PM runtime calls are paired within the functions. The glue layer will take care of the rest.

[PATCH 07/15] usb: musb: Handle cable status better for 2430 glue layer

2016-05-11 Thread Tony Lindgren
We may have drivers loaded but no configured gadgets and MUSB may be in host mode. If gadgets are configured during host mode, PM runtime will get confused. Disable PM runtime from gadget state, and do it based on the cable and last state. Note that we may get multiple cable events, so we need

[PATCH 12/15] usb: musb: Remove extra PM runtime calls from 2430 glue layer

2016-05-11 Thread Tony Lindgren
With PM runtime behaving, these are all now unnecessary. Doing pm_runtime_get(musb->controller) will keep the parent glue layer also active. Signed-off-by: Tony Lindgren --- drivers/usb/musb/omap2430.c | 28 1 file changed, 4 insertions(+), 24

[PATCH 13/15] usb: musb: Remove pm_runtime_set_irq_safe

2016-05-11 Thread Tony Lindgren
With the pull up being handled with delayed work, we can now finally remove pm_runtime_set_irq_safe that blocks the MUSB glue from idling. Signed-off-by: Tony Lindgren --- drivers/usb/musb/musb_core.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 11/15] usb: musb: Return error value from musb_mailbox

2016-05-11 Thread Tony Lindgren
At least on n900 we have phy-twl4030-usb only generating cable interrupts, and then have a separate USB PHY. In order for musb to know the real cable status, we need to clear any cached state until musb is ready. Otherwise the cable status interrupts will get just ignored if the status does not

[PATCH 03/15] usb: musb: Update to use PM runtime autosuspend

2016-05-11 Thread Tony Lindgren
Let's make the PM runtime use the standard autosuspend calls. Commit 5de85b9d57ab ("PM / runtime: Re-init runtime PM states at probe error and driver unbind") means we must pair use_autosuspend with dont_use_autosuspend and then use put_sync to properly idle the device. Note that we'll be

[PATCHv2 00/15] Get MUSB PM runtime working again

2016-05-11 Thread Tony Lindgren
Hi all, Here's the whole series reposted with a bunch of additional changes. It seems to now properly work with with multiple phy cable status events, and should work for Ivaylo on n900 too. Please re-review and re-test. Regards, Tony Tony Lindgren (15): usb: musb: Fix idling after host

[PATCH 06/15] usb: musb: Use delayed for musb_gadget_pullup

2016-05-11 Thread Tony Lindgren
We have MUSB setting pm_runtime_irq_safe with the following commits: 30a70b026b4c ("usb: musb: fix obex in g_nokia.ko causing kernel panic") 3e43a0725637 ("usb: musb: core: add pm_runtime_irq_safe()") Let's fix things to use delayed work so we can remove the pm_runtime_irq_safe. Note that we

[PATCH 10/15] usb: musb: Don't set d+ high before enable for 2430 glue layer

2016-05-11 Thread Tony Lindgren
At least 2430 glue layer pulls d+ high on start up even if there are no gadgets configured. This is bad at least for anything using a separate battery charger chip as it can confuse the charger detection. Let's fix the issue by getting rid of omap2430_musb_set_mode() and only write session bit in

[PATCH 08/15] usb: musb: Improve PM runtime and phy handling for 2430 glue layer

2016-05-11 Thread Tony Lindgren
This simplifies things and allows idling both MUSB and PHY when nothing is configured. Let's just return early from PM runtime if musb is not yet initialized. Let's also warn if PHY is not configured. Signed-off-by: Tony Lindgren --- drivers/usb/musb/omap2430.c | 30

[PATCH 14/15] usb: musb: Use normal module_init for 2430 glue

2016-05-11 Thread Tony Lindgren
There's no longer any need for custom initcall level for musb. Signed-off-by: Tony Lindgren --- drivers/usb/musb/omap2430.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index

[PATCH 15/15] usb: phy: Check initial state for twl6030

2016-05-11 Thread Tony Lindgren
We need to check the state for the PHY with delayed_work as otherwise MUSB will get confused and idles immediately. Signed-off-by: Tony Lindgren --- drivers/usb/phy/phy-twl6030-usb.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

[PATCH 01/15] usb: musb: Fix idling after host mode by increasing autosuspend delay

2016-05-11 Thread Tony Lindgren
Looks like at least 2430 glue won't idle reliably with the 200 ms autosuspend delay. This causes deeper idle states being blocked for the whole SoC when disconnecting OTG A cable. Increasing the delay to 500 ms seems to idle both MUSB and the PHY reliably. This is probably because of time needed

[PATCH 04/15] usb: musb: Split PM runtime between wrapper IP and musb core

2016-05-11 Thread Tony Lindgren
Let's not tinker with the PM runtime of musb core from the omap2430 wrapper. This allows us to initialize PM runtime for musb core later on instead of doing it in stages. And omap2430 wrapper has no need to for accessing musb core at this point. Note that this does not remove all the PM runtime

[PATCH 02/15] usb: musb: Remove unnecessary shutdown function

2016-05-11 Thread Tony Lindgren
We have remove() already calling shutdown(), so let's drop it and move the code to remove(). No code changes, we'll drop the the FIXME in the following patch with more clean-up. Signed-off-by: Tony Lindgren --- drivers/usb/musb/musb_core.c | 39

[PATCH 09/15] usb: musb: Remove try_idle for 2430 glue layer

2016-05-11 Thread Tony Lindgren
This is no longer needed with PM runtime at least for 2430 glue. We can now rely only on PM runtime and cable detection. The other glue layers can probably remove try_idle too, but that needs to be tested for each platform before doing it. Signed-off-by: Tony Lindgren ---

Re: [PATCH 00/10] Get MUSB PM runtime working again

2016-05-11 Thread Tony Lindgren
* Ivaylo Dimitrov [160503 10:46]: > On 3.05.2016 19:25, Tony Lindgren wrote: > >* Ivaylo Dimitrov [160430 23:34]: > >> > >>Unfortunately that makes my n900 unbootable with USB cable detached, see the > >>attached file (at [ 152.121673])

Re: Downloading tracks from gps via usb

2016-05-11 Thread Stephen Furner
The kernel is: 3.19.0-59-generic Listing the USB devices I see: stephen@stephen-N150P:~$ lsusb Bus 001 Device 004: ID 0ac8:c33f Z-Star Microelectronics Corp. Webcam Bus 001 Device 003: ID 0781:5567 SanDisk Corp. Cruzer Blade Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 005

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-11 Thread Dean Jenkins
Hi John, I have purchased a "uGreen" USB Ethernet Adaptor which was reported as showing the issue: lsusb shows: ID 0b95:772b ASIX Electronics Corp. AX88772B dmesg shows: [119591.413298] usb 2-1: new high-speed USB device number 12 using ci_hdrc [119591.576970] usb 2-1: New USB device found,

Dear Friend,

2016-05-11 Thread Jaslin Ikhsan
Dear Friend, How are you? I want to inquire from you if you can handle a transaction for mutual benefits/life opportunity for you and me. I am Dr.Jaslin Ikhsan. The Chief International Relation Foreign RemittanceUnit of my bank here in Burkina Faso Ouagadougou Branch. I Have an Opportunity to

Re: Downloading tracks from gps via usb

2016-05-11 Thread Alan Stern
On Wed, 11 May 2016, Stephen Furner wrote: > When using Gebabbel to download tracks from a Garmin GPSMAP96 I am > receiving the error message: > > "The original error message reported by gpsbabel was: Claim interfaced > failed: could not claim interface 0: Operation not permitted" Depending on

[PATCH 3/3] usb: gr_udc: Remove unnecessary platform_set_drvdata().

2016-05-11 Thread Sandhya Bankar
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL. Signed-off-by: Sandhya Bankar ---

[PATCH 2/3] usb: dwc3-keystone: Remove unnecessary platform_set_drvdata().

2016-05-11 Thread Sandhya Bankar
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL Signed-off-by: Sandhya Bankar ---

[PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().

2016-05-11 Thread Sandhya Bankar
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL. Signed-off-by: Sandhya Bankar ---

[PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata().

2016-05-11 Thread Sandhya Bankar
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver datato NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. Sandhya Bankar (3): usb: pci: Remove unnecessary pci_set_drvdata().

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-05-11 Thread Hongzhou Yang
On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote: > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun > wrote: > > > the default mode of GPIO16 pin is gpio, when set EINT16 to > > IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be > > fixed when set its

Downloading tracks from gps via usb

2016-05-11 Thread Stephen Furner
When using Gebabbel to download tracks from a Garmin GPSMAP96 I am receiving the error message: "The original error message reported by gpsbabel was: Claim interfaced failed: could not claim interface 0: Operation not permitted" My OS is Ubuntu 14.04 LTS running on a Samsung N150 plus. The GPS

[PATCH] usb: dwc3: st: Fix USB_DR_MODE_PERIPHERAL configuration.

2016-05-11 Thread Peter Griffin
Set USB3_FORCE_VBUSVALID when configured for USB_DR_MODE_PERIPHERAL mode, as it is required to have a working setup. This worked on the internal driver by relying on the reset value of the syscfg register as the bits aren't explicity cleared and set like the upstream driver. Also add a comment

Re: [PATCH 3/6] dt-bindings: mtu3: add devicetree bindings

2016-05-11 Thread Rob Herring
On Tue, May 10, 2016 at 04:23:31PM +0800, Chunfeng Yun wrote: > add a DT binding doc for MediaTek USB3 DRD driver > > Signed-off-by: Chunfeng Yun > --- > Documentation/devicetree/bindings/usb/mtu3.txt | 86 > > 1 file changed, 86

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

2016-05-11 Thread Guenter Roeck
Hi, On Wed, May 11, 2016 at 12:40:11PM +0300, Heikki Krogerus wrote: > On Tue, May 10, 2016 at 08:14:34PM -0700, Guenter Roeck wrote: > > Heikki, > > > > On 05/06/2016 01:08 AM, Heikki Krogerus wrote: > > > Hi, > > > > > [ ... ] > > > > > > I don't have not made any new code for the class

Re: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-11 Thread Alan Stern
On Wed, 11 May 2016, Roger Quadros wrote: > > What I mean is if you have 2 EHCI controllers with 2 companion > > controllers, don't you need to know which companion goes with which EHCI > > controller? Just like you do for the otg-controller property. > > > > That is a very good point. I'm

[PATCH v8 1/5] usb: dwc3: omap: use request_threaded_irq()

2016-05-11 Thread Roger Quadros
We intend to share this interrupt with the OTG driver an to ensure that irqflags match for the shared interrupt handlers we use request_threaded_irq() If we don't use request_treaded_irq() then forced threaded irq will set IRQF_ONESHOT and this won't match with the OTG IRQ handler's IRQ flags.

[PATCH v8 0/5] dwc3: omap: fixes and dual-role preparation

2016-05-11 Thread Roger Quadros
Hi Felipe, I've removed the patches that add dual role support. These are just some fixes can go in before any actual dual role support. About the OTG software mailbox, I tried checking internally in TI but nobody was aware of any constraints. The events can be set as they are obtained from the

[PATCH v8 5/5] usb: dwc3: core: cleanup IRQ resources

2016-05-11 Thread Roger Quadros
Implementations might use different IRQs for host, gadget and OTG so use named interrupt resources to allow Device tree to specify the 3 interrupts. Following are the interrupt names Peripheral Interrupt - peripheral HOST Interrupt - host OTG Interrupt - otg We still maintain backward

[PATCH v8 3/5] usb: dwc3: omap: Don't set POWERPRESENT

2016-05-11 Thread Roger Quadros
TRM [1] recommends that POWERPRESENT bit must not be set and left at it's default value of 0. [1] OMAP542x TRM - http://www.ti.com/lit/pdf/swpu249 Section 23.11.4.5.1 Mailbox VBUS/ID Management "Because PIPE powerpresent has a different meaning in host and in device mode, and because of the

[PATCH v8 2/5] usb: dwc3: omap: Mark the interrupt handler as shared

2016-05-11 Thread Roger Quadros
On OMAPs, OTG events come on the same IRQ so we need to share this IRQ with the OTG device driver. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/dwc3-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c

[PATCH v8 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently

2016-05-11 Thread Roger Quadros
Don't make any decisions regarding VBUS session based on ID status. That is best left to the OTG core. Pass ID and VBUS events independent of each other so that OTG core knows exactly what to do. This makes dual-role with extcon work with OTG irq on OMAP platforms. Signed-off-by: Roger Quadros

Re: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-11 Thread Roger Quadros
On 11/05/16 16:54, Rob Herring wrote: > On Wed, May 04, 2016 at 04:47:18PM +0300, Roger Quadros wrote: >> On 04/05/16 16:17, Rob Herring wrote: >>> On Mon, May 02, 2016 at 03:18:53PM +0300, Roger Quadros wrote: From: Yoshihiro Shimoda Since some

Re: [PATCH v7 1/5] usb: dwc3: omap: use request_threaded_irq()

2016-05-11 Thread Roger Quadros
On 11/05/16 15:39, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > static irqreturn_t dwc3_omap_threaded_interrupt(int irq, void *_omap) > { > struct dwc3_omap *omap = _omap; > u32 reg; > > spin_lock(>lock); Do we

Re: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-11 Thread Rob Herring
On Wed, May 04, 2016 at 04:47:18PM +0300, Roger Quadros wrote: > On 04/05/16 16:17, Rob Herring wrote: > > On Mon, May 02, 2016 at 03:18:53PM +0300, Roger Quadros wrote: > >> From: Yoshihiro Shimoda > >> > >> Since some host controller (e.g. EHCI) needs a

[RFC PATCH v2 3/4] ARM: dts: vfxxx: Make Vybrid match only on it's own compatible string

2016-05-11 Thread Sanchayan Maity
Remove the compatible string "fsl,imx27-usb" from being used to match on usb device nodes for Vybrid. This is required for specifying that Vybrid USB controller is a dual role but not a true OTG controller using the CI_HDRC_DUAL_ROLE_NOT_OTG flag in the corresponding ci_hdrc_imx driver.

[RFC PATCH v2 2/4] usb: chipidea: otg: Do not rely on OTG with CI_HDRC_DUAL_ROLE_NOT_OTG

2016-05-11 Thread Sanchayan Maity
If CI_HDRC_DUAL_ROLE_NOT_OTG is specified do not use the OTGSC registers. Signed-off-by: Sanchayan Maity --- drivers/usb/chipidea/otg.c | 40 ++-- 1 file changed, 34 insertions(+), 6 deletions(-) diff --git

[RFC PATCH v2 4/4] ARM: dts: vf-colibri: USB device/host switch using extcon gpio

2016-05-11 Thread Sanchayan Maity
Use USBC_DET feature of standard Colibri SODIMM pin 137 for USB device/host switching using the generic extcon USB gpio implementation. Signed-off-by: Sanchayan Maity --- arch/arm/boot/dts/vf-colibri-eval-v3.dtsi | 12 arch/arm/boot/dts/vf-colibri.dtsi

[RFC PATCH v2 1/4] usb: chipidea: ci_hdrc_imx: Introduce CI_HDRC_DUAL_ROLE_NOT_OTG for Vybrid

2016-05-11 Thread Sanchayan Maity
The Vybrid SoC has a dual role device which can be configured to act as a host or device through firmware interface, but, it is not a true OTG controller. Use the CI_HDRC_DUAL_ROLE_NOT_OTG in the platform flag, introduce a new platform data structure for Vybrid and match on the compatible string

[RFC PATCH v2 0/4] Implement USB device/host switch for Vybrid

2016-05-11 Thread Sanchayan Maity
Hello Peter, The following set of patches are generated after applying your [1]. usb: chipidea: add flag CI_HDRC_DP_ALWAYS_PULLUP usb: chipidea: improve the OTG handler These somewhat work for me but I believe it is slightly racy considering the fact that we use the same extcon for both vbus

Re: [PATCH v7 1/5] usb: dwc3: omap: use request_threaded_irq()

2016-05-11 Thread Felipe Balbi
Hi, Roger Quadros writes: static irqreturn_t dwc3_omap_threaded_interrupt(int irq, void *_omap) { struct dwc3_omap *omap = _omap; u32 reg; spin_lock(>lock); >>> >>> Do we really need a spin_lock for the dwc3-omap driver? >>>

Re: [PATCH v7 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops

2016-05-11 Thread Roger Quadros
Peter, On 11/05/16 14:02, Roger Quadros wrote: > On 11/05/16 09:10, Peter Chen wrote: >> On Mon, May 02, 2016 at 03:18:48PM +0300, Roger Quadros wrote: >>> This is to prevent missing symbol build error if OTG is >>> enabled (built-in) and HCD core (CONFIG_USB) is module. >>> >>> Signed-off-by:

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-11 Thread Michal Nazarewicz
On Wed, May 11 2016, Felipe Balbi wrote: > Also, returning -EOVERFLOW is not exactly correct here, because you'd > violate POSIX specification of read(), right ? Maybe we could piggyback on: EINVAL fd was created via a call to timerfd_create(2) and the wrong size buffer was

Re: [PATCH 6/6] pinctrl: mt8173: set GPIO16 to usb iddig mode

2016-05-11 Thread Linus Walleij
On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun wrote: > the default mode of GPIO16 pin is gpio, when set EINT16 to > IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be > fixed when set its default mode as usb iddig. > > Signed-off-by: Chunfeng Yun

Re: [PATCH v7 1/5] usb: dwc3: omap: use request_threaded_irq()

2016-05-11 Thread Roger Quadros
On 11/05/16 12:47, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> Roger Quadros writes: >> @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device >> *pdev) >> /* check the DMA Status */ >> reg =

Re: xhci_handle_command_timeout and wait_for_completion

2016-05-11 Thread Mathias Nyman
On 10.05.2016 17:04, Joe Lawrence wrote: On 05/09/2016 06:18 AM, Mathias Nyman wrote: On 06.05.2016 23:32, Joe Lawrence wrote: ...snip... Given that the default command timeout is 5 seconds, it seems strange to hit a 120 second hung task warning in this instance. I can only think that maybe

Re: [PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-11 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > From: "Du, Changbin" > > Since the buffer size for req is rounded up to maxpacketsize, > then we may end up with more data then user space has space > for. only for OUT direction with the controller you're using ;-) > If it happen, we

Re: [PATCH v7 00/14] USB OTG/dual-role framework

2016-05-11 Thread Roger Quadros
On 11/05/16 11:36, Peter Chen wrote: > On Mon, May 02, 2016 at 03:18:43PM +0300, Roger Quadros wrote: >> Hi, >> >> This series centralizes OTG/Dual-role functionality in the kernel. >> As of now I've got Dual-role functionality working pretty reliably on >> dra7-evm and am437x-gp-evm. >> >> DWC3

Re: [PATCH v7 09/14] usb: of: add an API to get OTG device from USB controller node

2016-05-11 Thread Roger Quadros
On 11/05/16 11:40, Peter Chen wrote: > On Mon, May 02, 2016 at 03:18:52PM +0300, Roger Quadros wrote: >> The OTG controller and the USB controller an be linked via the > > Typo? Will fix. cheers, -roger > > Others are ok for me. > > Acked-by: Peter Chen > >>

Re: [PATCH v7 08/14] usb: otg: add OTG/dual-role core

2016-05-11 Thread Roger Quadros
On 11/05/16 11:34, Peter Chen wrote: > On Mon, May 02, 2016 at 03:18:51PM +0300, Roger Quadros wrote: >> + >> +if (config->otg_work) /* custom otg_work ? */ >> +INIT_WORK(>work, config->otg_work); >> +else >> +INIT_WORK(>work, usb_drd_work); >> + >> +otg->wq =

Re: [PATCH v7 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops

2016-05-11 Thread Roger Quadros
On 11/05/16 09:10, Peter Chen wrote: > On Mon, May 02, 2016 at 03:18:48PM +0300, Roger Quadros wrote: >> This is to prevent missing symbol build error if OTG is >> enabled (built-in) and HCD core (CONFIG_USB) is module. >> >> Signed-off-by: Roger Quadros >> Acked-by: Peter Chen

[PATCH] usb: gadget: f_fs: report error if excess data received

2016-05-11 Thread changbin . du
From: "Du, Changbin" Since the buffer size for req is rounded up to maxpacketsize, then we may end up with more data then user space has space for. If it happen, we can keep the excess data for next i/o, or report an error. But we cannot silently drop data, because USB

Re: [PATCH v7 1/5] usb: dwc3: omap: use request_threaded_irq()

2016-05-11 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger Quadros writes: > @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device > *pdev) > /* check the DMA Status */ > reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG); > > - ret =

Re: [PATCH v2] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support

2016-05-11 Thread Johan Hovold
On Tue, May 10, 2016 at 09:08:48AM +0200, Mathieu OTHACEHE wrote: > Add support for : > > - UPort 1110 : 1 port RS-232 USB to Serial Hub. > - UPort 1130 : 1 port RS-422/485 USB to Serial Hub. > - UPort 1130I : 1 port RS-422/485 USB to Serial Hub with Isolation. > - UPort 1150 : 1 port

Re: [PATCH 0/3] usb: USB Type-C Class and driver for UCSI

2016-05-11 Thread Heikki Krogerus
On Tue, May 10, 2016 at 08:14:34PM -0700, Guenter Roeck wrote: > Heikki, > > On 05/06/2016 01:08 AM, Heikki Krogerus wrote: > > Hi, > > > [ ... ] > > > > I don't have not made any new code for the class driver yet, but I'm > > attempting to prepare v2 next week. > > > Would it make sense to

Re: [PATCH v7 14/14] usb: host: xhci-plat: Add otg device to platform data

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:57PM +0300, Roger Quadros wrote: > Host controllers that are part of an OTG/dual-role instance > need to somehow pass the OTG controller device information > to the HCD core. > > We use platform data to pass the OTG controller device. > > Signed-off-by: Roger

Re: [PATCH v7 12/14] usb: hcd: Adapt to OTG core

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:55PM +0300, Roger Quadros wrote: > Introduce usb_otg_add/remove_hcd() for use by host > controllers that are part of OTG/dual-role port. > > Non Device tree platforms can use the otg_dev argument > to specify the OTG controller device. If otg_dev is NULL > then the

Re: [PATCH v7 11/14] usb: otg: use dev_dbg() instead of VDBG()

2016-05-11 Thread Peter Chen
On Mon, May 09, 2016 at 12:48:28PM +0300, Roger Quadros wrote: > On 06/05/16 12:04, Peter Chen wrote: > > On Mon, May 02, 2016 at 03:18:54PM +0300, Roger Quadros wrote: > >> Now that we have a device reference in struct usb_otg > >> let's use dev_dbg() for debug messages. > >> > >> Signed-off-by:

Re: [PATCH v7 10/14] usb: otg: add hcd companion support

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:53PM +0300, Roger Quadros wrote: > From: Yoshihiro Shimoda > > Since some host controller (e.g. EHCI) needs a companion host controller > (e.g. OHCI), this patch adds such a configuration to use it in the OTG > core. > >

Re: [PATCH v7 09/14] usb: of: add an API to get OTG device from USB controller node

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:52PM +0300, Roger Quadros wrote: > The OTG controller and the USB controller an be linked via the Typo? Others are ok for me. Acked-by: Peter Chen > 'otg-controller' property in the USB controller's device node. > > of_usb_get_otg() can be

Re: [PATCH v7 00/14] USB OTG/dual-role framework

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:43PM +0300, Roger Quadros wrote: > Hi, > > This series centralizes OTG/Dual-role functionality in the kernel. > As of now I've got Dual-role functionality working pretty reliably on > dra7-evm and am437x-gp-evm. > > DWC3 controller and platform related patches will

Re: [PATCH v7 08/14] usb: otg: add OTG/dual-role core

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:51PM +0300, Roger Quadros wrote: > + > + if (config->otg_work) /* custom otg_work ? */ > + INIT_WORK(>work, config->otg_work); > + else > + INIT_WORK(>work, usb_drd_work); > + > + otg->wq =

Re: [PATCH v7 07/14] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:50PM +0300, Roger Quadros wrote: > Let's use CONFIG_USB_OTG as a single config option to enable > USB OTG and the OTG FSM. This makes things a lot less confusing. > > Update all users of CONFIG_USB_OTG_FSM to CONFIG_USB_OTG. > > Signed-off-by: Roger Quadros

Re: [PATCH v7 1/5] usb: dwc3: omap: use request_threaded_irq()

2016-05-11 Thread Roger Quadros
Felipe, On 10/05/16 13:12, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: @@ -497,8 +503,8 @@ static int dwc3_omap_probe(struct platform_device *pdev) /* check the DMA Status */ reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);

Re: [PATCH v7 02/14] usb: otg-fsm: Prevent build warning "VDBG" redefined

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:45PM +0300, Roger Quadros wrote: > If usb/otg-fsm.h and usb/composite.h are included together > then it results in the build warning [1]. > > Prevent that by defining VDBG locally. > > Also get rid of MPC_LOC which doesn't seem to be used > by anyone. > > [1] -

Re: [PATCH v7 03/14] usb: hcd.h: Add OTG to HCD interface

2016-05-11 Thread Peter Chen
On Tue, May 10, 2016 at 12:20:28PM +0300, Roger Quadros wrote: > On 10/05/16 11:03, Jun Li wrote: > > Hi > > > >> -Original Message- > >> From: Roger Quadros [mailto:rog...@ti.com] > >> Sent: Tuesday, May 10, 2016 3:35 PM > >> To: Peter Chen > >> Cc:

Re: [PATCH v7 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops

2016-05-11 Thread Peter Chen
On Mon, May 02, 2016 at 03:18:48PM +0300, Roger Quadros wrote: > This is to prevent missing symbol build error if OTG is > enabled (built-in) and HCD core (CONFIG_USB) is module. > > Signed-off-by: Roger Quadros > Acked-by: Peter Chen > --- >

Re: 03f0:521d Hewlett-Packard

2016-05-11 Thread Aleksander Morgado
On Thu, Apr 21, 2016 at 7:15 AM, mirkt wrote: > Bus 001 Device 007: ID 03f0:521d Hewlett-Packard > Device Descriptor: > bLength18 > bDescriptorType 1 > bcdUSB 2.00 > bDeviceClass 255 Vendor Specific Class > bDeviceSubClass