Re: [PATCH] hid: migrate Riso Kagaku LED driver from USB misc to HID

2016-05-28 Thread Heiner Kallweit
Am 27.05.2016 um 23:45 schrieb Benjamin Tissoires: > On May 27 2016 or thereabouts, Heiner Kallweit wrote: >> The Riso Kagaku Webmail Notifier (and its clones) is supported as part of >> usb/misc/usbled driver currently. This patch migrates the driver for this >> device to the HID subsystem. >> >>

Re: [OOPS] cppi41_dma_channel_program: Unable to handle kernel NULL pointer dereference

2016-05-28 Thread Matwey V. Kornilov
2016-05-23 16:36 GMT+03:00 Bin Liu : > Hi, > > On Sat, May 21, 2016 at 10:04:48PM +0300, Matwey V. Kornilov wrote: >> 2016-05-21 20:50 GMT+03:00 Matwey V. Kornilov : >> > 2016-05-21 6:13 GMT+03:00 Bin Liu : >> >> Hi, >> >> >> >> On Fri, May 20,

Re: [patch] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-28 Thread Michal Nazarewicz
On Sat, May 28 2016, Dan Carpenter wrote: > Try compiling the code you suggested. I find this amusing to be perfectly honest. Kernel uses designated initialisers, flexible array members, stdint.h, compound literals and variadic macros, yet still for some reason sticks to -std=gnu89. No matter,

Re: [patch] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-28 Thread Dan Carpenter
On Sat, May 28, 2016 at 12:15:24PM +0200, Michal Nazarewicz wrote: > On Sat, May 28 2016, Dan Carpenter wrote: > > Also in the kernel we have to declare variables at the start of the > > block. > > /me shrugs > > I looked at this out of curiosity and there are precedents: > > $ git grep

Re: [patch] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-28 Thread Dan Carpenter
On Sat, May 28, 2016 at 12:15:24PM +0200, Michal Nazarewicz wrote: > On Sat, May 28 2016, Dan Carpenter wrote: > > Also in the kernel we have to declare variables at the start of the > > block. > > /me shrugs > > I looked at this out of curiosity and there are precedents: > > $ git grep

Re: [PATCH v5] input: tablet: add Pegasus Notetaker tablet driver

2016-05-28 Thread Martin Kepplinger
Hi Dmitry, Thanks again for your help! Only one comment below... Am 2016-05-27 um 23:59 schrieb Dmitry Torokhov: > Hi Martin, > >> +static void pegasus_parse_packet(struct pegasus *pegasus) >> +{ >> +unsigned char *data = pegasus->data; >> +struct input_dev *dev = pegasus->dev; >> +

Re: [patch v2] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-28 Thread Michal Nazarewicz
On Sat, May 28 2016, Dan Carpenter wrote: > This loop is supposed to set all the .num[] values to -1 but it's off by > one so it skips the first element and sets one element past the end of > the array. > > I've cleaned up the loop a little as well. > > Fixes: ddf8abd25994 ('USB: f_fs: the

Re: [patch] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-28 Thread Michal Nazarewicz
On Sat, May 28 2016, Dan Carpenter wrote: > Also in the kernel we have to declare variables at the start of the > block. /me shrugs I looked at this out of curiosity and there are precedents: $ git grep 'for (\(int\|unsigned\|signed\|long\|char\)[[:space:]]' |wc -l 19 (albeit mostly in

Re: [patch v2] usb: f_fs: off by one bug in _ffs_func_bind()

2016-05-28 Thread walter harms
much better readable than the original. nice work re, wh Am 28.05.2016 06:48, schrieb Dan Carpenter: > This loop is supposed to set all the .num[] values to -1 but it's off by > one so it skips the first element and sets one element past the end of > the array. > > I've cleaned up the loop a

Re: SuperH 7760 OHCI

2016-05-28 Thread Martin Townsend
On Thu, May 26, 2016 at 8:04 PM, Alan Stern wrote: > On Thu, 26 May 2016, Martin Townsend wrote: > >> >> and setting the HCD_MEMORY_LOCAL flag in the HC driver. >> > >> > Did you do this correctly? That is, in the correct driver? >> > >> I put the code for the