Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

2016-07-08 Thread kbuild test robot
Hi, [auto build test WARNING on phy/next] [also build test WARNING on v4.7-rc6 next-20160708] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rajesh-Bhagat/drivers-usb-chipidea-Add-qoriq

[PATCH v2 0/5] drivers: usb: chipidea: Add qoriq platform

2016-07-08 Thread Rajesh Bhagat
Adds qoriq platform driver for chipidea controller as well as qoriq usb 2.0 phy driver. Also, enables chipidea driver and QorIQ USB 2.0 PHY driver on LS1021A platform. Rajesh Bhagat (5): drivers: usb: chipidea: Add qoriq platform driver usb: DT binding documentation for qoriq usb 2.0

[PATCH v2 5/5] arm: dts: ls1021a: enable chipidea driver and USB 2.0 PHY driver

2016-07-08 Thread Rajesh Bhagat
This patch adds entries in dts to enable chipidea platform driver and USB 2.0 PHY driver. Signed-off-by: Rajesh Bhagat --- Changes in v2: - Reworked for latest changes arch/arm/boot/dts/ls1021a.dtsi | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-)

[PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller

2016-07-08 Thread Rajesh Bhagat
Describes the qoriq usb 2.0 controller driver binding, currently used for LS1021A and LS1012A platform. Signed-off-by: Rajesh Bhagat --- Changes in v2: - Adds DT binding documentation for qoriq usb 2.0 controller - Changed the compatible string to fsl,ci-qoriq-usb2

[PATCH v2 3/5] drivers: usb: phy: Add qoriq usb 2.0 phy driver support

2016-07-08 Thread Rajesh Bhagat
Adds qoriq usb 2.0 phy driver support for LS1021A and LS1012A platform. Signed-off-by: Rajesh Bhagat --- Changes in v2: - Replaced Freescale with QorIQ in comments section - Changed the compatible string to fsl,qoriq-usb2-phy and added version - Added dependency on

[PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver

2016-07-08 Thread Rajesh Bhagat
Adds qoriq platform driver for chipidea controller, verfied on LS1021A and LS1012A platforms. Signed-off-by: Rajesh Bhagat --- Changes in v2: - Replaced Freescale with QorIQ in comments section - Added macros to remove hardcoding while programming registers - Changed

[PATCH v2 4/5] phy: DT binding documentation for qoriq usb 2.0 phy

2016-07-08 Thread Rajesh Bhagat
Describes the qoriq usb 2.0 phy driver binding, currently used for LS1021A and LS1012A platform. Signed-off-by: Rajesh Bhagat --- Changes in v2: - Adds DT binding documentation for qoriq usb 2.0 phy - Changed the compatible string to fsl,qoriq-usb2-phy

Re: [PATCH net] r8152: remove the setting of LAN_WAKE_EN

2016-07-08 Thread David Miller
From: Hayes Wang Date: Wed, 6 Jul 2016 17:03:29 +0800 > The LAN_WAKE_EN is not used to determine if the device could support > WOL. It is used to sigal a GPIO pin when a WOL event occurs. The WOL > still works even though it is disabled. > > Signed-off-by: Hayes Wang

Re: [PATCH v6 3/5] usb: dwc3: add phyif_utmi_quirk

2016-07-08 Thread William.wu
Dear Heiko & Balbi, On 2016/7/8 21:29, Felipe Balbi wrote: Hi, Heiko Stuebner writes: Am Donnerstag, 7. Juli 2016, 10:54:24 schrieb William Wu: Add a quirk to configure the core to support the UTMI+ PHY with an 8- or 16-bit interface. UTMI+ PHY interface is hardware

Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

2016-07-08 Thread Dmitry Torokhov
On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote: > Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov: > > Hi Martin, > > > > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote: > >> static int pegasus_reset_resume(struct usb_interface *intf) > >> { > >> + struct

[PATCH 3/3] usb: phy: generic: remove the vbus dependency

2016-07-08 Thread Robert Jarzmik
As the last known user, ie. pxa27x_udc relying on calls to usb_gadget_xxx() was amended to use the phy notifier, remove a bit the USB stack adherence. Actually the driver still uses the gadget API for structures definition, but the implementation of USB gadget specific function usb_gadget_*() is

[PATCH 2/3] usb: phy: generic: cope with initial state

2016-07-08 Thread Robert Jarzmik
In the gpio based case, the status of the phy is known at start by reading the VBus gpio. Actually, this is a fix, as this initial state, when not set up, prevents a gadget to answer to the enumeration phase, as there is no notification in this case (the VBus is already high when kernel boots) so

[PATCH 1/3] usb: gadget: pxa27x: add phy notifier event handler

2016-07-08 Thread Robert Jarzmik
In the legacy behavior, and USB phy, upon detection a VBus signal, was calling usb_gadget_vbus_(dis)connect(). This model doesn't work if the phy is generic and doesn't have an adherence to the gadget API. Instead of relying on the phy to call the gadget API, hook up the phy notifier to report

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-08 Thread Michal Nazarewicz
On Fri, Jul 08 2016, Felipe Balbi wrote: > My take on this is that it's calling max_t() to try and align to > wMaxPacketSize. We can see from original commit what was the intent: > > commit 03d27ade4941076b34c823d63d91dc895731a595 > Author: Felipe F. Tonello > Date: Wed

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-08 Thread Michal Nazarewicz
> Baolin Wang writes: >> @@ -359,10 +361,12 @@ static int f_midi_set_alt(struct usb_function *f, >> unsigned intf, unsigned alt) >> >> /* allocate a bunch of read buffers and queue them all at once. */ >> for (i = 0; i < midi->qlen && err == 0; i++) { >> -

Re: [PATCH v2 1/2] usb: gadget: legacy: Add udc module param to all legacy gadgets

2016-07-08 Thread Krzysztof Opasiak
On 07/08/2016 08:56 AM, Peter Chen wrote: > On Thu, Jul 07, 2016 at 02:17:57PM +0200, Krzysztof Opasiak wrote: >> Add new module parameter called "udc" to all legacy gadgets. >> By using this parameter user can choose a controller towhich >> this gadget should be bound. >> >> This may be useful

Re: [PATCH v6 3/5] usb: dwc3: add phyif_utmi_quirk

2016-07-08 Thread Felipe Balbi
Hi, Heiko Stuebner writes: > Am Donnerstag, 7. Juli 2016, 10:54:24 schrieb William Wu: >> Add a quirk to configure the core to support the >> UTMI+ PHY with an 8- or 16-bit interface. UTMI+ PHY >> interface is hardware property, and it's platform >> dependent. Normall, the

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-08 Thread Felipe Balbi
Hi again, Felipe Balbi writes: > Michal Nazarewicz writes: >> On Fri, Jul 08 2016, Baolin Wang wrote: >>> On 7 July 2016 at 20:51, Michal Nazarewicz wrote: On Thu, Jul 07 2016, Baolin Wang wrote: > Some gadget device (such as

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-08 Thread Felipe Balbi
Hi, Michal Nazarewicz writes: > On Fri, Jul 08 2016, Baolin Wang wrote: >> On 7 July 2016 at 20:51, Michal Nazarewicz wrote: >>> On Thu, Jul 07 2016, Baolin Wang wrote: Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-08 Thread Felipe Balbi
Hi, Baolin Wang writes: > Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size > attribute, which means it need to align the request buffer's size to an ep's > maxpacketsize. > > Thus we add usb_ep_align_maybe() function to check if it is need to

Re: [PATCH] usb: gadget: f_midi: Add checking if it need align buffer's size to an ep's maxpacketsize

2016-07-08 Thread Michal Nazarewicz
On Fri, Jul 08 2016, Baolin Wang wrote: > On 7 July 2016 at 20:51, Michal Nazarewicz wrote: >> On Thu, Jul 07 2016, Baolin Wang wrote: >>> Some gadget device (such as dwc3 gadget) requires quirk_ep_out_aligned_size >>> attribute, which means it need to align the request

Re: [PATCH v6 3/5] usb: dwc3: add phyif_utmi_quirk

2016-07-08 Thread Heiko Stuebner
Hi William, Am Donnerstag, 7. Juli 2016, 10:54:24 schrieb William Wu: > Add a quirk to configure the core to support the > UTMI+ PHY with an 8- or 16-bit interface. UTMI+ PHY > interface is hardware property, and it's platform > dependent. Normall, the PHYIf can be configured > during

[PATCH] USB: bcma: initialize Northstar USB 3.0 controller

2016-07-08 Thread Rafał Miłecki
It's a rather simple controller, we just need to make sure USB is powered (using GPIO pin) and reset bus core. Once this is done it's safe to register XHCI controller and let it init PHY and do its magic. Signed-off-by: Rafał Miłecki --- drivers/usb/host/bcma-hcd.c | 19

Re: [PATCH] usb/gadget: fix gadgetfs aio support

2016-07-08 Thread Mathieu Laurendeau
I'll resend the patch. Sorry for the noise. Le 08/07/2016 13:01, Sergei Shtylyov a écrit : > Hello. > > On 7/8/2016 9:15 AM, Mathieu Laurendeau wrote: > >> Hi, > >Greetings should not be a part of the patch description. > >> Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget:

Re: [PATCH] usb/gadget: fix gadgetfs aio support

2016-07-08 Thread Sergei Shtylyov
Hello. On 7/8/2016 9:15 AM, Mathieu Laurendeau wrote: Hi, Greetings should not be a part of the patch description. Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch ep_io_operations to ->read_iter/->write_iter") io submissions fail with ENODEV. Fixes: 7fe3976e0f3a

Re: [PATCH 1/1] usb: udc: core: fix error handling

2016-07-08 Thread Felipe Balbi
Hi, Peter Chen writes: > The udc device needs to be deleted if error occurs > > Fixes: 855ed04a (usb: gadget: udc-core: independent registration of gadgets > and gadget drivers) it's preferred that the abbreviation is done with 12 characters and commit subject be wrapped

Re: [PATCH] usb/gadget: fix gadgetfs aio support

2016-07-08 Thread kbuild test robot
-support/20160708-164431 base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/compiler.h

Re: [PATCH v2 08/22] usb: chipidea: Remove locking in ci_udc_start()

2016-07-08 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:20:59PM -0700, Stephen Boyd wrote: > We don't call hw_device_reset() with the ci->lock held, so it > doesn't seem like this lock here is protecting anything. Let's > just remove it. This allows us to call sleeping functions like > phy_init() from within the

Re: [PATCH v2 07/22] usb: chipidea: Notify events when switching host mode

2016-07-08 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:20:58PM -0700, Stephen Boyd wrote: > The chipidea/udc.c file sends a CI_HDRC_CONTROLLER_RESET_EVENT to > the wrapper drivers when it calls hw_device_reset(), but that > function is not called from chipidea/host.c. And the udc.c file > sends the

Re: [PATCH] usb/gadget: fix gadgetfs aio support

2016-07-08 Thread kbuild test robot
-support/20160708-164431 base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next config: x86_64-randconfig-s5-07081546 (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached .config to linux build tree make ARCH=x86_64

Re: [PATCH v2 06/22] usb: chipidea: Add platform flag for wrapper phy management

2016-07-08 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:20:57PM -0700, Stephen Boyd wrote: > The ULPI phy on qcom platforms needs to be initialized and > powered on after a USB reset and before we toggle the run/stop > bit. Otherwise, the phy locks up and doesn't work properly. > Therefore, add a flag to skip any phy power

Re: [PATCH] usb/gadget: fix gadgetfs aio support

2016-07-08 Thread kbuild test robot
-support/20160708-164431 base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next config: i386-randconfig-r0-07081252 (attached as .config) compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 reproduce: # save the attached .config to linux build tree make ARCH=i386

[peter.chen-usb:pwrseq-lib 4/7] ERROR: "pwrseq_get" [drivers/usb/core/usbcore.ko] undefined!

2016-07-08 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git pwrseq-lib head: 72289855b3d236efef879059b315940de9e80df2 commit: bda499ece3edc6187490ad32238bcc65075d80d5 [4/7] usb: core: add power sequence handling for USB devices config: i386-allmodconfig (attached as .config)

Re: [PATCH v2 04/22] usb: chipidea: Only read/write OTGSC from one place

2016-07-08 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:20:55PM -0700, Stephen Boyd wrote: > With the id and vbus detection done via extcon we need to make > sure we poll the status of OTGSC properly by considering what the > extcon is saying, and not just what the register is saying. Let's > move this hw_wait_reg() function

Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties

2016-07-08 Thread Peter Chen
On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote: > @@ -39,6 +42,10 @@ static int ulpi_match(struct device *dev, struct > device_driver *driver) > struct ulpi *ulpi = to_ulpi_dev(dev); > const struct ulpi_device_id *id; > > + /* Some ULPI devices don't have a product

[PATCH] usb/gadget: fix gadgetfs aio support

2016-07-08 Thread Mathieu Laurendeau
Hi, Since commit 7fe3976e0f3ab26f8ffd9430d3d2a19a70f2c8d2 ("gadget: switch ep_io_operations to ->read_iter/->write_iter") io submissions fail with ENODEV. Fixes: 7fe3976e0f3a ("gadget: switch ep_io_operations to ->read_iter/->write_iter") Signed-off-by: Mathieu Laurendeau

[PATCH 2/2] usb: Kconfig: move ulpi bus to common

2016-07-08 Thread Peter Chen
The ULPI bus is not only for host, but for device mode too, so move it out from host's Kconfig. Cc: Heikki Krogerus Signed-off-by: Peter Chen --- drivers/usb/common/Kconfig | 21 + drivers/usb/core/Kconfig | 21

[PATCH 1/2] usb: Kconfig: move common things under usb/common

2016-07-08 Thread Peter Chen
It can simplify root Kconfig Signed-off-by: Peter Chen --- drivers/usb/Kconfig| 10 +- drivers/usb/common/Kconfig | 9 + 2 files changed, 10 insertions(+), 9 deletions(-) create mode 100644 drivers/usb/common/Kconfig diff --git

[PATCH 1/1] usb: udc: core: fix error handling

2016-07-08 Thread Peter Chen
The udc device needs to be deleted if error occurs Fixes: 855ed04a (usb: gadget: udc-core: independent registration of gadgets and gadget drivers) Signed-off-by: Peter Chen --- drivers/usb/gadget/udc/core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH v2 1/2] usb: gadget: legacy: Add udc module param to all legacy gadgets

2016-07-08 Thread Peter Chen
On Thu, Jul 07, 2016 at 02:17:57PM +0200, Krzysztof Opasiak wrote: > Add new module parameter called "udc" to all legacy gadgets. > By using this parameter user can choose a controller towhich > this gadget should be bound. > > This may be useful esp. when having multiple controllers > or

[peter.chen-usb:pwrseq-lib 4/7] drivers/usb/core/pwrseq.c:52:23-29: ERROR: application of sizeof to pointer

2016-07-08 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git pwrseq-lib head: 72289855b3d236efef879059b315940de9e80df2 commit: bda499ece3edc6187490ad32238bcc65075d80d5 [4/7] usb: core: add power sequence handling for USB devices coccinelle warnings: (new ones prefixed by >>)

[PATCH] usb: core: fix noderef.cocci warnings

2016-07-08 Thread kbuild test robot
drivers/usb/core/pwrseq.c:52:23-29: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci Signed-off-by: Fengguang Wu --- pwrseq.c |2 +- 1 file

[PATCH] power: fix noderef.cocci warnings

2016-07-08 Thread kbuild test robot
drivers/power/pwrseq/pwrseq_generic.c:121:22-28: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci Signed-off-by: Fengguang Wu ---

[peter.chen-usb:pwrseq-lib 2/7] drivers/power/pwrseq/pwrseq_generic.c:121:22-28: ERROR: application of sizeof to pointer

2016-07-08 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git pwrseq-lib head: 72289855b3d236efef879059b315940de9e80df2 commit: 36fe54395583ac3cd6f704a8b3b1dd8c18b8ac04 [2/7] power: add power sequence library coccinelle warnings: (new ones prefixed by >>) >>