[PATCH v2 1/1] usb: xhci: clean up error_bitmask usage

2016-10-20 Thread Lu Baolu
In xhci_handle_event(), when errors are detected, driver always sets a bit in error_bitmask (one member of the xhci private driver data). That means users have to retrieve and decode the value of error_bitmask in xhci private driver data if they want to know whether those erros ever happened in

Re: [PATCH v5 23/23] phy: Add support for Qualcomm's USB HS phy

2016-10-20 Thread Peter Chen
On Thu, Oct 20, 2016 at 04:20:38PM -0700, Stephen Boyd wrote: > Quoting Stephen Boyd (2016-10-17 18:56:36) > > + > > +static int > > +qcom_usb_hs_phy_vbus_notifier(struct notifier_block *nb, unsigned long > > event, > > + void *ptr) > > +{ > > + struct

Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable path

2016-10-20 Thread Peter Chen
On Thu, Oct 20, 2016 at 01:36:30PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-20 03:10:18) > > On Wed, Oct 19, 2016 at 11:55:29PM -0700, Stephen Boyd wrote: > > > Quoting Peter Chen (2016-10-19 01:02:11) > > > > On Tue, Oct 18, 2016 at 06:53:07PM -0700, Stephen Boyd wrote: > > > > >

Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

2016-10-20 Thread Chen Yu
On 2016/10/19 6:21, John Youn wrote: > On 10/16/2016 7:42 PM, Chen Yu wrote: >> >> >> On 2016/10/15 3:37, John Youn wrote: >>> On 10/13/2016 4:36 PM, John Stultz wrote: From: Chen Yu The Hi6220's usb controller is limited in that it does not automatically

Re: [RESEND PATCH v2 4/4] usb: doc: add document for USB3 debug port usage

2016-10-20 Thread Lu Baolu
Hi, On 10/20/2016 04:30 PM, Jani Nikula wrote: > On Thu, 20 Oct 2016, Lu Baolu wrote: >> Hi Jani, >> >> On 10/19/2016 03:48 PM, Jani Nikula wrote: >>> On Wed, 19 Oct 2016, Lu Baolu wrote: Add Documentation/usb/usb3-debug-port.txt. This

Re: [RESEND PATCH v2 1/4] usb: dbc: early driver for xhci debug capability

2016-10-20 Thread Lu Baolu
Hi Peter, On 10/20/2016 05:08 PM, Peter Zijlstra wrote: > On Thu, Oct 20, 2016 at 10:41:32AM +0200, Peter Zijlstra wrote: >> I'm already only using early_printk() because regular printk() is an >> unfixable piece of crap, and now you're making early_printk() useless >> too. > Note that the

Re: [PATCH v5 23/23] phy: Add support for Qualcomm's USB HS phy

2016-10-20 Thread Stephen Boyd
Quoting Stephen Boyd (2016-10-17 18:56:36) > + > +static int > +qcom_usb_hs_phy_vbus_notifier(struct notifier_block *nb, unsigned long event, > + void *ptr) > +{ > + struct qcom_usb_hs_phy *uphy; > + int is_host; > + u8 addr; > + > + uphy =

Etron EJ188/EJ198 USB 3.0 Host Controller is very unstable

2016-10-20 Thread pengu1n
Hello, I have a motherboard ASRock FM2A88X Extreme4+ which has this USB 3.0 Controller: 03:00.0 USB controller [0c03]: Etron Technology, Inc. EJ188/EJ198 USB 3.0 Host Controller [1b6f:7052] The USB ports that belong to this controller are very unstable, practically unusable on my system. Below

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

2016-10-20 Thread Ladislav Michl
On Thu, Oct 20, 2016 at 05:35:24AM -0700, Tony Lindgren wrote: > Hi, > > * Ladislav Michl [161020 01:24]: > > On Wed, Oct 19, 2016 at 12:03:38PM -0500, Bin Liu wrote: > > > Hi Greg, > > > > > > Here are musb pm fixes for v4.9-rc2. Please let me know if any change is > > >

[PATCH v9 2/2] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset

2016-10-20 Thread Randy Li
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. We'll use the reset that's in the CRU to reset the port when it's in a bad state. Note that we add the reset to both dwc2 controllers

[PATCH v9 0/2] the fixup for the USB HOST1 at rk3288 platform

2016-10-20 Thread Randy Li
changelog: v9 use a work_queue to reset usb phy to prevent access mutex lock at interrupter runtime. v8 minior fixup v7 add the forgot dummy phy_reset() for the generic phy is disabled. v7 Some minor fixup v6 Send the last two patches v5 A few modification at style, add the missing doc

[PATCH v9 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-10-20 Thread Randy Li
On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state by asserting its "port reset", but

Re: [PATCH] Documentation: usb: the dumb conversion to Sphinx

2016-10-20 Thread Jonathan Corbet
On Thu, 20 Oct 2016 18:22:28 +0200 Oliver Neukum wrote: > > Why does this not remove the .tmpl file? > > 1. We might want to keep it > 2. It is an operation beyond the scope of this patch. I have to disagree with this part; the last thing we want is two copies of the

Re: [PATCH] Documentation: usb: the dumb conversion to Sphinx

2016-10-20 Thread Oliver Neukum
On Thu, 2016-10-20 at 18:04 +0300, Jani Nikula wrote: > On Thu, 20 Oct 2016, Oliver Neukum wrote: Hi, > > This just is the result of the conversion script and its addition > > to the index. Just the plain automatic conversion. > > How does this relate to [1]? It is the

Re: [PATCH] USB: update intro of documentation

2016-10-20 Thread Rami Rosen
Hi Oliver, Thanks for your patch. Typo: Should be "their" instead of " thei1r" in the following paragraph: > Device driver authors should make a point of doing disconnect > testing (while the device is active) with each different host > controller driver, to make sure drivers

musb RPM sleep-while-atomic in 4.9-rc1

2016-10-20 Thread Johan Hovold
Hi Tony, I'm getting the splat below when booting 4.9-rc1 on a BBB and tracked it down to 65b3f50ed6fa ("usb: musb: Add PM runtime support for MUSB DSPS glue layer") which added a synchronous RPM get in a timer callback: [6.466226] BUG: sleeping function called from invalid context at

Re: [PATCH] dt-bindings: usb: atmel: fix a couple of copy-paste style typos

2016-10-20 Thread Alexandre Belloni
On 18/10/2016 at 13:58:44 +0200, Nicolas Ferre wrote : > Le 18/10/2016 à 13:05, Peter Rosin a écrit : > > Signed-off-by: Peter Rosin > > Acked-by: Nicolas Ferre > > We may take it in a future at91-x.y-dt branch which will go through arm-soc. > >

[PATCH 0/3] xhci fixes for usb-linus

2016-10-20 Thread Mathias Nyman
Hi Greg A few xhci fixes for usb-linus. Prevent restart at poweroff for Intel Wildcatpoint xhci, and fix resume realated issues Mathias Nyman (3): xhci: add restart quirk for Intel Wildcatpoint PCH xhci: workaround for hosts missing CAS bit xhci: use default USB_RESUME_TIMEOUT when

[PATCH 2/3] xhci: workaround for hosts missing CAS bit

2016-10-20 Thread Mathias Nyman
If a device is unplugged and replugged during Sx system suspend some Intel xHC hosts will overwrite the CAS (Cold attach status) flag and no device connection is noticed in resume. A device in this state can be identified in resume if its link state is in polling or compliance mode, and the

[PATCH 3/3] xhci: use default USB_RESUME_TIMEOUT when resuming ports.

2016-10-20 Thread Mathias Nyman
USB2 host inititated resume, and system suspend bus resume need to use the same USB_RESUME_TIMEOUT as elsewhere. This resolves a device disconnect issue at system resume seen on Intel Braswell and Apollolake, but is in no way limited to those platforms. Signed-off-by: Mathias Nyman

[PATCH 1/3] xhci: add restart quirk for Intel Wildcatpoint PCH

2016-10-20 Thread Mathias Nyman
xHC in Wildcatpoint-LP PCH is similar to LynxPoint-LP and need the same quirks to prevent machines from spurious restart while shutting them down. Reported-by: Hasan Mahmood CC: Signed-off-by: Mathias Nyman ---

Re: [PATCH] Documentation: usb: the dumb conversion to Sphinx

2016-10-20 Thread Jani Nikula
On Thu, 20 Oct 2016, Oliver Neukum wrote: > This just is the result of the conversion script and its addition > to the index. Just the plain automatic conversion. How does this relate to [1]? Why does this not remove the .tmpl file? BR, Jani. [1]

[PATCH] Documentation: usb: the dumb conversion to Sphinx

2016-10-20 Thread Oliver Neukum
This just is the result of the conversion script and its addition to the index. Just the plain automatic conversion. Signed-off-by: Oliver Neukum --- Documentation/index.rst | 1 + Documentation/usb/conf.py | 5 + Documentation/usb/usb.rst | 750

[PATCH v11 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-20 Thread Martyn Welch
This patch adds support for the GPIO found on the CP2105. Unlike the GPIO provided by some of the other devices supported by the cp210x driver, the GPIO on the CP2015 is muxed on pins otherwise used for serial control lines. The GPIO have been configured in 2 separate banks as the choice to

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-10-20 Thread Alan Stern
On Thu, 20 Oct 2016, Lukas Wunner wrote: > On Tue, Oct 11, 2016 at 11:18:28AM -0400, Alan Stern wrote: > > On Sat, 8 Oct 2016, Lukas Wunner wrote: > > > The PCI core already calls pm_runtime_get_sync() before invoking the > > > ->probe hook of a driver (see local_pci_probe()). Drivers need to >

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-20 Thread Martyn Welch
On Thu, Oct 20, 2016 at 10:49:24AM +0200, Johan Hovold wrote: > On Thu, Oct 20, 2016 at 09:13:41AM +0100, Martyn Welch wrote: > > + /* 2 banks of GPIO - One for the pins taken from each serial port */ > > + if (intf_num == 0) { > > + if (mode.eci == 0) > > Would you mind explaining

[PATCH] USB: update intro of documentation

2016-10-20 Thread Oliver Neukum
It does no good to mention The 2.4 kernel series and neglect USB 3.x and XHCI. Also with type C and micro/mini USB we better not talk about the shape of connectors. Signed-off-by: Oliver Neukum --- Documentation/DocBook/usb.tmpl | 68 +++---

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

2016-10-20 Thread Tony Lindgren
Hi, * Ladislav Michl [161020 01:24]: > On Wed, Oct 19, 2016 at 12:03:38PM -0500, Bin Liu wrote: > > Hi Greg, > > > > Here are musb pm fixes for v4.9-rc2. Please let me know if any change is > > needed. > > Hi Bin, Tony, > > just moved away from 4.6 where musb worked

[PATCH] ARM: dts: imx50: remove non-existent USB instances

2016-10-20 Thread Alexander Kurz
According to the i.MX50 Reference Manual, the SOC features one USB OTG and one host controller. Remove the non-existent instances from the SOC DTS which probably got initially copied from the mx53 DTS. Signed-off-by: Alexander Kurz --- arch/arm/boot/dts/imx50-evk.dts | 8

Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable path

2016-10-20 Thread Peter Chen
On Wed, Oct 19, 2016 at 11:55:29PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-19 01:02:11) > > On Tue, Oct 18, 2016 at 06:53:07PM -0700, Stephen Boyd wrote: > > > If you're asking if I've made modifications to extcon-usb-gpio, then the > > > answer is no. The branch on linaro.org git

Re: USB hot-plug not working (ASUS TP301UA-C4028T)

2016-10-20 Thread Lukas Wunner
On Tue, Oct 11, 2016 at 11:18:28AM -0400, Alan Stern wrote: > On Sat, 8 Oct 2016, Lukas Wunner wrote: > > The PCI core already calls pm_runtime_get_sync() before invoking the > > ->probe hook of a driver (see local_pci_probe()). Drivers need to > > explicitly release a runtime ref to allow their

Re: [RESEND PATCH v2 1/4] usb: dbc: early driver for xhci debug capability

2016-10-20 Thread Peter Zijlstra
On Thu, Oct 20, 2016 at 10:41:32AM +0200, Peter Zijlstra wrote: > I'm already only using early_printk() because regular printk() is an > unfixable piece of crap, and now you're making early_printk() useless > too. Note that the existing USB debug port stuff doesn't seem to have a single lock in.

Re: [PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-20 Thread Johan Hovold
On Thu, Oct 20, 2016 at 09:13:41AM +0100, Martyn Welch wrote: > This patch adds support for the GPIO found on the CP2105. Unlike the GPIO > provided by some of the other devices supported by the cp210x driver, the > GPIO on the CP2015 is muxed on pins otherwise used for serial control > lines. The

Re: Interactive whiteboards

2016-10-20 Thread María Cano
>> HITACHI STARBOARD (DOESN’T WORK) >> DIFF FOR cat /proc/bus/input/devices >> > T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 12 Spd=12 MxCh= 0 >> > D: Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 >> > P: Vendor=10c4 ProdID=0661 Rev= 0.00 >> > S: Manufacturer=SZiB0rdelectronics

Re: [RESEND PATCH v2 1/4] usb: dbc: early driver for xhci debug capability

2016-10-20 Thread Peter Zijlstra
On Thu, Oct 20, 2016 at 04:08:17PM +0800, Lu Baolu wrote: > Hi Peter, > > Thanks for your comments. > > On 10/19/2016 09:09 PM, Peter Zijlstra wrote: > > On Wed, Oct 19, 2016 at 08:18:22AM +0800, Lu Baolu wrote: > >> +++ b/drivers/usb/early/xhci-dbc.c > >> +static int xdbc_bulk_write(const char

Re: [RESEND PATCH v2 4/4] usb: doc: add document for USB3 debug port usage

2016-10-20 Thread Jani Nikula
On Thu, 20 Oct 2016, Lu Baolu wrote: > Hi Jani, > > On 10/19/2016 03:48 PM, Jani Nikula wrote: >> On Wed, 19 Oct 2016, Lu Baolu wrote: >>> Add Documentation/usb/usb3-debug-port.txt. This document includes >>> the user guide for USB3 debug port.

Re: [PATCH 0/2] musb-fixes for v4.9-rc2

2016-10-20 Thread Ladislav Michl
On Wed, Oct 19, 2016 at 12:03:38PM -0500, Bin Liu wrote: > Hi Greg, > > Here are musb pm fixes for v4.9-rc2. Please let me know if any change is > needed. Hi Bin, Tony, just moved away from 4.6 where musb worked (well, not quite reliably, but...) in host only mode with dma on dm3730. Later

Re: Interactive whiteboards

2016-10-20 Thread Greg KH
On Thu, Oct 20, 2016 at 10:09:22AM +0200, María Cano wrote: > I have to visit other school where I work too, but here is a summary > of datas found related with the whiteboard we have. I have to say It > is a summary because we have several whiteboards that are apparently > made by the same

[PATCH v10 1/1] USB: serial: cp210x: Adding GPIO support for CP2105

2016-10-20 Thread Martyn Welch
This patch adds support for the GPIO found on the CP2105. Unlike the GPIO provided by some of the other devices supported by the cp210x driver, the GPIO on the CP2015 is muxed on pins otherwise used for serial control lines. The GPIO have been configured in 2 separate banks as the choice to

Re: [RESEND PATCH v2 1/4] usb: dbc: early driver for xhci debug capability

2016-10-20 Thread Lu Baolu
Hi Peter, Thanks for your comments. On 10/19/2016 09:09 PM, Peter Zijlstra wrote: > On Wed, Oct 19, 2016 at 08:18:22AM +0800, Lu Baolu wrote: >> +++ b/drivers/usb/early/xhci-dbc.c >> +static int xdbc_bulk_write(const char *bytes, int size) >> +{ >> +unsigned long flags; >> +int ret,

Re: Interactive whiteboards

2016-10-20 Thread María Cano
I have to visit other school where I work too, but here is a summary of datas found related with the whiteboard we have. I have to say It is a summary because we have several whiteboards that are apparently made by the same manufacturer and get exactly the same output device so internally work

Re: usb_ep_{dis,en}able() calling context (was: Re: [PATCH 2/3] usb: dwc3: gadget: wait for End Transfer to complete)

2016-10-20 Thread Baolin Wang
Hi, On 19 October 2016 at 18:09, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >> >> We should not check the DWC3_EP_ENABLED flag, since we will clear all >> flags in __dwc3_gadget_ep_disable() after setting >>

[RFC][PATCH] usb: dwc2: Make sure we disconnect the gadget state on reset

2016-10-20 Thread John Stultz
I had seen some odd behavior with HiKey's usb-gadget interface that I finally seemed to have chased down. Basically every other time I pluged in the OTG port, the gadget interface would properly initialize. The other times, I'd get a big WARN_ON in dwc2_hsotg_init_fifo() about the fifo_map not