Re: [RFC PATCH] usb: core: correct usb_get_dev() documentation

On Thu, Oct 27, 2016 at 04:49:18PM -0700, Dmitry Torokhov wrote: > On Thu, Oct 27, 2016 at 03:02:30PM -0700, Brian Norris wrote: > > In reading through a USB interface driver, I noticed that it called > > usb_{get,put}_dev() in its probe() and disconnect() methods. This seemed > > unnecessary, but

Re: [PATCH v2 3/3] usb: musb: da8xx: Only execute the OTG workaround when phy in OTG mode

On 10/26/2016 05:58 AM, Alexandre Bailon wrote: When the phy is forced in host mode, only the first hot plug and hot remove works. That is actually because the driver execute the OTG workaround, whereas it is not applicable in host or device mode. Indeed, to work correctly, the VBUS sense and

RE: [PATCH 3/3] usb: dwc3: host: Do not use dma_coerce_mask_and_coherent

>From: Arnd Bergmann [mailto:a...@arndb.de] >On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote: >> Do not use dma_coerce_mask_and_coherent for hcd. >> >> Signed-off-by: Arnd Bergmann > >The patch is good, but please follow the usual rules for submitting someone

Re: [RFC PATCH] usb: core: correct usb_get_dev() documentation

On Thu, Oct 27, 2016 at 03:02:30PM -0700, Brian Norris wrote: > In reading through a USB interface driver, I noticed that it called > usb_{get,put}_dev() in its probe() and disconnect() methods. This seemed > unnecessary, but a look at the comments here matched the usage. > > USB interface

Re: [PATCH] USB: update intro of documentation

On Mon, 24 Oct 2016 14:25:27 +0200 Greg KH wrote: > I don't have any objection to the changes, please take them through your > documentation tree: I have now done so. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message

[RFC PATCH] usb: core: correct usb_get_dev() documentation

In reading through a USB interface driver, I noticed that it called usb_{get,put}_dev() in its probe() and disconnect() methods. This seemed unnecessary, but a look at the comments here matched the usage. USB interface devices seem to be well covered by the parent/child relationship of the device

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Thu, Oct 27 2016, Baolin Wang wrote: > Hi Felipe, > > On 19 October 2016 at 10:37, Baolin Wang wrote: >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >>

Re: [PATCH 13/15] Documentation: devicetree: dwc2: Add host DMA binding

On 10/26/2016 3:07 PM, Rob Herring wrote: > On Wed, Oct 19, 2016 at 06:22:52PM -0700, John Youn wrote: >> Add the host-dma property to devicetree. This controls whether to use >> DMA in host mode. >> >> Signed-off-by: John Youn >> --- >>

Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation

On 10/26/2016 3:22 AM, Sergei Shtylyov wrote: > Hello. > > On 10/25/2016 10:42 PM, John Youn wrote: > >> Add interrupt moderation interval binding for dwc3. >> >> Signed-off-by: John Youn >> --- >> Documentation/devicetree/bindings/usb/dwc3.txt | 1 + >> 1 file changed,

Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation

On 10/27/2016 3:47 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> Add interrupt moderation interval binding for dwc3. >> >> Signed-off-by: John Youn >> --- >> Documentation/devicetree/bindings/usb/dwc3.txt | 1 + >> 1 file changed, 1

Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation

On 10/26/2016 3:57 AM, Mark Rutland wrote: > On Tue, Oct 25, 2016 at 12:42:46PM -0700, John Youn wrote: >> Add interrupt moderation interval binding for dwc3. >> >> Signed-off-by: John Youn >> --- >> Documentation/devicetree/bindings/usb/dwc3.txt | 1 + >> 1 file changed,

Re: [PATCH] kalmia: avoid potential uninitialized variable use

From: Arnd Bergmann Date: Mon, 24 Oct 2016 17:54:18 +0200 > The kalmia_send_init_packet() returns zero or a negative return > code, but gcc has no way of knowing that there cannot be a > positive return code, so it determines that copying the ethernet > address at the end of

Re: musb RPM sleep-while-atomic in 4.9-rc1

* Johan Hovold [161027 11:46]: > On Thu, Oct 27, 2016 at 10:40:17AM -0700, Tony Lindgren wrote: > > And that one I must have hosed when cleaning up, thanks for noticing > > these. Updated patch below. > > I had a couple of inline comments to the previous version about locking >

Re: Identifying Synopsys USB3 Controller on Baytrail Device

Hi Felipe, That's some great information, thanks! At first glance, the DSDT table has two interesting bits. (I would paste the decompiled source, but I think it may be copyrighted? Correct me if I'm wrong.) The first is the USB mux, an SMSC USB3750 connected to I2C1. According to the datasheet,

Re: musb RPM sleep-while-atomic in 4.9-rc1

On Thu, Oct 27, 2016 at 10:40:17AM -0700, Tony Lindgren wrote: > * Johan Hovold [161027 09:45]: > > On Thu, Oct 27, 2016 at 08:14:46AM -0700, Tony Lindgren wrote: > > > * Tony Lindgren [161026 07:32]: > > > > > 8< --- > > > From

Re: [PATCH v2 0/3] usb: musb: da8xx: Fix few issues

On 10/27/2016 12:16 PM, David Lechner wrote: On 10/26/2016 05:58 AM, Alexandre Bailon wrote: Currently, the USB OTG of the da8xx doesn't work. This series intend to fix them. Change in v2: * Fix the error path da8xx_musb_init() Alexandre Bailon (3): usb: musb: da8xx: Call earlier

[PATCH v3 0/4] Add DT support for DA8xx

Changes in v2: * Remove unrelated changes in patch 3 * Rename the device node in patch 4 Changes in v3: * Fix few mistakes in DT binding sample * Only build the device table if DT is enabled Alexandre Bailon (1): ARM: dts: da850: Add the usb otg device node Petr Kulhavy (3): dt/bindings:

Re: musb RPM sleep-while-atomic in 4.9-rc1

* Johan Hovold [161027 09:45]: > On Thu, Oct 27, 2016 at 08:14:46AM -0700, Tony Lindgren wrote: > > * Tony Lindgren [161026 07:32]: > > > 8< --- > > From tony Mon Sep 17 00:00:00 2001 > > From: Tony Lindgren > >

Re: [PATCH v2 0/3] usb: musb: da8xx: Fix few issues

On 10/26/2016 05:58 AM, Alexandre Bailon wrote: Currently, the USB OTG of the da8xx doesn't work. This series intend to fix them. Change in v2: * Fix the error path da8xx_musb_init() Alexandre Bailon (3): usb: musb: da8xx: Call earlier clk_prepare_enable() phy: da8xx-usb: Configure

Re: musb RPM sleep-while-atomic in 4.9-rc1

On Thu, Oct 27, 2016 at 08:14:46AM -0700, Tony Lindgren wrote: > * Tony Lindgren [161026 07:32]: > 8< --- > From tony Mon Sep 17 00:00:00 2001 > From: Tony Lindgren > Date: Tue, 25 Oct 2016 08:42:00 -0700 > Subject: [PATCH] usb:

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

On Thu, Oct 06, 2016 at 12:08:26PM +0300, Ville Syrjälä wrote: > On Thu, Oct 06, 2016 at 10:36:09AM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Felipe Balbi writes: > > > Okay, I have found a regression on dwc3 and another patch follows: > > > > commit

[PATCH v3 4/4] ARM: dts: da850: Add the usb otg device node

This adds the device tree node for the usb otg controller present in the da850 family of SoC's. This also enables the otg usb controller for the lcdk board. Signed-off-by: Alexandre Bailon --- arch/arm/boot/dts/da850-lcdk.dts | 8 arch/arm/boot/dts/da850.dtsi

Re: musb RPM sleep-while-atomic in 4.9-rc1

* Tony Lindgren [161026 07:32]: > * Johan Hovold [161026 07:21]: > > On Tue, Oct 25, 2016 at 08:11:10AM -0700, Tony Lindgren wrote: > > > * Johan Hovold [161025 01:33]: > > > > On Mon, Oct 24, 2016 at 10:35:38AM -0700, Tony Lindgren wrote: >

[PATCH v3 3/4] usb: musb: da8xx: Add DT support for the DA8xx driver

From: Petr Kulhavy This adds DT support for TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon Tested-by: David Lechner --- drivers/usb/musb/da8xx.c | 46

Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver

On Wed, Oct 19, 2016 at 10:28:19AM +0800, Chunfeng Yun wrote: > These patches introduce the MediaTek USB3 dual-role controller > driver. > > The driver can be configured as Dual-Role Device (DRD), > Peripheral Only and Host Only (xHCI) modes. It works well > with Mass Storage, RNDIS and g_zero on

[PATCH v3 1/4] dt/bindings: Add binding for the DA8xx MUSB driver

From: Petr Kulhavy DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx MUSB driver. Signed-off-by: Petr Kulhavy Signed-off-by: Alexandre Bailon --- .../devicetree/bindings/usb/da8xx-usb.txt | 43 ++ 1 file

[PATCH 6/7] usb: dwc3: pci: add a private driver structure

We'll be tracking a little more information for PCI drivers, it's about time we add a private structure for that. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-pci.c | 49 +++-- 1 file changed, 34 insertions(+), 15

[PATCH v3 2/4] usb: musb: core: added helper function for parsing DT

From: Petr Kulhavy This adds the function musb_get_mode() to get the DT property "dr_mode" Signed-off-by: Petr Kulhavy Acked-by: Sergei Shtylyov Signed-off-by: Alexandre Bailon Tested-by: David Lechner

patch "tty: vgacon+sisusb, move scrolldelta to a common helper" added to tty-testing

This is a note to let you know that I've just added the patch titled tty: vgacon+sisusb, move scrolldelta to a common helper to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-testing branch. The patch will show up in the

patch "tty: vt, cleanup and document con_scroll" added to tty-testing

This is a note to let you know that I've just added the patch titled tty: vt, cleanup and document con_scroll to my tty git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git in the tty-testing branch. The patch will show up in the next release of

Re: [PATCH] USB: OHCI: make ohci-da8xx a separate driver

On Thu, Oct 27, 2016 at 2:58 AM, David Lechner wrote: > On 10/26/2016 04:08 PM, ahas...@baylibre.com wrote: > >> +module_exit(ohci_da8xx_exit); >> +MODULE_DESCRIPTION(DRIVER_DESC); >> +MODULE_LICENSE("GPL"); >> MODULE_ALIAS("platform:ohci"); > > > The "ohci" in

Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation

Hi, John Youn writes: > Add interrupt moderation interval binding for dwc3. > > Signed-off-by: John Youn > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[PATCH 1/7] usb: dwc3: gadget: cope with XferNotReady before usb_ep_queue()

If XferNotReady comes before usb_ep_queue() we will set our PENDING request flag and wait for a request. However, originally, we were assuming usb_ep_queue() would always happen before our first XferNotReady and that causes a corner case where we could try to issue ENDTRANSFER command before

[PATCH 4/7] usb: dwc3: gadget: stop touching HWO TRBs

Say we have three requests prepared to the HW (reqA, reqB, and reqC). All of them are composed of SG-lists with several entries and they all requests interrupt only on last TRBs of the SG-list. When we get interrupt for reqA, it could be that reqB is already half-way transferred and some of its

[PATCH 2/7] usb: dwc3: gadget: tracking per-TRB remaining bytes

This will give us a simpler way of figuring out how many bytes were left in each TRB. It's useful for cases where we queue only part of an SG-list due to amount of available TRBs at the time of kicking the transfer. Signed-off-by: Felipe Balbi ---

[PATCH 5/7] usb: dwc3: gadget: always kick if num_pending_sgs > 0

When we get a half-way processed request, we should make sure to try to prepare further TRBs for it or for any possibly queued up request held in our pending_list. This will make sure our controller is kept busy for as long as possible. Signed-off-by: Felipe Balbi

[PATCH 3/7] usb: dwc3: gadget: always try to prepare on started_list first

In cases where we're given an SG-list which is longer than the amount of currently available TRBs, we will be left with the same request on started_list and we should prioritize that request over possible new requests on pending_list. That's a way to guarantee requests complete in order.

[PATCH 7/7] usb: dwc3: pci: call _DSM for suspend/resume

Intel's BXT devices need to execute a _DSM method during {runtime_,}{suspend,resume} in order to get a chunk of dwc3 to power gate and save some extra power. Let's do that now. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-pci.c | 73

[PATCH v2] USB: OHCI: make ohci-da8xx a separate driver

From: Manjunath Goudar Separate the Davinci OHCI host controller driver from ohci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM Tested-by: David Lechner

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

Hi Felipe, On 19 October 2016 at 10:37, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add