Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
Hi, On 20 December 2016 at 15:18, Lu Baolu wrote: > Hi, > > On 12/20/2016 02:46 PM, Baolin Wang wrote: >> On 20 December 2016 at 14:39, Lu Baolu wrote: >>> Hi, >>> >>> On 12/20/2016 02:06 PM, Baolin Wang wrote: Hi, On 20

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Lu Baolu
Hi, On 12/20/2016 02:46 PM, Baolin Wang wrote: > On 20 December 2016 at 14:39, Lu Baolu wrote: >> Hi, >> >> On 12/20/2016 02:06 PM, Baolin Wang wrote: >>> Hi, >>> >>> On 20 December 2016 at 12:29, Lu Baolu wrote: Hi Mathias, On

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-19 Thread Baolin Wang
Hi Neil, On 3 November 2016 at 09:25, NeilBrown wrote: > On Tue, Nov 01 2016, Baolin Wang wrote: > > >>> So I won't be responding on this topic any further until I see a genuine >>> attempt to understand and resolve the inconsistencies with >>> usb_register_notifier(). >> >> Any

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
On 20 December 2016 at 14:39, Lu Baolu wrote: > Hi, > > On 12/20/2016 02:06 PM, Baolin Wang wrote: >> Hi, >> >> On 20 December 2016 at 12:29, Lu Baolu wrote: >>> Hi Mathias, >>> >>> On 12/19/2016 08:13 PM, Mathias Nyman wrote: On

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Lu Baolu
Hi, On 12/20/2016 02:06 PM, Baolin Wang wrote: > Hi, > > On 20 December 2016 at 12:29, Lu Baolu wrote: >> Hi Mathias, >> >> On 12/19/2016 08:13 PM, Mathias Nyman wrote: >>> On 19.12.2016 13:34, Baolin Wang wrote: Hi Mathias, On 19 December 2016 at 18:33,

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
Hi, On 20 December 2016 at 12:29, Lu Baolu wrote: > Hi Mathias, > > On 12/19/2016 08:13 PM, Mathias Nyman wrote: >> On 19.12.2016 13:34, Baolin Wang wrote: >>> Hi Mathias, >>> >>> On 19 December 2016 at 18:33, Mathias Nyman >>> wrote:

[PATCH v2 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
If a command event is found on the event ring during an interrupt, we need to stop the command timer with del_timer(). Since del_timer() can fail if the timer is running and waiting on the xHCI lock, then it maybe get the wrong timeout command in xhci_handle_command_timeout() if host fetched a new

[peter.chen-usb:pwrseq-lib 4/9] warning: (USB) selects POWER_SEQUENCE which has unmet direct dependencies (OF)

2016-12-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git pwrseq-lib head: 284f898fe1c6ea79103391c1b1384694567732c2 commit: 1b4828637fb0c5b4ac844290a3127bf8769f9f61 [4/9] usb: core: add power sequence handling for USB devices config: x86_64-randconfig-x006-201651 (attached as

Re: [PATCH v10 0/8] power: add power sequence library

2016-12-19 Thread Peter Chen
On Mon, Dec 19, 2016 at 09:15:04PM +0200, Krzysztof Kozlowski wrote: > On Mon, Nov 14, 2016 at 09:35:51AM +0800, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of >

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Lu Baolu
Hi Mathias, On 12/19/2016 08:13 PM, Mathias Nyman wrote: > On 19.12.2016 13:34, Baolin Wang wrote: >> Hi Mathias, >> >> On 19 December 2016 at 18:33, Mathias Nyman >> wrote: >>> On 13.12.2016 05:21, Baolin Wang wrote: Hi Mathias, On 12 December

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
On 19 December 2016 at 20:13, Mathias Nyman wrote: > On 19.12.2016 13:34, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 19 December 2016 at 18:33, Mathias Nyman >> wrote: >>> >>> On 13.12.2016 05:21, Baolin Wang wrote: Hi

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

2016-12-19 Thread Russell Senior
>> Apart from the two additional tests mentioned above, can you also >> provide a log from when connecting the device using the following commit >> that I just pushed to the ch341 branch: >> >> f341ee36198d ("dbg: ch341: add register dumps to probe") >> >> which provides dumps of the

Re: [PATCH 2/2] usb: musb: blackfin: add bfin_fifo_offset in bfin_ops

2016-12-19 Thread Bin Liu
On Fri, Dec 16, 2016 at 07:19:40PM -0500, Jérémy Lefaure wrote: > Commit cc92f6818f6e ("usb: musb: Populate new IO functions for > blackfin") defines bfin_fifo_offset function without using it: Please use 'Fixes:' comment style. Regards, -Bin. > > drivers/usb/musb/blackfin.c:36:12: warning:

Re: [PATCH 1/2] usb: musb: blackfin: fix unused warnings on suspend/resume

2016-12-19 Thread Bin Liu
On Fri, Dec 16, 2016 at 07:19:39PM -0500, Jérémy Lefaure wrote: > When CONFIG_PM_SLEEP is disabled, SIMPLE_DEV_PM_OPS does not use > bfin_resume and bfin_suspend even if CONFIG_PM is enabled: > > drivers/usb/musb/blackfin.c:602:12: warning: ‘bfin_resume’ defined but > not used [-Wunused-function]

Re: [PATCH v3] usb: musb: debugfs: allow forcing host mode together with speed in testmode

2016-12-19 Thread Bin Liu
On Mon, Dec 19, 2016 at 04:23:47PM +0100, Pali Rohár wrote: > Based on the musb ug, force_host bit is allowed to be set along with > force_hs or force_fs bit. > > It could help to implement forced host mode via testmode on Nokia N900. > > Signed-off-by: Pali Rohár

[PATCH] usb: musb: fix runtime PM in debugfs

2016-12-19 Thread Bin Liu
MUSB driver now has runtime PM support, but the debugfs driver misses the PM _get/_put() calls, which could cause MUSB register access failure. Cc: sta...@vger.kernel.org # 4.9+ Signed-off-by: Bin Liu --- drivers/usb/musb/musb_debugfs.c | 20 +++- 1 file changed,

Re: [PATCH v10 0/8] power: add power sequence library

2016-12-19 Thread Krzysztof Kozlowski
On Mon, Nov 14, 2016 at 09:35:51AM +0800, Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > power sequence instances will be added at postcore_initcall, the match >

Re: [RFC PATCH] usb: USB Type-C connector class

2016-12-19 Thread Guenter Roeck
On 12/19/2016 06:45 AM, Heikki Krogerus wrote: The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power

[PATCH] USB: fix problems with duplicate endpoint addresses

2016-12-19 Thread Alan Stern
When checking a new device's descriptors, the USB core does not check for duplicate endpoint addresses. This can cause a problem when the sysfs files for those endpoints are created; trying to create multiple files with the same name will provoke a WARNING: WARNING: CPU: 2 PID: 865 at

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

2016-12-19 Thread Russell Senior
On Mon, Dec 19, 2016 at 2:58 AM, Johan Hovold wrote: > On Sat, Dec 17, 2016 at 03:27:43AM -0800, Russell Senior wrote: >> All testing is with minicom. > > Thanks for this through report. > >> Starting with 00013-gc510871: >> >> In 8-bit mode, interoperates correctly with

[PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-by: Stefan

[PATCH] usb: dwc2: gadget: Fix fifo size configuration

2016-12-19 Thread Stefan Wahren
Currently the upper limit for the endpoint index during fifo size config was always 16 instead of the available endpoints. So fix this by using the determined amount of endpoints and avoid a warning about "insufficient fifo memory" on bcm2835 which has only 8 endpoints. Signed-off-by: Stefan

[PATCH v3] usb: musb: debugfs: allow forcing host mode together with speed in testmode

2016-12-19 Thread Pali Rohár
Based on the musb ug, force_host bit is allowed to be set along with force_hs or force_fs bit. It could help to implement forced host mode via testmode on Nokia N900. Signed-off-by: Pali Rohár --- Changes in v2: * Use == instead of & for comparison of testmode Changes in

Re: [PATCH v2] usb: musb: debugfs: allow forcing host mode together with speed in testmode

2016-12-19 Thread Bin Liu
On Sun, Dec 18, 2016 at 12:54:40AM +0100, Pali Rohár wrote: > Based on the musb ug, force_host bit is allowed to be set along with > force_hs or force_fs bit. > > It could help to implement forced host mode via testmode on Nokia N900. > > Signed-off-by: Pali Rohár > --- >

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

2016-12-19 Thread Christian Lamparter
Hello John, hello Felipe On Monday, November 28, 2016 7:32:20 PM CET John Youn wrote: > On 11/22/2016 12:51 PM, Christian Lamparter wrote: > > On Monday, November 21, 2016 7:32:30 PM CET John Youn wrote: > >> On 11/21/2016 1:10 PM, Christian Lamparter wrote: > >>> On Monday, November 21, 2016

[RFC PATCH] usb: USB Type-C connector class

2016-12-19 Thread Heikki Krogerus
The purpose of USB Type-C connector class is to provide unified interface for the user space to get the status and basic information about USB Type-C connectors on a system, control over data role swapping, and when the port supports USB Power Delivery, also control over power role swapping and

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Mathias Nyman
On 19.12.2016 13:34, Baolin Wang wrote: Hi Mathias, On 19 December 2016 at 18:33, Mathias Nyman wrote: On 13.12.2016 05:21, Baolin Wang wrote: Hi Mathias, On 12 December 2016 at 23:52, Mathias Nyman wrote: On 05.12.2016

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Baolin Wang
Hi Mathias, On 19 December 2016 at 18:33, Mathias Nyman wrote: > On 13.12.2016 05:21, Baolin Wang wrote: >> >> Hi Mathias, >> >> On 12 December 2016 at 23:52, Mathias Nyman >> wrote: >>> >>> On 05.12.2016 09:51, Baolin Wang wrote:

Re: [PATCH v2] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

2016-12-19 Thread Johan Hovold
On Sun, Dec 18, 2016 at 10:19:28AM +0100, Geert Uytterhoeven wrote: > With gcc 4.1.2: > > drivers/usb/serial/f81534.c: In function ‘f81534_port_probe’: > drivers/usb/serial/f81534.c:1250: warning: comparison is always false due > to limited range of data type > >

Re: [PATCH] USB: cypress_m8: remove unused variable

2016-12-19 Thread Johan Hovold
On Sun, Dec 18, 2016 at 10:29:27PM +, Sudip Mukherjee wrote: > The variable havedata was only being set but never used afterwards. > > Signed-off-by: Sudip Mukherjee Thanks, I'll queue this up for 4.11. Johan -- To unsubscribe from this list: send the line

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

2016-12-19 Thread Johan Hovold
On Sat, Dec 17, 2016 at 03:27:43AM -0800, Russell Senior wrote: > All testing is with minicom. Thanks for this through report. > Starting with 00013-gc510871: > > In 8-bit mode, interoperates correctly with pl2303. Switching to > 5-bit mode on both sides (I get unicode boxes of indeterminate

Re: [PATCH 1/2] usb: xhci: switch to running avg trb length

2016-12-19 Thread Felipe Balbi
Hi, Felipe Balbi writes: > Hi, > > Felipe Balbi writes: >> It's unlikely that we will ever know the avg so >> instead of assuming it'll be something really large, >> we will calculate the avg as we go as mentioned in >> XHCI

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

2016-12-19 Thread Mathias Nyman
On 13.12.2016 05:21, Baolin Wang wrote: Hi Mathias, On 12 December 2016 at 23:52, Mathias Nyman wrote: On 05.12.2016 09:51, Baolin Wang wrote: If a command event is found on the event ring during an interrupt, we need to stop the command timer with

[PATCH v3 1/3] USB3/DWC3: Add definition for global soc bus configuration register

2016-12-19 Thread Changming Huang
Add the macro definition for global soc bus configuration register 0/1 Signed-off-by: Changming Huang --- Changes in v3: - no change Changes in v2: - split the patch - add more macro definition for soc bus configuration register drivers/usb/dwc3/core.h | 26

[PATCH v3 2/3] USB3/DWC3: Add property "snps,incr-burst-type-adjustment" for INCR burst type

2016-12-19 Thread Changming Huang
New property "snps,incr-burst-type-adjustment = , " for USB3.0 DWC3. Field "x": 1/0 - undefined length INCR burst type enable or not; Field "y": INCR4/INCR8/INCR16/INCR32/INCR64/INCR128/INCR256 burst type. While enabling undefined length INCR burst type and INCR16 burst type, get better write

[PATCH v3 3/3] USB3/DWC3: Enable undefined length INCR burst type

2016-12-19 Thread Changming Huang
Enable the undefined length INCR burst type and set INCRx. Different platform may has the different burst size type. In order to get best performance, we need to tune the burst size to one special value, instead of the default value. Signed-off-by: Changming Huang

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

2016-12-19 Thread Felipe Balbi
Hi, Jerry Huang writes: >> >> Jerry Huang writes: >> >> >> there's no need for that. This patch is in good format. I do have >> >> >> a question, >> >> >> however: how do you know this will work for all users? Burst size >> >> >> is a function of how

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

2016-12-19 Thread Jerry Huang
Hi, Balbi, > -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Saturday, December 17, 2016 1:02 AM > To: Jerry Huang ; gre...@linuxfoundation.org > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Rajesh Bhagat >