Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

Hi Mathias, I have some comments for the implementation of xhci_handle_command_timeout() as well. On 12/20/2016 11:13 PM, Mathias Nyman wrote: > On 20.12.2016 09:30, Baolin Wang wrote: > ... > > Alright, I gathered all current work related to xhci races and timeouts > and put them into a branch:

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

Hi Mathias, I have some comments for the implementation of xhci_abort_cmd_ring() below. On 12/20/2016 11:13 PM, Mathias Nyman wrote: > On 20.12.2016 09:30, Baolin Wang wrote: > ... > > Alright, I gathered all current work related to xhci races and timeouts > and put them into a branch: > >

Re: [PATCH 1/2] usb: musb: blackfin: fix unused warnings on suspend/resume

Hi Bin, On Mon, Dec 19, 2016 at 3:56 PM, Bin Liu wrote: > > On Fri, Dec 16, 2016 at 07:19:39PM -0500, Jérémy Lefaure wrote: > > When CONFIG_PM_SLEEP is disabled, SIMPLE_DEV_PM_OPS does not use > > bfin_resume and bfin_suspend even if CONFIG_PM is enabled: > > > >

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Wed, Dec 21 2016, Baolin Wang wrote: > Hi, > > On 21 December 2016 at 06:07, NeilBrown wrote: >> On Tue, Dec 20 2016, Baolin Wang wrote: >> >>> Hi Neil, >>> >>> On 3 November 2016 at 09:25, NeilBrown wrote: On Tue, Nov 01 2016, Baolin Wang wrote:

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

Hi, On 21 December 2016 at 06:07, NeilBrown wrote: > On Tue, Dec 20 2016, Baolin Wang wrote: > >> Hi Neil, >> >> On 3 November 2016 at 09:25, NeilBrown wrote: >>> On Tue, Nov 01 2016, Baolin Wang wrote: >>> >>> > So I won't be responding on this topic any

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

Hi Mathias, On 20 December 2016 at 23:13, Mathias Nyman wrote: > On 20.12.2016 09:30, Baolin Wang wrote: > ... > > Alright, I gathered all current work related to xhci races and timeouts > and put them into a branch: > >

Re: [PATCH 2/2] usb: gadget: printer: Remove pnp_string static buffer

Hi Krzysztof, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.9 next-20161220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Krzysztof-Opasiak/usb-gadget-ether-Add-n

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

On Tue, Dec 20 2016, Baolin Wang wrote: > Hi Neil, > > On 3 November 2016 at 09:25, NeilBrown wrote: >> On Tue, Nov 01 2016, Baolin Wang wrote: >> >> So I won't be responding on this topic any further until I see a genuine attempt to understand and resolve the

[PATCH] usb: host: oxu210hp-hcd: remove unused variable

The variable live was assigned the host controller running status but it was never used or checked after that. Signed-off-by: Sudip Mukherjee --- drivers/usb/host/oxu210hp-hcd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

* Ladislav Michl [161220 10:41]: > Hi Laurent, > > On Sat, Nov 12, 2016 at 03:21:24AM +0200, Laurent Pinchart wrote: > > Hi Bin, > > > > http://pandaboard.org/sites/default/files/board_reference/ES/750-2170-002-sch_revb.pdf > > > > It would seem that the voltage is

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Tue, Dec 20, 2016 at 12:09:55PM -0800, Russell Senior wrote: > On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold wrote: > > > Perhaps we should determine what else is working or broken first, > > though. > > > > Russel, could you test if break-signalling works, and if the > >

[PATCH v2] tools: usb: usbip: Update README

Update README file: - remove outdated parts - clarify terminology and general structure - add some description of vUDC Signed-off-by: Krzysztof Opasiak --- Changes since v1: - Add server and client definition - rephrase modules description --- tools/usb/usbip/README | 57

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Tue, Dec 20, 2016 at 8:07 AM, Johan Hovold wrote: > Perhaps we should determine what else is working or broken first, > though. > > Russel, could you test if break-signalling works, and if the > modem-control signals (DTR/RTS) are asserted at open? Do you get any >

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Tue, Dec 20, 2016 at 7:52 AM, Johan Hovold wrote: > On Tue, Dec 20, 2016 at 07:31:55AM -0800, Russell Senior wrote: >> Not sure what the complaint about keys is about, I had not seen that >> before. > > Related to module signing, not sure why you only see it with the vendor

[PATCH 1/2] usb: gadget: ether: Add \n to each attribute of ethernet functions

Generally in SysFS and ConfigFS files are new line terminated. Also most of USB functions adds a trailing newline to each attribute. Let's follow this convention also in ethernet functions. Signed-off-by: Krzysztof Opasiak --- drivers/usb/gadget/function/u_ether.c

[PATCH] usb: gadget: composite: Test get_alt() presence instead of set_alt()

By convention (according to doc) if function does not provide get_alt() callback composite framework should assume that it has only altsetting 0 and should respond with error if host tries to set other one. After commit dd4dff8b035f ("USB: composite: Fix bug: should test set_alt function pointer

[PATCH 2/2] usb: gadget: printer: Remove pnp_string static buffer

pnp string is usually much shorter than 1k so let's stop wasting 1k of memory for its buffer and make it dynamically alocated. This also removes 1k len limitation for pnp_string and adds a new line after string content if required. Signed-off-by: Krzysztof Opasiak ---

Re: [PATCH 0/4] musb fixes for v4.9-rc cycle

Hi Laurent, On Sat, Nov 12, 2016 at 03:21:24AM +0200, Laurent Pinchart wrote: > Hi Bin, > > http://pandaboard.org/sites/default/files/board_reference/ES/750-2170-002-sch_revb.pdf > > It would seem that the voltage is provided by the TWL6030. I'm not sure > what's > turning it on as the MUSB

[PATCH] usb: make the MTK XHCI driver compile for older MIPS SoCs

The MIPS based MT7621 shares the same XHCI core as the newer generation of ARM based SoCs. The driver works out of the box and we only need to make it buildable in Kconfig. Signed-off-by: John Crispin --- drivers/usb/host/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Tue, Dec 20, 2016 at 05:07:48PM +0100, Johan Hovold wrote: > On Tue, Dec 20, 2016 at 04:38:19AM -0800, Russell Senior wrote: > > > I'm not sure what device we're dealing with here, but it seems it would > > > not be supported by the vendor (whose version of this driver also uses > > > the

Re: [PATCH] usb: musb: fix runtime PM in debugfs

* Bin Liu [161219 12:46]: > MUSB driver now has runtime PM support, but the debugfs driver misses > the PM _get/_put() calls, which could cause MUSB register access > failure. Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Tue, Dec 20, 2016 at 04:38:19AM -0800, Russell Senior wrote: > > I'm not sure what device we're dealing with here, but it seems it would > > not be supported by the vendor (whose version of this driver also uses > > the init-command). > > > > Perhaps you could give the attached vendor driver a

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Tue, Dec 20, 2016 at 07:31:55AM -0800, Russell Senior wrote: > On Tue, Dec 20, 2016 at 1:13 AM, Johan Hovold wrote: > > Perhaps you could give the attached vendor driver a quick spin just to > > confirm that? It's a rebased version against usb-next. > > This is plain jane

Re: [PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

On 12/20/2016 6:20 PM, Stefan Wahren wrote: > Hi Sevak, > >> Sevak Arakelyan hat am 20. Dezember 2016 um >> 13:57 geschrieben: >> >> >> On 12/19/2016 8:39 PM, Stefan Wahren wrote: >>> Currently the upper limit for the endpoint index during fifo size >>> config was

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Tue, Dec 20, 2016 at 1:13 AM, Johan Hovold wrote: > Perhaps you could give the attached vendor driver a quick spin just to > confirm that? It's a rebased version against usb-next. This is plain jane usb-next with your vendor patch, which I applied in a local branch:

Re: [PATCH 2/2] usb: host: xhci: Handle the right timeout command

On 20.12.2016 09:30, Baolin Wang wrote: ... Alright, I gathered all current work related to xhci races and timeouts and put them into a branch: git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git timeout_race_fixes Its based on 4.9 It includes a few other patches just to avoid

Re: [PATCH] usbip: vudc: check for NULL before use

On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: > to_vep() is doing a container_of() on _ep. It is better to do the NULL > check first and then use it. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/usbip/vudc_dev.c | 2 +- > 1 file changed, 1

Re: [RFC PATCH] usb: USB Type-C connector class

On Mon, Dec 19, 2016 at 09:22:33AM -0800, Guenter Roeck wrote: > On 12/19/2016 06:45 AM, Heikki Krogerus wrote: > > The purpose of USB Type-C connector class is to provide > > unified interface for the user space to get the status and > > basic information about USB Type-C connectors on a system,

Re: [PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

Hi Sevak, > Sevak Arakelyan hat am 20. Dezember 2016 um > 13:57 geschrieben: > > > On 12/19/2016 8:39 PM, Stefan Wahren wrote: > > Currently the upper limit for the endpoint index during fifo size > > config was always 16 instead of the available endpoints. So

Re: [PATCH RFT] usb: dwc2: gadget: Fix fifo size configuration

On 12/19/2016 8:39 PM, Stefan Wahren wrote: > Currently the upper limit for the endpoint index during fifo size > config was always 16 instead of the available endpoints. So fix this > by using the determined amount of endpoints and avoid a warning about > "insufficient fifo memory" on bcm2835

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

> I'm not sure what device we're dealing with here, but it seems it would > not be supported by the vendor (whose version of this driver also uses > the init-command). > > Perhaps you could give the attached vendor driver a quick spin just to > confirm that? It's a rebased version against

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, John Youn writes: > On 12/7/2016 7:06 PM, John Youn wrote: >> On 12/7/2016 4:44 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: >> Roger Quadros writes: >>> DCFG.DEVSPD == 0x3 is not valid and we need to set

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Mon, Dec 19, 2016 at 02:12:05PM -0800, Russell Senior wrote: > >> Apart from the two additional tests mentioned above, can you also > >> provide a log from when connecting the device using the following commit > >> that I just pushed to the ch341 branch: > >> > >> f341ee36198d ("dbg:

Re: [PATCH 06/13] USB: serial: ch341: fix initial line settings

On Mon, Dec 19, 2016 at 08:40:53AM -0800, Russell Senior wrote: > On Mon, Dec 19, 2016 at 2:58 AM, Johan Hovold wrote: > > On Sat, Dec 17, 2016 at 03:27:43AM -0800, Russell Senior wrote: > >> All testing is with minicom. > > > > Thanks for this through report. > > > >> Starting