Re: Question: Does usbip support USB 3.0?

A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Feb 23, 2017 at

RE: Question: Does usbip support USB 3.0?

Oh, then let me try to simplify it, what if it's an only USB 3.0 device? Thanks, Yuyang -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Thursday, February 23, 2017 3:20 PM To: Du, Yuyang Cc: linux-usb@vger.kernel.org;

Re: [PATCH 1/2] [TRIVIAL] usb: gadget: Remove duplicated function declaration in pxa27x_udc

Petr Cvek writes: > Remove duplicated function declaration for udc_enable() and udc_disable(). The patch title looks a bit tool long to me, and that also applied to your second one. Moreover the correct prefix for this driver (for the title) is : usb: gadget: pxa27x:

Re: [PATCH 2/2] usb: gadget: Add test if argument pointer has a valid value in pxa27x_udc

Petr Cvek writes: > Move call usb_put_phy(udc->transceiver) inside a valid pointer test. > > Reported-by: robert.jarz...@free.fr I'd rather have my normal signature here : Reported-by: Robert Jarzmik > Signed-off-by: Petr Cvek

Re: Question: Does usbip support USB 3.0?

On Thu, Feb 23, 2017 at 06:59:25AM +, Du, Yuyang wrote: > Hi there, > > I have this simple question. Thanks. What exactly do you mean by "USB 3.0"? Remember, USB 3.0 supports low-speed devices like keyboards :) So this isn't really a "simple" question. Also, have you tried it yourself to

Question: Does usbip support USB 3.0?

Hi there, I have this simple question. Thanks. Yuyang -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 15/15] usb: dwc2: Replace msleep with mdelay in dwc2_clear_force_mode()

On 2/22/2017 10:59 PM, John Youn wrote: > On 2/21/2017 5:16 AM, David Laight wrote: >> From: Vardan Mikayelyan >>> Sent: 20 February 2017 15:15 >>> dwc2_clear_force_mode() can be called in hibernation exit flow which >>> can occur in interrupt context. >>> >>> Signed-off-by: Vardan Mikayelyan

[PATCH 1/2] [TRIVIAL] usb: gadget: Remove duplicated function declaration in pxa27x_udc

Remove duplicated function declaration for udc_enable() and udc_disable(). Signed-off-by: Petr Cvek --- drivers/usb/gadget/udc/pxa27x_udc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index

Re: [RFC] usb: gadget: scheduling while atomic in pxa27x_udc, IS_ERR_OR_NULL test, duplicated definition

Dne 22.2.2017 v 21:46 Robert Jarzmik napsal(a): > Petr Cvek writes: > > Hi Petr, > >> I found a few problems with the PXA27x UDC. >> >> usb_function_activate() in drivers/usb/gadget/composite.c >> >> does spin_lock_irqsave() and then calls >> >>

[PATCH 0/2] usb: gadget: Fixes for pxa27x_udc

Two simple fixes for pxa27x gadget UDC. First one remove function declaration duplication, second one add test for a valid pointer before function call as it can be called with an error value in the pointer. Petr Cvek (2): [TRIVIAL] usb: gadget: Remove duplicated function declaration in

[PATCH 2/2] usb: gadget: Add test if argument pointer has a valid value in pxa27x_udc

Move call usb_put_phy(udc->transceiver) inside a valid pointer test. Reported-by: robert.jarz...@free.fr Signed-off-by: Petr Cvek --- drivers/usb/gadget/udc/pxa27x_udc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [RFC] usb: gadget: scheduling while atomic in pxa27x_udc, IS_ERR_OR_NULL test, duplicated definition

Petr Cvek writes: Hi Petr, > I found a few problems with the PXA27x UDC. > > usb_function_activate() in drivers/usb/gadget/composite.c > > does spin_lock_irqsave() and then calls > > gadget->ops->pullup() in drivers/usb/gadget/udc/core.c > > which is set to

Re: [RESEND PATCH v2 0/2] add multiple clock handling for dwc2 driver

On 2/21/2017 5:30 PM, Frank Wang wrote: > Hi John and Greg, > > Friendly ping... :-) > Hi Frank, We'll take a look at this and get back to you soon. Regards, John > On 2017/2/10 11:06, Frank Wang wrote: >> Resend this series to involve device tree maintainer and add 'Reviewed-by' >> tag for

Re: [PATCH 15/15] usb: dwc2: Replace msleep with mdelay in dwc2_clear_force_mode()

On 2/21/2017 5:16 AM, David Laight wrote: > From: Vardan Mikayelyan >> Sent: 20 February 2017 15:15 >> dwc2_clear_force_mode() can be called in hibernation exit flow which >> can occur in interrupt context. >> >> Signed-off-by: Vardan Mikayelyan >> --- >>

[PATCH] usb: phy: isp1301: Add OF device ID table

The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could

[PATCH v3 1/2] usbip: Fix-format-overflow

The usbip userspace tools call sprintf()/snprintf() and don't check for the return value which can lead the paths to overflow, truncating the final file in the path. More urgently, GCC 7 now warns that these aren't checked with -Wformat-overflow, and with -Werror enabled in configure.ac, that

[PATCH v3 2/2] usbip: Fix implicit fallthrough warning

GCC 7 now warns when switch statements fall through implicitly, and with -Werror enabled in configure.ac, that makes these tools unbuildable. We fix this by notifying the compiler that this particular case statement is meant to fall through. Reviewed-by: Peter Senna Tschudin

Re: [PATCH v2 1/2] usbip: Fix-format-overflow

On Wed, 2017-02-22 at 06:49 +0100, Krzysztof Opasiak wrote: > Hi, > > W dniu 2017-02-21 o 18:57, Jonathan Dieter pisze: > >   char busid[SYSFS_BUS_ID_SIZE]; > > + unsigned int size; > > I'm not really convinced to use unsigned here. snprintf() is declared > to  > return signed integer so we

[RFC PATCH] xhci: Use Cached ring during endpoint ring allocation

Currently during endpoint initialization, a new endpoint ring is alloacte using xhci_ring_alloc(), if this function fails to allocate ring a cached ring(if available) is assigned to endpoint ring. This patch modifies the code that during endpoint initialization, if cached ring is available it is

Re: [RESEND PATCH v2 0/2] add multiple clock handling for dwc2 driver

On Wed, Feb 22, 2017 at 09:29:43AM +0800, Frank Wang wrote: > Hi John and Greg, > > Friendly ping... :-) I'm not the one to take dwc2 patches, sorry, nothing I can do here, especially in the middle of the merge window... greg k-h -- To unsubscribe from this list: send the line "unsubscribe

[GIT PULL] USB/PHY driver patches for 4.11-rc1

The following changes since commit d5adbfcd5f7bcc6fa58a41c5c5ada0e5c826ce2c: Linux 4.10-rc7 (2017-02-05 15:10:58 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.11-rc1 for you to fetch changes up to

RE: Re: Subject: [PATCH v3] USB:Core: BugFix: Proper handling of Race Condition when two USB class drivers try to call init_usb_class simultaneously

On Tue, 21 Feb 2017, Alan Stern wrote:    > On Mon, 20 Feb 2017, Ajay Kaher wrote:   >> Alan, as per my understanding I have shifted the lock from >> release_usb_class() to destroy_usb_class() in patch v3.  >> If it is not right, please explain in detail which race condition >> I have missed and 

Re: [PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes

Hi, On Wed, 2017-02-22 at 12:36 +0300, Sergei Shtylyov wrote: > On 2/22/2017 11:55 AM, Chunfeng Yun wrote: > > > there is a reference clock for each port, HighSpeed port is 48M, > > and SuperSpeed port is 26M which usually comes from 26M oscillator > > directly, but some SoCs is not. it is

[PATCH, RESEND] usb: gadget: udc: atmel: fix debug output

The debug output now contains the wrong variable, as seen from the compiler warning: drivers/usb/gadget/udc/atmel_usba_udc.c: In function 'usba_ep_enable': drivers/usb/gadget/udc/atmel_usba_udc.c:632:550: error: 'ept_cfg' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Re: [PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes

On 2/22/2017 11:55 AM, Chunfeng Yun wrote: there is a reference clock for each port, HighSpeed port is 48M, and SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs is not. it is flexible to move it into port ... but on some SoCs does not? node.

Re: [PATCH v3 4/8] phy: phy-mt65xx-usb3: move clock from phy node into port nodes

Hello! On 2/22/2017 11:55 AM, Chunfeng Yun wrote: the reference clock of HighSpeed port is 48M which comes from PLL; the reference clock of SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs are not, add it for ... but on some SoCs does not?

Re: Choppy USB audio on i.MX53 chipidea with 4.4 kernel. Ok in 4.10

On 22/02/17 10:06, Oliver Neukum wrote: Am Dienstag, den 21.02.2017, 17:06 +0100 schrieb Martin Fuzzey: However the revert commit message doesn't really indicate that it is a bug fix. The links in the revert commit are describing scenarios involving multiple codecs, whereas I am only using

Re: Choppy USB audio on i.MX53 chipidea with 4.4 kernel. Ok in 4.10

Am Dienstag, den 21.02.2017, 17:06 +0100 schrieb Martin Fuzzey: >  > However the revert commit message doesn't really indicate that it is > a  > bug fix. > The links in the revert commit are describing scenarios involving  > multiple codecs, whereas I am only using one. Hi, if it fixes a bug, it

[PATCH v3 6/8] arm64: dts: mt8173: split usb SuperSpeed port into two ports

split the old SuperSpeed port node into a HighSpeed one and a new SuperSpeed one. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[PATCH v3 1/8] phy: phy-mt65xx-usb3: improve RX detection stable time

The default value of RX detection stable time is 10us, and this margin is too big for some critical cases which cause U3 link fail and link to U2(probability is about 1%). So change it to 5us. Signed-off-by: Chunfeng Yun --- drivers/phy/phy-mt65xx-usb3.c | 18

[PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes

there is a reference clock for each port, HighSpeed port is 48M, and SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs is not. it is flexible to move it into port node. Signed-off-by: Chunfeng Yun ---

[PATCH v3 5/8] phy: phy-mt65xx-usb3: add support for new version phy

There are some variations from mt2701 to mt2712: 1. banks shared by multiple ports are put back into each port, such as SPLLC and U2FREQ; 2. add a new bank MISC for u2port, and CHIP for u3port; 3. bank's offset in each port are also rearranged; Signed-off-by: Chunfeng Yun

[PATCH v3 8/8] dt-bindings: phy-mt65xx-usb: add support for new version phy

add a new compatible string for "mt2712", and move reference clock into each port node; Signed-off-by: Chunfeng Yun --- .../devicetree/bindings/phy/phy-mt65xx-usb.txt | 93 +--- 1 file changed, 80 insertions(+), 13 deletions(-) diff --git

[PATCH v3 3/8] phy: phy-mt65xx-usb3: split SuperSpeed port into two ones

Currently usb3 port in fact includes two sub-ports, but it is not flexible for some cases, such as following one: usb3 port0 includes u2port0 and u3port0; usb2 port0 includes u2port1; If wants to support only HS, we can use u2port0 or u2port1, when select u2port0, u3port0 is not needed; If

[PATCH v3 4/8] phy: phy-mt65xx-usb3: move clock from phy node into port nodes

the reference clock of HighSpeed port is 48M which comes from PLL; the reference clock of SuperSpeed port is 26M which usually comes from 26M oscillator directly, but some SoCs are not, add it for compatibility, and put them into port node for flexibility. Signed-off-by: Chunfeng Yun

[PATCH v3 2/8] phy: phy-mt65xx-usb3: increase LFPS filter threshold

Increase LFPS filter threshold to avoid some fake remote wakeup signal which cause U3 link fail and link to U2 only at about 0.01% probability. Signed-off-by: Chunfeng Yun --- drivers/phy/phy-mt65xx-usb3.c |9 + 1 file changed, 9 insertions(+) diff --git