Re: [PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

[PATCH] usb: dwc3: of-simple: fix noderef.cocci warnings

drivers/usb/dwc3/dwc3-of-simple.c:53:43-49: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci CC: Vivek Gautam Signed-off-by: Fengguang Wu

Re: [PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

[PATCH v2 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype

Remove unnecessary variable and update function prototype. Acked-by: Michal Nazarewicz Reviewed-by: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: None. drivers/usb/gadget/udc/amd5536udc.c | 5

[PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer

Rewrite udc_free_dma_chain() function to avoid use of pointer after free. Addresses-Coverity-ID: 1091172 Acked-by: Michal Nazarewicz Reviewed-by: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2:

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

On 04/04/2017 09:44 AM, kbuild test robot wrote: Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [PATCH v2 1/4] reset: Add API to count number of reset available with device

Hi Vivek, [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

[PATCH v2 1/2] usb: misc: add missing continue in switch

Add missing continue in switch. Addresses-Coverity-ID: 1248733 Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: None. drivers/usb/misc/usbtest.c | 1 + 1 file changed,

[PATCH v2 2/2] usb: misc: refactor code

Code refactoring to make the flow easier to follow. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Remove unfruitful changes in previous patch. Revert change to

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

Hi, * Kishon Vijay Abraham I [170330 04:51]: > On Monday 27 March 2017 08:35 PM, Tony Lindgren wrote: > > Seems this can be also done when implementing PM runtime handling. > > If you want some of these changes done for the initial patch, > > please let me know. > > I think it's

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

On Mon, Apr 3, 2017 at 5:54 AM, Minas Harutyunyan wrote: > On 4/3/2017 9:23 AM, John Youn wrote: >> On 03/31/2017 04:04 PM, John Stultz wrote: >>> On Thu, Mar 2, 2017 at 12:00 PM, John Stultz wrote: Hey John, We've noticed that

Re: [PATCH 2/2] usb: misc: refactor code

Hi Alan, Quoting Alan Stern : On Mon, 3 Apr 2017, Gustavo A. R. Silva wrote: Code refactoring to make the flow easier to follow. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva

Re: [PATCHv4] net: usbnet: support 64bit stats

From: Greg Ungerer Date: Mon, 3 Apr 2017 15:50:03 +1000 > Add support for the net stats64 counters to the usbnet core. With that > in place put the hooks into every usbnet driver to use it. > > This is a strait forward addition of 64bit counters for RX and TX packet > and

Re: [PATCH 2/2] usb: misc: refactor code

On Mon, 3 Apr 2017, Gustavo A. R. Silva wrote: > Code refactoring to make the flow easier to follow. > > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Signed-off-by: Gustavo A. R. Silva > --- >

Re: [RESEND PATCH v6 4/4] usb: musb: da8xx: Add a primary support of PM runtime

On 03/27/2017 02:54 PM, Alexandre Bailon wrote: > On 03/27/2017 07:38 PM, Grygorii Strashko wrote: >> >> >> On 03/27/2017 11:39 AM, Alexandre Bailon wrote: >>> Hello Grygorii, >>> On 03/24/2017 06:26 PM, Grygorii Strashko wrote: On 03/24/2017 09:36 AM, Alexandre Bailon wrote:

[PATCH 2/2] usb: misc: refactor code

Code refactoring to make the flow easier to follow. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- drivers/usb/misc/usbtest.c | 67 +- 1

Re: [PATCH] usb: misc: add missing continue and refactor code

Quoting Alan Stern : On Mon, 3 Apr 2017, Greg Kroah-Hartman wrote: On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > -Code refactoring to make the flow easier to follow. > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. Don't do

Fw: New Defects reported by Coverity Scan for Linux

Looks like new warnings in usbnet ** CID 751368: Null pointer dereferences (FORWARD_NULL) /drivers/net/usb/usbnet.c: 1925 in __usbnet_read_cmd() *** CID 751368: Null pointer dereferences

[PATCH 1/2] usb: misc: add missing continue in switch

Add missing continue in switch. Addresses-Coverity-ID: 1248733 Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- drivers/usb/misc/usbtest.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH v3 3/3] usb: dwc3: Add dual-role support

Hi Roger, [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.11-rc5 next-20170403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Roger-Quadros/usb-dwc3-dual-role-support

Re: [PATCH] usb: misc: add missing continue and refactor code

On Mon, 3 Apr 2017, Greg Kroah-Hartman wrote: > On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > > -Code refactoring to make the flow easier to follow. > > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. > > Don't do multiple things in the same patch, please make

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

> > > > > ...1d.7: PCI fixup... pass 2 > > > > > ...1d.7: PCI fixup... pass 3 > > > > > ...1d.7: PCI fixup... pass 3 done > > > > > > > > > > ...followed by hang. So yes, it looks USB related. > > > > > > > > > > (Sometimes it hangs with some kind backtrace involving secondary CPU > > > > >

Re: [PATCH] usb: misc: add missing continue and refactor code

On Mon, Apr 03, 2017 at 09:39:53AM -0500, Gustavo A. R. Silva wrote: > -Code refactoring to make the flow easier to follow. > -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. Don't do multiple things in the same patch, please make these multiple patches. And do the "add missing continue"

[PATCH] usb: misc: add missing continue and refactor code

-Code refactoring to make the flow easier to follow. -Add missing 'continue' for case USB_ENDPOINT_XFER_INT. Addresses-Coverity-ID: 1248733 Cc: Alan Stern Signed-off-by: Gustavo A. R. Silva --- drivers/usb/misc/usbtest.c | 68

Re: [RESEND PATCH v3 6/7] DT bindings documentation for Broadcom IPROC USB Device controller.

On Fri, Mar 31, 2017 at 06:39:12PM +0530, Raviteja Garimella wrote: > The device node is used for UDCs integrated into Broadcom's > iProc family of SoCs'. The UDC is based on Synopsys Designware > Cores AHB Subsystem USB Device Controller IP. > > Signed-off-by: Raviteja Garimella

Re: [Bug] One sector less reported through usb-storage than actual hard disk capacity

On Mon, 3 Apr 2017, Guan Xin wrote: > Thank you for your analysis! > I checked that the lost sector is not at the beginning, and I hope > it's not in the middle either. No, it's the very last sector. > So I can avoid using the last few sectors and live with it. > > Thanks again and sorry for

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

Hi Vivek, thank you for the patch series. A few comments below: I'd like to reduce the API surface a bit and include the counting and array allocation in the _get functions, if possible. On Mon, 2017-04-03 at 19:12 +0530, Vivek Gautam wrote: > Many devices may want to request a bunch of resets >

Re: [Bug] One sector less reported through usb-storage than actual hard disk capacity

Thank you for your analysis! I checked that the lost sector is not at the beginning, and I hope it's not in the middle either. So I can avoid using the last few sectors and live with it. Thanks again and sorry for wasting your time on a bug that's not in the linux kernel. On Mon, Apr 3, 2017 at

Re: [Bug] One sector less reported through usb-storage than actual hard disk capacity

On Mon, 3 Apr 2017, Guan Xin wrote: > Not sure if attachments can be sent around on a mailing list. > I'll put it into the content if you don't see the attached "usbmon.log > (14 bytes, 1398 lines)". Here's your answer. From the usbmon trace: 8800765753c0 1906124951 S Bo:1:015:4 -115

Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

On Thu, Feb 23, 2017 at 07:40:13PM +0100, Pavel Machek wrote: > On Thu 2017-02-23 17:28:26, Frederic Weisbecker wrote: > > On Tue, Feb 14, 2017 at 08:27:43PM +0100, Pavel Machek wrote: > > > On Tue 2017-02-14 18:59:56, Pavel Machek wrote: > > > > Hi! > > > > > > > > > > > > Hmm. I moved keyboard

Re: [PATCH v5 0/5] usb: dwc2: Add support for USB OTG on STM32F4x9

Hi On 02/01/2017 02:25 AM, Bruno Herrera wrote: The STM32F4x9 MCU family has two DWC2 USB OTG cores on it. One core is USB OTG FS and other core is USB OTG HS. The USB FS core only works with its internal phy whilst the USF HS core can work in HS with external ulpi phy or in FS/LS speed with

Re: [PATCH v7 2/3] usb: musb: Add support of CPPI 4.1 DMA controller to DA8xx

On Wed, Mar 29, 2017 at 06:24:31PM +0200, Alexandre Bailon wrote: > Currently, only the PIO mode is supported. > This add support of CPPI 4.1 to DA8xx. > As the In DA8xx the CPPI 4.1 DMA is a part of the USB. > Create the CPPI 4.1 device as a child of USB. > > Signed-off-by: Alexandre Bailon

Re: [PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

On Mon, 3 Apr 2017, Roger Quadros wrote: > allow usb_del_gadget_udc() and usb add_gadget_udc() to be called > repeatedly on the same gadget->dev structure. > > We need to clear the gadget->dev structure so that kobject_init() > doesn't complain about already initialized object. > >

[PATCH v2 2/4] reset: Add APIs to manage array of resets

Many devices may want to request a bunch of resets and control them. So it's better to manage them as an array. Add APIs to _get(), _assert(), and _deassert() an array of reset_control. Cc: Philipp Zabel Signed-off-by: Vivek Gautam ---

[PATCH v2 1/4] reset: Add API to count number of reset available with device

Count number of reset phandles available with the device node to know the resets a given device has. Cc: Philipp Zabel Signed-off-by: Vivek Gautam --- Changes since v1: - Handling the error path by returning error code for failures and

[PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets for the device

Add support to get a list of resets available for the device. These resets must be kept de-asserted until the device is in use. Cc: Felipe Balbi Cc: Philipp Zabel Signed-off-by: Vivek Gautam --- Changes since v1: - Using

[PATCH v2 0/4] reset: APIs to manage a list of resets

Set of patches to support getting and de/asserting a list (array) of reset controllers available with the device. These patches address the comments received for the earlier posted series [1,2]. The users can pass a list of reset controllers and the number of resets available in the driver or the

[PATCH v2 4/4] soc/tegra: pmc: Use the new reset APIs to manage reset controllers

Make use of reset_control_array_*() set of APIs to manage an array of reset controllers available with the device. Cc: Thierry Reding Cc: Philipp Zabel Signed-off-by: Vivek Gautam --- Changes since v1: - New patch added

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

On Mon, Apr 03, 2017 at 01:21:08PM +, Kalle Valo wrote: > Johan Hovold writes: > > > On Mon, Apr 03, 2017 at 01:02:28PM +, Kalle Valo wrote: > >> Kalle Valo writes: > >> > >> > Johan Hovold writes: > >> > > >> >> On Mon, Mar

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

Johan Hovold writes: > On Mon, Apr 03, 2017 at 01:02:28PM +, Kalle Valo wrote: >> Kalle Valo writes: >> >> > Johan Hovold writes: >> > >> >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >> >>> Make sure to check

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

On Mon, Apr 03, 2017 at 01:02:28PM +, Kalle Valo wrote: > Kalle Valo writes: > > > Johan Hovold writes: > > > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: > >>> Make sure to check the number of endpoints to avoid dereferencing a >

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

Kalle Valo writes: > Johan Hovold writes: > >> On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >>> Make sure to check the number of endpoints to avoid dereferencing a >>> NULL-pointer or accessing memory beyond the endpoint array should a

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

Hi, On 4/3/2017 9:23 AM, John Youn wrote: > On 03/31/2017 04:04 PM, John Stultz wrote: >> On Thu, Mar 2, 2017 at 12:00 PM, John Stultz wrote: >>> Hey John, >>> We've noticed that when using usb ethernet adapters on HiKey, we >>> occasionally see errors like: >>> >>>

[PATCH v3 0/3] usb: dwc3: dual-role support

Hi, Taking a simplistic approach this time. We don't use the OTG controller block at all. Instead we just rely on ID events via extcon framework. I tried to get rid of workqueue but unfortunately it causes too much pain when the UDC is unregistered. https://hastebin.com/upugaqogol.xml

[PATCH v3 2/3] usb: dwc3: make role-switching work with debugfs/mode

If dr_mode == "otg", we start by default in PERIPHERAL mode. Keep track of current role in "current_dr_role" whenever dwc3_set_mode() is called. When debugfs/mode is changed AND we're in dual-role mode, handle the switch by stopping and starting the respective host/gadget controllers.

[PATCH v3 1/3] usb: udc: allow adding and removing the same gadget device

allow usb_del_gadget_udc() and usb add_gadget_udc() to be called repeatedly on the same gadget->dev structure. We need to clear the gadget->dev structure so that kobject_init() doesn't complain about already initialized object. Signed-off-by: Roger Quadros ---

[PATCH v3 3/3] usb: dwc3: Add dual-role support

If dr_mode is "otg" then support dual role mode of operation. Currently this mode is only supported when an extcon handle is present in the dwc3 device tree node. This is needed to get the ID status events of the port. We're using a workqueue to manage the dual-role state transitions as the

Re: [Bug] One sector less reported through usb-storage than actual hard disk capacity

Not sure if attachments can be sent around on a mailing list. I'll put it into the content if you don't see the attached "usbmon.log (14 bytes, 1398 lines)". Guan On Sun, Apr 2, 2017 at 10:15 PM, Alan Stern wrote: > On Sun, 2 Apr 2017, Guan Xin wrote: > >> Bus 002

[PATCH] USB: serial: quatech2: drop redundant tty_buffer_request_room

Drop redundant calls to tty_buffer_request_room and use the more efficient tty_insert_flip_char when inserting single characters. Signed-off-by: Johan Hovold --- drivers/usb/serial/quatech2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH] USB: serial: iuu_phoenix: drop excessive sanity checks

The transfer buffers and URBs are allocated and initialised by USB serial core during probe, and there's no need to check for NULL transfer buffers in the bulk-in completion handlers. Signed-off-by: Johan Hovold --- drivers/usb/serial/iuu_phoenix.c | 9 +++-- 1 file

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

Johan Hovold writes: > On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: >> Make sure to check the number of endpoints to avoid dereferencing a >> NULL-pointer or accessing memory beyond the endpoint array should a >> malicious device lack the expected endpoints. >>

Re: [PATCH 1/2] wireless: ath9k_htc: fix NULL-deref at probe

On Mon, Mar 13, 2017 at 01:44:20PM +0100, Johan Hovold wrote: > Make sure to check the number of endpoints to avoid dereferencing a > NULL-pointer or accessing memory beyond the endpoint array should a > malicious device lack the expected endpoints. > > Fixes: 36bcce430657 ("ath9k_htc: Handle

[PATCH] usb: hcd: use correct device pointer for dma ops

commit a8c06e407ef9 ("usb: separate out sysdev pointer from usb_bus") converted to use hcd->self.sysdev for DMA operations instead of hcd->self.controller but forgot to do it for one instance. This gets caught when DMA debugging is enabled since dma map and unmap end up using different device

Re: [PATCHv4] net: usbnet: support 64bit stats

Greg Ungerer writes: > Add support for the net stats64 counters to the usbnet core. With that > in place put the hooks into every usbnet driver to use it. > > This is a strait forward addition of 64bit counters for RX and TX packet > and byte counts. It is done in the same

Re: Patch for drivers/usb/serial/ch341.c enabling parity

On Sun, Apr 02, 2017 at 10:12:38AM -0700, Joe Perches wrote: > On Sun, 2017-04-02 at 18:57 +0200, Leif Neland wrote: > > There is a patch > > https://github.com/karlp/ch341-linux/blob/master/0001-usb-serial-ch341-Add-parity-support.patch > > which enables parity selection for the ch341 USB-RS485

[PATCH 2/3 v2] i2c: i2c-piix4: Use the common mutex

Use the common mutex from driver/usb/host/pci-quirks.c in the i2c-piix4 driver to synchronize access to the I/O port pair 0xcd6 / 0xcd7. At the same time, remove the request_region() call to reserve these I/O ports, so the sp5100_tco watchdog driver can also load. The mutex is enough to protect

[PATCH 1/3 v2] usb: pci-quirks: Add a common mutex for the I/O port pair of SB800

This patch adds a common mutex in the USB PCI quirks code and starts using it to synchronize access to the I/O port pair 0xcd6 / 0xcd7 on SB800. These I/O ports are also used by i2c-piix4 and sp5100_tco, the next two patches port these drivers to use this common mutex. v2: No extra header and no

[PATCH 3/3 v2] watchdog: sp5100_tco: Use the common mutex

Use the common mutex from usb/host/pci-quirks.c to synchronize accesses to the SB800 I/O port pair (0xcd6 / 0xcd7) with the PCI quirk for isochronous USB transfers and with the i2c-piix4 driver. At the same time, remove the request_region() call to reserve these I/O ports, similarly to i2c-piix4

[PATCH 0/3 v2] Fix regression in the sp5100_tco driver

Three drivers are accessing the same I/O ports (0xcd6 / 0xcd7) on AMD SB800 based machines without synchronization or with excluding each other out: * the USB quirk for isochronous transfers on SB800 (no locking) * sp5100_tco (request_region) * i2c-piix4 (request_region) Historically, the

[PATCH linux-next v3 4/4] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0

From: Cristian Birsan Update Kconfig help for fifo_mode = 0 to explain the behavior better. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/Kconfig | 5 +++-- 1 file

[PATCH linux-next v3 3/4] usb: gadget: udc: atmel: Use dev_err() to display EP configuration error

From: Cristian Birsan Use dev_err() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 8

[PATCH linux-next v3 0/4] usb: gadget: udc: atmel: Endpoint allocation scheme fixes

From: Cristian Birsan This patch series provides fixes, based on the feedback received on the mailing list, for the following: - fifo table parameters validation against device tree values - coding style - message display for EP

[PATCH linux-next v3 2/4] usb: gadget: udc: atmel: Minor code cleanup

From: Cristian Birsan Minor code cleanup based on feedback received on mailinglist. Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre --- drivers/usb/gadget/udc/atmel_usba_udc.c | 17

[PATCH linux-next v3 1/4] usb: gadget: udc: atmel: Check fifo configuration values against device tree

From: Cristian Birsan Check fifo configuration values against device tree values for endpoint fifo in auto configuration mode (fifo_mode=0). Signed-off-by: Cristian Birsan Acked-by: Nicolas Ferre ---

Re: [PATCH] dwc2: gadget: Fix in control write transfers

Hi, Minas Harutyunyan writes: >> Minas Harutyunyan writes: >>> After data out stage gadget driver should not initate ZLP on control EP, >>> because it is up to function driver. >> >> not true always, depends on return value from