Re: [PATCH v2] extcon: Split out extcon header file for consumer and provider device

Dear Kishon, Could you please review this patch? After that, I'll make the immutable brand and then send the pull request for power_supply, mfd, phy, usb and extcon framework. On 2017년 10월 10일 19:17, Chanwoo Choi wrote: > The extcon has two type of extcon devices as following. > - 'extcon

[PATCH] usb: dwc3: gadget: Correct ISOC DATA PIDs for short packets

From: Manu Gautam commit 40d829fb2ec636b6b4b0cc95e2546ab9aca04cc9 upstream. The PIDs for Isochronous data transfers are incorrect for high bandwidth IN endpoints when the request length is less than EP wMaxPacketSize. As per spec correct PIDs for ISOC data transfers

RE: [PATCH] xhci: Cope with VIA VL805 readahead

From: Mathias Nyman > Sent: 11 October 2017 15:41 .. > If possible I'd like to try and find some other solution before chopping the > Segment > size to smaller than 256. > I think that your first proposal of adding the guard page to the segment pool > could be an option. Would be a waste of a

[PATCH] usb: gadget: make config_item_type structures const

This is a followup patch for: https://patchwork.kernel.org/patch/649/ Make these structures const as they are only passed to the const argument of the functions config_{group/item}_init_type_name. Done using Coccinelle: @rule1 disable optional_qualifier @ identifier x; @@ static struct

Re: [PATCH v2 3/9] ALSA: caiaq: Add a sanity check for invalid EPs

On Wed, 11 Oct 2017 16:49:10 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 04:40:36PM +0200, Takashi Iwai wrote: > > On Wed, 11 Oct 2017 16:20:31 +0200, > > Johan Hovold wrote: > > > > Unrelated to this patch, but this driver fails to kill the ep1_in_urb > > > (which is submitted in

Re: [PATCH] USB: Force disconnect Huawei 4G modem during suspend

On Wed, 11 Oct 2017, Daniel Drake wrote: > From: Chris Chiu > > When going into S3 suspend, the Acer TravelMate P648-M and P648-G3 > laptops immediately wake up 3-4 seconds later for no obvious reason. > > Unbinding the integrated Huawei 4G LTE modem before suspend avoids >

Re: [PATCH v2 4/9] ALSA: line6: Add a sanity check for invalid EPs

On Wed, 11 Oct 2017 16:52:09 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 04:45:16PM +0200, Takashi Iwai wrote: > > On Wed, 11 Oct 2017 16:28:37 +0200, > > Johan Hovold wrote: > > > > > > On Wed, Oct 11, 2017 at 12:36:41PM +0200, Takashi Iwai wrote: > > > > As syzkaller spotted,

Re: [PATCH v2 1/9] usb: core: Add a helper function to check the validity of EP type in URB

On Wed, Oct 11, 2017 at 04:31:07PM +0200, Takashi Iwai wrote: > On Wed, 11 Oct 2017 16:14:55 +0200, > Johan Hovold wrote: > > > > On Wed, Oct 11, 2017 at 12:36:38PM +0200, Takashi Iwai wrote: > > > This patch adds a new helper function to perform a sanity check of the > > > given URB to see

Re: [PATCH v2 4/9] ALSA: line6: Add a sanity check for invalid EPs

On Wed, Oct 11, 2017 at 04:45:16PM +0200, Takashi Iwai wrote: > On Wed, 11 Oct 2017 16:28:37 +0200, > Johan Hovold wrote: > > > > On Wed, Oct 11, 2017 at 12:36:41PM +0200, Takashi Iwai wrote: > > > As syzkaller spotted, currently line6 drivers submit a URB with the > > > fixed EP without checking

Re: [PATCH v2 3/9] ALSA: caiaq: Add a sanity check for invalid EPs

On Wed, Oct 11, 2017 at 04:40:36PM +0200, Takashi Iwai wrote: > On Wed, 11 Oct 2017 16:20:31 +0200, > Johan Hovold wrote: > > Unrelated to this patch, but this driver fails to kill the ep1_in_urb > > (which is submitted in this function) in case of later probe errors. > > This can lead to

Re: [PATCH v2 9/9] ALSA: line6: Add yet more sanity checks for invalid EPs

On Wed, 11 Oct 2017 16:39:52 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 12:36:46PM +0200, Takashi Iwai wrote: > > There are a few other places calling usb_submit_urb() with the URB > > composed from the fixed endpoint without validation. For avoiding the > > spurious kernel warnings,

Re: [PATCH v2 4/9] ALSA: line6: Add a sanity check for invalid EPs

On Wed, 11 Oct 2017 16:28:37 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 12:36:41PM +0200, Takashi Iwai wrote: > > As syzkaller spotted, currently line6 drivers submit a URB with the > > fixed EP without checking whether it's actually available, which may > > result in a kernel warning

Re: [PATCH v2 6/9] ALSA: usx2y: Add sanity checks for invalid EPs

On Wed, 11 Oct 2017 16:33:37 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 12:36:43PM +0200, Takashi Iwai wrote: > > usx2y driver sets up URBs containing the fixed endpoints without > > validation. This may end up with an oops-like kernel warning when > > submitted. > > > > For

Re: [PATCH v2 3/9] ALSA: caiaq: Add a sanity check for invalid EPs

On Wed, 11 Oct 2017 16:20:31 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 12:36:40PM +0200, Takashi Iwai wrote: > > As syzkaller spotted, currently caiaq driver submits a URB with the > > fixed EP without checking whether it's actually available, which may > > result in a kernel warning

Re: [PATCH v2 9/9] ALSA: line6: Add yet more sanity checks for invalid EPs

On Wed, Oct 11, 2017 at 12:36:46PM +0200, Takashi Iwai wrote: > There are a few other places calling usb_submit_urb() with the URB > composed from the fixed endpoint without validation. For avoiding the > spurious kernel warnings, add the sanity checks to appropriate > places. > > Signed-off-by:

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

On 10/11/2017 03:26 PM, Felipe Balbi wrote: Hi, Alexandre Torgue writes: Hi On 10/11/2017 01:50 PM, Felipe Balbi wrote: Hi, Alexandre Torgue writes: Hi Felip On 10/11/2017 12:04 PM, Felipe Balbi wrote: Hi, Amelie Delaunay

Re: [PATCH] xhci: Cope with VIA VL805 readahead

On 10.10.2017 21:09, Robin Murphy wrote: The VIA VL805 host controller is well-known for causing problems on systems with IOMMUs enabled, ranging from triggering endless streams of fault messages to locking itself up completely. It appears that the root of the problem might be an over-aggressive

Re: [PATCH v2 6/9] ALSA: usx2y: Add sanity checks for invalid EPs

On Wed, Oct 11, 2017 at 12:36:43PM +0200, Takashi Iwai wrote: > usx2y driver sets up URBs containing the fixed endpoints without > validation. This may end up with an oops-like kernel warning when > submitted. > > For avoiding it, this patch adds the calls of the new sanity-check > helper for

Re: [PATCH v2 1/9] usb: core: Add a helper function to check the validity of EP type in URB

On Wed, 11 Oct 2017 16:14:55 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 12:36:38PM +0200, Takashi Iwai wrote: > > This patch adds a new helper function to perform a sanity check of the > > given URB to see whether it contains a valid endpoint. It's a light- > > weight version of what

Re: [PATCH v2 4/9] ALSA: line6: Add a sanity check for invalid EPs

On Wed, Oct 11, 2017 at 12:36:41PM +0200, Takashi Iwai wrote: > As syzkaller spotted, currently line6 drivers submit a URB with the > fixed EP without checking whether it's actually available, which may > result in a kernel warning like: > usb 1-1: BOGUS urb xfer, pipe 3 != type 1 >

Re: [PATCH v2 3/9] ALSA: caiaq: Add a sanity check for invalid EPs

On Wed, Oct 11, 2017 at 12:36:40PM +0200, Takashi Iwai wrote: > As syzkaller spotted, currently caiaq driver submits a URB with the > fixed EP without checking whether it's actually available, which may > result in a kernel warning like: > usb 1-1: BOGUS urb xfer, pipe 3 != type 1 >

Re: [PATCH v2 1/9] usb: core: Add a helper function to check the validity of EP type in URB

On Wed, Oct 11, 2017 at 12:36:38PM +0200, Takashi Iwai wrote: > This patch adds a new helper function to perform a sanity check of the > given URB to see whether it contains a valid endpoint. It's a light- > weight version of what usb_submit_urb() does, but without the kernel > warning followed

[PATCH] xhci: Set DMA parameters appropriately

xHCI requires that data buffers do not cross 64KB boundaries (and are thus at most 64KB long as well) - whilst xhci_queue_{bulk,isoc}_tx() already split their input buffers into individual TRBs as necessary, it's still a good idea to advertise the limitations via the standard DMA API mechanism, so

Re: [PATCH 1/5] USB: serial: garmin_gps: fix I/O after failed probe and remove

On Wed, Oct 11, 2017 at 02:51:53PM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 11, 2017 at 02:02:57PM +0200, Johan Hovold wrote: > > Make sure to stop any submitted interrupt and bulk-out URBs before > > returning after failed probe and when the port is being unbound to avoid > > later

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Alexandre Torgue writes: > Hi > > On 10/11/2017 01:50 PM, Felipe Balbi wrote: >> >> Hi, >> >> Alexandre Torgue writes: >>> Hi Felip >>> >>> On 10/11/2017 12:04 PM, Felipe Balbi wrote: Hi, Amelie Delaunay

Re: [PATCH] HID: usbhid: Convert timers to use timer_setup()

On Wed, 4 Oct 2017, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Adds pointer back to hid_device for > multitouch. Applied,

Re: [PATCH v2 0/9] sound: Add sanity checks for invalid EPs

On Wed, 11 Oct 2017 15:03:29 +0200, Greg KH wrote: > > On Wed, Oct 11, 2017 at 12:36:37PM +0200, Takashi Iwai wrote: > > Hi, > > > > this is a revised patch set to cover the codes that may submit URBs > > containing invalid EPs without validation, which result in the kernel > > warning from the

Re: [PATCH v2] HID: usbhid: fix out-of-bounds bug

On Thu, 28 Sep 2017, Jaejoong Kim wrote: > The hid descriptor identifies the length and type of subordinate > descriptors for a device. If the received hid descriptor is smaller than > the size of the struct hid_descriptor, it is possible to cause > out-of-bounds. > > In addition, if

Re: [PATCH v2 0/9] sound: Add sanity checks for invalid EPs

On Wed, Oct 11, 2017 at 12:36:37PM +0200, Takashi Iwai wrote: > Hi, > > this is a revised patch set to cover the codes that may submit URBs > containing invalid EPs without validation, which result in the kernel > warning from the USB core. The first patch adds a new helper for > simplifying the

Re: [PATCH 5/5] USB: serial: garmin_gps: simplify init-session logic

On Wed, Oct 11, 2017 at 02:03:01PM +0200, Johan Hovold wrote: > Clean up the somewhat convoluted init-session logic to improve > readability. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the

Re: [PATCH 4/5] USB: serial: garmin_gps: clean up init-session messages

On Wed, Oct 11, 2017 at 02:03:00PM +0200, Johan Hovold wrote: > Use the port device for any init-session error and debug messages, > remove one redundant debug message and simplify one error message. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 3/5] USB: serial: garmin_gps: drop unused timer initialisation

On Wed, Oct 11, 2017 at 02:02:59PM +0200, Johan Hovold wrote: > Drop out-commented timer expiry initialisation which would not even > compile anymore. > > Signed-off-by: Johan Hovold Reviewed-by: Greg Kroah-Hartman -- To unsubscribe from this list:

Re: [PATCH 2/5] USB: serial: garmin_gps: fix memory leak on probe errors

On Wed, Oct 11, 2017 at 02:02:58PM +0200, Johan Hovold wrote: > Make sure to free the port private data before returning after a failed > probe attempt. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable > Signed-off-by: Johan Hovold

Re: [PATCH 1/5] USB: serial: garmin_gps: fix I/O after failed probe and remove

On Wed, Oct 11, 2017 at 02:02:57PM +0200, Johan Hovold wrote: > Make sure to stop any submitted interrupt and bulk-out URBs before > returning after failed probe and when the port is being unbound to avoid > later NULL-pointer dereferences in the completion callbacks. > > Also fix up the related

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi On 10/11/2017 01:50 PM, Felipe Balbi wrote: Hi, Alexandre Torgue writes: Hi Felip On 10/11/2017 12:04 PM, Felipe Balbi wrote: Hi, Amelie Delaunay writes: The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB OTG FS

[PATCH 3/5] USB: serial: garmin_gps: drop unused timer initialisation

Drop out-commented timer expiry initialisation which would not even compile anymore. Signed-off-by: Johan Hovold --- drivers/usb/serial/garmin_gps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index

[PATCH 2/5] USB: serial: garmin_gps: fix memory leak on probe errors

Make sure to free the port private data before returning after a failed probe attempt. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/garmin_gps.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 0/5] USB: serial: garmin_gps: fixes and clean ups

A recent timer API change brought my attention to this old gem of a driver which has been suffering from some error-handling bugs that would allow a malicious device to trigger a crash. Given the nature of the problem and the fact that it's been around since forever (i.e. pre-git), I don't think

[PATCH 1/5] USB: serial: garmin_gps: fix I/O after failed probe and remove

Make sure to stop any submitted interrupt and bulk-out URBs before returning after failed probe and when the port is being unbound to avoid later NULL-pointer dereferences in the completion callbacks. Also fix up the related and broken I/O cancellation on failed open and on close. (Note that

[PATCH 5/5] USB: serial: garmin_gps: simplify init-session logic

Clean up the somewhat convoluted init-session logic to improve readability. Signed-off-by: Johan Hovold --- drivers/usb/serial/garmin_gps.c | 41 - 1 file changed, 16 insertions(+), 25 deletions(-) diff --git

[PATCH 4/5] USB: serial: garmin_gps: clean up init-session messages

Use the port device for any init-session error and debug messages, remove one redundant debug message and simplify one error message. Signed-off-by: Johan Hovold --- drivers/usb/serial/garmin_gps.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Alexandre Torgue writes: > Hi Felip > > On 10/11/2017 12:04 PM, Felipe Balbi wrote: >> >> Hi, >> >> Amelie Delaunay writes: >>> The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB >>> OTG FS and the other is USB OTG HS.

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi Felip On 10/11/2017 12:04 PM, Felipe Balbi wrote: Hi, Amelie Delaunay writes: The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB OTG FS and the other is USB OTG HS. The USB FS core only works with its internal phy whilst the USB HS core can work

[PATCH v2 6/9] ALSA: usx2y: Add sanity checks for invalid EPs

usx2y driver sets up URBs containing the fixed endpoints without validation. This may end up with an oops-like kernel warning when submitted. For avoiding it, this patch adds the calls of the new sanity-check helper for URBs. Signed-off-by: Takashi Iwai ---

[PATCH v2 7/9] ALSA: hiface: Add sanity checks for invalid EPs

hiface usb-audio driver sets up URBs containing the fixed endpoints without validation. This may end up with an oops-like kernel warning when submitted. For avoiding it, this patch adds the calls of the new sanity-check helper for URBs. Signed-off-by: Takashi Iwai ---

[PATCH v2 5/9] ALSA: usb-audio: Add sanity checks for invalid EPs

USB-audio driver may set up a URB containing the fixed EP without validating its presence for some non-class-compliant devices. This may end up with an oops-like kernel warning when submitted. For avoiding it, this patch adds the call of the new sanity-check helper for URBs. The checks are

[PATCH v2 2/9] ALSA: bcd2000: Add a sanity check for invalid EPs

As syzkaller spotted, currently bcd2000 driver submits a URB with the fixed EP without checking whether it's actually available, which may result in a kernel warning like: usb 1-1: BOGUS urb xfer, pipe 1 != type 3 [ cut here ] WARNING: CPU: 0 PID: 1846 at

[PATCH v2 4/9] ALSA: line6: Add a sanity check for invalid EPs

As syzkaller spotted, currently line6 drivers submit a URB with the fixed EP without checking whether it's actually available, which may result in a kernel warning like: usb 1-1: BOGUS urb xfer, pipe 3 != type 1 [ cut here ] WARNING: CPU: 0 PID: 24 at

[PATCH v2 9/9] ALSA: line6: Add yet more sanity checks for invalid EPs

There are a few other places calling usb_submit_urb() with the URB composed from the fixed endpoint without validation. For avoiding the spurious kernel warnings, add the sanity checks to appropriate places. Signed-off-by: Takashi Iwai --- sound/usb/line6/driver.c | 23

[PATCH v2 1/9] usb: core: Add a helper function to check the validity of EP type in URB

This patch adds a new helper function to perform a sanity check of the given URB to see whether it contains a valid endpoint. It's a light- weight version of what usb_submit_urb() does, but without the kernel warning followed by the stack trace, just returns an error code. Especially for a

[PATCH v2 8/9] ALSA: caiaq: Add yet more sanity checks for invalid EPs

A few other places in caiaq driver have the URB handling with the fixed endpoints without checking the validity, too. Add the sanity check with the new helper function at each appropriate place for avoiding the spurious kernel warnings due to invalid EPs. Signed-off-by: Takashi Iwai

[PATCH v2 3/9] ALSA: caiaq: Add a sanity check for invalid EPs

As syzkaller spotted, currently caiaq driver submits a URB with the fixed EP without checking whether it's actually available, which may result in a kernel warning like: usb 1-1: BOGUS urb xfer, pipe 3 != type 1 [ cut here ] WARNING: CPU: 1 PID: 1150 at

Re: [bugzilla-dae...@bugzilla.kernel.org: [Bug 197159] New: Xhci host controller not responding starting kernel 4.13]

On 10/10/2017 01:38, Bjorn Helgaas wrote: > On Mon, Oct 09, 2017 at 10:45:39PM +0200, Mason wrote: >> On 09/10/2017 19:01, Bjorn Helgaas wrote: >> ... > >>> In that thread, Mason reported a regression that looks similar, but as >>> far as I can tell, we never identified a root cause. >>> >>> 1)

Re: [PATCH] usb: typec: wcove: fix uninitialized usbc_irq1 and usbc_irq2

On Wed, Oct 11, 2017 at 10:09:57AM +0100, Colin King wrote: > From: Colin Ian King > > Calls to regmap_read may fail with an -EINVAL return without setting > usbc_irq1 and usbc_irq2. The error handling clean up expects these > to have been set (or zero on a failure)

Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

Hi, John Stultz writes: > On Thu, Aug 17, 2017 at 12:03 PM, John Stultz wrote: >> In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we >> disconnect the gadget state"), I was trying to fix up the >> fact that we somehow weren't

Re: [PATCH 2/9] drivers: usb: phy: omap: use setup_timer() helper.

Allen Pais writes: >Use setup_timer function instead of initializing timer with the >function and data fields. why the extra spaces here? This time I'll fix it myself. Next time make sure to send patches in correct formatting. -- balbi signature.asc

Re: [PATCHv2 0/7] Add support for USB OTG on STM32F7

Hi, Amelie Delaunay writes: > The STM32F7 MCU family embeds two DWC2 USB OTG cores. One core is USB > OTG FS and the other is USB OTG HS. The USB FS core only works with its > internal phy whilst the USB HS core can work in HS with external ULPI phy > or in FS/LS with

RE: [PATCH] xhci: Cope with VIA VL805 readahead

From: Robin Murphy > Sent: 10 October 2017 19:09 > > The VIA VL805 host controller is well-known for causing problems on > systems with IOMMUs enabled, ranging from triggering endless streams of > fault messages to locking itself up completely. It appears that the root > of the problem might be

[PATCH] usb: typec: wcove: fix uninitialized usbc_irq1 and usbc_irq2

From: Colin Ian King Calls to regmap_read may fail with an -EINVAL return without setting usbc_irq1 and usbc_irq2. The error handling clean up expects these to have been set (or zero on a failure) and currently may try to clear the wrong IRQs if the uninitalized

[PATCH] usb: cdc_acm: Add quirk for Elatec TWN3

Elatec TWN3 has the union descriptor on data interface. This results in failure to bind the device to the driver with the following log: usb 1-1.2: new full speed USB device using streamplug-ehci and address 4 usb 1-1.2: New USB device found, idVendor=09d8, idProduct=0320 usb 1-1.2: New USB

Re: [PATCH] USB: serial: garmin_gps: Convert timers to use timer_setup()

On Tue, Oct 10, 2017 at 11:25:22AM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Johan Hovold >

[PATCH] USB: Force disconnect Huawei 4G modem during suspend

From: Chris Chiu When going into S3 suspend, the Acer TravelMate P648-M and P648-G3 laptops immediately wake up 3-4 seconds later for no obvious reason. Unbinding the integrated Huawei 4G LTE modem before suspend avoids the issue, even though we are not using the modem at all

Re: Dell thunderbolt docking station not working

On Tue, Oct 10, 2017 at 03:42:10PM -0700, Stephen Hemminger wrote: > On Tue, 10 Oct 2017 22:31:34 +0300 > Mika Westerberg wrote: > > > On Tue, Oct 10, 2017 at 12:11:49PM -0700, Stephen Hemminger wrote: > > > The Dell thunderbolt docking brick (TB16) does not

Re: [PATCH 8/9] dt-bindings: usb: mtk-xhci: add a optional property to disable u3ports

On Thu, 2017-10-05 at 17:16 -0500, Rob Herring wrote: Hi, > On Wed, Sep 27, 2017 at 05:23:04PM +0800, Chunfeng Yun wrote: > > Add a new optional property to disable u3ports > > > > Signed-off-by: Chunfeng Yun > > --- > >