Re: Dual-Role switch with single input

2017-10-31 Thread Peter Chen
On Tue, Oct 31, 2017 at 06:07:39PM +0100, Stefan Agner wrote: > Hi Peter, > > I am currently trying to come up with a upstreamable solution for USB > device/host switch for our NXP i.MX 7 CoM (Colibri iMX7). My colleague > Sanchayan already posted on the mailing list in a earlier attempt for >

Re: [PATCH] xhci: Hard reset controller on shutdown.

2017-10-31 Thread wenxiong
On 2017-10-21 10:04, Alan Stern wrote: On Fri, 20 Oct 2017, Brian King wrote: On 10/19/2017 12:04 PM, Alan Stern wrote: > On Thu, 19 Oct 2017, Mathias Nyman wrote: > >> Current shutdown routine just forces the host controller to stop, it clears the >> run bit and polls the "halted" status for

Re: [PATCH] USB: serial: option: add Novatel USB730L enterprise mode

2017-10-31 Thread Johan Hovold
On Tue, Oct 31, 2017 at 04:54:56PM +, Gal Shalif wrote: > From 436a7eb28215081d34c386a92213bd6932d0779a Mon Sep 17 00:00:00 2001 > From: Gal Shalif > Date: Tue, 31 Oct 2017 18:00:36 +0200 > Subject: [PATCH] USB: serial: option: add Novatel USB730L enterprise mode > > Add the

Re: MUSB Error Handling

2017-10-31 Thread Bin Liu
Hi, On Tue, Oct 31, 2017 at 12:56:40PM -0500, Adam Ford wrote: > We have a situation where occasionally the USB glitches where the D- > glitches low at or near an end of frame (EOF) or end of packet (EOP). > We're using the TWL4030 with MUSB on an OMAP3 processor. We cannot > tell where the

Re: [PATCH v3] usb: wusbcore: Use put_unaligned_le32

2017-10-31 Thread Himanshu Jha
On Tue, Oct 17, 2017 at 05:14:30PM +0530, Himanshu Jha wrote: Hi Greg, > Use put_unaligned_le32 rather than using byte ordering function and > memcpy which makes code clear. > Also, add the header file where it is declared. > I hope my patch is in your queue! > Done using Coccinelle and

[PATCH 11/11] usb/gadget: Make it again possible to enable the legacy drivers without enabling USB_ETH

2017-10-31 Thread Bart Van Assche
Considerable time ago the legacy gadget menu was added inside the USB_ETH choice. I think this was a mistake and that the legacy gadget menu should have been added after "endchoice" instead of before. Hence this patch. Fixes: commit 8443f2d2b778 ("usb: gadget: Gadget directory cleanup - group

MUSB Error Handling

2017-10-31 Thread Adam Ford
We have a situation where occasionally the USB glitches where the D- glitches low at or near an end of frame (EOF) or end of packet (EOP). We're using the TWL4030 with MUSB on an OMAP3 processor. We cannot tell where the glitch is originating. We're working on resolving this in both hardware

Dual-Role switch with single input

2017-10-31 Thread Stefan Agner
Hi Peter, I am currently trying to come up with a upstreamable solution for USB device/host switch for our NXP i.MX 7 CoM (Colibri iMX7). My colleague Sanchayan already posted on the mailing list in a earlier attempt for our Colibri VFxx modules (NXP Vybrid):

[PATCH] USB: serial: option: add Novatel USB730L enterprise mode

2017-10-31 Thread Gal Shalif
>From 436a7eb28215081d34c386a92213bd6932d0779a Mon Sep 17 00:00:00 2001 From: Gal Shalif Date: Tue, 31 Oct 2017 18:00:36 +0200 Subject: [PATCH] USB: serial: option: add Novatel USB730L enterprise mode Add the serial interface of the Novatel USB730L enterprise mode. Change is done

Re: DWC3 Gadget backtrace

2017-10-31 Thread Howey, Dylan
Felipe, The 10/31/2017 12:05, Felipe Balbi wrote: > > Hi, > > "Howey, Dylan" writes: > > Felipe, > > > > On 10/30/2017 15:28, Felipe Balbi wrote: > >> > >> Hi, > >> > >> "Howey, Dylan" writes: > >> > Felipe, > >> > > >> > It's also

Re: DWC3 Gadget backtrace

2017-10-31 Thread Howey, Dylan
Roger, On 10/31/2017 10:23, Roger Quadros wrote: > Hi Dylan, > > On 30/10/17 10:59, Felipe Balbi wrote: > > > > Hi, > > > > "Howey, Dylan" writes: > >> Hello, > >> > >> I'm on an AM437x platform and I'm using FunctionFS to create a HID > >> gadget. The device

Re: mmc: vub300: Use common code in __download_offload_pseudocode()

2017-10-31 Thread SF Markus Elfring
> Regarding posts from Markus' I am well aware of the problems. Interesting … > In my case, it hasn't been much of a hurdle, I simply ignore changes > that seems silly to me. * How often did this happen so far? * Are any update suggestions left over where a constructive feedback will make

Re: State of USB-C PD on the linux kernel

2017-10-31 Thread L. Rose
Hi, thanks for your reply! On 31.10.2017 10:17, Heikki Krogerus wrote: Hi, It is likely that your system handles USB PD in firmware, and the OS has no say in that. Which board is it? It's a "Gigabyte Z170X Ultra Gaming", which I (obviously) don't use for gaming ;) You should be able to see

Re: [PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

2017-10-31 Thread Ulf Hansson
On 31 October 2017 at 09:45, Dan Carpenter wrote: > On Mon, Oct 30, 2017 at 02:03:13PM +0100, Ulf Hansson wrote: >> On 30 October 2017 at 13:15, Dan Carpenter wrote: >> > On Mon, Oct 30, 2017 at 12:40:39PM +0100, Ulf Hansson wrote: >> >> On 27

Re: xhci_hcd WARN Event TRB for slot ep with no TDs queued?

2017-10-31 Thread Juan Simón
Hi, Thanks but that patch doesn't work for me. The warnings in system log aren't the problem. In my case, with 4.13.x kernels, the problem is that the system continuously receives mouse signals.How do I detect it? Because when I put a video on YouTube the bar with the controls never disappears

RE: Linux and usb device drivers using functionfs

2017-10-31 Thread andy_purcell
Hello Felipe, I am not using DWC3. I have new information about the problem. The context was this: 1) device boots 2) some usb transfers happen, all are OK 3) a device app runs to completion (USB quiescent during this time, no USB transfers required) 4) the controlling PC starts a

[PATCH v2][RESEND] usb: gadget: core: Fix ->udc_set_speed() speed handling

2017-10-31 Thread Roger Quadros
Currently UDC core calls ->udc_set_speed() with the speed parameter containing the maximum speed supported by the gadget function driver. This might very well be more than that supported by the UDC controller driver. Select the lesser of the 2 speeds so both UDC and gadget function driver are

Re: [PATCH v2] usb: dwc3: gadget: Fix .udc_set_speed()

2017-10-31 Thread Roger Quadros
Felipe, Forgot to update subject :P. Will resend. On 31/10/17 15:47, Roger Quadros wrote: > Currently UDC core calls ->udc_set_speed() with the speed parameter > containing the maximum speed supported by the gadget function > driver. This might very well be more than that supported by the > UDC

[PATCH v2] usb: dwc3: gadget: Fix .udc_set_speed()

2017-10-31 Thread Roger Quadros
Currently UDC core calls ->udc_set_speed() with the speed parameter containing the maximum speed supported by the gadget function driver. This might very well be more than that supported by the UDC controller driver. Select the lesser of the 2 speeds so both UDC and gadget function driver are

Re: [PATCH v3 1/3] usb: host: remove ehci-msm.c

2017-10-31 Thread Alan Stern
On Tue, 31 Oct 2017, Alex Elder wrote: > No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it. > > Suggested-by: Stephen Boyd > Signed-off-by: Alex Elder > Acked-by: Bjorn Andersson > Acked-by: Andy Gross

Re: [PATCH] usb: dwc3: gadget: Fix .udc_set_speed()

2017-10-31 Thread Roger Quadros
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 31/10/17 15:24, Felipe Balbi wrote: > Roger Quadros writes: > >> UDC core calls .udc_set_speed() with the speed parameter >> containing the maximum

[PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2

2017-10-31 Thread Roger Quadros
The metastability workaround causes Erratic errors [1] on the HighSpeed USB PHY which can cause upto 2 seconds delay in enumerating to a USB host while in Gadget mode. Disable the Run/Stop metastability workaround to avoid this ill effect. We are aware that this opens up the opportunity for

Re: [PATCH] usb: dwc3: gadget: Fix .udc_set_speed()

2017-10-31 Thread Felipe Balbi
Roger Quadros writes: > UDC core calls .udc_set_speed() with the speed parameter > containing the maximum speed supported by the gadget function > driver. This might very well be more or less than that > supported by the dwc3 controller driver. > > Select the lesser of the 2

Re: [PATCH] net: hso: remove redundant unused variable dev

2017-10-31 Thread Johan Hovold
On Tue, Oct 31, 2017 at 12:01:47PM +, Colin King wrote: > From: Colin Ian King > > The pointer dev is being assigned but is never used, hence it is > redundant and can be removed. Cleans up clang warning: > > drivers/net/usb/hso.c:2280:2: warning: Value stored to

[PATCH v3 0/3] usb: remove some unused code

2017-10-31 Thread Alex Elder
This series deletes some Qualcomm USB code is no longer needed by any Qualcomm hardware. A separate series deletes the Kconfig options that enable building this code from the ARM64 defconfig. With these drivers, host and gadget mode were implemented separately for the same hardware, which is

[PATCH v3 1/3] usb: host: remove ehci-msm.c

2017-10-31 Thread Alex Elder
No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it. Suggested-by: Stephen Boyd Signed-off-by: Alex Elder Acked-by: Bjorn Andersson Acked-by: Andy Gross --- drivers/usb/host/Kconfig

[PATCH v3 2/3] usb: phy: remove phy-msm-usb.c

2017-10-31 Thread Alex Elder
No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support any more, so remove the code. Suggested-by: Stephen Boyd Signed-off-by: Alex Elder Acked-by: Bjorn Andersson Acked-by: Andy Gross ---

[PATCH v3 3/3] usb: phy: remove phy-qcom-8x16-usb.c

2017-10-31 Thread Alex Elder
No Qualcomm SoC requires the "phy-qcom-8x16-usb.c" USB phy driver support any more, so remove the code. Suggested-by: Stephen Boyd Signed-off-by: Alex Elder Acked-by: Bjorn Andersson Acked-by: Andy Gross

[PATCH] usb: dwc3: Allow disabling of metastability workaround

2017-10-31 Thread Roger Quadros
Some platforms (e.g. TI's DRA7 USB2 instance) have more trouble with the metastability workaround as it supports only a High-Speed PHY and the PHY can enter into an Erratic state [1] when the controller is set in SuperSpeed mode as part of the metastability workaround. This causes upto 2 seconds

[PATCH] usb: dwc3: gadget: Fix .udc_set_speed()

2017-10-31 Thread Roger Quadros
UDC core calls .udc_set_speed() with the speed parameter containing the maximum speed supported by the gadget function driver. This might very well be more or less than that supported by the dwc3 controller driver. Select the lesser of the 2 speeds so both are operating within limits. This fixes

Re: [PATCH v2 0/4] usb: xhci: fix build warnings

2017-10-31 Thread Mathias Nyman
On 26.10.2017 13:46, Corentin Labbe wrote: Hello This patchset fix some build warnings on usb/xhci. Regards Changes since v1: - Changed subject of patch Corentin Labbe (4): usb: xhci: remove unused variable last_freed_endpoint usb: xhci: remove unused variable ep usb: xhci: remove

Re: DWC3 Gadget backtrace

2017-10-31 Thread Roger Quadros
Felipe, On 31/10/17 12:24, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > > > >>> Roger, your PHY is toast :-( >>> >>> irq/90-dwc3-969 [000] d...52.323145: dwc3_event: event >>> (0901): Erratic Error [U0] >>> irq/90-dwc3-969 [000] d...

[PATCH] net: hso: remove redundant unused variable dev

2017-10-31 Thread Colin King
From: Colin Ian King The pointer dev is being assigned but is never used, hence it is redundant and can be removed. Cleans up clang warning: drivers/net/usb/hso.c:2280:2: warning: Value stored to 'dev' is never read Signed-off-by: Colin Ian King

Re: xhci_hcd WARN Event TRB for slot ep with no TDs queued?

2017-10-31 Thread Mathias Nyman
On 30.10.2017 23:14, Greg KH wrote: On Mon, Oct 30, 2017 at 04:16:29PM +0100, Juan Simón wrote: Hi, I have read this thread (https://marc.info/?l=linux-usb=150056183628924=2) and supposedly the problem was solved in version 4.13.7 but in my case it's not like that. It's not solved in 4.13.7.

Re: [PATCH v7 usb-next 3/4] usb: core: hcd: integrate the PHY roothub wrapper

2017-10-31 Thread Chunfeng Yun
Hi Martin, On Tue, 2017-10-31 at 00:10 +0100, Martin Blumenstingl wrote: > Hi Manu, > > thank you for reviewing this! > > On Thu, Oct 26, 2017 at 7:42 AM, Manu Gautam wrote: > > Hi, > > > > > > On 10/24/2017 3:27 AM, Martin Blumenstingl wrote: > >> This integrates the

Re: usbip port number limits

2017-10-31 Thread Bjørn Mork
Juan Zea writes: > Having a look at the code of the VHCI driver at > https://github.com/torvalds/linux/tree/master/drivers/usb/usbip , I > found these two parameters: USBIP_VHCI_HC_PORTS and USBIP_VHCI_NR_HCS > > I've compiled VHCI driver from latest source above, altering

Re: DWC3 Gadget backtrace

2017-10-31 Thread Felipe Balbi
Hi, Manu Gautam writes: > Hi, > > On 10/31/2017 4:12 PM, Felipe Balbi wrote: >> Hi, >> >> Roger Quadros writes: >>> On 31/10/17 12:24, Felipe Balbi wrote: Hi, Roger Quadros writes: >> Roger, your PHY is

Re: DWC3 Gadget backtrace

2017-10-31 Thread Manu Gautam
Hi, On 10/31/2017 4:12 PM, Felipe Balbi wrote: > Hi, > > Roger Quadros writes: >> On 31/10/17 12:24, Felipe Balbi wrote: >>> Hi, >>> >>> Roger Quadros writes: >>> >>> >>> > Roger, your PHY is toast :-( > > irq/90-dwc3-969 [000] d...

Re: DWC3 Gadget backtrace

2017-10-31 Thread Felipe Balbi
Hi, Roger Quadros writes: > On 31/10/17 12:24, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >> >> >> Roger, your PHY is toast :-( irq/90-dwc3-969 [000] d...52.323145: dwc3_event: event (0901): Erratic Error

[PATCH] usb: host: max3421-hcd: Remove pdata test in max3421_hub_control()

2017-10-31 Thread Jules Maselbas
We do not have to test if platform_data pointer is null in max3421_hub_control(), as the driver probe will fail if no platform_data is found. Fixes: 721fdc83b31b ("usb: max3421: Add devicetree support") Signed-off-by: Jules Maselbas Reported-by: Julia Lawall

Re: DWC3 Gadget backtrace

2017-10-31 Thread Roger Quadros
On 31/10/17 12:24, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > > > >>> Roger, your PHY is toast :-( >>> >>> irq/90-dwc3-969 [000] d...52.323145: dwc3_event: event >>> (0901): Erratic Error [U0] >>> irq/90-dwc3-969 [000] d...52.560646:

[PATCH] dt-bindings: usb: max3421: Interrupt-parent is optional

2017-10-31 Thread Jules Maselbas
Documentation modification, now interrupt-parent is an optional property. Also fix few typos. Signed-off-by: Jules Maselbas Reported-by: Sergei Shtylyov --- Documentation/devicetree/bindings/usb/maxim,max3421.txt | 8 +---

Re: DWC3 Gadget backtrace

2017-10-31 Thread Felipe Balbi
Hi, Roger Quadros writes: >> Roger, your PHY is toast :-( >> >> irq/90-dwc3-969 [000] d...52.323145: dwc3_event: event >> (0901): Erratic Error [U0] >> irq/90-dwc3-969 [000] d...52.560646: dwc3_event: event >> (0901): Erratic Error [U0] >>

Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away

2017-10-31 Thread Felipe Balbi
Doug Anderson writes: > Hi, > > On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi wrote: >> >> Hi, >> >> Doug Anderson writes: >>> Hi, >>> >>> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren >>> wrote: Hi

Re: DWC3 Gadget backtrace

2017-10-31 Thread Roger Quadros
On 31/10/17 12:05, Felipe Balbi wrote: > > Hi, > > "Howey, Dylan" writes: >> Felipe, >> >> On 10/30/2017 15:28, Felipe Balbi wrote: >>> >>> Hi, >>> >>> "Howey, Dylan" writes: Felipe, It's also happening in v4.14-rc7. >>> >>>

Re: Linux and usb device drivers using functionfs

2017-10-31 Thread Felipe Balbi
Hi, andy_purc...@keysight.com writes: > I have implemented a USB device function using Linux functionfs and > now there is a problem being reported. > > I need to ask this group for advice. > > The problem is this: > 1) device boots > > 2) some usb transfers happen, all are OK > > 3) a

Re: DWC3 Gadget backtrace

2017-10-31 Thread Felipe Balbi
Hi, "Howey, Dylan" writes: > Felipe, > > On 10/30/2017 15:28, Felipe Balbi wrote: >> >> Hi, >> >> "Howey, Dylan" writes: >> > Felipe, >> > >> > It's also happening in v4.14-rc7. >> >> Please make sure to also Cc:

Re: Linux and usb device drivers using functionfs

2017-10-31 Thread Greg KH
On Mon, Oct 30, 2017 at 04:51:57PM +, andy_purc...@keysight.com wrote: > Hello, > > I have implemented a USB device function using Linux functionfs and now there > is a problem being reported. > I need to ask this group for advice. > > The problem is this: > 1) device boots > 2) some

Re: State of USB-C PD on the linux kernel

2017-10-31 Thread Heikki Krogerus
Hi, On Mon, Oct 30, 2017 at 05:48:43PM +0100, L. Rose wrote: > Hello everyone, > > I see this is primarily a development mailing list, but I didn't find a > corresponding users mailing list. If there's a better place to ask this > question, just let me know. > > What is the state of USB-C Power

Re: mmc: vub300: Use common code in __download_offload_pseudocode()

2017-10-31 Thread SF Markus Elfring
>>> What's the advantage of this patch? The new code seems more complicated >>> to me and GCC automatically reuses duplicate constant strings so there >>> is no memory savings. >> >> It looked to me that the error path got a bit cleaner. However, I >> guess it's matter of taste. >> >> If you

Re: [PATCH V1 2/2] usb: serial: f81534: Implement break control

2017-10-31 Thread Johan Hovold
On Fri, Oct 13, 2017 at 10:21:35AM +0800, Ji-Ze Hong (Peter Hong) wrote: > Implement Fintek f81534 break on/off with LCR register. > It's the same with 16550A LCR register layout. > > Signed-off-by: Ji-Ze Hong (Peter Hong) > --- > drivers/usb/serial/f81534.c | 46

Re: [PATCH V1 1/2] usb: serial: f81534: fix hang-up on overrun

2017-10-31 Thread Johan Hovold
On Fri, Oct 13, 2017 at 10:21:34AM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 without this patch will hang-up on data overrun. > > It's caused by enable LSR interrupt in IER by default and occur data > overrun, the chip will busy for process LSR interrupt but not read LSR >

Re: [PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

2017-10-31 Thread Dan Carpenter
On Mon, Oct 30, 2017 at 02:03:13PM +0100, Ulf Hansson wrote: > On 30 October 2017 at 13:15, Dan Carpenter wrote: > > On Mon, Oct 30, 2017 at 12:40:39PM +0100, Ulf Hansson wrote: > >> On 27 October 2017 at 21:31, SF Markus Elfring > >>

usbip port number limits

2017-10-31 Thread Juan Zea
Hi, My name is Juan, and I work for Qindel, a small IT company based in Spain. I'm currently trying to do some development for our main product QVD. Specifically, I'm trying to get usbip to work with a great number of LXC containers. Due to the nature of LXC, all usbip ports are shared among

Re: [PATCH] ARM: dts: bcm283x: Fix fifo size for EP 6,7

2017-10-31 Thread Stefan Wahren
Hi Eric, > Eric Anholt hat am 31. Oktober 2017 um 01:40 geschrieben: > > > Stefan Wahren writes: > > >> Stefan Wahren hat am 7. Oktober 2017 um 12:16 > >> geschrieben: > >> > >> > >> In case the RPi Zero has at least a

Re: [PATCH] usb: typec: tps6598x: mark expected switch fall-through

2017-10-31 Thread Heikki Krogerus
On Fri, Oct 27, 2017 at 04:01:13PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Heikki Krogerus

Re: DWC3 Gadget backtrace

2017-10-31 Thread Roger Quadros
Hi Dylan, On 30/10/17 10:59, Felipe Balbi wrote: > > Hi, > > "Howey, Dylan" writes: >> Hello, >> >> I'm on an AM437x platform and I'm using FunctionFS to create a HID >> gadget. The device enumerates correctly when I plug it into a Linux >> host. If I unplug the cord

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-31 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:50:02PM -0500, Gustavo A. R. Silva wrote: > Quoting Johan Hovold : > > This code is pretty hard to read as is and could really use some clean > > up... > > > > I agree. I'll send a V2 of this patch and then let's see if I can help > with some code

Re: [PATCH] usb serial: qcserial: pid/vid for Sierra Wireless EM7355 firmware update

2017-10-31 Thread Johan Hovold
On Sun, Oct 29, 2017 at 11:29:55PM +, Douglas Fischer wrote: > Add USB PID/VID for Sierra Wireless EM7355 LTE modem QDL firmware update > mode. Fixed formatting and style issues. Thanks for the v2. Next time remember to include the patch revision in the PATCH prefix (e.g. "[PATCH v2] USB: