RE: stopping and starting a functionfs USB-device causes panic

2017-11-03 Thread andy_purcell
Hello Felipe, > > > > I have a second issue with a functionfs USB-device implementation. > > > > The scenario is this: > > 1) USB-device app starts up, runs fine > > 2) ssh to the device, kill the app with CTRL-C > > 3) try to start the USB-device app 2nd time > > > > PANIC > > > > dmesg output:

Re: xhci bandwidth problem with isochronous endpoints

2017-11-03 Thread Curt Meyers
On 09/19/2017 06:00 AM, Mathias Nyman wrote: On 08.09.2017 20:35, Curt Meyers wrote: On 09/05/2017 02:56 PM, Curt Meyers wrote: On 09/04/2017 04:13 AM, Mathias Nyman wrote: On 04.09.2017 13:46, Felipe Balbi wrote: Hi, Mathias Nyman writes: Unfortunately

Re: MUSB Error Handling

2017-11-03 Thread Alan Stern
On Fri, 3 Nov 2017, Adam Ford wrote: > One other similar question. I apologize for my ignorance. It appears > as if the MUSB support suspending and resume in host mode. If we can > predict that the noise will generate, we're hoping to suspend the USB > before the noise even, then resume the USB

Re: [PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub_control()

2017-11-03 Thread Alan Stern
On Fri, 3 Nov 2017, Roger Quadros wrote: > There will never be a case when gadget.speed isn't already > USB_SPEED_FULL if connection is not USB-3 and gadget.speed > is not USB_SPEED_HIGH or USB_SPEED_LOW. > > Remove the unnecessary code. > > Signed-off-by: Roger Quadros > --- >

Re: [PATCH 2/9] USB: storage: Remove redundant license text

2017-11-03 Thread Alan Stern
On Fri, 3 Nov 2017, Greg Kroah-Hartman wrote: > On Fri, Nov 03, 2017 at 10:01:01AM -0700, Matthew Dharm wrote: > > Alan, this might also be a good time to remove the "Please see [...] > > for more information" bits also. That URL hasn't worked for well, > > a very very long time. > > I can

Re: [PATCH][RFC] usb: hub: Cycle HUB power when initialization fails

2017-11-03 Thread Alan Stern
On Fri, 3 Nov 2017, Mike Looijmans wrote: > Sometimes the USB device gets confused about the state of the initialization > and > the connection fails. In particular, the device thinks that it's already set > up > and running while the host thinks the device still needs to be configured. To How

Re: [PATCH 1/9] USB: serial: Remove redundant license text

2017-11-03 Thread Johan Hovold
On Fri, Nov 03, 2017 at 12:40:56PM +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to

Re: [PATCH] USB: serial: fix module-license macros

2017-11-03 Thread Greg Kroah-Hartman
On Fri, Nov 03, 2017 at 06:12:08PM +0100, Johan Hovold wrote: > Several GPL-2.0 drivers used "GPL" rather than "GPL v2" in their > MODULE_LICENSE macros; fix the macros to match the licenses. > > Signed-off-by: Johan Hovold > --- > > Greg, > > Here's a follow-up you can apply

[PATCH] USB: serial: fix module-license macros

2017-11-03 Thread Johan Hovold
Several GPL-2.0 drivers used "GPL" rather than "GPL v2" in their MODULE_LICENSE macros; fix the macros to match the licenses. Signed-off-by: Johan Hovold --- Greg, Here's a follow-up you can apply after you add the SPDX identifiers. Thanks, Johan

Re: [PATCH 2/9] USB: storage: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
On Fri, Nov 03, 2017 at 10:01:01AM -0700, Matthew Dharm wrote: > Alan, this might also be a good time to remove the "Please see [...] > for more information" bits also. That URL hasn't worked for well, > a very very long time. I can do that too if you want in a follow-on patch. thanks,

Re: [PATCH 2/9] USB: storage: Remove redundant license text

2017-11-03 Thread Matthew Dharm
Alan, this might also be a good time to remove the "Please see [...] for more information" bits also. That URL hasn't worked for well, a very very long time. Matt On Fri, Nov 3, 2017 at 7:45 AM, Alan Stern wrote: > On Fri, 3 Nov 2017, Greg Kroah-Hartman wrote: >

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-03 Thread Johan Hovold
On Fri, Nov 03, 2017 at 11:28:30AM +0100, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/usb/ and include/linux/usb* files with the correct > SPDX license identifier based on the

[PATCH] Add delay-init quirk for Corsair K70 LUX keyboards

2017-11-03 Thread Bernhard Rosenkraenzer
Without this patch, K70 LUX keyboards don't work, saying usb 3-3: unable to read config index 0 descriptor/all usb 3-3: can't read configurations, error -110 usb usb3-port3: unable to enumerate USB device Signed-off-by: Bernhard Rosenkraenzer ---

Re: [PATCH 7/9] USB: core: Remove redundant license text

2017-11-03 Thread Alan Stern
On Fri, 3 Nov 2017, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+

Re: [PATCH 2/9] USB: storage: Remove redundant license text

2017-11-03 Thread Alan Stern
On Fri, 3 Nov 2017, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+

Re: MUSB Error Handling

2017-11-03 Thread Adam Ford
On Thu, Nov 2, 2017 at 2:58 PM, Adam Ford wrote: > On Thu, Nov 2, 2017 at 2:43 PM, Tony Lindgren wrote: >> * Bin Liu [171031 18:35]: >>> Hi, >>> >>> On Tue, Oct 31, 2017 at 12:56:40PM -0500, Adam Ford wrote: >>> > We have a situation where

Re: [PATCH] usb: remove msm_hsusb_hw.h

2017-11-03 Thread Alex Elder
On 11/02/2017 07:21 PM, Jack Pham wrote: > The last two remaining drivers (ehci-msm.c and phy-msm-usb.c) that > needed this header were recently removed, so delete this now-unused > file. > > Signed-off-by: Jack Pham Looks good. Thanks a lot Jack. Reviewed-by: Alex Elder

Re: [PATCH v3 2/3] usb: phy: remove phy-msm-usb.c

2017-11-03 Thread Alex Elder
On 11/02/2017 07:02 PM, Jack Pham wrote: > Hi Alex, > > On Tue, Oct 31, 2017 at 08:11:30AM -0500, Alex Elder wrote: >> No Qualcomm SoC requires the "phy-msm-usb.c" USB phy driver support >> any more, so remove the code. >> >> Suggested-by: Stephen Boyd >> Signed-off-by:

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-03 Thread Greg Kroah-Hartman
On Fri, Nov 03, 2017 at 12:50:57PM +0200, Felipe Balbi wrote: > Greg Kroah-Hartman writes: > > > It's good to have SPDX identifiers in all files to make it easier to > > audit the kernel tree for correct licenses. > > > > Update the drivers/usb/ and include/linux/usb*

[PATCH 7/9] USB: core: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH 2/9] USB: storage: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH 6/9] USB: image: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH 3/9] USB: misc: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH 5/9] USB: class: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH 8/9] USB: common: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH 4/9] USB: atm: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH 1/9] USB: serial: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH 9/9] USB: usb-skeleton: Remove redundant license text

2017-11-03 Thread Greg Kroah-Hartman
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL

[PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub_control()

2017-11-03 Thread Roger Quadros
There will never be a case when gadget.speed isn't already USB_SPEED_FULL if connection is not USB-3 and gadget.speed is not USB_SPEED_HIGH or USB_SPEED_LOW. Remove the unnecessary code. Signed-off-by: Roger Quadros --- drivers/usb/gadget/udc/dummy_hcd.c | 2 -- 1 file changed,

[PATCH][RFC] usb: hub: Cycle HUB power when initialization fails

2017-11-03 Thread Mike Looijmans
Sometimes the USB device gets confused about the state of the initialization and the connection fails. In particular, the device thinks that it's already set up and running while the host thinks the device still needs to be configured. To work around this issue, power-cycle the hub's output to

Re: stopping and starting a functionfs USB-device causes panic

2017-11-03 Thread Felipe Balbi
Hi, andy_purc...@keysight.com writes: > Hello, > > I have a second issue with a functionfs USB-device implementation. > > The scenario is this: > 1) USB-device app starts up, runs fine > 2) ssh to the device, kill the app with CTRL-C > 3) try to start the USB-device app 2nd time > > PANIC

RE: Linux and usb device drivers using functionfs

2017-11-03 Thread Felipe Balbi
Hi, andy_purc...@keysight.com writes: >> > > And where is your swap? What happens if you just do not have swap at >> > > all? >> > Our system has no swap. Running 'top' says 0 total, 0 free, 0 used >> >> then your program can not get swapped out, so this whole thing is crazy. > > Colleague

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

2017-11-03 Thread Felipe Balbi
Hi, Greg Kroah-Hartman writes: >> > >> Greg Kroah-Hartman writes: >> >>> > >> >> > xHCI compatible USB host controllers(i.e. super-speed USB3 >> >>> > >> >> > controllers) >> >>> > >> >> > can be implemented with the

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-03 Thread Felipe Balbi
Greg Kroah-Hartman writes: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/usb/ and include/linux/usb* files with the correct > SPDX license identifier based on the license

Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/

2017-11-03 Thread Greg Kroah-Hartman
On Fri, Nov 03, 2017 at 11:28:30AM +0100, Greg Kroah-Hartman wrote: > It's good to have SPDX identifiers in all files to make it easier to > audit the kernel tree for correct licenses. > > Update the drivers/usb/ and include/linux/usb* files with the correct > SPDX license identifier based on the

[PATCH] USB: core: move existing SPDX tags to top of the file

2017-11-03 Thread Greg Kroah-Hartman
To match the rest of the kernel, the SPDX tags for the drivers/usb/core/ files are moved to the first line of the file. This makes it more obvious the tag is present as well as making it match the other 12k files in the tree with this location. It also uses // to match the "expected style" as

Re: [PATCH v3 2/3] usb: xhci: Add DbC support in xHCI driver

2017-11-03 Thread Greg Kroah-Hartman
On Fri, Nov 03, 2017 at 08:45:46AM +0800, Lu Baolu wrote: > Hi, > > On 11/03/2017 12:51 AM, Greg Kroah-Hartman wrote: > > On Thu, Nov 02, 2017 at 12:38:57PM +0200, Felipe Balbi wrote: > >> > > >> > Hi, > >> > > >> > Greg Kroah-Hartman writes: > > >> Greg