Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

On Mon, 13 Nov 2017 09:16:39 +0300 Andrey Astafyev <1...@246060.ru> wrote: > 13.11.2017 09:14, Jérôme Carretero пишет: > > For my devices, adding US_FL_NO_ATA_1X to unusual_uas.h didn't > > change anything, and while adding US_FL_IGNORE_UAS (using > > quirks=0bc2:ab34:u,0bc2:ab38:u) there are

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

13.11.2017 09:14, Jérôme Carretero пишет: For my devices, adding US_FL_NO_ATA_1X to unusual_uas.h didn't change anything, and while adding US_FL_IGNORE_UAS (using quirks=0bc2:ab34:u,0bc2:ab38:u) there are still device resets, but they cause shorter hangs in system activity (~1 second when UAS

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

On Mon, 13 Nov 2017 07:01:30 +0300 Andrey Astafyev <1...@246060.ru> wrote: > 13.11.2017 00:42, Jérôme Carretero пишет: > > Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2 > > uas_eh_abort_handler 0 uas-tag 3 inflight: CMD OUT > > [...] > > Do you see such things? > > > Hi, I've seen

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

13.11.2017 00:42, Jérôme Carretero пишет: Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2 uas_eh_abort_handler 0 uas-tag 3 inflight: CMD OUT Nov 12 16:20:59 Bidule kernel: sd 22:0:0:0: [sdaa] tag#2 CDB: Write(16) 8a 00 00 00 00 00 20 00 08 00 00 00 00 08 00 00 Nov 12

[PATCH 2/2 v6] typec: tcpm: Only request matching pdos

At present, TCPM code assumes that local device supports variable/batt pdos and always selects the pdo with highest possible power within the board limit. This assumption might not hold good for all devices. To overcome this, this patch makes TCPM only accept a source_pdo when there is a matching

[PATCH 1/2 v6] typec: tcpm: Validate source and sink caps

The source and sink caps should follow the following rules. This patch validates whether the src_caps/snk_caps adheres to it. 6.4.1 Capabilities Message A Capabilities message (Source Capabilities message or Sink Capabilities message) shall have at least one Power Data Object for vSafe5V. The

Re: [PATCH 2/2 v5] typec: tcpm: Only request matching pdos

On Tue, Nov 7, 2017 at 4:07 AM, Heikki Krogerus wrote: > On Sat, Nov 04, 2017 at 12:22:13PM -0700, Badhri Jagan Sridharan wrote: >> At present, TCPM code assumes that local device supports >> variable/batt pdos and always selects the pdo with highest >> possible

Re: [PATCH 1/2 v5] typec: tcpm: Validate source and sink caps

Thanks Heikki ! I am making another version addressing your nits as well. Guenter, Are you fine with the patch as well ? Regards, Badhri On Tue, Nov 7, 2017 at 3:00 AM, Heikki Krogerus wrote: > On Sat, Nov 04, 2017 at 12:22:12PM -0700, Badhri Jagan Sridharan

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

On Fri, 10 Nov 2017 16:13:44 +0100 Hans de Goede wrote: > Just like all previous UAS capable Seagate disk enclosures, this > one needs a US_FL_NO_ATA_1X quirk. > [...] > +/* Reported-by: Andrey Astafyev */ Hi Andrey, I notice that you have an external

[PATCH 5/5] USB: Add format_template attribute to struct usb_class_driver

This serves as human-readable documentation as well as allowing the format_template plugin to complain about any static initializers of this struct member that do not have the same set of printf specifiers. Signed-off-by: Rasmus Villemoes --- include/linux/usb.h | 2 +-

[PATCH 1/5] plugins: implement format_template attribute

Most format strings in the kernel are string literals, so the compiler and other static analyzers can do type checking. This plugin covers a few of the remaining cases, by introducing a format_template attribute. Consider struct usb_class_driver. Its member 'name' is used as a format string in

Re: [PATCH v7 usb-next 4/4] dt-bindings: usb: xhci: include the roothub and a device in the example

Hi Arnd (and anyone else who is interested in this), On Mon, Oct 30, 2017 at 11:59 PM, Martin Blumenstingl wrote: > Hi Arnd, > > On Mon, Oct 30, 2017 at 3:08 PM, Arnd Bergmann wrote: >> On Sat, Oct 28, 2017 at 3:33 PM, Martin Blumenstingl >>