[PATCH V1 2/4] usb: serial: f81534: add auto RTS direction support

2017-11-15 Thread Ji-Ze Hong (Peter Hong)
The F81532/534 had auto RTS direction support for RS485 mode. We'll read it from internal Flash with address 0x2f01~0x2f04 for 4 ports. There are 4 conditions below: 0: F81534_PORT_CONF_RS232. 1: F81534_PORT_CONF_RS485. 2: value error, default to F81534_PORT_CONF_RS232.

[PATCH V1 4/4] usb: serial: f81534: add H/W disable port support

2017-11-15 Thread Ji-Ze Hong (Peter Hong)
The F81532/534 can be disable port by manufacturer with following H/W design. 1: Connect DCD/DSR/CTS/RI pin to ground. 2: Connect RX pin to ground. In driver, we'll implements some detect method likes following: 1: Read MSR. 2: Turn MCR LOOP bit on, off and read LSR after delay

[PATCH V1 1/4] usb: serial: f81534: add high baud rate support

2017-11-15 Thread Ji-Ze Hong (Peter Hong)
The F81532/534 had 4 clocksource 1.846/18.46/14.77/24MHz and baud rates can be up to 1.5Mbits with 24MHz. F81532/534 Clock register (offset +08h) Bit0: UART Enable (always on) Bit2-1: Clock source selector 00: 1.846MHz. 01: 18.46MHz.

[PATCH V1 3/4] usb: serial: f81534: add output pin control

2017-11-15 Thread Ji-Ze Hong (Peter Hong)
The F81532/534 had 3 output pin (M0/SD, M1, M2) with open-drain mode to control transceiver. We'll read it from internal Flash with address 0x2f05~0x2f08 for 4 ports. The value is range from 0 to 7. The M0/SD is MSB of this value. For a examples, If read value is 6, we'll write M0/SD, M1, M2 as 1,

Re: Seagate External SMR drive USB resets (XHCI transfer error, not timeout)

2017-11-15 Thread Jérôme Carretero
Hi, On Wed, 15 Nov 2017 18:17:08 -0500 Jérôme Carretero wrote: > Hi, > > > On Thu, 16 Nov 2017 07:40:08 +0900 > James Bottomley wrote: > > > On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > > > On Wed, 15 Nov 2017, Jérôme

Re: [PATCH 2/2 v6] typec: tcpm: Only request matching pdos

2017-11-15 Thread Guenter Roeck
On 11/15/2017 05:01 PM, Badhri Jagan Sridharan wrote: On Tue, Nov 14, 2017 at 9:05 AM, Guenter Roeck wrote: [ ... ] Reviewed-by: Guenter Roeck /* Though I really dislike this new-world comment style. * It hurts my eyes and distracts me from the

[PATCH 2/2 v7] typec: tcpm: Only request matching pdos

2017-11-15 Thread Badhri Jagan Sridharan
At present, TCPM code assumes that local device supports variable/batt pdos and always selects the pdo with highest possible power within the board limit. This assumption might not hold good for all devices. To overcome this, this patch makes TCPM only accept a source_pdo when there is a matching

[PATCH 1/2 v7] typec: tcpm: Validate source and sink caps

2017-11-15 Thread Badhri Jagan Sridharan
The source and sink caps should follow the following rules. This patch validates whether the src_caps/snk_caps adheres to it. 6.4.1 Capabilities Message A Capabilities message (Source Capabilities message or Sink Capabilities message) shall have at least one Power Data Object for vSafe5V. The

Re: [PATCH 2/2 v6] typec: tcpm: Only request matching pdos

2017-11-15 Thread Badhri Jagan Sridharan
On Tue, Nov 14, 2017 at 9:05 AM, Guenter Roeck wrote: > On Sun, Nov 12, 2017 at 04:23:17PM -0800, Badhri Jagan Sridharan wrote: >> At present, TCPM code assumes that local device supports >> variable/batt pdos and always selects the pdo with highest >> possible power within

Re: Seagate External SMR drive USB resets... why? / USB storage debugging

2017-11-15 Thread Bart Van Assche
On Wed, 2017-11-15 at 18:27 -0500, Jérôme Carretero wrote: > OK but I find that a "reset" message without any reason is not > as helpful as it could have been. At the minimum I'll try to scratch my > own itch and see if I can go at the bottom of my issue. If you want more information about SCSI

Re: Seagate External SMR drive USB resets... why? / USB storage debugging

2017-11-15 Thread Jérôme Carretero
On Wed, 15 Nov 2017 17:02:39 -0500 (EST) Alan Stern wrote: > > > - It looks like (haven't tested it yet) the CONFIG_DYNAMIC_DEBUG > > > isn't used with the USB mass storage debugging infrastructure, > > > please confirm? If unused, are we interested to have a patch

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
Hi, On Thu, 16 Nov 2017 07:40:08 +0900 James Bottomley wrote: > On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > > On Wed, 15 Nov 2017, Jérôme Carretero wrote: > > > >   Because with several of these drives / lots of activity / > > occasional

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread James Bottomley
On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > On Wed, 15 Nov 2017, Jérôme Carretero wrote: > > >   Because with several of these drives / lots of activity / > occasional > > >   issues, it looks like it will be hard to catch (yes I can use > > > usbmon). > > >  > > > - It looks like there

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Alan Stern
On Wed, 15 Nov 2017, Jérôme Carretero wrote: > (Adding Tejun Heo who was assigned on still-open bugzilla #93581 which > is about SATA but seems terribly related.) > > On Wed, 15 Nov 2017 16:43:14 -0500 > Jérôme Carretero wrote: > > > Hi Hans, > > > > > > Tests are

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
(Adding Tejun Heo who was assigned on still-open bugzilla #93581 which is about SATA but seems terribly related.) On Wed, 15 Nov 2017 16:43:14 -0500 Jérôme Carretero wrote: > Hi Hans, > > > Tests are currently undergoing with drives operating in plain USB mass > storage

Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
Hi Hans, Tests are currently undergoing with drives operating in plain USB mass storage class. In a first time, I'm filling drives with data (uncontrolled corpus, just TBs that I have on hand). It looks like the drives with most usage history are the ones that drop most often. kernel: usb

[PATCH 2/2] musb: remove unused pipe variable

2017-11-15 Thread Corentin Labbe
This patch fix the following build warning: drivers/usb/musb/musb_host.c:1809:8: warning: variable 'pipe' set but not used [-Wunused-but-set-variable] by removing the pipe variable in musb_host_rx() Signed-off-by: Corentin Labbe --- drivers/usb/musb/musb_host.c | 3 --- 1

[PATCH 1/2] musb: remove unused frame variable

2017-11-15 Thread Corentin Labbe
This patch fix the following warning drivers/usb/musb/musb_host.c:223:8: warning: variable 'frame' set but not used [-Wunused-but-set-variable] by remove the frame variable in musb_start_urb(). Signed-off-by: Corentin Labbe --- drivers/usb/musb/musb_host.c | 2 -- 1 file

Re: usbip port number limits

2017-11-15 Thread Shuah Khan
On 11/15/2017 01:52 AM, Juan Zea wrote: >> On 11/14/2017 09:25 AM, Juan Zea wrote: >>> Hi, >>> >>> I've been working on the issue. This is what I found about multi-controller >>> setup: >>> >>> The problem comes from the usbip tool trying to connect usb2 devices to >>> usb3 ports, like this:

Re: 8k interrupts/sec with USB hub

2017-11-15 Thread Greg KH
On Wed, Nov 15, 2017 at 02:58:00PM +, Billy Araujo wrote: > Hi Greg, > > 1. What kernel version are you using here? > > Sorry about the lack of info. The kernel is: SOCKit: Angstrom v2016.12 > - Kernel 4.1.22-ltsi-altera Oh wow that is old and obsolete. Please go get support from the

Re: [PATCH 4/8] dt-bindings: usb: document hub and host-controller properties

2017-11-15 Thread Rob Herring
On Thu, Nov 09, 2017 at 06:07:19PM +0100, Johan Hovold wrote: > Hub nodes and host-controller nodes with child nodes must specify values > for #address-cells (1) and #size-cells (0). > > Also make the definition of the related reg property a bit more > stringent, and add comments to the example

Re: [PATCH 1/8] dt-bindings: usb: fix example hub node name

2017-11-15 Thread Rob Herring
On Thu, Nov 09, 2017 at 06:07:16PM +0100, Johan Hovold wrote: > According to the OF Recommended Practice for USB, hub nodes shall be > named "hub", but the example had mixed up the label and node names. Fix > the node name and drop the redundant label. > > While at it, remove a newline and add a

Re: [PATCH] usb: musb: musb_host: Introduce postponed URB giveback

2017-11-15 Thread Matwey V. Kornilov
The issue is also present in 4.9.60-ti-r75 2017-11-04 17:05 GMT+03:00 Matwey V. Kornilov : > Hi Bin, > > I've just checked that the issue is still present in 4.13.10. > > 2017-04-27 13:20 GMT+03:00 Matwey V. Kornilov : >> This commit changes the order of

Re: 8k interrupts/sec with USB hub

2017-11-15 Thread Billy Araujo
Hi Johan, Thanks for your answer. That seems a lot like what I am seeing because I had a USB tracer and it showed many NAKed transactions. Regards, Billy. On Wed, Nov 15, 2017 at 2:45 PM, Johan Hovold wrote: > On Wed, Nov 15, 2017 at 12:12:16PM +, Billy Araujo

Re: usbip port number limits

2017-11-15 Thread Shuah Khan
Hi Juan, On 11/15/2017 07:43 AM, Juan Zea wrote: > >>> Also, will you be able to revert the usb3 commit >>> 1c9de5bf428612458427943b724bea51abde520a >>> >>> and see if any of the problems go away. >>> >>> thanks, >>> -- Shuah >>> > >> I'm on it and will send results later. > >> Thanks, >>

Re: 8k interrupts/sec with USB hub

2017-11-15 Thread Billy Araujo
Hi Greg, 1. What kernel version are you using here? Sorry about the lack of info. The kernel is: SOCKit: Angstrom v2016.12 - Kernel 4.1.22-ltsi-altera 2. Why is this an "issue"? Is the device not working properly? It is an issue because it makes the CPU busier and when I have another

Re: 8k interrupts/sec with USB hub

2017-11-15 Thread Johan Hovold
On Wed, Nov 15, 2017 at 12:12:16PM +, Billy Araujo wrote: > Hi all, > > I built a kernel/rootfs for altera SoCkit amd uses the default SoCkit > device tree and I plug when in plug in a USB stick it uses the dwc2 > driver. > When doing cat /proc/interrupts I get normal amount of interrupts - >

Re: usbip port number limits

2017-11-15 Thread Juan Zea
>>Also, will you be able to revert the usb3 commit >>1c9de5bf428612458427943b724bea51abde520a >> >>and see if any of the problems go away. >> >>thanks, >>-- Shuah >> >I'm on it and will send results later. >Thanks, >Juan Ok, I'm back. The revert was quite complex, with several conflicts I

Re: [PATCH] Re: xhci bandwidth problem with isochronous endpoints

2017-11-15 Thread Mathias Nyman
On 14.11.2017 21:16, Curt Meyers wrote: ... Hi Mathias, The manufacture hired a Linux developer to solve the problem with this isochronous camera device and it turns out to be related to LPM that only shows up in newer Intel hardware, according to the developer. He says that there is

Re: 8k interrupts/sec with USB hub

2017-11-15 Thread Greg KH
On Wed, Nov 15, 2017 at 12:12:16PM +, Billy Araujo wrote: > Hi all, > > I built a kernel/rootfs for altera SoCkit amd uses the default SoCkit > device tree and I plug when in plug in a USB stick it uses the dwc2 > driver. What kernel version are you using here? > When doing cat

8k interrupts/sec with USB hub

2017-11-15 Thread Billy Araujo
Hi all, I built a kernel/rootfs for altera SoCkit amd uses the default SoCkit device tree and I plug when in plug in a USB stick it uses the dwc2 driver. When doing cat /proc/interrupts I get normal amount of interrupts - everything seems ok. However, when I connect the USB stick to a USB hub

Hello Dear...

2017-11-15 Thread M,Shakour Rosarita
Hello Dear... I know that this message will come to you as a surprise. I hoped that you will not expose or betray this trust and confident that I am about to repose on you, my name is M, Shakour Rosarita. I am 19 years old Girl, female, from Tartu Syria, (never married) 61 kg, white in

Re: [PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

2017-11-15 Thread David Miller
From: Bjørn Mork Date: Wed, 15 Nov 2017 09:35:02 +0100 > The GetNtbFormat and SetNtbFormat requests operate on 16 bit little > endian values. We get away with ignoring this most of the time, because > we only care about USB_CDC_NCM_NTB16_FORMAT which is 0x. This > fails for

Re: [PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

2017-11-15 Thread Enrico Mioso
Thank you very much Ben and bjorn, for the spot, the fix, and overall helping me learn new things. Acked-By: Enrico Mioso On Wed, 15 Nov 2017, Bjørn Mork wrote: Date: Wed, 15 Nov 2017 09:35:02 From: Bjørn Mork To: net...@vger.kernel.org Cc: Oliver

RE: [PATCH] usb: dwc3: Enable the USB snooping

2017-11-15 Thread Felipe Balbi
Hi, Ran Wang writes: >> Ran Wang writes: >> > Add support for USB3 snooping by asserting bits in register >> > DWC3_GSBUSCFG0 for data and descriptor. >> >> we know *how* to enable a feature :-) It's always the same, you fiddle with >> some registers

Re: "hub doesn't have any ports" error message on the disabled USB addressable root hub port

2017-11-15 Thread Thang Q. Nguyen
On Wed, Nov 1, 2017 at 4:17 PM, Thang Q. Nguyen wrote: > Hi, > > On Mon, Oct 23, 2017 at 5:27 PM, Mathias Nyman > wrote: >> On 23.10.2017 12:37, Thang Q. Nguyen wrote: >>> >>> Hi, >>> In our latest ARM64-based CPU, we use the DesignWare USB which

RE: [PATCH] usb: dwc3: Enable the USB snooping

2017-11-15 Thread Ran Wang
Hi Balbi, > -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Wednesday, November 15, 2017 4:52 PM > To: Ran Wang > Cc: Greg Kroah-Hartman ; open > list:DESIGNWARE USB3 DRD IP DRIVER ; open

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-15 Thread Hans de Goede
Hi, On 15-11-17 10:06, Oliver Neukum wrote: Am Dienstag, den 14.11.2017, 18:44 +0100 schrieb Hans de Goede: Greg, please do no merge the 2 recent uas seagate quirks I send then. I will submit a patch with the new approach right away. Hi, I am afraid in that case we will need a way to

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-15 Thread Oliver Neukum
Am Dienstag, den 14.11.2017, 18:44 +0100 schrieb Hans de Goede: > > Greg, please do no merge the 2 recent uas seagate quirks I send > then. I will submit a patch with the new approach right away. Hi, I am afraid in that case we will need a way to override a quirk in the other direction, that

Re: usbip port number limits

2017-11-15 Thread Juan Zea
>On 11/14/2017 09:25 AM, Juan Zea wrote: >> Hi, >> >> I've been working on the issue. This is what I found about multi-controller >> setup: >> >> The problem comes from the usbip tool trying to connect usb2 devices to usb3 >> ports, like this: >> >> - usbip tool asks vhci driver for free

Re: [PATCH] usb: dwc3: Enable the USB snooping

2017-11-15 Thread Felipe Balbi
Hi, Ran Wang writes: > Add support for USB3 snooping by asserting bits > in register DWC3_GSBUSCFG0 for data and descriptor. we know *how* to enable a feature :-) It's always the same, you fiddle with some registers and it works. What you failed to tell us is: a) WHY do

[PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

2017-11-15 Thread Bjørn Mork
The GetNtbFormat and SetNtbFormat requests operate on 16 bit little endian values. We get away with ignoring this most of the time, because we only care about USB_CDC_NCM_NTB16_FORMAT which is 0x. This fails for USB_CDC_NCM_NTB32_FORMAT. Fix comparison between LE value from device and

Re: [PATCH 4.4 27/56] cdc_ncm: Set NTB format again after altsetting switch for Huawei devices

2017-11-15 Thread Bjørn Mork
Ben Hutchings writes: > On Tue, 2017-07-11 at 17:21 +0200, Enrico Mioso wrote: >> From: Enrico Mioso >> >> commit 2b02c20ce0c28974b44e69a2e2f5ddc6a470ad6f upstream. > [...] >> --- a/drivers/net/usb/cdc_ncm.c >> +++ b/drivers/net/usb/cdc_ncm.c