Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-17 Thread David Miller
From: Greg Kroah-Hartman Date: Fri, 17 Nov 2017 15:19:39 +0100 > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source >

Re: Seagate External SMR drive USB resets (XHCI transfer error, not timeout)

2017-11-17 Thread Jérôme Carretero
Hi, On Thu, 16 Nov 2017 14:42:51 -0500 (EST) Alan Stern wrote: > On Wed, 15 Nov 2017, Jérôme Carretero wrote: > > > I performed an usbmon capture extract, centered around the event > > (there was a few hundred MBs written for this to happen): > > > > Nov 15

RE: [PATCH v2] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-17 Thread Adam Thomson
On 17 November 2017 17:20, Guenter Roeck wrote: > On Thu, Nov 16, 2017 at 04:28:11PM +, Adam Thomson wrote: > > The expectation in the FUSB302 driver is that a TX_SUCCESS event > > should occur after a message has been sent, but before a GCRCSENT > > event is raised to indicate successful

[PATCH] usbnet: ipheth: fix potential null pointer dereference in ipheth_carrier_set

2017-11-17 Thread Gustavo A. R. Silva
_dev_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _dev_ has been null checked. Addresses-Coverity-ID: 1462020 Fixes: bb1b40c7cb86 ("usbnet: ipheth: prevent TX queue timeouts when device not

[PATCH -next] usb: build drivers/usb/common/ when USB_SUPPORT is set

2017-11-17 Thread Randy Dunlap
From: Randy Dunlap PHY drivers can use ULPI interfaces when CONFIG_USB (which is host side support) is not enabled, so also build drivers/usb/ when CONFIG_USB_SUPPORT is enabled so that drivers/usb/common/ is built. ERROR: "ulpi_unregister_driver"

Re: question about usb_rebind_intf

2017-11-17 Thread Alan Stern
On Fri, 17 Nov 2017, Mathias Nyman wrote: > On 17.11.2017 19:09, Greg Kroah-Hartman wrote: > > On Fri, Nov 17, 2017 at 09:35:51AM -0700, Jerry Snitselaar wrote: > >> Should this skip warning that the rebind failed if device_attach > >> is returning -EPROBE_DEFER? If I do something like 'rtcwake

Re: question about usb_rebind_intf

2017-11-17 Thread Mathias Nyman
On 17.11.2017 19:09, Greg Kroah-Hartman wrote: On Fri, Nov 17, 2017 at 09:35:51AM -0700, Jerry Snitselaar wrote: Should this skip warning that the rebind failed if device_attach is returning -EPROBE_DEFER? If I do something like 'rtcwake -m mem -s 30' on a laptop I have here I will see a couple

Re: [PATCH v2] typec: tcpm: fusb302: Resolve out of order messaging events

2017-11-17 Thread Guenter Roeck
On Thu, Nov 16, 2017 at 04:28:11PM +, Adam Thomson wrote: > The expectation in the FUSB302 driver is that a TX_SUCCESS event > should occur after a message has been sent, but before a GCRCSENT > event is raised to indicate successful receipt of a message from > the partner. However in some

Re: question about usb_rebind_intf

2017-11-17 Thread Greg Kroah-Hartman
On Fri, Nov 17, 2017 at 09:35:51AM -0700, Jerry Snitselaar wrote: > Should this skip warning that the rebind failed if device_attach > is returning -EPROBE_DEFER? If I do something like 'rtcwake -m mem -s 30' > on a laptop I have here I will see a couple "rebind failed: -517" messages > as it

question about usb_rebind_intf

2017-11-17 Thread Jerry Snitselaar
Should this skip warning that the rebind failed if device_attach is returning -EPROBE_DEFER? If I do something like 'rtcwake -m mem -s 30' on a laptop I have here I will see a couple "rebind failed: -517" messages as it comes back out of suspend. Since the device probe eventually happens once

Re: [PATCH 0/8] USB: add device-tree support for interfaces

2017-11-17 Thread Johan Hovold
On Thu, Nov 16, 2017 at 12:33:33PM -0600, Rob Herring wrote: > On Thu, Nov 16, 2017 at 10:12 AM, Johan Hovold wrote: > > On Thu, Nov 16, 2017 at 08:43:21AM -0600, Rob Herring wrote: > >> On Thu, Nov 09, 2017 at 06:07:15PM +0100, Johan Hovold wrote: > >> > This series adds

Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-17 Thread Philippe Ombredanne
On Fri, Nov 17, 2017 at 3:19 PM, Greg Kroah-Hartman wrote: > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code

Re: INFO: task gpartedbin:1832 blocked for more than 120 seconds.

2017-11-17 Thread Greg KH
On Fri, Nov 17, 2017 at 09:59:00AM -0300, Cristian wrote: > Hello, > > [ 243.044590] INFO: task gpartedbin:1832 blocked for more than 120 seconds. > [ 243.044603] Not tainted 4.14.0-041400-generic #201711122031 > [ 243.044606] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" > disables

Re: Enabling PIO_ONLY (i.e. Disabling DMA in USB) for arm based ASIC

2017-11-17 Thread Bin Liu
Hi, On Fri, Nov 17, 2017 at 05:51:31PM +0530, dev jad wrote: > Thanks Balbi adding 'Bin Liu' MUSB maintainer. > > Hi Liu, > Can you help me enabling PIO ONLY mode in USB HCD ? > the ASIC I am using doesn't support dma. so to enable USB WiFi dongle I > need to disable DMA usage of USB subsystem

[PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define

2017-11-17 Thread Greg Kroah-Hartman
There is no need to #define the license of the driver, just put it in the MODULE_LICENSE() line directly as a text string. This allows tools that check that the module license matches the source code license to work properly, as there is no need to unwind the unneeded dereference. Cc: "David S.

INFO: task gpartedbin:1832 blocked for more than 120 seconds.

2017-11-17 Thread Cristian
Hello, [ 243.044590] INFO: task gpartedbin:1832 blocked for more than 120 seconds. [ 243.044603] Not tainted 4.14.0-041400-generic #201711122031 [ 243.044606] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 243.044611] gpartedbin D0 1832 1827

Re: Enabling PIO_ONLY (i.e. Disabling DMA in USB) for arm based ASIC

2017-11-17 Thread Felipe Balbi
Hi, dev jad writes: > Hi Balbi, > > (sorry for top posting in previous mail.) > >> Is it a good idea to add support for ASIC in musb, to be able to enable >> > MUSB_PIO_ONLY ? >> >> depends on what you want to do > > > currently the ASIC doesn't support dma. so to enable

Re: Enabling PIO_ONLY (i.e. Disabling DMA in USB) for arm based ASIC

2017-11-17 Thread Felipe Balbi
Hi, (please don't top-post) dev jad writes: >> There's nothing this forum can do to help you, sorry. > > Is there a provision in latest linux kernel to disable dma for generic > SoCs ? no idea > I presume you were maintainer of MUSB for some time. a long time ago >

Re: 8k interrupts/sec with USB hub

2017-11-17 Thread Felipe Balbi
HI, Billy Araujo writes: > Hi all, > > I built a kernel/rootfs for altera SoCkit amd uses the default SoCkit which kernel is this? > device tree and I plug when in plug in a USB stick it uses the dwc2 > driver. > When doing cat /proc/interrupts I get normal amount of

Re: Enabling PIO_ONLY (i.e. Disabling DMA in USB) for arm based ASIC

2017-11-17 Thread Felipe Balbi
Hi, dev jad writes: > Hello, > > Is there a way to disable DMA in Linux Kernel USB subsystem > for generic SoC ? > > I found a way to disable DMA called 'musb' (MUSB_PIO_ONLY), but it is > only available for ti / mentor graphics SoC's. > > I am using linux