Re: [PATCH v8] xhci : AMD Promontory USB disable port support

Hi Joe, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.14] [also build test WARNING on next-20171201] [cannot apply to usb/usb-testing v4.15-rc1] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

[PATCH] xhci : fix boolreturn.cocci warnings

drivers/usb/host/pci-quirks.c:541:9-10: WARNING: return of 0/1 in function 'usb_amd_pt_check_port' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: 5462b4b541a4 ("xhci : AMD

Re: [PATCH v2] usb: xhci: allow imod-interval to be configurable

Hi Chunfeng, On 11/30/2017 10:32 PM, Chunfeng Yun wrote: > Hi, > On Wed, 2017-11-29 at 10:52 -0500, Adam Wallis wrote: >> The xHCI driver currently has the IMOD set to 160, which >> translates to an IMOD interval of 40,000ns (160 * 250)ns >> >> Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK

[PATCH v3] usb: xhci: allow imod-interval to be configurable

The xHCI driver currently has the IMOD set to 160, which translates to an IMOD interval of 40,000ns (160 * 250)ns Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") introduced a QUIRK for the MTK platform to adjust this interval to 20, which translates to an IMOD interval of

Re: [PATCH 2/2] usb: xhci: fix panic in xhci_free_virt_devices_depth_first

On Fri, Dec 01, 2017 at 06:38:16AM -0800, Guenter Roeck wrote: > On Fri, Dec 1, 2017 at 3:41 AM, Mathias Nyman > wrote: > > From: Yu Chen > > > > Check vdev->real_port 0 to avoid panic > > [9.261347] [] > >

Re: [PATCH v8] xhci : AMD Promontory USB disable port support

A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Dec 01, 2017 at

Re: [PATCH 2/2] usb: xhci: fix panic in xhci_free_virt_devices_depth_first

On Fri, Dec 1, 2017 at 3:41 AM, Mathias Nyman wrote: > From: Yu Chen > > Check vdev->real_port 0 to avoid panic > [9.261347] [] > xhci_free_virt_devices_depth_first+0x58/0x108 > [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 > [

[PATCH v2] gadget event trace : add request pointer

This allows to identify transfer request, if more than one are in queue. This is allowed by usb_ep_queue : "Any endpoint (except control endpoints like ep0) may have more than one transfer request queued; they complete in FIFO order." For example with adb gadget with function fs :

Re: [PATCH] gadget event trace : add request pointer

Hi, Matthieu CASTET writes: > Hi Felipe, > > Le Fri, 1 Dec 2017 12:49:07 +0200, > Felipe Balbi a écrit : > >> Hi, >> >> >> This is, indeed, really useful. However do you mind removing the [] and >> adding a space so that output looks

Re: [PATCH] gadget event trace : add request pointer

Hi Felipe, Le Fri, 1 Dec 2017 12:49:07 +0200, Felipe Balbi a écrit : > Hi, > > > This is, indeed, really useful. However do you mind removing the [] and > adding a space so that output looks like: > > [00:59:36.784082] ->transport-222 [002] d..1

[PATCH v2] HID: add quirk for another PIXART OEM mouse used by HP

This mouse keep disconnecting in runleve 3 like below, add it needs the quirk to mute the anoying messages. [ 111.230555] usb 2-2: USB disconnect, device number 6 [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd [ 112.941594] usb 2-2: New USB device found, idVendor=03f0,

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

Hi again, > From: Yoshihiro Shimoda, Sent: Friday, December 1, 2017 8:04 PM > > Hi, > > However, the following message still exists. > >Enabling runtime PM for inactive device (ee08.usb) with active children > > So, I guess ohci-platform.c also has similar issue. > > JFYI, the

[PATCH 2/2] usb: xhci: fix panic in xhci_free_virt_devices_depth_first

From: Yu Chen Check vdev->real_port 0 to avoid panic [9.261347] [] xhci_free_virt_devices_depth_first+0x58/0x108 [9.261352] [] xhci_mem_cleanup+0x1bc/0x570 [9.261355] [] xhci_stop+0x140/0x1c8 [9.261365] [] usb_remove_hcd+0xfc/0x1d0 [9.261369] []

[PATCH 1/2] xhci: Don't show incorrect WARN message about events for empty rings

xHC can generate two events for a short transfer if the short TRB and last TRB in the TD are not the same TRB. The driver will handle the TD after the first short event, and remove it from its internal list. Driver then incorrectly prints a warning for the second event: "WARN Event TRB for slot

[PATCH 0/2] xhci fixes for usb-linus

Hi Greg A couple xhci fixes for usb-linus, one fixes a panic if driver is removed shortly after probing, the other a flood of false warning messages. -Mathias Mathias Nyman (1): xhci: Don't show incorrect WARN message about events for empty rings Yu Chen (1): usb: xhci: fix panic in

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

Hi, > From: Ulf Hansson, Sent: Friday, December 1, 2017 6:22 PM > > + Kishon > > On 30 November 2017 at 13:51, Yoshihiro Shimoda > wrote: > > Hi, > > > >> From: Ulf Hansson, Sent: Wednesday, November 29, 2017 6:59 PM > >> > >> On 29 November 2017 at 10:43,

Re: [PATCH] gadget event trace : add request pointer

Hi, Matthieu CASTET writes: > This allow to identify transfert request, if more than one are in queue. ^ ^ allowstransfer > @@ -238,9 +239,10 @@ DECLARE_EVENT_CLASS(udc_log_req, > __entry->short_not_ok

[PATCH] gadget event trace : add request pointer

This allow to identify transfert request, if more than one are in queue. This is allowed by usb_ep_queue : "Any endpoint (except control endpoints like ep0) may have more than one transfer request queued; they complete in FIFO order." For example with adb gadget with function fs :

Re: [PATCH v8] xhci : AMD Promontory USB disable port support

On Fri, Dec 01, 2017 at 11:54:20AM +0800, Joe Lee wrote: > Signed-off-by: Joe Lee > --- I can't take patches without any changelog text at all. Please fix that up. Also always list what the difference between this and the previous versions below the --- line. How to do

Re: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

+ Kishon On 30 November 2017 at 13:51, Yoshihiro Shimoda wrote: > Hi, > >> From: Ulf Hansson, Sent: Wednesday, November 29, 2017 6:59 PM >> >> On 29 November 2017 at 10:43, Geert Uytterhoeven >> wrote: >> > Hi Ulf, > >> Okay, so the

RE: drivers/net/usb/r8152.c USB net driver outdated

Cameron Seader [mailto:csea...@suse.com] > Sent: Thursday, November 30, 2017 11:40 PM [...] > I have experienced with kernel 4.14 and the driver 1.09.9 that when a > system goes into sleep mode and then comes out of sleep that the network > interface gets set to speed 100 in half duplex. I then

Re: [RFC PATCH 0/2] usb: typec: alternate mode bus

Hi, Thanks for taking a look at this.. On Sun, Nov 26, 2017 at 12:23:31PM +0100, Hans de Goede wrote: > Hi Heiko, > > On 28-09-17 13:35, Heikki Krogerus wrote: > > Hi guys, > > > > The bus allows SVID specific communication with the partners to be > > handled in separate drivers for each