Re: [debian bug:883345] vhci-hcd: kernel oops when attaching a mass storage on client side of usbip

2017-12-04 Thread Greg KH
On Mon, Dec 04, 2017 at 10:05:45PM +0200, borissh1...@gmail.com wrote: > Hi , > > vhci-hcd kernel oops when attaching a mass storage on 4.13.13. > > When I try to attach a mass storage device to a vhci-hcd, it generates an > oops. no problem with other devices. > > A second user had also

Re: [PATCH 21/45] usb: typec: remove duplicate includes

2017-12-04 Thread Heikki Krogerus
On Tue, Dec 05, 2017 at 07:34:55AM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Signed-off-by: Pravin Shedge Acked-by: Heikki

[PATCH 21/45] usb: typec: remove duplicate includes

2017-12-04 Thread Pravin Shedge
These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge --- drivers/usb/typec/fusb302/fusb302.c | 1 - 1 file changed, 1 deletion(-) diff --git

RE: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-12-04 Thread Yoshihiro Shimoda
Hi, > From: Ulf Hansson, Sent: Monday, December 4, 2017 7:41 PM > > On 1 December 2017 at 12:03, Yoshihiro Shimoda > wrote: > > Sure! I tested your patch, and then the following message disappeared! > > > >Enabling runtime PM for inactive device

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Adam Wallis
On 12/4/2017 9:15 PM, Chunfeng Yun wrote: > On Mon, 2017-12-04 at 09:27 -0500, Adam Wallis wrote: >> The xHCI driver currently has the IMOD set to 160, which >> translates to an IMOD interval of 40,000ns (160 * 250)ns >> >> Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller")

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Chunfeng Yun
On Mon, 2017-12-04 at 09:27 -0500, Adam Wallis wrote: > The xHCI driver currently has the IMOD set to 160, which > translates to an IMOD interval of 40,000ns (160 * 250)ns > > Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") > introduced a QUIRK for the MTK platform to

[debian bug:883345] vhci-hcd: kernel oops when attaching a mass storage on client side of usbip

2017-12-04 Thread borissh1983
Hi , vhci-hcd kernel oops when attaching a mass storage on 4.13.13. When I try to attach a mass storage device to a vhci-hcd, it generates an oops. no problem with other devices. A second user had also confirmed on a different hardware ( https://

Re: [PATCH] usb: Don't print a warning if interface driver rebind is deferred at resume

2017-12-04 Thread Jerry Snitselaar
On Mon Dec 04 17, Mathias Nyman wrote: Interface drivers like btusb that don't support reset-resume will be rebound at resume if port was reset. Rebind is done during the pm_ops .complete callback when probe returns EPROBE_DEFER as default. Remove the "rebind failed: -517" message. Device probe

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Timur Tabi
On 12/04/2017 09:48 AM, Adam Wallis wrote: As noted in the patch description, xhci-plat devices will use a default of 40,000, while MTK devices will use a default of 5,000. This is also documented in the probe for each relevant driver. This is further confirmed in the description for each

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Adam Wallis
Timur On 12/4/2017 9:58 AM, Timur Tabi wrote: > On 12/4/17 8:27 AM, Adam Wallis wrote: >> If no interval is specified, the default of 40,000ns (IMOD=160) will be >> used. > > ... > >> + - imod-interval-ns: default interrupt moderation interval is 5000ns > > ... > >> +  - imod-interval-ns:

Re: "Illegal Request" with JMicron JMS567-based USB3 HDD enclosure

2017-12-04 Thread Alan Stern
On Sun, 3 Dec 2017, David Kozub wrote: > Hi all, > > I'm observing the following error with a JMS567-based USB3 HDD enclosure: > > sd 6:0:0:0: [sda] tag#0 FAILED Result: hostbyte=DID_OK > driverbyte=DRIVER_SENSE > sd 6:0:0:0: [sda] tag#0 Sense Key : Illegal Request [current] > sd 6:0:0:0:

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Timur Tabi
On 12/4/17 8:27 AM, Adam Wallis wrote: If no interval is specified, the default of 40,000ns (IMOD=160) will be used. ... + - imod-interval-ns: default interrupt moderation interval is 5000ns ... + - imod-interval-ns: default interrupt moderation interval is 5000ns ... +

[PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Adam Wallis
The xHCI driver currently has the IMOD set to 160, which translates to an IMOD interval of 40,000ns (160 * 250)ns Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") introduced a QUIRK for the MTK platform to adjust this interval to 20, which translates to an IMOD interval of

Re: [PATCH v3] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Adam Wallis
On 12/4/2017 3:57 AM, Mathias Nyman wrote: > On 03.12.2017 05:22, Chunfeng Yun wrote: >> On Fri, 2017-12-01 at 10:44 -0500, Adam Wallis wrote: >>> The xHCI driver currently has the IMOD set to 160, which >>> translates to an IMOD interval of 40,000ns (160 * 250)ns >>> >>> Commit 0cbd4b34cda9

Re: [PATCH v3] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Adam Wallis
On 12/2/2017 10:22 PM, Chunfeng Yun wrote: > On Fri, 2017-12-01 at 10:44 -0500, Adam Wallis wrote: >> The xHCI driver currently has the IMOD set to 160, which >> translates to an IMOD interval of 40,000ns (160 * 250)ns >> >> Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller")

Re: [PATCH v3 35/36] usb/gadget/NCM: Replace tasklet with softirq hrtimer

2017-12-04 Thread Felipe Balbi
Anna-Maria Gleixner writes: > From: Thomas Gleixner > > The tx_tasklet tasklet is used in invoke the hrtimer (task_timer) in > softirq context. This can be also achieved without the tasklet but > with HRTIMER_MODE_SOFT as hrtimer mode. > >

[balbi-usb:testing/next 6/16] drivers/usb/gadget/function/f_ncm.c:1105:10: error: 'HRTIMER_MODE_REL_SOFT' undeclared

2017-12-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: 4929fb631d4cedc385910fd998518e22bd71d680 commit: 562d8eeed9a6bb9ca3370a3f75d96f0e7ba0a059 [6/16] usb/gadget/NCM: Replace tasklet with softirq hrtimer config: xtensa-allmodconfig (attached as .config)

[balbi-usb:testing/next 6/16] drivers/usb/gadget/function/f_ncm.c:1105:10: error: 'HRTIMER_MODE_REL_SOFT' undeclared; did you mean 'HRTIMER_MODE_REL'?

2017-12-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: 4929fb631d4cedc385910fd998518e22bd71d680 commit: 562d8eeed9a6bb9ca3370a3f75d96f0e7ba0a059 [6/16] usb/gadget/NCM: Replace tasklet with softirq hrtimer config: i386-randconfig-x073-201749 (attached as

[PATCH] usb: Don't print a warning if interface driver rebind is deferred at resume

2017-12-04 Thread Mathias Nyman
Interface drivers like btusb that don't support reset-resume will be rebound at resume if port was reset. Rebind is done during the pm_ops .complete callback when probe returns EPROBE_DEFER as default. Remove the "rebind failed: -517" message. Device probe will eventually take place later.

Re: [PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2

2017-12-04 Thread Felipe Balbi
Roger Quadros writes: > The metastability workaround causes Erratic errors [1] > on the HighSpeed USB PHY which can cause upto 2 seconds > delay in enumerating to a USB host while in Gadget mode. > > Disable the Run/Stop metastability workaround to avoid this > ill effect. We are

Re: [PATCH 0/1] USB Audio Device Class 3.0 Gadget support

2017-12-04 Thread Felipe Balbi
Hi, Ruslan Bilovol writes: > On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol > wrote: >> Hi, >> >> This patch adds USB Audio Device Class 3.0 [1] function >> support to gadget subsystem. >> I didn't add UAC3 support to legacy gadget as it

Re: [PATCH] PM / runtime: Drop children check from __pm_runtime_set_status()

2017-12-04 Thread Ulf Hansson
On 1 December 2017 at 12:03, Yoshihiro Shimoda wrote: > Hi, > >> From: Ulf Hansson, Sent: Friday, December 1, 2017 6:22 PM >> >> + Kishon >> >> On 30 November 2017 at 13:51, Yoshihiro Shimoda >> wrote: >> > Hi, >> > >> >> From:

Re: [PATCH v2 1/4] dt-bindings: usb: add DT binding for RK3328 dwc3 controller

2017-12-04 Thread Heiko Stuebner
Am Montag, 4. Dezember 2017, 10:40:38 CET schrieb Heiko Stuebner: > From: William Wu > > Adds the device tree bindings description for RK3328 and > compatible USB DWC3 controller. > > Signed-off-by: William Wu > Acked-by: Rob Herring

[PATCH v2 2/4] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs

2017-12-04 Thread Heiko Stuebner
From: William Wu RK3328 has one USB 3.0 OTG controller which uses DWC_USB3 core's general architecture. It can act as static xHCI host controller, static device controller, USB 3.0/2.0 OTG basing on ID of USB3.0 PHY. Signed-off-by: William Wu

[PATCH v2 3/4] arm64: dts: rockchip: enable usb3 for RK3328 evaluation board

2017-12-04 Thread Heiko Stuebner
From: William Wu Rockchip's RK3328 evaluation board has one USB 3.0 OTG controller, we enable it and set it act as static xHCI host controller to support USB 3.0 HOST on RK3328 evaluation board. Signed-off-by: William Wu Signed-off-by:

[PATCH v2 1/4] dt-bindings: usb: add DT binding for RK3328 dwc3 controller

2017-12-04 Thread Heiko Stuebner
From: William Wu Adds the device tree bindings description for RK3328 and compatible USB DWC3 controller. Signed-off-by: William Wu Acked-by: Rob Herring Signed-off-by: Heiko Stuebner --- changes in v2: -

[PATCH v2 4/4] arm64: dts: rockchip: enable usb3 nodes on rk3328-rock64

2017-12-04 Thread Heiko Stuebner
Enable the nodes to make the usb3 port usable on that board. Signed-off-by: Heiko Stuebner --- changes in v2: - new patch arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts

Re: [PATCH 2/2] usb: xhci: fix panic in xhci_free_virt_devices_depth_first

2017-12-04 Thread Mathias Nyman
On 01.12.2017 17:23, Greg Kroah-Hartman wrote: On Fri, Dec 01, 2017 at 06:38:16AM -0800, Guenter Roeck wrote: On Fri, Dec 1, 2017 at 3:41 AM, Mathias Nyman wrote: From: Yu Chen Check vdev->real_port 0 to avoid panic [9.261347] []

Re: [PATCH v3] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Mathias Nyman
On 03.12.2017 05:22, Chunfeng Yun wrote: On Fri, 2017-12-01 at 10:44 -0500, Adam Wallis wrote: The xHCI driver currently has the IMOD set to 160, which translates to an IMOD interval of 40,000ns (160 * 250)ns Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") introduced a

Re: [PATCH v9] xhci : AMD Promontory USB disable port support

2017-12-04 Thread Greg KH
On Mon, Dec 04, 2017 at 04:49:33PM +0800, Joe Lee wrote: > For AMD Promontory xHCI host, > although you can disable USB 2.0 ports in BIOSsettings, > those ports will be enabled anyway after you remove a device on > that port and re-plug it in again. It's a known limitation of the chip. > As a

[PATCH v9] xhci : AMD Promontory USB disable port support

2017-12-04 Thread Joe Lee
For AMD Promontory xHCI host, although you can disable USB 2.0 ports in BIOSsettings, those ports will be enabled anyway after you remove a device on that port and re-plug it in again. It's a known limitation of the chip. As a workaround we can clear the PORT_WAKE_BITS. --- v9: Fix multi-line

Re: [PATCH v2] HID: add quirk for another PIXART OEM mouse used by HP

2017-12-04 Thread Benjamin Tissoires
On Fri, Dec 1, 2017 at 1:19 PM, Dave Young wrote: > This mouse keep disconnecting in runleve 3 like below, add it needs the > quirk to mute the anoying messages. > > [ 111.230555] usb 2-2: USB disconnect, device number 6 > [ 112.718156] usb 2-2: new low-speed USB device