[PATCH] usb: f_fs: Prevent gadget unbind if it is already unbound

From: Hemant Kumar Upon usb composition switch there is possibility of ep0 file release happening after gadget driver bind. In case of composition switch from adb to a non-adb composition gadget will never gets bound again resulting into failure of usb device enumeration.

Re: [PATCH 14/15] usb: dwc3: Add disabling of start_transfer failure quirk

On Fri, Jan 05, 2018 at 12:16:02PM -0800, Thinh Nguyen wrote: > In DWC_usb31 version 1.70a-ea06 and prior needs a SW workaround for isoc > START TRANSFER command failure. However, some affected versions may have > RTL patches to fix this without a SW workaround. Add this quirk to > disable the SW

Re: [PATCH 08/15] usb: dwc3: Make RX/TX threshold configurable

On Fri, Jan 05, 2018 at 12:14:48PM -0800, Thinh Nguyen wrote: > DWC_usb31 periodic transfer at 48K+ bytes per interval may need > modification to the TX/RX packet threshold to achieve optimal result. > Add properties to make it configurable. I tend to think these should all be implied by the SoC

Re: [PATCH 09/15] usb: dwc3: Check for ESS TX/RX threshold config

Hi, On 1/8/2018 4:05 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> Check and configure TX/RX threshold for DWC_usb31. Update dwc3 structure >> with new variables to store these threshold configurations. > > couldn't we calculate these in runtime? Then

Re: [PATCH 12/15] usb: dwc3: Dump LSP and BMU debug info

Hi, On 1/8/2018 4:08 AM, Felipe Balbi wrote: > Thinh Nguyen writes: >> Dump LSP and BMU debug info. >> >> Signed-off-by: Thinh Nguyen >> --- >> drivers/usb/dwc3/core.h| 5 + >> drivers/usb/dwc3/debugfs.c | 5 + >> 2 files changed,

Re: [PATCH 03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields

On 1/8/2018 4:02 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP >> is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM. >> >> The GTXFIFOSIZ register for DWC_usb31 is as

Re: [PATCH 01/15] usb: dwc3: Device SoftReset PHY synchonization delay

On 1/8/2018 4:01 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> From DWC_usb31 databook section 1.3.2, once DWC3_DCTL_CSFTRST bit is >> cleared, we must wait at least 50ms before accessing the PHY domain >> (synchronization delay). >> >> Signed-off-by:

Re: [PATCH 10/15] usb: dwc3: gadget: Set maxpacket size for ep0 IN

Hi, On 1/8/2018 4:06 AM, Felipe Balbi wrote: > > Hi, > > Thinh Nguyen writes: >> There are 2 control endpoint structures for DWC3. However, the driver >> only updates the OUT direction control endpoint structure during >> ConnectDone event. DWC3 driver needs to

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 22:44:27 +0100 Peter Zijlstra wrote: > On Mon, Jan 08, 2018 at 10:31:09PM +0100, Jesper Dangaard Brouer wrote: > > I did expected the issue to get worse, when you load the Pi with > > network traffic, as now the softirq time-budget have to be shared > >

[PATCH] The usbmon triggers a BUG in ./include/linux/mm.h

Automated tests triggered this by opening usbmon and accessing the mmap while simultaneously resizing the buffers. This bug was with us since 2006, because typically applications only size the buffers once and thus avoid racing. Reported by Kirill A. Shutemov. Signed-off-by: Pete Zaitcev

Re: [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case.

On Mon, 8 Jan 2018 16:28:58 +0100 Johan Hovold wrote: > On Mon, Jan 08, 2018 at 11:33:32AM +0100, Oliver Neukum wrote: > > Am Samstag, den 06.01.2018, 20:14 +0300 schrieb Mikhail Zaytsev: > > > The patch removes unused TIOCSSERIAL ioctl case and adds the default block > > >

Re: dvb usb issues since kernel 4.9

On Mon, Jan 08, 2018 at 10:31:09PM +0100, Jesper Dangaard Brouer wrote: > I did expected the issue to get worse, when you load the Pi with > network traffic, as now the softirq time-budget have to be shared > between networking and USB/DVB. Thus, I guess you are running TCP and > USB/mpeg2ts on

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 17:26:10 +0100 "Josef Griebichler" wrote: > I tried your mentioned patch but unfortunately no real improvement for me. > dmesg http://ix.io/DOg > tvheadend service log http://ix.io/DOi > > Errors during recording are still there. Are you _also_

Re: kernel BUG at ./include/linux/mm.h:LINE! (3)

On Wed, 3 Jan 2018 12:26:04 +0300 "Kirill A. Shutemov" wrote: > > > - unsigned long offset, chunk_idx; > > > + unsigned long offset, chunk_idx, flags; > > > struct page *pageptr; > > > > > > + mutex_lock(>fetch_lock); > > > + spin_lock_irqsave(>b_lock, flags); > > >

Re: Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 12:35:08 -0500 (EST) Alan Stern wrote: > On Mon, 8 Jan 2018, Josef Griebichler wrote: > > > No I can't sorry. There's no sat connection near to my workstation. > > Can we ask the person who made this post: >

Re: dvb usb issues since kernel 4.9

On Mon, Jan 8, 2018 at 11:15 AM, Alan Stern wrote: > > Both dwc2_hsotg and ehci-hcd use the tasklets embedded in the > giveback_urb_bh member of struct usb_hcd. See usb_hcd_giveback_urb() > in drivers/usb/core/hcd.c; the calls are > > else if (high_prio_bh) >

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Linus Torvalds wrote: > Can somebody tell which softirq it is that dvb/usb cares about? I don't know about the DVB part. The USB part is a little difficult to analyze, mostly because the bug reports I've seen are mostly from people running non-vanilla kernels. For example,

Re: Help needed debugging Motorola Solutions TETRA PEI interface

Thanks Johan for taking a look. Am 08.01.2018 um 17:30 schrieb Johan Hovold: > Adding the device ids and a quirk to cdc_acm.c >>> .driver_info = NO_UNION_NORMAL, >> does only suppress the "Zero length" message. > Do you then get a ttyACMn device? Or some other error? Nothing more. No ttyACM

Re: [PATCH] phy: work around 'phys' references to usb-phy devices

Hi Arnd, On Monday 08 January 2018 06:31 PM, Arnd Bergmann wrote: > Stefan Wahren reports a problem with a warning fix that was merged > for v4.15: we had lots of device nodes with a 'phys' property pointing > to a device node that is not compliant with the binding documented in >

Re: dvb usb issues since kernel 4.9

On Mon, Jan 8, 2018 at 9:55 AM, Ingo Molnar wrote: > > as I doubt we have enough time to root-case this properly. Well, it's not like this is a new issue, and we don't have to get it fixed for 4.15. It's been around since 4.9, it's not a "have to suddenly fix it this week"

Re: dvb usb issues since kernel 4.9

* Linus Torvalds wrote: > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > wrote: > > > > Em Sat, 6 Jan 2018 16:04:16 +0100 > > "Josef Griebichler" escreveu: > >> > >> the causing commit has been

Re: Aw: Re: Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Josef Griebichler wrote: > No I can't sorry. There's no sat connection near to my workstation. Can we ask the person who made this post: https://forum.libreelec.tv/thread/4235-dvb-issue-since-le-switched-to-kernel-4-9-x/?postID=75965#post75965 to run the test? The post

Aw: Re: Re: dvb usb issues since kernel 4.9

No I can't sorry. There's no sat connection near to my workstation.     Gesendet: Montag, 08. Januar 2018 um 17:31 Uhr Von: "Alan Stern" An: "Josef Griebichler" Cc: "Mauro Carvalho Chehab" , "Greg Kroah-Hartman"

Re: Aw: Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Josef Griebichler wrote: > Hi Maro, > > I tried your mentioned patch but unfortunately no real improvement for me. > dmesg http://ix.io/DOg > tvheadend service log http://ix.io/DOi > Errors during recording are still there. > Errors increase if there is additional tcp load on

Re: Help needed debugging Motorola Solutions TETRA PEI interface

On Thu, Jan 04, 2018 at 07:38:26PM +0100, Max Schulze wrote: > Hello, > > I need some advice how to debug a device, that under Windows presents 2 > virtual com ports. Windows .sys. file mentions a "Jungo CDC ACM OBEX > Driver". > > > I get the following dmesg output > > > [ 1700.263981] usb

Aw: Re: dvb usb issues since kernel 4.9

Hi Maro, I tried your mentioned patch but unfortunately no real improvement for me. dmesg http://ix.io/DOg tvheadend service log http://ix.io/DOi Errors during recording are still there. Errors increase if there is additional tcp load on raspberry. Unfortunately there's no usbmon or tshark on

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Mauro Carvalho Chehab wrote: > > Let find the root-cause of this before reverting, as this will hurt the > > networking use-case. > > > > I want to see if the increase buffer will solve the issue (the current > > buffer of 0.63 ms seem too small). > > For TV, high latency

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018, Mauro Carvalho Chehab wrote: > Em Sun, 7 Jan 2018 10:41:37 -0500 (EST) > Alan Stern escreveu: > > > On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote: > > > > > > > It seems that the original patch were designed to solve some IRQ > > > > > issues >

Re: [GIT PULL] USB: changes for v4.16 merge window

On Mon, 8 Jan 2018, Felipe Balbi wrote: > > Hi Greg, > > Here are my changes for this merge window. Let me know if you want > anything to be changed. > > Patches have been on linux-next for quite a while ;-) > > cheers > > The following changes since commit

Re: [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case.

On Mon, Jan 08, 2018 at 11:33:32AM +0100, Oliver Neukum wrote: > Am Samstag, den 06.01.2018, 20:14 +0300 schrieb Mikhail Zaytsev: > > The patch removes unused TIOCSSERIAL ioctl case and adds the default block > > to the switch. This will make the ioctl return -ENOTTY to user space (e.g. > >

Re: Second Try, as you will not accept not text mails: 4.14.10-gentoo-r1 breaks cups functionality

Am Montag, den 01.01.2018, 23:12 +0100 schrieb Roman Gruber : > A test kernel with the same kernel config with antique 4.1.x kernel on > gentoo, oldest stable available kernel on gentoo, as described on kernel.org > bugzilla, yielded in instantly working printer. But broken wifi which seems >

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

Hi Stefan, On 12/31/2017 9:19 PM, Stefan Wahren wrote: > Hi Grigor, > > sorry for misusing the cover letter for my comments, but i didn't received > all patches. > >> Grigor Tovmasyan hat am 26. Dezember 2017 um >> 12:21 geschrieben: >> >> >> ... >> >> >> Minas

Re: [GIT PULL] USB: changes for v4.16 merge window

On Mon, Jan 08, 2018 at 01:48:29PM +0200, Felipe Balbi wrote: > > Hi Greg, > > Here are my changes for this merge window. Let me know if you want > anything to be changed. > > Patches have been on linux-next for quite a while ;-) > > cheers > > The following changes since commit

[PATCH] phy: work around 'phys' references to usb-phy devices

Stefan Wahren reports a problem with a warning fix that was merged for v4.15: we had lots of device nodes with a 'phys' property pointing to a device node that is not compliant with the binding documented in Documentation/devicetree/bindings/phy/phy-bindings.txt This generally works because USB

Re: dvb usb issues since kernel 4.9

Em Mon, 8 Jan 2018 12:59:10 +0100 Jesper Dangaard Brouer escreveu: > On Mon, 8 Jan 2018 08:02:00 -0200 > Mauro Carvalho Chehab wrote: > > > Hi Linus, > > > > Em Sun, 7 Jan 2018 13:23:39 -0800 > > Linus Torvalds

Re: [PATCH v3 00/49] usb: dwc2: fixes, enhancements and new features

On 12/31/2017 9:19 PM, Stefan Wahren wrote: Hi Stefan, >> >> Razmik Karapetyan (10): >>usb: dwc2: Set AHB burst size to INCR > > The usage hsotg->params.ahbcfg instead of the defines is a unintended fix for > BCM2835. According to the BCM2835 datasheet this register have a different >

[PATCH v4 1/3] usb: renesas_usbhs: Add support for RZ/A1

This patch adds the capability to support RZ/A1 SoCs. Signed-off-by: Chris Brandt --- v2: * Removed "renesas,usbhs-r7s72100" * Changed license of rza.c --- drivers/usb/renesas_usbhs/Makefile | 2 +- drivers/usb/renesas_usbhs/common.c | 13 ++

[PATCH v4 0/3] usb: renesas_usbhs: Add RZ/A1 support

This series adds RZ/A1 gadget support to the renesas_usbhs driver. Basically, it's almost the same HW as the R-Car (and SH) parts. The only real difference is the some extra registers for the PHY. This was tested on an RSK board by connecting to a PC as an Ethernet CDC gadget. v4: * Re-added

[PATCH v4 3/3] ARM: dts: r7s72100: add USB device to device tree

Add USB device support. Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven --- v4: * Changed to "renesas,usbhs-r7s72100", "renesas,rza1-usbhs" v3: * Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs" v2: * Node name is

[PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: Add support for RZ/A1

Document support for RZ/A1 SoCs Signed-off-by: Chris Brandt Reviewed-by: Geert Uytterhoeven --- v4: * Re-added "renesas,usbhs-r7s72100" v3: * Removed "renesas,usbhs-r7s72100" v2: * Added Reviewed-by ---

Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

Hi Chris, On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt wrote: > On Monday, January 08, 2018, Geert Uytterhoeven wrote: >> Thanks for the update, but I think there has been a misunderstanding. >> I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from >>

Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt wrote: > Hi Geert and Simon, > > > On Monday, January 08, 2018, Geert Uytterhoeven wrote: >> Thanks for the update, but I think there has been a misunderstanding. >> I didn't mean to drop "renesas,usbhs-r7s72100" everywhere,

Re: [PATCH v3 03/49] usb: dwc2: Remove version check in GSNPSID

Hi Greg k-h On 12/29/2017 20:59, Greg KH wrote: > On Tue, Dec 26, 2017 at 03:22:05PM +0400, Grigor Tovmasyan wrote: >> From: Gevorg Sahakyan >> >> Only check the ID portion of the GSNPSID register and don’t check >> the version. This will allow the driver to work with

Re: [PATCH 12/15] usb: dwc3: Dump LSP and BMU debug info

Hi, Thinh Nguyen writes: > Dump LSP and BMU debug info. > > Signed-off-by: Thinh Nguyen > --- > drivers/usb/dwc3/core.h| 5 + > drivers/usb/dwc3/debugfs.c | 5 + > 2 files changed, 10 insertions(+) > > diff --git

Re: [PATCH 10/15] usb: dwc3: gadget: Set maxpacket size for ep0 IN

Hi, Thinh Nguyen writes: > There are 2 control endpoint structures for DWC3. However, the driver > only updates the OUT direction control endpoint structure during > ConnectDone event. DWC3 driver needs to update the endpoint max packet > size for control IN endpoint

Re: [PATCH 09/15] usb: dwc3: Check for ESS TX/RX threshold config

Hi, Thinh Nguyen writes: > Check and configure TX/RX threshold for DWC_usb31. Update dwc3 structure > with new variables to store these threshold configurations. couldn't we calculate these in runtime? Then we wouldn't need new Device Properties. -- balbi

Re: [PATCH 03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields

Hi, Thinh Nguyen writes: > Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP > is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM. > > The GTXFIFOSIZ register for DWC_usb31 is as follows: >

Re: [PATCH 01/15] usb: dwc3: Device SoftReset PHY synchonization delay

Hi, Thinh Nguyen writes: > From DWC_usb31 databook section 1.3.2, once DWC3_DCTL_CSFTRST bit is > cleared, we must wait at least 50ms before accessing the PHY domain > (synchronization delay). > > Signed-off-by: Thinh Nguyen > --- >

RE: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

Hi Geert and Simon, On Monday, January 08, 2018, Geert Uytterhoeven wrote: > Thanks for the update, but I think there has been a misunderstanding. > I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from > the matching in the driver. Opps, I was all kinds of confused then. So,

Re: dvb usb issues since kernel 4.9

On Mon, 8 Jan 2018 08:02:00 -0200 Mauro Carvalho Chehab wrote: > Hi Linus, > > Em Sun, 7 Jan 2018 13:23:39 -0800 > Linus Torvalds escreveu: > > > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > >

Re: [PATCH] usb: gadget: uvc:change the UVC_NUM_REQUESTS value

Hi, Lipengcheng writes: > The value is 4, it can cache four descriptors. When streaming_interval = 1, > it can tolerate 500us. Some busy scenes, it may be more than 500us because > cpu scheduling is not timely. There will have some problems. It is better > set to eight. >

Re: [PATCH] usb: dwc3: gadget: decrease the queued_requests in removal

Hi, Lipengcheng writes: > In removal requests, it is necessary to make the corresponding trb > disable state (HWO = 1) and dep->queued_requests a corresponding reduction. > It is better to use a alone funtion to disable trb (HWO = 0). this shouldn't be necessary. What

RE: [PATCH] usb: dwc3: gadget:Core consumes a trb software to fill a trb, in ISO

Hi, Lipengcheng writes: >> Lipengcheng writes: >> >> > Iso transmission, the current process is that all trb(HWO=1) is handled. >> > Then core generate DWC3_DEPEVT_XFERNOTREADY event, Software begin >> > refill trb, this will produce 0 length

[GIT PULL] USB: changes for v4.16 merge window

Hi Greg, Here are my changes for this merge window. Let me know if you want anything to be changed. Patches have been on linux-next for quite a while ;-) cheers The following changes since commit 50c4c4e268a2d7a3e58ebb698ac74da0de40ae36: Linux 4.15-rc3 (2017-12-10 17:56:26 -0800) are

Re: [PATCH] usb:dwc3:fix access poisoned list_head in dwc3_gadget_giveback

Hi, Yu Chen writes: > From: Yu Chen > > Unable to handle kernel paging request at virtual address dead0108 > pgd = fff7a3179000 > [dead0108] *pgd=230e0003, *pud=230e0003, > *pmd= > Internal error:

Re: [PATCH] Revert "ARM: dts: bcm283x: Fix DTC warnings about missing phy-cells"

On Mon, Jan 8, 2018 at 10:36 AM, Stefan Wahren wrote: > Am 08.01.2018 um 10:27 schrieb Arnd Bergmann: >> >> On Mon, Jan 8, 2018 at 10:15 AM, Stefan Wahren >> wrote: >>> >>> Hi Eric, >>> Am 07.01.2018 um 23:08 schrieb Eric Anholt: Stefan

Re: [PATCH v2 1/2] USB: serial: ark3116: Remove unused TIOCSSERIAL ioctl case.

Am Samstag, den 06.01.2018, 20:14 +0300 schrieb Mikhail Zaytsev: > The patch removes unused TIOCSSERIAL ioctl case and adds the default block > to the switch. This will make the ioctl return -ENOTTY to user space (e.g. > setserial), because TIOCSSERIAL really isn't supported for these devices >

Re: dvb usb issues since kernel 4.9

Hi Linus, Em Sun, 7 Jan 2018 13:23:39 -0800 Linus Torvalds escreveu: > On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab > wrote: > > > > Em Sat, 6 Jan 2018 16:04:16 +0100 > > "Josef Griebichler" escreveu:

Re: dvb usb issues since kernel 4.9

Em Sun, 7 Jan 2018 10:41:37 -0500 (EST) Alan Stern escreveu: > On Sun, 7 Jan 2018, Mauro Carvalho Chehab wrote: > > > > > It seems that the original patch were designed to solve some IRQ issues > > > > with network cards with causes data losses on high traffic.