[V2][PATCH] ohci-hcd: Fix race condition caused by ohci_urb_enqueue() and io_watchdog_func()

2018-02-01 Thread Haiqing Bai
From: Shigeru Yoshida Running io_watchdog_func() while ohci_urb_enqueue() is running can cause a race condition where ohci->prev_frame_no is corrupted and the watchdog can mis-detect following error: ohci-platform 664a0800.usb: frame counter not updating;

Re: [PATCH 1/1] usb: host: ehci: always enable interrupt for qtd completion at test mode

2018-02-01 Thread Peter Chen
On Thu, Feb 01, 2018 at 02:24:29PM -0500, Alan Stern wrote: > On Thu, 1 Feb 2018, Peter Chen wrote: > > > At former code, the SETUP stage does not enable interrupt > > for qtd completion, it relies on IAA watchdog to complete > > interrupt, then the transcation would be considered timeout > > if

Re: [RFC v3] Add support for Sony PS2 OHCI

2018-02-01 Thread Fredrik Noring
Hi Alan Stern, On Mon, Nov 27, 2017 at 10:46:55AM -0500, Alan Stern wrote: > I did not read the whole thing in detail, but it generally looks okay. > Except, of course, that the dma-mapping.h change can't be part of this > patch. That will have to be done separately. We are observing seemingly

Re: [PATCH] ohci-hcd: Fix race condition caused by ohci_urb_enqueue() and io_watchdog_func()

2018-02-01 Thread Yoshida, Shigeru
Hi Alan, On Thu, 1 Feb 2018 10:33:33 -0500, Alan Stern wrote: >> I think we must choose an invalid frame number for the special >> sentinel value, but I'm not sure which value is adequate for it. >> Is 0xff00 an invalid frame number, otherwise how about simply >> -1(0x)? > > Well,

Re: WARNING in usb_submit_urb

2018-02-01 Thread Eric Biggers
On Tue, Nov 07, 2017 at 08:11:13AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 36ef71cae353f88fd6e095e2aaa3e5953af1685d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: BUG: Bad page state (3)

2018-02-01 Thread Eric Biggers
On Sun, Dec 31, 2017 at 11:03:01PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 30a7acd573899fd8b8ac39236eff6468b195ac7d > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console

Re: [usb-serial] Support for console read from usb serial driver

2018-02-01 Thread Greg KH
On Thu, Feb 01, 2018 at 11:52:18PM +0530, Ivid Suvarna wrote: > Hi All, > > I was going through usb serial driver console related source code > (drivers/usb/serial/console.c) in linux kernel and came across > "usb_console_write" function and was wondering if any usb serial > convertor drivers

Re: [PATCH 1/1] usb: host: ehci: use correct device pointer for dma ops

2018-02-01 Thread Alan Stern
On Thu, 1 Feb 2018, Peter Chen wrote: > commit a8c06e407ef9 ("usb: separate out sysdev pointer from usb_bus") > converted to use hcd->self.sysdev for DMA operations instead of > hcd->self.controller, but forgot to do it for hcd test mode. Replace > the correct one in this commit. > > Fixes:

Re: [PATCH 1/1] usb: host: ehci: always enable interrupt for qtd completion at test mode

2018-02-01 Thread Alan Stern
On Thu, 1 Feb 2018, Peter Chen wrote: > At former code, the SETUP stage does not enable interrupt > for qtd completion, it relies on IAA watchdog to complete > interrupt, then the transcation would be considered timeout > if the flag need_io_watchdog is cleared by platform code. > > In this

[usb-serial] Support for console read from usb serial driver

2018-02-01 Thread Ivid Suvarna
Hi All, I was going through usb serial driver console related source code (drivers/usb/serial/console.c) in linux kernel and came across "usb_console_write" function and was wondering if any usb serial convertor drivers were using this function? If so any pointers on how it is being used? Also

Re: [PATCH] ohci-hcd: Fix race condition caused by ohci_urb_enqueue() and io_watchdog_func()

2018-02-01 Thread Alan Stern
On Thu, 1 Feb 2018, Yoshida, Shigeru wrote: > Hi Alan, > > Thank you for your commenting. > > On Wed, 31 Jan 2018 11:02:47 -0500, Alan Stern wrote: > >> To address above scenario, this patch introduces timer_running flag to > >> ohci_hcd structure. Setting true to ohci->timer_running indicates

Re: [PATCH v5 00/17] Support for Qualcomm QUSBv2 and QMPv3 USB PHYs

2018-02-01 Thread Kishon Vijay Abraham I
Hi, On Wednesday 31 January 2018 10:51 AM, Manu Gautam wrote: > Hi Kishon, > > > On 1/16/2018 4:26 PM, Manu Gautam wrote: >> QUSB-v2 and QMP-v3 USB PHYs are present on Qualcomm's 14nm >> and 10nm SOCs. >> This patch series adds support for runtime PM for these >> USB PHYs and adds fixes in

[GIT PULL] USB/PHY updates for 4.16-rc1

2018-02-01 Thread Greg KH
The following changes since commit a8750ddca918032d6349adbf9a4b6555e7db20da: Linux 4.15-rc8 (2018-01-14 15:32:30 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.16-rc1 for you to fetch changes up to

[PATCH 2/2] usb: gadget: udc: atmel: convert to use GPIO descriptors

2018-02-01 Thread Ludovic Desroches
Use GPIO descriptors instead of relying on the old method. Include irq.h header since it is needed and was indirectly included through of_gpio.h. Signed-off-by: Ludovic Desroches --- drivers/usb/gadget/udc/atmel_usba_udc.c | 51 ++---

[PATCH 1/2] usb: gadget: udc: atmel: remove code related to platform stuff

2018-02-01 Thread Ludovic Desroches
With the removal of AVR platforms, code related to platform stuff is useless. Signed-off-by: Ludovic Desroches --- drivers/usb/gadget/udc/atmel_usba_udc.c | 73 + 1 file changed, 2 insertions(+), 71 deletions(-) diff --git

[PATCH v2] USB: serial: option: Add support for Quectel EP06

2018-02-01 Thread Kristian Evensen
The Quectel EP06 is a Cat. 6 LTE modem, and the interface mapping is as follows: 0: Diag 1: NMEA 2: AT 3: Modem Interface 4 is QMI and interface 5 is ADB, so they are blacklisted. This patch should also be considered for -stable. The QMI-patch for this modem is already in the -stable-queue.

Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-02-01 Thread Krzysztof Kozlowski
On Thu, Feb 1, 2018 at 9:19 AM, Andrzej Hajda wrote: > On 01.02.2018 08:50, Krzysztof Kozlowski wrote: >> On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda wrote: >>> OF graph describes USB data lanes between USB-PHY and respective MUIC. >>> Since graph is

Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

2018-02-01 Thread Andrzej Hajda
On 01.02.2018 08:50, Krzysztof Kozlowski wrote: > On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete >> extcon property can