Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

Hi, Roger Quadros writes: > In the following test we get stuck by sleeping forever in _dwc3_set_mode() > after which dual-role switching doesn't work. > > On dra7-evm's dual-role port, > - Load g_zero gadget driver and enumerate to host > - suspend to mem > - disconnect USB cable

Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

On 27.02.2018 22:24, Rob Herring wrote: > On Wed, Feb 21, 2018 at 2:55 AM, Andrzej Hajda wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda >> --- >> v4: >> - added missing reg

回覆: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

Hi Jun, For the questions of drp_toggling, our test is as following: According to TCPCI 4.4.5.2 It is recommended the TCPM write ROLE_CONTROL.DRP=0 before writing to POWER_CONTROL.AutoDischargeDisconnect and starting the DRP toggling using COMMAND.Look4Connection. We've encounter a

Re: [PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

Hi Roger, On 27 February 2018 at 19:22, Roger Quadros wrote: > In the following test we get stuck by sleeping forever in _dwc3_set_mode() > after which dual-role switching doesn't work. > > On dra7-evm's dual-role port, > - Load g_zero gadget driver and enumerate to host > -

回覆: [PATCH] staging: typec: handle vendor defined part and modify drp toggling flow

Hi Guenter, regmap_write returns a negative return code or 0, thus this can be simplified to return regmap_write(...); Ok, I'll modify it in v4 Hmm, normally I'd expect this function _after_ the function it calls. Guess that doesn't matter much here, so I am fine with it as long as

Re: [PATCH] usbip: tools usbip_attach: Fix cryptic error messages

On 02/27/2018 03:45 PM, Krzysztof Opasiak wrote: > > > On 02/27/2018 11:23 PM, Shuah Khan wrote: >> Attach device error message is cryptic and useless. Fix it to be >> informative. >> >> Signed-off-by: Shuah Khan >> --- >>   tools/usb/usbip/src/usbip_attach.c | 3 ++- >>

Re: [PATCH] usbip: tools usbip_attach: Fix cryptic error messages

On 02/27/2018 11:23 PM, Shuah Khan wrote: Attach device error message is cryptic and useless. Fix it to be informative. Signed-off-by: Shuah Khan --- tools/usb/usbip/src/usbip_attach.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers

Without pm_runtime_{get,put}_sync calls in place, reading vbus status via /sys causes the following error: Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 pgd = b333e822 [fa0ab060] *pgd=48011452(bad) [] (musb_default_readb) from [] (musb_vbus_show+0x58/0xe4) []

[PATCH v2 0/1] usb: musb: fix vbus_show

Hi, This fixes reading vbus status in musb. v2 places the pm_runtime_{get,put}_sync calls outside of the spinlocks, because pm_runtime_{get,put}_sync would otherwise (sometimes, depending on the platform) cause deadlocks. Hopefully this fixes the deadlock issue that Bin Liu ran into. I've tested

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

Hi, On 2018년 02월 27일 21:05, Andrzej Hajda wrote: > On 27.02.2018 12:08, Chanwoo Choi wrote: >> Hi, >> >> On 2018년 02월 27일 16:11, Andrzej Hajda wrote: >>> From: Maciej Purski >>> >>> Currently MHL chip must be turned on permanently to detect MHL cable. It >>> duplicates

[PATCH] usbip: tools usbip_network: Fix cryptic error messages

Kernel and tool version mismatch message is cryptic. Fix it to be informative. Signed-off-by: Shuah Khan --- tools/usb/usbip/src/usbip_network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/usb/usbip/src/usbip_network.c

[PATCH] usbip: tools usbip_attach: Fix cryptic error messages

Attach device error message is cryptic and useless. Fix it to be informative. Signed-off-by: Shuah Khan --- tools/usb/usbip/src/usbip_attach.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/usb/usbip/src/usbip_attach.c

Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

On Wed, Feb 21, 2018 at 2:55 AM, Andrzej Hajda wrote: > OF graph describes MHL data lanes between MHL and respective USB > connector. > > Signed-off-by: Andrzej Hajda > --- > v4: > - added missing reg property in connector's port node (Krzysztof) > --- >

Re: [PATCH v1 1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

On 2/27/2018 2:05 PM, Greg KH wrote: On Tue, Feb 27, 2018 at 01:22:24PM -0500, Joe Moriarty wrote: On 2/27/2018 1:14 PM, Greg KH wrote: On Tue, Feb 27, 2018 at 09:59:40AM -0500, Joe Moriarty wrote: On 2/26/2018 2:35 PM, Greg KH wrote: On Mon, Feb 26, 2018 at 02:08:08PM -0500, Joe Moriarty

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

From: Bassem Boubaker Date: Tue, 27 Feb 2018 14:04:44 +0100 > The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces. > > The modem is controlled via AT commands through the exposed TTYs. > > AT^SWWAN write command can be used to activate or

Re: [PATCH v1 1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

On Tue, Feb 27, 2018 at 01:22:24PM -0500, Joe Moriarty wrote: > On 2/27/2018 1:14 PM, Greg KH wrote: > > On Tue, Feb 27, 2018 at 09:59:40AM -0500, Joe Moriarty wrote: > > > On 2/26/2018 2:35 PM, Greg KH wrote: > > > > On Mon, Feb 26, 2018 at 02:08:08PM -0500, Joe Moriarty wrote: > > > > > On

Re: [PATCH v1 1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

On 2/27/2018 1:14 PM, Greg KH wrote: On Tue, Feb 27, 2018 at 09:59:40AM -0500, Joe Moriarty wrote: On 2/26/2018 2:35 PM, Greg KH wrote: On Mon, Feb 26, 2018 at 02:08:08PM -0500, Joe Moriarty wrote: On 2/26/2018 1:12 PM, Greg KH wrote: On Mon, Feb 26, 2018 at 12:10:02PM -0500, Joe Moriarty

Re: [PATCH v1 1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

On Tue, Feb 27, 2018 at 09:59:40AM -0500, Joe Moriarty wrote: > On 2/26/2018 2:35 PM, Greg KH wrote: > > On Mon, Feb 26, 2018 at 02:08:08PM -0500, Joe Moriarty wrote: > > > On 2/26/2018 1:12 PM, Greg KH wrote: > > > > On Mon, Feb 26, 2018 at 12:10:02PM -0500, Joe Moriarty wrote: > > > > > The

Re: [RFC PATCH] usb: hcd: complete URBs in threaded-IRQ context instead of tasklet

Hi Sebastian, Em Fri, 16 Feb 2018 18:04:50 +0100 Sebastian Andrzej Siewior escreveu: > I've been going over Frederic's softirq patches and it seems that there > were two problems. One was network related, the other was Mauro's USB > dvb-[stc] device which was not able to

Re: [PATCH v1 1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

On 2/27/2018 9:59 AM, Joe Moriarty wrote: On 2/26/2018 2:35 PM, Greg KH wrote: On Mon, Feb 26, 2018 at 02:08:08PM -0500, Joe Moriarty wrote: On 2/26/2018 1:12 PM, Greg KH wrote: On Mon, Feb 26, 2018 at 12:10:02PM -0500, Joe Moriarty wrote: The Parfait (version 2.1.0) static code analysis

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet: > On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote: > > > > > > Note that for this one, it seems we also could perform stats updates in > > BH context, since skb is queued via defer_bh() > > > > But simplicity wins I guess. >

Re: Wakeup from USB on i.MX6S

Hi Peter, here is an overview of the output voltages of all voltage regulators I could find on that system: for i in $(find / -name microvolts);do echo $i -- $(cat $i);done /sys/devices/soc0/soc/200.aips-bus/20c8000.anatop/20c8000.anatop:regulator-3p0/regulator/regulator.2/microvolts --

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote: > > Note that for this one, it seems we also could perform stats updates in > BH context, since skb is queued via defer_bh() > > But simplicity wins I guess. Thinking more about this, I am not sure we have any guarantee that TX and RX can

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

Bus 01.Port 1: Dev 1, Class=root_hub, Driver=exynos-ehci/3p, 480M > > >     |__ Port 1: Dev 2, If 0, Class=Video, Driver=, 480M > > >     |__ Port 1: Dev 2, If 1, Class=Video, Driver=, 480M > > > > > > > > > And the log with mentioned warning: > >

Re: [PATCH v1 1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem

On 2/26/2018 2:35 PM, Greg KH wrote: On Mon, Feb 26, 2018 at 02:08:08PM -0500, Joe Moriarty wrote: On 2/26/2018 1:12 PM, Greg KH wrote: On Mon, Feb 26, 2018 at 12:10:02PM -0500, Joe Moriarty wrote: The Parfait (version 2.1.0) static code analysis tool found the following NULL pointer

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

ed warning: [   17.768040] [   17.772239] WARNING: inconsistent lock state [   17.776511] 4.16.0-rc3-next-20180227-7-g876c53a7493c #453 Not tainted [   17.783329] [   17.787580] inconsistent {IN-HARDIRQ-W} -> {HARDIR

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

=Video, Driver=, 480M >     |__ Port 1: Dev 2, If 1, Class=Video, Driver=, 480M > > > And the log with mentioned warning: > > [   17.768040] ==== > [   17.772239] WARNING: inconsistent lock state > [   17.776511] 4.16.0-rc3-next-20180227-7-

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

On Tue, Feb 27, 2018 at 11:22 AM, Masahiro Yamada wrote: > 2018-02-27 18:03 GMT+09:00 Arnd Bergmann : >> On Tue, Feb 27, 2018 at 1:46 AM, Masahiro Yamada >> wrote: >>> But, we need to decide what the right solution is.

Re: [PATCH] usbip: vudc: fix null pointer dereference on udc->lock

On 02/26/2018 05:40 PM, Shuah Khan wrote: On 02/22/2018 10:39 AM, Colin King wrote: From: Colin Ian King Currently the driver attempts to spin lock on udc->lock before a NULL pointer check is performed on udc, hence there is a potential null pointer dereference on

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Am Dienstag, den 27.02.2018, 14:04 +0100 schrieb Bassem Boubaker: >     The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces. > >     The modem is  controlled via AT commands through the exposed TTYs. > >     AT^SWWAN write command can be used to activate or deactivate a WWAN >    

[PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces. The modem is controlled via AT commands through the exposed TTYs. AT^SWWAN write command can be used to activate or deactivate a WWAN connection for a PDP context defined with AT+CGDCONT. UE supports two WWAN

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Am Dienstag, den 27.02.2018, 13:29 +0100 schrieb Bjørn Mork : > Bassem Boubaker writes: > > > > > +#define GEMALTO_VENDOR_ID 0x1e2d > > This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c. > > I have no idea which defintion is most correct, but I

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Bassem Boubaker writes: > +#define GEMALTO_VENDOR_ID0x1e2d This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c. I have no idea which defintion is most correct, but I believe the macros should be kept identical whatever you decide. Anything else

[PATCH v6 5/6] extcon: add possibility to get extcon device by OF node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v5: function renamed to

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

On 27.02.2018 12:08, Chanwoo Choi wrote: > Hi, > > On 2018년 02월 27일 16:11, Andrzej Hajda wrote: >> From: Maciej Purski >> >> Currently MHL chip must be turned on permanently to detect MHL cable. It >> duplicates micro-USB controller's (MUIC) functionality and consumes >>

[PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

The Cinterion PL8 is an LTE modem with 2 possible WWAN interfaces. The modem is controlled via AT commands through the exposed TTYs. AT^SWWAN write command can be used to activate or deactivate a WWAN connection for a PDP context defined with AT+CGDCONT. UE supports two WWAN

[PATCH v2 2/2] usb: dwc3: add dual role support using OTG block

This is useful on platforms (e.g. TI AM437x) that don't have ID available on a GPIO but do have the OTG block. We can obtain the ID state via the OTG block and use it for dual-role switching. Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.c | 67 ++-

[PATCH v2 1/2] usb: dwc3: core.h: add some register definitions

Add OTG and GHWPARAMS6 register definitions Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.h | 82 + 1 file changed, 82 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 860d2bc..0d4c698

[PATCH v2 0/2] usb: dwc3: Add dual-role support using OTG core

Hi Felipe, Some platforms (e.g. TI's AM437x) don't have USB ID pin state available over GPIO/extcon but need to rely on the DWC3 core's OTG block to get the ID pin state instead. This series implements simple dual-role functionality using DWC3's OTG block. Debugfs 'mode' override is also

[PATCH] usb: dwc3: Prevent indefinite sleep in _dwc3_set_mode during suspend/resume

In the following test we get stuck by sleeping forever in _dwc3_set_mode() after which dual-role switching doesn't work. On dra7-evm's dual-role port, - Load g_zero gadget driver and enumerate to host - suspend to mem - disconnect USB cable to host and connect otg cable with Pen drive in it. -

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

Hi, On 2018년 02월 27일 16:11, Andrzej Hajda wrote: > From: Maciej Purski > > Currently MHL chip must be turned on permanently to detect MHL cable. It > duplicates micro-USB controller's (MUIC) functionality and consumes > unnecessary power. Lets use extcon attached to MUIC

Re: [PATCH v5 5/6] extcon: add possibility to get extcon device by OF node

Hi, On 2018년 02월 27일 16:11, Andrzej Hajda wrote: > Since extcon property is not allowed in DT, extcon subsystem requires > another way to get extcon device. Lets try the simplest approach - get > edev by of_node. > > Signed-off-by: Andrzej Hajda > Acked-by: Chanwoo Choi

Re: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt

Hi, On Mon, Feb 26, 2018 at 02:30:53PM +, Jun Li wrote: > > > + child = of_get_child_by_name(tcpci->dev->of_node, "connector"); > > > + if (!child) { > > > + dev_err(tcpci->dev, "failed to get connector node.\n"); > > > + return -EINVAL; > > > + } > > > > Why do you need

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

11] 4.16.0-rc3-next-20180227-7-g876c53a7493c #453 Not tainted [   17.783329] [   17.787580] inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage. [   17.793607] swapper/0/0 [HC0[0]:SC1[1]:HE1:SE0] takes: [   17.798751]  (>seq#5){?.-.}

[PATCH] usb: dwc3: prevent setting PRTCAP to OTG from debugfs

We don't support PRTCAP == OTG yet, so prevent user from setting it via debugfs. Fixes: 41ce1456e1db ("usb: dwc3: core: make dwc3_set_mode() work properly") Cc: # v4.12+ Signed-off-by: Roger Quadros --- drivers/usb/dwc3/core.c | 3 +++ 1 file changed, 3

[PATCH] usb: dwc3: Fix lock-up on ID change during system suspend/resume

To reproduce the lock up do the following - connect otg host adapter and a USB device to the dual-role port so that it is in host mode. - suspend to mem. - disconnect otg adapter. - resume the system. If we call dwc3_host_exit() before tasks are thawed xhci_plat_remove() seems to lock up at the

Re: inconsistent lock state with usbnet/asix usb ethernet and xhci

the same SoC works fine without any warnings. Odd. > And the log with mentioned warning: > > [   17.768040] > [   17.772239] WARNING: inconsistent lock state > [   17.776511] 4.16.0-rc3-next-20180227-7-

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

2018-02-27 18:03 GMT+09:00 Arnd Bergmann : > On Tue, Feb 27, 2018 at 1:46 AM, Masahiro Yamada > wrote: >> 2018-02-26 21:43 GMT+09:00 Arnd Bergmann : >>> On Mon, Feb 26, 2018 at 12:53 PM, Masahiro Yamada >>>

Re: [RFC PATCH] drivers: use 'depends on MFD_SYSCON' instead of 'select MFD_SYSCON'

On Tue, Feb 27, 2018 at 1:46 AM, Masahiro Yamada wrote: > 2018-02-26 21:43 GMT+09:00 Arnd Bergmann : >> On Mon, Feb 26, 2018 at 12:53 PM, Masahiro Yamada >> wrote: >>> 2018-02-26 17:43 GMT+09:00 Arnd Bergmann

Re: [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery

On 26.02.2018 12:49, Li Jun wrote: > In case of usb-c-connector with power delivery support, add bingdings > supported by current typec driver, so user can pass all those properties > via dt. > > Signed-off-by: Li Jun > --- > Changes for v2: > - Added typec properties are based on

[PATCH 2/2] usb: gadget: udc: renesas_usb3: add binging for r8a77965

This patch adds binding for r8a77965 (R-Car M3-N). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/renesas_usb3.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt

[PATCH 0/2] usb: add USB2.0/3.0 peripheral bindings for r8a77965

This patch set is based on the latest Felipe's usb.git / testing/next branch (commit id = 892b3e4a3df3f8fa18053aba65acd5a3dee05325). Yoshihiro Shimoda (2): usb: renesas_usbhs: add binding for r8a77965 usb: gadget: udc: renesas_usb3: add binging for r8a77965

[PATCH 1/2] usb: renesas_usbhs: add binding for r8a77965

This patch adds binding for r8a77965 (R-Car M3-N). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt

[PATCH] usb: host: xhci-rcar: add support for r8a77965

This patch adds support for r8a77965 (R-Car M3-N). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + drivers/usb/host/xhci-rcar.c | 4 2 files changed, 5 insertions(+) diff --git

RE: [PATCH] usb: host: xhci-rcar: add support for r8a77965

Hi, I'm afraid but I will re-submit this patch because we should get review by device tree maintainers. Best regards, Yoshihiro Shimoda > From: Yoshihiro Shimoda, Sent: Tuesday, February 27, 2018 5:12 PM > > This patch adds support for r8a77965 (R-Car M3-N). > > Signed-off-by: Yoshihiro

[PATCH] usb: host: xhci-rcar: add support for r8a77965

This patch adds support for r8a77965 (R-Car M3-N). Signed-off-by: Yoshihiro Shimoda --- Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 + drivers/usb/host/xhci-rcar.c | 4 2 files changed, 5 insertions(+) diff --git