Re: [PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()

On Sat, Mar 10, 2018 at 07:22:55PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 10 Mar 2018 19:05:45 +0100 > > Two update suggestions were taken into account > from static source code analysis. Hi Markus How about re-writing this driver to

Re: [PATCH 1/2] net/usb/ax88179_178a: Use common code in ax88179_chk_eee()

On Sat, Mar 10, 2018 at 8:41 PM, Joe Perches wrote: > On Sat, 2018-03-10 at 19:24 +0100, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sat, 10 Mar 2018 18:22:43 +0100 >> >> Adjust a jump target so that a bit of common code can be

Re: [PATCH 1/2] net/usb/ax88179_178a: Use common code in ax88179_chk_eee()

On Sat, 2018-03-10 at 19:24 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 10 Mar 2018 18:22:43 +0100 > > Adjust a jump target so that a bit of common code can be better reused > at the end of this function. Please stop mindlessly sending

[PATCH 2/2] net/usb/ax88179_178a: Delete three unnecessary variables in ax88179_chk_eee()

From: Markus Elfring Date: Sat, 10 Mar 2018 18:53:28 +0100 Use three values directly for a condition check without assigning them to intermediate variables. Signed-off-by: Markus Elfring --- drivers/net/usb/ax88179_178a.c | 13

[PATCH 1/2] net/usb/ax88179_178a: Use common code in ax88179_chk_eee()

From: Markus Elfring Date: Sat, 10 Mar 2018 18:22:43 +0100 Adjust a jump target so that a bit of common code can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/2] net/usb/ax88179_178a: Adjustments for ax88179_chk_eee()

From: Markus Elfring Date: Sat, 10 Mar 2018 19:05:45 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use common code Delete three unnecessary variables drivers/net/usb/ax88179_178a.c | 45