Re: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

On Thu, Mar 29, 2018 at 12:06:15AM +0800, Li Jun wrote: > In case of drp toggling, we may need set correct cc value for role control > after attach as it may never been set. > Isn't CC set by the lower level driver in this case ? In other words, is it ever necessary to call back into the low

Re: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach

Hi Li, On 03/28/2018 06:06 PM, Li Jun wrote: > In case of drp toggling, we may need set correct cc value for role control > after attach as it may never been set. > > Signed-off-by: Li Jun > --- > drivers/usb/typec/tcpm.c | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

Hi Li, On 03/28/2018 06:06 PM, Li Jun wrote: > Add bingdings supported by current typec driver, so user can pass > all those properties via dt. > > Signed-off-by: Li Jun > --- > .../bindings/connector/usb-connector.txt | 39 > ++ > 1 file changed,

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

Hi! > > Does ofonod work for you? I could not get that one to work... > > Because it's looking for a Gobi modem but the MDM6600 isn't one and > doesn't expose that layout (and doesn't really need to anyway). I > don't think ofono has a generic QMI driver, so you'd either need to for > ce it to

Re: [PATCH] usb: musb: gadget: misplaced out of bounds check

On Thu, Mar 29, 2018 at 06:36:42PM +0200, Greg Kroah-Hartman wrote: > On Thu, Mar 29, 2018 at 10:48:28AM -0500, Bin Liu wrote: > > From: Heinrich Schuchardt > > > > musb->endpoints[] has array size MUSB_C_NUM_EPS. > > We must check array bounds before accessing the array and

Re: [PATCH] usb: musb: gadget: misplaced out of bounds check

On Thu, Mar 29, 2018 at 10:48:28AM -0500, Bin Liu wrote: > From: Heinrich Schuchardt > > musb->endpoints[] has array size MUSB_C_NUM_EPS. > We must check array bounds before accessing the array and not afterwards. > > Signed-off-by: Heinrich Schuchardt >

[PATCH] musb patches for v4.17-rc1

Hi Greg, Here is one musb patch for v4.17 rc, which fixes an improper array boundary check. Please let me know if any change is needed. regards, -Bin. --- Heinrich Schuchardt (1): usb: musb: gadget: misplaced out of bounds check drivers/usb/musb/musb_gadget_ep0.c | 14 +- 1 file

[PATCH] usb: musb: gadget: misplaced out of bounds check

From: Heinrich Schuchardt musb->endpoints[] has array size MUSB_C_NUM_EPS. We must check array bounds before accessing the array and not afterwards. Signed-off-by: Heinrich Schuchardt Signed-off-by: Bin Liu ---

[PATCH v2 3/3] usb: dwc2: Add High Bandwidth ISOC OUT support

Updated checking of chain full condition based on mult count. For each packet in uframe (dpi) created new desc by setting size of transfer to mps. Buffer addresses in descs differ by mps in function dwc2_gadget_fill_isoc_desc(). In function dwc2_gadget_start_isoc_ddma() upadted loop boundaries

[PATCH v2 2/3] usb: dwc2: Change ISOC DDMA flow

Changed existing two descriptor-chain flow to one chain. In two-chain implementation BNA interrupt used for switching between two chains. BNA interrupt asserted because of returning to beginning of the chain based on L-bit of last descriptor. Because of that we lose packets. This issue resolved

[PATCH v2 0/3] usb: dwc2: gadget: Update ISOC DDMA flow.

This series fully update existing ISOC DDMA flow which initially based on 2 descriptor chains. Switching between desc chains performing based on BNA interrupt. Because of BNA interrupt few packets can be lost. 1/3 patch unmask ISOC IN BNA interrupt only. 2/3 patch changing ISOC IN/OUT flow as

[PATCH v2 1/3] usb: dwc2: Enable BNA interrupt for IN endpoints

In DDMA mode required to enable BNA interrupt for both directions. Signed-off-by: Minas Harutyunyan --- drivers/usb/dwc2/gadget.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index

Re: Wakeup from USB on i.MX6S

Hi and sorry for the long time to the new answere. I think meanwhile I've lost the trust in that I'm able to get this wakeup on usb plugin running properly by myself. And, of course, there was a lot of work besides that wakeup problem. Meanwhile our board supplier classified our wish as a

Re: [PATCH v4 04/13] usb: typec: add fwnode to tcpc

Hi, On Thu, Mar 29, 2018 at 12:06:09AM +0800, Li Jun wrote: > Add fwnode handle to get the fwnode so we can get typec configs > it contains. > > Suggested-by: Heikki Krogerus > Signed-off-by: Li Jun > --- > drivers/staging/typec/tcpci.c | 14

Re: Sorry, Patch wrong (was: patch "USB: serial: ftdi_sio: add Id for Physik Instrumente E-870" added to usb-testing)

On Thu, Mar 29, 2018 at 01:49:02PM +0200, Teichmann, Martin wrote: > Dear Greg, dear Johan, dear list, > > I'm very sorry I was a bit quick in sending you a patch for the PI > E-870 device, because it's actually wrong. Everything seemed to work > fine, until I realized that once in a while two

[PATCH] Revert "USB: serial: ftdi_sio: add Id for Physik Instrumente E-870"

This reverts commit 79a0b33165d8d8ec0840fcfc74fd0a8f219abeee. Turns out this is not an FTDI device after all. Reported-by: Martin Teichmann Cc: stable Signed-off-by: Johan Hovold --- Greg, I included the stable tag above as

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

Hi, On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > > This allows dual-role ports to be reported as having gadget mode by > > the > > musb_has_gadget helper. This is required to enable MUSB at all with > > MUSB > >

Sorry, Patch wrong (was: patch "USB: serial: ftdi_sio: add Id for Physik Instrumente E-870" added to usb-testing)

Dear Greg, dear Johan, dear list, I'm very sorry I was a bit quick in sending you a patch for the PI E-870 device, because it's actually wrong. Everything seemed to work fine, until I realized that once in a while two characters were missing. Checking dmesg I realized error messages had piled

Re: [PATCH v4 07/13] staging: typec: tcpci: register port before request irq

On Thu, Mar 29, 2018 at 12:06:12AM +0800, Li Jun wrote: > With that we can clear any pending events and the port is registered > so driver can be ready to handle typec events once we request irq. > > Signed-off-by: Peter Chen > Signed-off-by: Li Jun These

Re: [PATCH 0/5] usb: chipidea: updates for v4.17-rc1

On Thu, Mar 29, 2018 at 05:52:44PM +0800, Peter Chen wrote: > Hi Greg, > > This series including the bug fix for imx53 and some cleanups. > Due to network problem during nxp and qualcomm merge, I can't > do ssh for kernel.org currently, I am sorry I can't upload my > code, then can't send pull

[PATCH 5/5] usb: chipidea: imx: Fix ULPI on imx53

From: Sebastian Reichel Traditionally, PORTSC should be set before initializing ULPI phys. But setting PORTSC before powering on the phy results in a kernel freeze on imx53 based GE PPD. As a workaround this initializes the phy early in the imx platform code

[PATCH 4/5] usb: chipidea: imx: Cleanup ci_hdrc_imx_platform_flag

From: Sebastian Reichel Some trivial cleanups, that do not change functionality. Signed-off-by: Sebastian Reichel Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 +-- 1 file

[PATCH 1/5] usb: chipidea: usbmisc: evdo is only specific to OTG port

From: Michael Trimarchi The USB_PHY_CTRL_FUNC is used specific for OTG port as described in user manual. EVDO need to be set only for index 0 that correspond to OTG port Signed-off-by: Michael Trimarchi Signed-off-by: Peter Chen

[PATCH 0/5] usb: chipidea: updates for v4.17-rc1

Hi Greg, This series including the bug fix for imx53 and some cleanups. Due to network problem during nxp and qualcomm merge, I can't do ssh for kernel.org currently, I am sorry I can't upload my code, then can't send pull request either. I hope ssh access can be recovered soon. Thanks. Michael

[PATCH 2/5] usb: chipidea: usbmisc: evdo can be set e/o reset

From: Michael Trimarchi evdo bit can be set or reset. We can not trust evdo bit status after bootloader stage Signed-off-by: Michael Trimarchi Signed-off-by: Peter Chen --- drivers/usb/chipidea/usbmisc_imx.c | 20

[PATCH 3/5] usb: chipidea: usbmisc: small clean up

From: Michael Trimarchi The register write can be done outside the if and else condition Signed-off-by: Michael Trimarchi Signed-off-by: Peter Chen --- drivers/usb/chipidea/usbmisc_imx.c | 3 +-- 1 file changed,

Re: [GIT PULL] USB-serial updates for v4.17-rc1

On Thu, Mar 29, 2018 at 11:10:41AM +0200, Johan Hovold wrote: > The following changes since commit 4a3928c6f8a53fa1aed28ccba227742486e8ddcb: > > Linux 4.16-rc3 (2018-02-25 18:50:41 -0800) > > are available in the Git repository at: > >

Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role

On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > This allows dual-role ports to be reported as having gadget mode by the > musb_has_gadget helper. This is required to enable MUSB at all with MUSB > glue layers that set the port mode to MUSB_PORT_MODE_DUAL_ROLE at init. > >

[GIT PULL] USB-serial updates for v4.17-rc1

The following changes since commit 4a3928c6f8a53fa1aed28ccba227742486e8ddcb: Linux 4.16-rc3 (2018-02-25 18:50:41 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git tags/usb-serial-4.17-rc1 for you to fetch changes up to

[PATCH] usb: chipidea: Don't select EXTCON

Not all chipidea users need EXTCON, so it's better to avoid unconditionally select EXTCON, this could save us 2KB kernel Image size. Signed-off-by: Jisheng Zhang --- drivers/usb/chipidea/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH] ftdi_sio: add Id for Physik Instrumente E-870

On Thu, Mar 29, 2018 at 08:39:37AM +0200, Teichmann, Martin wrote: > This adds support for the Physik Instrumente E-870 PIShift Drive > Electronics, a Piezo motor driver. > > Signed-off-by: Martin Teichmann Now applied with an updated commit summary (prefix). Thanks,

[PATCH] ftdi_sio: add Id for Physik Instrumente E-870

This adds support for the Physik Instrumente E-870 PIShift Drive Electronics, a Piezo motor driver. Signed-off-by: Martin Teichmann --- drivers/usb/serial/ftdi_sio.c | 1 + drivers/usb/serial/ftdi_sio_ids.h | 1 + 2 files changed, 2 insertions(+) diff --git

[PATCH] usb: dwc3: of-simple: use managed and shared reset control

This driver handles the reset control in a common manner; deassert resets before use, assert them after use. There is no good reason why it should be exclusive. Also, use devm_ for clean-up. Signed-off-by: Masahiro Yamada --- CCing Philipp Zabel. I see his sob