RE: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config

data config > > Hi Li, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.17-rc7 > next-20180529] [cannot apply to staging/staging-testing] [if your patch is > applied to the wrong git tree, please

Re: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config

Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.17-rc7 next-20180529] [cannot apply to staging/staging-testing] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

RE: [PATCH 13/22] USB: chipidea: no need to check return value of debugfs_create functions

> > When calling debugfs functions, there is no need to ever check the return > value. The > function can work or not, but the code logic should never do something > different > based on this. > > Cc: Peter Chen > Signed-off-by: Greg Kroah-Hartman Tested on imx6sx-sdb board. Acked-by:

Re: [PATCH 20/22] USB: gadget: udc: pxa27x_udc: no need to check return value of debugfs_create functions

Greg Kroah-Hartman writes: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > There is also no need to keep the file dentries around at all, so remove >

[RESEND][PATCH v6 1/2] usb/gadget/uvc-configfs Fix linked flag in a format not being set when format is linked into streaming header

While checks are in place to avoid attributes and children of a format being manipulated after the format is linked into the streaming header, the linked flag was never actually set, invalidating the protections. Signed-off-by: Joel Pepper --- drivers/usb/gadget/function/uvc_configfs.c | 3 +++

[RESEND][PATCH v6 2/2] usb/gadget/uvc-configfs Fix host unable to negotiate framesizes other than first

- Add bFrameIndex as a UVCG_FRAME_ATTR_RO for each frame size. - Automatically assign ascending bFrameIndex to each frame in a format. Before all "bFrameindex" attributes were set to "1" with no way to configure the gadget otherwise. This resulted in the host always negotiating for bFrameIndex 1

[RESEND][PATCH v6 0/2] usb/gadget/uvc-configs Fix host unable to negotiate framesizes other than first​

This patch set is mostly concerned with fixing a bug with the driver setting incorrect bFrameIndexes, for details refer to the second patch. However part of the fix also depends on fixing an unrelated bug, which involved the "linked" flag on formats not beig set. v6: This is mostly a resubmit of

Re: [PATCH 05/22] USB: mon: no need to check return value of debugfs_create functions

Hi Greg, On Tue, May 29, 2018 at 06:51:54PM +0200, Greg Kroah-Hartman wrote: > On Tue, May 29, 2018 at 11:34:34AM -0500, Pete Zaitcev wrote: > > On Tue, 29 May 2018 17:30:50 +0200 > > Greg Kroah-Hartman wrote: > > > > > When calling debugfs functions, there is no need to ever check the > > >

Re: [PATCH 05/22] USB: mon: no need to check return value of debugfs_create functions

On Tue, May 29, 2018 at 11:34:34AM -0500, Pete Zaitcev wrote: > On Tue, 29 May 2018 17:30:50 +0200 > Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do

Re: [PATCH 02/22] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

On Tue, May 29, 2018 at 06:27:03PM +0200, Greg Kroah-Hartman wrote: > On Tue, May 29, 2018 at 09:15:30AM -0700, Guenter Roeck wrote: > > On Tue, May 29, 2018 at 05:30:47PM +0200, Greg Kroah-Hartman wrote: > > > When calling debugfs functions, there is no need to ever check the > > > return value.

Re: [PATCH 05/22] USB: mon: no need to check return value of debugfs_create functions

On Tue, 29 May 2018 17:30:50 +0200 Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Okay, fair enough. And the code works,

Re: [PATCH 02/22] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

On Tue, May 29, 2018 at 09:15:30AM -0700, Guenter Roeck wrote: > On Tue, May 29, 2018 at 05:30:47PM +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do

Re: [PATCH 02/22] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

On Tue, May 29, 2018 at 05:30:47PM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Clean up the fsusb302 driver to not

[PATCH 14/22] USB: core: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Johan Hovold Cc: Kai-Heng Feng Cc: Peter Chen Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/usb.c

[PATCH 04/22] USB: mtu3: no need to check return value of debugfs_create_dir()

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Chunfeng Yun Signed-off-by: Greg Kroah-Hartman --- drivers/usb/mtu3/mtu3_dr.c | 4 1 file changed, 4

[PATCH 11/22] USB: fhci-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. There is also no need to keep the file dentries around at all, so remove those variables from the host controller

[PATCH 13/22] USB: chipidea: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Peter Chen Signed-off-by: Greg Kroah-Hartman --- drivers/usb/chipidea/ci.h| 2 +-

[PATCH 16/22] USB: dwc3: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc3/debugfs.c | 43

[PATCH 18/22] USB: gadget: udc: bcm63xx_udc: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. There is also no need to keep the file dentries around at all, so remove those variables from the device structure.

[PATCH 07/22] USB: ohci: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. There is also no need to keep the file dentries around at all, so remove those variables from the host controller

[PATCH 15/22] USB: dwc2: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Minas Harutyunyan Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc2/debugfs.c | 78

[PATCH 22/22] USB: gadget: udc: s3c2410_udc: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Cc: Li Yang Cc: Nicolas Ferre Cc: Robert Jarzmik Signed-off-by: Greg Kroah-Hartman ---

[PATCH 19/22] USB: gadget: udc: gr_udc: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. There is also no need to keep the file dentries around at all, so remove those variables from the device structure.

[PATCH 03/22] USB: musb: clean up debugfs file and directory creation

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Because of this, lots of init functions do not need to have return values, so this cleans up a lot of unused error

[PATCH 06/22] USB: uhci: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/uhci-hcd.c | 15 --- 1 file

[PATCH 09/22] USB: imx21-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Cc: Johan Hovold Cc: Andy Shevchenko Signed-off-by: Greg Kroah-Hartman ---

[PATCH 08/22] USB: isp116x-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Olav Kongas Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/isp116x-hcd.c | 17 - 1

[PATCH 10/22] USB: fotg210-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Cc: Alan Stern Cc: Johan Hovold Cc: Kuppuswamy Sathyanarayanan Cc: Vasyl Gomonovych Cc:

[PATCH 01/22] USB: typec: tcpm: no need to check return value of debugfs_create_dir()

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the tcpm.c code to not care about this, turns out no one was even checking the return value of this

[PATCH 02/22] USB: typec: fsusb302: no need to check return value of debugfs_create_dir()

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Clean up the fsusb302 driver to not care about the dentry being created, or if the root directory was created, as

[PATCH 20/22] USB: gadget: udc: pxa27x_udc: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. There is also no need to keep the file dentries around at all, so remove those variables from the device structure.

[PATCH 12/22] USB: ehci-hcd: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Alan Stern Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/ehci-dbg.c | 30

[PATCH 17/22] USB: udc: atmel_usba_udc: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. There is also no need to keep the file dentries around at all, so remove those variables from the device structure.

[PATCH 21/22] USB: gadget: udc: renesas_usb3: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi Cc: Yoshihiro Shimoda Cc: Simon Horman Cc: Geert Uytterhoeven Signed-off-by: Greg

[PATCH 05/22] USB: mon: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. We do need to save the dentries for these files, so keep them around, but no need to check if they are "valid" or

Re: Patches for "Renesas uPD72020x workaround" don't work

On 29.05.2018 15:50, Marcus Mönius wrote: Hello, as described here (https://bbs.archlinux.org/viewtopic.php?pid=1787759#p1787759 ) the patches for the Renesas host controller  (https://www.spinics.net/lists/linux-usb/msg169384.html

Patches for "Renesas uPD72020x workaround" don't work

Hello, as described here (https://bbs.archlinux.org/viewtopic.php?pid=1787759#p1787759 ) the patches for the Renesas host controller (https://www.spinics.net/lists/linux-usb/msg169384.html

[usb:debugfs_cleanup 109/109] drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git debugfs_cleanup head: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 commit: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 [109/109] usb: debugfs cleanup - try 2 config: i386-allmodconfig (attached as .config) compiler: gcc-8 (Debian

[usb:debugfs_cleanup 109/109] drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & (have 'struct dentry *' and 'struct rtl_debugfs_priv')

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git debugfs_cleanup head: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 commit: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 [109/109] usb: debugfs cleanup - try 2 config: i386-randconfig-i0-201821 (attached as .config) compiler: gcc-8

Re: [usb:debugfs_cleanup 109/109] drivers/usb/typec/tcpm.c:580:9: warning: 'return' with a value, in function returning void

On Tue, May 29, 2018 at 05:32:48PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > debugfs_cleanup > head: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54 > commit: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54 [109/109] usb: debugfs > cleanup >

[usb:debugfs_cleanup 109/109] drivers/usb/typec/tcpm.c:580:9: warning: 'return' with a value, in function returning void

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git debugfs_cleanup head: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54 commit: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54 [109/109] usb: debugfs cleanup config: i386-randconfig-s1-201821 (attached as .config) compiler: gcc-6 (Debian

Re: Fwd: usb: uas: device reset most the time while enumeration- usb3.0

Hi, On 2018-05-28 18:12, Oliver Neukum wrote: Am Donnerstag, den 24.05.2018, 20:13 +0530 schrieb Tushar Nimkar: We have built SCSI as module will it cause any problem to enable CONFIG_SCSI_SCAN_ASYNC ? No, that should work. But the failure is bizzare. You say yes there is no problem! I have