Re: [BUG] usb: USB Mass Storage - USB cable is bad warning

2018-09-22 Thread Matthew Dharm
FYI, this message is *not* coming from usb-storage. While your device happens to be a storage device, this message comes from a lower USB layer. Matt On Sat, Sep 22, 2018 at 2:06 PM Barry Grussling wrote: > > When I plug my USB reader (11b0:6348) into my computer (MSI X399 > Carbon Pro,

[BUG] usb: USB Mass Storage - USB cable is bad warning

2018-09-22 Thread Barry Grussling
When I plug my USB reader (11b0:6348) into my computer (MSI X399 Carbon Pro, Threadripper 1900X), I get warnings about a bad usb cable: Sep 22 11:11:51 ciri kernel: usb 5-3.3-port4: Cannot enable. Maybe the USB cable is bad? Sep 22 11:11:52 ciri kernel: usb 5-3.3.4: new high-speed USB device

Re: [PATCH] ALSA: usb-audio: ensure that cluster header size is enough

2018-09-22 Thread Sergei Shtylyov
Hello! On 09/22/2018 04:38 PM, Dan Carpenter wrote: > I think we need a check to make sure that "hc_header.wLength" is large > enough for a struct struct uac3_cluster_header_descriptor. struct struct? :-) > Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0 support") >

[PATCH] ALSA: usb-audio: ensure that cluster header size is enough

2018-09-22 Thread Dan Carpenter
I think we need a check to make sure that "hc_header.wLength" is large enough for a struct struct uac3_cluster_header_descriptor. Fixes: 9a2fe9b801f5 ("ALSA: usb: initial USB Audio Device Class 3.0 support") Signed-off-by: Dan Carpenter diff --git a/sound/usb/stream.c b/sound/usb/stream.c index

[usb:usb-testing 34/67] drivers/usb/class/usbtmc.c:339 usbtmc_ioctl_abort_bulk_in_tag() error: uninitialized symbol 'actual'.

2018-09-22 Thread Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing head: ae8a2ca8a2215c7e31e6d874f7303801bb15fbbc commit: cbe743f1333b23040d1312afd58224dbd58fcc25 [34/67] usb: usbtmc: Fix ioctl USBTMC_IOCTL_ABORT_BULK_IN New smatch warnings: drivers/usb/class/usbtmc.c:339

[usb:usb-testing 21/67] drivers/usb/class/usbtmc.c:1275 usbtmc_ioctl_request() warn: possible memory leak of 'buffer'

2018-09-22 Thread Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing head: ae8a2ca8a2215c7e31e6d874f7303801bb15fbbc commit: 658f24f4523e41cda6a389c38b763f4c0cad6fbc [21/67] usb: usbtmc: Add ioctl for generic requests on control smatch warnings: drivers/usb/class/usbtmc.c:1275

[PATCH -next] USB: core: remove set but not used variable 'udev'

2018-09-22 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/usb/core/driver.c: In function 'usb_driver_claim_interface': drivers/usb/core/driver.c:513:21: warning: variable 'udev' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- drivers/usb/core/driver.c | 3 --- 1 file