Re: 64 byte EP0 OUT data transfer issue on Chipidea highspeed dual role controller

2015-06-26 Thread Alexander Shishkin
Jayan John jayanjoh...@gmail.com writes: I am developing a custom USB device on a iMX6q platform (Wandboard) Chipidea HDRC (highspeed dual role controller). The HID interface consists of a single Interrupt IN ep and ep0. It is required to send HID reports from Host to Gadget over ep0 (with

Re: [PATCH v5 3/3] usb: udc: add usb_udc_activation_handler

2015-02-03 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Currently, connect gadget is unconditional after binding, but some function drivers may want to connect gadget on the fly. With this API, the function driver can disconnect gadget during the initialization, and connect gadget when it wants. During

Re: [PATCH v5 0/3] usb: udc: Unify dp control

2015-02-03 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Thu, Jan 29, 2015 at 12:27:23PM +0800, Peter Chen wrote: Hi Felipe, Hi Felipe, I see you tree is closed, but below three patches are not in your tree, will you queue them now or at next rc? I have some other patches based on them, so I would

Re: [PATCH v3 2/2] chipidea: pci: add comment regarding to ehci-pci driver

2015-01-30 Thread Alexander Shishkin
andriy.shevche...@linux.intel.com Reviewed-by: Alexander Shishkin alexander.shish...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/2] ehci-pci: disable for Intel MID platforms

2015-01-30 Thread Alexander Shishkin
a bypass list, which currently consists of chipidea ids. Since now it's bigger than just chipidea. Acked-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Alexander Shishkin alexander.shish...@linux.intel.com -- To unsubscribe

Re: [PATCh v4 3/3] usb: udc: add usb_udc_activation_handler

2015-01-28 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: During this API, the deactivation count will be update, and it will try to connect or disconnect gadget. It can be used to enable functions for gadget. It's up to Felipe, but I'd like to see answers to the following questions in this commit message:

Re: [PATCH v1] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Tue, Jan 27, 2015 at 11:21:56AM -0500, Alan Stern wrote: On Tue, 27 Jan 2015, Peter Chen wrote: Please fix this properly. I don't know the right way to fix this. Alan, has you any suggestion? It depends. How did the code

Re: [PATCH v2] ehci-pci: disable for Intel MID platforms

2015-01-28 Thread Alexander Shishkin
Andy Shevchenko andriy.shevche...@linux.intel.com writes: On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI is in conflict with the proper driver. The patch makes ehci-pci to be ignored in favour of ChipIdea controller. Signed-off-by: Andy Shevchenko

Re: [PATCH v2 1/4] usb: udc: add usb_gadget_find_udc

2015-01-13 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: @@ -348,23 +356,14 @@ static void usb_gadget_remove_driver(struct usb_udc *udc) */ void usb_del_gadget_udc(struct usb_gadget *gadget) { - struct usb_udc *udc = NULL; - - mutex_lock(udc_lock); - list_for_each_entry(udc,

Re: [PATCH 0/3] usb: udc: cleanup pullup operation

2015-01-12 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: This patch set cleans up udc drivers which define .pullup API, but still call pullup operation at .udc_start or .udc_stop. In fact, the related pullup operations are covered by udc core. Oh, this driver is still around? Are we going to obsolete it

Re: [PATCH 1/2] usb: udc: add usb_udc_vbus_handler

2015-01-12 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: + mutex_lock(udc_lock); + list_for_each_entry(udc, udc_list, list) + if (udc-gadget == gadget) + goto found; + mutex_unlock(udc_lock); Not entirely specific to this patchset, but this search pattern is

Re: [PATCH] USB: switch maintainership of chipidea to Peter

2013-12-03 Thread Alexander Shishkin
Greg KH gre...@linuxfoundation.org writes: From: Greg Kroah-Hartman gre...@linuxfoundation.org Alexander isn't able to maintain the Chipidea code anymore, and as Peter has been acting as the de-facto maintainer anyway, make it official. Cc: Alexander Shishkin alexander.shish

Re: [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-08-27 Thread Alexander Shishkin
Hector Palacios hector.palac...@digi.com writes: Dear Peter, On 08/27/2013 04:51 AM, Peter Chen wrote: On Mon, Aug 26, 2013 at 06:24:48PM +0200, Hector Palacios wrote: Dear Peter, On 08/12/2013 03:22 AM, Peter Chen wrote: This patchset adds tested otg id switch function and vbus connect

[PATCH 00/22] usb: chipidea: updates for v3.12

2013-08-14 Thread Alexander Shishkin
Hi, These are chipidea patches for v3.12. The highlight of the series is vbus detection support. Other than that, a few cleanups and fixes, mostly concerning imx platforms. Everything is sparse, smatch and coccinelle clean and bisectable. Fabio Estevam (3): usb: chipidea: ci_hdrc_imx: remove

[PATCH 02/22] usb: chipidea: move hw_phymode_configure() into probe

2013-08-14 Thread Alexander Shishkin
this function into probe. After this change, USB Host1 port on mx53qsb board is functional. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Tested-by: Arnaud Patard arnaud.pat...@rtp-net.org Reviewed-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish

[PATCH 01/22] usb: chipidea: ci_hdrc_imx: remove unused variable 'res'

2013-08-14 Thread Alexander Shishkin
From: Fabio Estevam fabio.este...@freescale.com 'res' is not used anywhere, so let's get rid of it. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Acked-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb

[PATCH 05/22] usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_remove()

2013-08-14 Thread Alexander Shishkin
From: Lothar Waßmann l...@karo-electronics.de This prevents the USB PHY refcount to be decremented below zero upon unloading the ci-hdrc-imx module. Signed-off-by: Lothar Waßmann l...@karo-electronics.de Acked-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin

[PATCH 09/22] usb: chipidea: move vbus regulator operation to core

2013-08-14 Thread Alexander Shishkin
-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 26 ++ drivers/usb/chipidea/core.c| 23 +++ include/linux/usb/chipidea.h | 1 + 3 files changed, 26 insertions(+), 24 deletions(-) diff

[PATCH 20/22] usb: chipidea: retire flag CI_HDRC_PULLUP_ON_VBUS

2013-08-14 Thread Alexander Shishkin
peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 1 - drivers/usb/chipidea/ci_hdrc_msm.c | 1 - drivers/usb/chipidea/udc.c | 24 ++-- include/linux/usb/chipidea.h | 1 - 4

[PATCH 08/22] usb: chipidea: remove previous MODULE_ALIAS

2013-08-14 Thread Alexander Shishkin
From: Fabio Estevam fabio.este...@freescale.com After the rename to ci_hdrc we ended up with two MODULE_ALIAS entries, so remove the old one. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Reviewed-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin

[PATCH 15/22] usb: chipidea: disable all interrupts and clear all interrupts status

2013-08-14 Thread Alexander Shishkin
-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/core.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index ab01e18..e9cfd31 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers

[PATCH 11/22] usb: chipidea: udc: otg_set_peripheral is useless for some chipidea users

2013-08-14 Thread Alexander Shishkin
From: Peter Chen peter.c...@freescale.com It is useless at below cases: - If we implement both usb host and device at chipidea driver. - If we don't need phy-otg. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin

[PATCH 21/22] usb: chipidea: udc: .pullup is valid only when vbus is there

2013-08-14 Thread Alexander Shishkin
From: Peter Chen peter.c...@freescale.com For chipidea, the IP must know vbus before the controller begins to run. So the .pullup should only be called when the vbus is there. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander

[PATCH 12/22] usb: chipidea: otg: add otg file used to access otgsc

2013-08-14 Thread Alexander Shishkin
From: Peter Chen peter.c...@freescale.com This file is mainly used to access otgsc currently, it may add otg related things in the future. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com

[PATCH 17/22] usb: chipidea: add vbus interrupt handler

2013-08-14 Thread Alexander Shishkin
Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci.h | 5 + drivers/usb/chipidea/core.c | 28 +++- drivers/usb/chipidea/otg.c | 42

[PATCH 13/22] usb: chipidea: add role init and destroy APIs

2013-08-14 Thread Alexander Shishkin
-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/core.c | 10 -- drivers/usb/chipidea/host.c | 7 +++ drivers/usb/chipidea/host.h | 6 ++ drivers/usb/chipidea/udc.c | 36

[PATCH 03/22] usb: chipidea: imx: delete the dead code

2013-08-14 Thread Alexander Shishkin
From: Peter Chen peter.c...@freescale.com Remove an unused macro leftover from the old initialization code. Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 --- 1 file changed, 3

[PATCH 16/22] usb: chipidea: move otg related things to otg file

2013-08-14 Thread Alexander Shishkin
From: Peter Chen peter.c...@freescale.com Move otg related things to otg file. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/core.c | 63

[PATCH 19/22] usb: chipidea: udc: fix misuse of REGS_SHARED and PULLUP_ON_VBUS flags

2013-08-14 Thread Alexander Shishkin
register. - When the gadget starts (load one gadget module), the controller can run if vbus is on (CI_HDRC_PULLUP_ON_VBUS), it also does not relate to shared register. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin

[PATCH 06/22] usb: chipidea: don't clobber return value of ci_role_start()

2013-08-14 Thread Alexander Shishkin
From: Lothar Waßmann l...@karo-electronics.de If a role fails to start, propagate the error code up the call stack from probe. Signed-off-by: Lothar Waßmann l...@karo-electronics.de Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/core.c | 1 - 1

[PATCH 10/22] usb: chipidea: host: add vbus regulator control

2013-08-14 Thread Alexander Shishkin
-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/host.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index

[PATCH 14/22] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG

2013-08-14 Thread Alexander Shishkin
-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/core.c | 37 ++--- include/linux/usb/chipidea.h | 5 + 2 files changed, 35 insertions(+), 7 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c

[PATCH 18/22] usb: chipidea: add wait vbus lower than OTGSC_BSV before role starts

2013-08-14 Thread Alexander Shishkin
...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci.h | 3 +++ drivers/usb/chipidea/core.c | 32 drivers/usb/chipidea/otg.c | 4 3 files changed, 39 insertions(+) diff --git a/drivers/usb

[PATCH 22/22] USB: chipidea: i.MX: simplify usbmisc

2013-08-14 Thread Alexander Shishkin
-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci_hdrc_imx.c | 71 +--- drivers/usb/chipidea/ci_hdrc_imx.h | 17 ++- drivers/usb/chipidea/usbmisc_imx.c | 95 +- 3 files changed, 76 insertions(+), 107 deletions

[PATCH 04/22] usb: chipidea: improve kconfig 2.0

2013-08-14 Thread Alexander Shishkin
. Signed-off-by: Lothar Waßmann l...@karo-electronics.de Reviewed-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/Kconfig | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/usb

Re: [PATCH v15 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-08-14 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Mon, Aug 12, 2013 at 09:22:46AM +0800, Peter Chen wrote: This patchset adds tested otg id switch function and vbus connect and disconnect detection for chipidea driver. And fix kinds of bugs found at chipidea drivers after enabling id and vbus

Re: [PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-14 Thread Alexander Shishkin
Sascha Hauer s.ha...@pengutronix.de writes: The chipidea i.MX driver is split into two drivers. The ci_hdrc_imx driver handles the chipidea cores and the usbmisc_imx driver handles the noncore registers common to all chipidea cores (but SoC specific). Current flow is: - usbmisc sets an ops

Re: [PATCH] chipidea: core: Move hw_phymode_configure() into probe

2013-08-09 Thread Alexander Shishkin
Fabio Estevam fabio.este...@freescale.com writes: Currently hw_phymode_configure() is located inside hw_device_reset(), which is only called by chipidea udc driver. When operating in host mode, we also need to call hw_phymode_configure() in order to properly configure the PHY mode, so move

Re: [PATCH 1/1] usb: chipidea: imx: delete the dead code

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Signed-off-by: Peter Chen peter.c...@freescale.com Added a commit message and applied. Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 3/3] usb: host: delete chipidea dependency

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Now, chipidea host has already depended on USB_EHCI_HCD Signed-off-by: Peter Chen peter.c...@freescale.com Alan, what do you think? --- drivers/usb/host/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/2] chipidea: Remove previous MODULE_ALIAS

2013-08-09 Thread Alexander Shishkin
Fabio Estevam feste...@gmail.com writes: From: Fabio Estevam fabio.este...@freescale.com After the rename to ci_hdrc we ended up with two MODULE_ALIAS entries, so remove the old one. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Applied and pushed, thanks! -- To unsubscribe

Re: [PATCH v14 06/12] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Since we need otgsc to know vbus's status at some chipidea controllers even it is peripheral-only mode. Besides, some SoCs (eg, AR9331 SoC) don't have otgsc register even the DCCPARAMS_DC and DCCPARAMS_HC are both 1 at CAP_DCCPARAMS. We inroduce

Re: [PATCH v14 04/12] usb: chipidea: otg: Add otg file used to access otgsc

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: This file is mainly used to access otgsc currently, it may add otg related things in the future. Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/Makefile |2 +-

Re: [PATCH v14 08/12] usb: chipidea: move otg relate things to otg file

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: A few typos: Move otg relate things to otg file. related Tested-by: Marek Vasut ma...@denx.de Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c | 63 +--

Re: [PATCH v14 06/12] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Fri, Aug 09, 2013 at 03:55:56PM +0300, Alexander Shishkin wrote: + } else { + /* + * If the controller is not OTG capable, but support + * role switch, the defalt role is gadget

Re: [PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-09 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: CI_HDRC_REGS_SHARED stands for the controller registers is shared with other USB drivers, if all USB drivers are at chipidea/, it doesn't needed to set. We still have the msm driver that uses REGS_SHARED. CI_HDRC_PULLUP_ON_VBUS stands for pullup

Re: [PATCH 3/3] usb: host: delete chipidea dependency

2013-08-09 Thread Alexander Shishkin
Alan Stern st...@rowland.harvard.edu writes: On Fri, 9 Aug 2013, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Now, chipidea host has already depended on USB_EHCI_HCD Signed-off-by: Peter Chen peter.c...@freescale.com Alan, what do you think

Re: [PATCH 1/1] usb: chipidea: refine the operation of creating register mapping

2013-08-05 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: - The old operation needs to call hw_alloc_regmap two times, and the first operation is only used to know if the controller is lpm supported, besides, there is a kfree before kzalloc, it is also tricky. Why tricky? kfree() is called from either

[PATCH 0/2] usb: chipidea: fixes for v3.11-rc3

2013-07-29 Thread Alexander Shishkin
Hi, Here are two small chipidea fixes for v3.11. Fabio Estevam (1): usb: chipidea: cast PORTSC_PTS and DEVLC_PTS macros Peter Chen (1): usb: chipidea: fix the build error with randconfig drivers/usb/chipidea/Kconfig | 4 ++-- drivers/usb/chipidea/bits.h | 4 ++-- 2 files changed, 4

[PATCH 1/2] usb: chipidea: cast PORTSC_PTS and DEVLC_PTS macros

2013-07-29 Thread Alexander Shishkin
] Reported-by: Felipe Balbi ba...@ti.com Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/bits.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/bits.h b

[PATCH 2/2] usb: chipidea: fix the build error with randconfig

2013-07-29 Thread Alexander Shishkin
the chipidea host depend on ehci even it is built as module. Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb

Re: [PATCH] chipidea: ci_hdrc_imx: Remove unused variable 'res'

2013-07-29 Thread Alexander Shishkin
Fabio Estevam feste...@gmail.com writes: From: Fabio Estevam fabio.este...@freescale.com 'res' is not used anywhere, so let's get rid of it. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Applied and pushed, thanks! -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA

2013-07-12 Thread Alexander Shishkin
: probably the parts using the DMA API should be factored out, instead of disabling the whole USB gadget subsystem. Indeed. How does this look instead? This one is much better. FWIW, Acked-by: Alexander Shishkin alexander.shish...@linux.intel.com Regards, -- Alex -- To unsubscribe from

Re: [PATCH v12 06/13] usb: chipidea: add otg_cap attribute for otg capable

2013-07-12 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Since we need otgsc to know vbus's status at some chipidea controllers even it is peripheral-only mode. Besides, some SoCs (eg, AR9331 SoC) don't have otgsc register even the DCCPARAMS_DC and DCCPARAMS_HC are both 1 at CAP_DCCPARAMS. We inroduce

Re: [PATCH v12 06/13] usb: chipidea: add otg_cap attribute for otg capable

2013-07-12 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Fri, Jul 12, 2013 at 11:12:01AM +0300, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: Since we need otgsc to know vbus's status at some chipidea controllers even it is peripheral-only mode. Besides, some SoCs (eg

Re: [PATCH 1/1] usb: chipidea: fix the build error with randconfig

2013-07-10 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: Using below configs, the compile will have error: ERROR: ehci_init_driver undefined! .config: CONFIG_USB_CHIPIDEA=m CONFIG_USB_CHIPIDEA_HOST=y CONFIG_USB_CHIPIDEA_DEBUG=y The reason is chipidea host uses symbol from ehci, but ehci is not

Re: [PATCH] chipidea: bits: Cast PORTSC_PTS and DEVLC_PTS macros

2013-07-10 Thread Alexander Shishkin
Fabio Estevam fabio.este...@freescale.com writes: Fix the following build warnings on x86: drivers/usb/chipidea/core.c: In function 'hw_phymode_configure': drivers/usb/chipidea/core.c:226:3: warning: large integer implicitly truncated to unsigned type [-Woverflow]

Re: Two remain problems at chipidea driver

2013-06-28 Thread Alexander Shishkin
Peter Chen hzpeterc...@gmail.com writes: On Thu, Mar 21, 2013 at 11:06 AM, Peter Chen peter.c...@freescale.com wrote: On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: Peter Chen peter.c...@freescale.com writes: On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin

Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available

2013-06-26 Thread Alexander Shishkin
Felipe Balbi ba...@ti.com writes: On Wed, Jun 26, 2013 at 05:37:19PM +0530, George Cherian wrote: On 6/26/2013 3:46 PM, Felipe Balbi wrote: Hi, On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: There can be configurations in which DWC3 is hoooked up only to USB2 PHY. In such

Re: [PATCH] chipidea: ci13xxx_imx: Access phy via private data

2013-06-25 Thread Alexander Shishkin
Fabio Estevam fabio.este...@freescale.com writes: commit ea1418b5f1a (usb: chipidea: i.MX: use devm_usb_get_phy_by_phandle to get phy) causes the USB host to miss the disconnect/connect events. In order to reproduce this problem: - Insert a USB thumb into the USB host port (connection is

[PATCH 0/1] usb: chipidea: imx fix

2013-06-25 Thread Alexander Shishkin
Hi, Here is one more fix for the usb-next. Fabio Estevam (1): usb: chipidea: ci_hdrc_imx: access phy via private data drivers/usb/chipidea/ci_hdrc_imx.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line

[PATCH 1/1] usb: chipidea: ci_hdrc_imx: access phy via private data

2013-06-25 Thread Alexander Shishkin
...@freescale.com Acked-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci_hdrc_imx.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb

Re: [RESEND PATCH v2 1/1] usb: fix build error without CONFIG_USB_PHY

2013-06-24 Thread Alexander Shishkin
Dunlap rdun...@infradead.org It's actually Felipe's turf, so needs either his ack or target his tree. I'm ok with this. FWIW, Acked-by: Alexander Shishkin alexander.shish...@linux.intel.com --- Changes for v2: - Using IS_ENABLED to MACRO define include/linux/usb/of.h | 16

Re: [PATCH 20/20] usb: chipidea: drop 13xxx infix

2013-06-24 Thread Alexander Shishkin
Greg KH gre...@linuxfoundation.org writes: On Thu, Jun 13, 2013 at 06:00:04PM +0300, Alexander Shishkin wrote: ci13xxx is bad for at least the following reasons: * people often mistype it * it doesn't add any informational value to the names it's used in * it needlessly attracts mail

Re: [PATCH 20/20] usb: chipidea: drop 13xxx infix

2013-06-14 Thread Alexander Shishkin
Peter Chen peter.c...@freescale.com writes: On Thu, Jun 13, 2013 at 06:00:04PM +0300, Alexander Shishkin wrote: ci13xxx is bad for at least the following reasons: * people often mistype it * it doesn't add any informational value to the names it's used in * it needlessly attracts mail

Re: [PATCH 1/3] usb: chipidea: add CSR SiRFSoC ci13xxx usb driver

2013-06-14 Thread Alexander Shishkin
Barry Song 21cn...@gmail.com writes: +if USB_CHIPIDEA_UDC USB_CHIPIDEA_HOST + +config USB_CHIPIDEA_SIRF + depends on ARCH_SIRF + bool SiRF USB controller ChipIdea driver binding + default y + help + Say Y here to enable sirf usb ChipIdea driver binding. + +config

Re: [PATCH 1/3] usb: chipidea: add CSR SiRFSoC ci13xxx usb driver

2013-06-14 Thread Alexander Shishkin
Barry Song 21cn...@gmail.com writes: 2013/6/14 Alexander Shishkin alexander.shish...@linux.intel.com: Barry Song 21cn...@gmail.com writes: +if USB_CHIPIDEA_UDC USB_CHIPIDEA_HOST + +config USB_CHIPIDEA_SIRF + depends on ARCH_SIRF + bool SiRF USB controller ChipIdea driver binding

[PATCH 09/20] usb: chipidea: udc: manage dynamic amount of tds with a linked list

2013-06-13 Thread Alexander Shishkin
-by: Felipe Balbi ba...@ti.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/debug.c | 19 +++-- drivers/usb/chipidea/udc.c | 161 +- drivers/usb/chipidea/udc.h | 11 +-- 3 files changed, 129 insertions

[PATCH 05/20] usb: chipidea: ci13xxx_imx: remove reg_vbus

2013-06-13 Thread Alexander Shishkin
'. Updating only the local reg_vbus is wrong, since we currently check for data-reg_vbus in the ci13xxx_imx_remove() function. In order to avoid such issue, just use 'data-reg_vbus' directly. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish

[PATCH 06/20] usb: chipidea: ci13xxx_imx: check if 'data-phy_np' is not NULL

2013-06-13 Thread Alexander Shishkin
From: Fabio Estevam fabio.este...@freescale.com Similarly as it is done in ci13xxx_imx_remove(), only calls of_node_put if data-phy_np is not NULL. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb

[PATCH 01/20] usb: chipidea: ci13xxx_imx: let device core handle pinctrl

2013-06-13 Thread Alexander Shishkin
fabio.este...@freescale.com Tested-by: Shawn Guo shawn@linaro.org Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci13xxx_imx.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea

[PATCH 03/20] usb: chipidea: udc: configure iso endpoints

2013-06-13 Thread Alexander Shishkin
Grzeschik m.grzesc...@pengutronix.de Reviewed-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/core.c |2 +- drivers/usb/chipidea/udc.c | 20 +++- drivers/usb/chipidea/udc.h |1 + 3 files

[PATCH 13/20] usb: chipidea: introduce dual role mode pdata flags

2013-06-13 Thread Alexander Shishkin
-by: Alexander Shishkin alexander.shish...@linux.intel.com --- .../devicetree/bindings/usb/ci13xxx-imx.txt|1 + drivers/usb/chipidea/core.c| 24 +++- include/linux/usb/chipidea.h |2 +- 3 files changed, 20 insertions(+), 7

[PATCH 11/20] usb: add devicetree helpers for determining dr_mode and phy_type

2013-06-13 Thread Alexander Shishkin
m...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/phy/Makefile |1 + drivers/usb/phy/of.c | 47

[PATCH 04/20] usb: chipidea: ci13xxx_imx: fix error path

2013-06-13 Thread Alexander Shishkin
structure. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci13xxx_imx.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b

[PATCH 00/20] usb: chipidea: updates for v3.11

2013-06-13 Thread Alexander Shishkin
. Everything is sparse, smatch, checkpatch and coccinelle clean. Alexander Shishkin (2): usb: chipidea: get rid of camelcase names usb: chipidea: drop 13xxx infix Andy Shevchenko (2): usb: chipidea: remove superfluous pci_set_drvdata(pci, NULL) usb: chipidea: move to pcim_* functions Fabio

[PATCH 02/20] usb: chipidea: usbmisc_imx: Staticize usbmisc_imx_drv_init/exit

2013-06-13 Thread Alexander Shishkin
' was not declared. Should it be static? Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/usbmisc_imx.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea

[PATCH 10/20] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-06-13 Thread Alexander Shishkin
-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci.h |1 + drivers/usb/chipidea/core.c |1 - drivers/usb/chipidea/udc.c | 192 +-- 3 files changed, 111 insertions(+), 83 deletions(-) diff --git a/drivers/usb

[PATCH 08/20] usb: chipidea: improve kconfig

2013-06-13 Thread Alexander Shishkin
), since chipidea core driver takes care of both host and device roles. Signed-off-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/Kconfig |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 14/20] usb: chipidea: ci13xxx-imx: move static pdata into probe function

2013-06-13 Thread Alexander Shishkin
-by: Sascha Hauer s.ha...@pengutronix.de Reviewed-by: Peter Chen peter.c...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci13xxx_imx.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 17/20] usb: chipidea: remove superfluous pci_set_drvdata(pci, NULL)

2013-06-13 Thread Alexander Shishkin
-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci13xxx_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/chipidea/ci13xxx_pci.c b/drivers/usb/chipidea/ci13xxx_pci.c index a2a6ac8..59fab90 100644 --- a/drivers/usb/chipidea/ci13xxx_pci.c +++ b

[PATCH 12/20] usb: chipidea: add PTW, PTS and STS handling

2013-06-13 Thread Alexander Shishkin
Grzeschik m.grzesc...@pengutronix.de Signed-off-by: Marc Kleine-Budde m...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- .../devicetree/bindings/usb/ci13xxx-imx.txt|5 ++ drivers/usb/chipidea/bits.h

[PATCH 15/20] usb: chipidea: usbmisc: use module_platform_driver

2013-06-13 Thread Alexander Shishkin
From: Philipp Zabel p.za...@pengutronix.de This patch converts the driver to use the module_platform_driver macro which makes the code smaller and a bit simpler. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Signed-off-by: Michael Grzeschik m...@pengutronix.de Signed-off-by: Alexander

[PATCH 18/20] usb: chipidea: move to pcim_* functions

2013-06-13 Thread Alexander Shishkin
From: Andy Shevchenko andriy.shevche...@linux.intel.com This patch makes error path cleaner and probe function tidier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea/ci13xxx_pci.c

[PATCH 16/20] usb: chipidea: i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-06-13 Thread Alexander Shishkin
From: Sascha Hauer s.ha...@pengutronix.de This patch converts the driver to use devm_usb_get_phy_by_phandle which makes the code smaller and a bit simpler. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb

[PATCH 07/20] usb: chipidea: ci13xxx_imx: remove 'phy_np'

2013-06-13 Thread Alexander Shishkin
From: Fabio Estevam fabio.este...@freescale.com There is no need to keep a local 'phy_np' as we can directly use the private structure in data-phy_np. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb

[PATCH 19/20] usb: chipidea: get rid of camelcase names

2013-06-13 Thread Alexander Shishkin
Since someone has added camelcase detection to checkpatch.pl, chipidea udc patches have been very noisy. To make everybody's life easier, this patch changes camelcase names into something more appropriate to the coding style. No functional changes. Signed-off-by: Alexander Shishkin

RE: [PATCH 10/20] usb: chipidea: udc: add multiple td support to hardware_{en,de}queue

2013-06-13 Thread Alexander Shishkin
Kerry Calvert kerry.calv...@micropower.com writes: [adding linux-usb back to the loop] Dude, what is with the spamming of this list? Cease and desist please These things are called patches. This is how they are distributed in linux kernel development process. Regards, -- Alex -- To

Re: [PATCH 14/20] usb: chipidea: ci13xxx-imx: move static pdata into probe function

2013-06-13 Thread Alexander Shishkin
Sergei Shtylyov sergei.shtyl...@cogentembedded.com writes: Hello. On 06/13/2013 06:59 PM, Alexander Shishkin wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de The pdata structure gets copied anyway inside ci13xxx_add_device by platform_device_add. We don't need to have it static

[PATCH 0/2] usb: chipidea: fixes for v3.10-rc5

2013-06-11 Thread Alexander Shishkin
Hi, Here are two fixes for v3.10-rc5, one of them is also applicable for -stable. Alexander Shishkin (2): usb: chipidea: fix no transceiver case usb: chipidea: fix id change handling drivers/usb/chipidea/core.c |3 ++- drivers/usb/chipidea/udc.c | 13 - 2 files changed

[PATCH 2/2] usb: chipidea: fix id change handling

2013-06-11 Thread Alexander Shishkin
Re-enable chipidea irq even if there's no role changing to do. This is a problem since b183c19f (USB: chipidea: re-order irq handling to avoid unhandled irqs); when it manifests, chipidea irq gets disabled for good. Cc: sta...@vger.kernel.org # v3.7 Signed-off-by: Alexander Shishkin

Re: [PATCH] chipidea: move to pcim_* functions

2013-06-10 Thread Alexander Shishkin
Andy Shevchenko andriy.shevche...@linux.intel.com writes: This patch makes error path cleaner and probe function tidier. ...but does not apply to chipidea tree. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- It assumes that removal of PCI_D0 and drvdata(NULL) were

Re: [PATCH] usb: chipidea: udc: add force-full-speed option

2013-06-10 Thread Alexander Shishkin
Michael Grzeschik m...@pengutronix.de writes: Hi, On Mon, Jun 10, 2013 at 04:52:06PM +0300, Alexander Shishkin wrote: Michael Grzeschik m...@pengutronix.de writes: From: Michael Grzeschik m.grzesc...@pengutronix.de This patch makes it possible to set the chipidea udc into full-speed

Re: [PATCH 7/7] usb: chipidea: udc: add force-full-speed option

2013-06-06 Thread Alexander Shishkin
Michael Grzeschik m...@pengutronix.de writes: From: Michael Grzeschik m.grzesc...@pengutronix.de This patch makes it possible to set the chipidea udc into full-speed only mode. It can be set by the oftree property force-full-speed. Signed-off-by: Michael Grzeschik

Re: [PATCH 2/7] USB: chipidea: ci13xxx-imx: move static pdata into probe function

2013-06-05 Thread Alexander Shishkin
Michael Grzeschik m...@pengutronix.de writes: Hi Alexander, On Fri, May 31, 2013 at 08:38:44PM +0200, Michael Grzeschik wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de The pdata structure gets copied anyway inside ci13xxx_add_device by platform_device_add. We don't need to have

Re: [PATCH 1/1] usb: chipidea: Improve kconfig

2013-06-04 Thread Alexander Shishkin
Peter Chen hzpeterc...@gmail.com writes: On Thu, May 9, 2013 at 3:51 AM, Randy Dunlap rdun...@infradead.org wrote: On 05/08/13 03:02, Peter Chen wrote: Randy Dunlap rdun...@infradead.org reported below problem at i386: drivers/built-in.o: In function `ci_hdrc_host_init': (.text+0x2ce75c):

Re: [PATCH 3/7] USB: chipidea: add PTW, PTS and STS handling

2013-06-04 Thread Alexander Shishkin
Michael Grzeschik m...@pengutronix.de writes: Hey Alex, On Mon, Jun 03, 2013 at 03:35:37PM +0300, Alexander Shishkin wrote: Michael Grzeschik m...@pengutronix.de writes: From: Michael Grzeschik m.grzesc...@pengutronix.de This patch makes it possible to configure the PTW, PTS and STS

Re: [PATCH 4/7] USB chipidea: introduce dual role mode pdata flags

2013-06-04 Thread Alexander Shishkin
Peter Chen hzpeterc...@gmail.com writes: On Mon, Jun 3, 2013 at 8:37 PM, Alexander Shishkin alexander.shish...@linux.intel.com wrote: Michael Grzeschik m...@pengutronix.de writes: From: Sascha Hauer s.ha...@pengutronix.de Even if a chipidea core is otg capable the board may

RE: [PATCH 1/1] usb: chipidea: Improve kconfig

2013-06-04 Thread Alexander Shishkin
Chen Peter-B29397 b29...@freescale.com writes: I did actually have this one in my tree, but since that time this commit 7c8bfed7aaeba690de30835fe89882e1047a55fd Author: David Rientjes rient...@google.com Date: Fri Apr 26 13:25:01 2013 -0700 usb, chipidea: fix link error when

Re: [PATCH 4/7] USB chipidea: introduce dual role mode pdata flags

2013-06-04 Thread Alexander Shishkin
Peter Chen hzpeterc...@gmail.com writes: On Tue, Jun 4, 2013 at 5:31 PM, Alexander Shishkin alexander.shish...@linux.intel.com wrote: Peter Chen hzpeterc...@gmail.com writes: On Mon, Jun 3, 2013 at 8:37 PM, Alexander Shishkin alexander.shish...@linux.intel.com wrote: Michael Grzeschik m

  1   2   3   4   >