[PATCH v3] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda --- v3: - removed #address-cells/#size-cells from ports node. Hi Krzysztof, This is next

Re: USB role switches, usb-connector, typec and device trees

On 12.06.2018 19:33, Mats Karrman wrote: > Hi Andrzej, > > On 2018-06-07 13:40, Andrzej Hajda wrote: > >> On 06.06.2018 23:36, Mats Karrman wrote: >>> Hello Gentlemen, >>> >>> I'm trying to get my head around USB role switches in connection with &g

Re: USB role switches, usb-connector, typec and device trees

On 06.06.2018 23:36, Mats Karrman wrote: > Hello Gentlemen, > > I'm trying to get my head around USB role switches in connection with Type-C > ports > and device-trees. So far I have not found much documentation, e.g. there are > no > device-tree bindings documented and really no good examples

Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

On 18.05.2018 09:38, Roger Quadros wrote: > On 18/05/18 08:39, Andrzej Hajda wrote: >> On 17.05.2018 18:06, kbuild test robot wrote: >>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings") >>> Signed-off-by: kbuild test robot <fenggu

Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

On 17.05.2018 18:06, kbuild test robot wrote: > Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings") > Signed-off-by: kbuild test robot <fengguang...@intel.com> It should be static of course, my bad. Reviewed-by: Andrzej Hajda <a.ha...@samsung.

[PATCH v2 0/2] USB: dwc3: get extcon device by OF graph bindings

property is not present, added code allowing to fallback to OTG block also in case of graph is not present [1]: https://marc.info/?i=20180131134435.12216-1-a.hajda%40samsung.com Regards Andrzej Andrzej Hajda (2): USB: dwc3: get extcon device by OF graph bindings arm64: dts: exynos: add OF graph betwee

[PATCH v2 1/2] USB: dwc3: get extcon device by OF graph bindings

extcon device is used to detect host/device connection. Since extcon OF property is deprecated, alternative method should be added. This method uses OF graph bindings to locate extcon. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/usb/dwc3/drd.

[PATCH v2 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../dts/exynos/exynos5433-tm2-common.dtsi

Re: [PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings

On 31.01.2018 16:57, Andrzej Hajda wrote: > extcon device is used to detect host/device connection. Since extcon > OF property is deprecated, alternative method should be added. > This method uses OF graph bindings to locate extcon. > > Signed-off-by: Andrzej Hajda <a.ha...@samsu

Re: [PATCH v4 01/13] dt-bindings: connector: add properties for typec

On 28.03.2018 18:06, Li Jun wrote: > Add bingdings supported by current typec driver, so user can pass > all those properties via dt. > > Signed-off-by: Li Jun > --- > .../bindings/connector/usb-connector.txt | 39 > ++ > 1 file changed, 39

Re: [PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

STEM) Serious omission, sorry for that. > > On 12/03/18 09:02, Andrzej Hajda wrote: >> On 09.03.2018 11:24, Roger Quadros wrote: >>> Hi, >>> >>> On 27/02/18 09:11, Andrzej Hajda wrote: >>>> These bindings allow to describe most known standard

Re: [PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

On 12.03.2018 08:02, Andrzej Hajda wrote: > On 09.03.2018 11:24, Roger Quadros wrote: >> Hi, >> >> On 27/02/18 09:11, Andrzej Hajda wrote: >>> These bindings allow to describe most known standard USB connectors >>> and it should be possible to extend it if ne

Re: [PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

On 09.03.2018 11:24, Roger Quadros wrote: > Hi, > > On 27/02/18 09:11, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be us

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

Hi Chanwoo, On 08.03.2018 02:52, Chanwoo Choi wrote: > Hi Andrzej, Archit, > > On 2018년 03월 07일 20:13, Andrzej Hajda wrote: >> Hi Chanwoo, Archit, >> >> On 07.03.2018 05:48, Chanwoo Choi wrote: >>> On 2018년 03월 07일 11:12, Chanwoo Choi wrote: >>>> H

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

On 07.03.2018 12:22, Krzysztof Kozlowski wrote: > On Wed, Mar 7, 2018 at 12:13 PM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> Hi Chanwoo, Archit, >> >> On 07.03.2018 05:48, Chanwoo Choi wrote: >>> On 2018년 03월 07일 11:12, Chanwoo Choi wrote: >>>> H

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

Hi Chanwoo, Archit, On 07.03.2018 05:48, Chanwoo Choi wrote: > On 2018년 03월 07일 11:12, Chanwoo Choi wrote: >> Hi Rob and Andrzej, >> >> On 2018년 03월 06일 21:53, Andrzej Hajda wrote: >>> Hi Rob, Chanwoo, Krzysztof, >>> >>> >>> On 27.02.2

Re: [PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

Hi Rob, Chanwoo, Krzysztof, On 27.02.2018 08:11, Andrzej Hajda wrote: > Hi, > > Thanks for reviews of previous iterations. > > This patchset introduces USB physical connector bindings, together with > working example. > I have removed RFC prefix - the patchset seems to be

Re: [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery

On 06.03.2018 10:38, Jun Li wrote: > Hi >> -Original Message- >> From: Andrzej Hajda [mailto:a.ha...@samsung.com] >> Sent: 2018年3月5日 17:59 >> To: Jun Li <jun...@nxp.com>; gre...@linuxfoundation.org; >> robh...@kernel.org; heikki.kroge...@linux.intel.c

Re: [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery

On 05.03.2018 08:00, Jun Li wrote: > >> -Original Message- >> From: Andrzej Hajda [mailto:a.ha...@samsung.com] >> Sent: 2018年2月27日 16:41 >> To: Jun Li <jun...@nxp.com>; gre...@linuxfoundation.org; >> robh...@kernel.org; heikki.kroge...@linux.intel.c

Re: [PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

On 02.03.2018 14:13, Heikki Krogerus wrote: > Hi, > > On Tue, Feb 27, 2018 at 08:11:29AM +0100, Andrzej Hajda wrote: >> +2. USB-C connector attached to CC controller (s2mm005), HS lines routed >> +to companion PMIC (max77865), SS lines to USB3 PHY and SBU to DisplayPort.

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

On 27.02.2018 23:26, Chanwoo Choi wrote: > Hi, > > On 2018년 02월 27일 21:05, Andrzej Hajda wrote: >> On 27.02.2018 12:08, Chanwoo Choi wrote: >>> Hi, >>> >>> On 2018년 02월 27일 16:11, Andrzej Hajda wrote: >>>> From: Maciej Purski <m.pur...

Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

On 27.02.2018 22:24, Rob Herring wrote: > On Wed, Feb 21, 2018 at 2:55 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com&g

[PATCH v6 5/6] extcon: add possibility to get extcon device by OF node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v5: func

Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

On 27.02.2018 12:08, Chanwoo Choi wrote: > Hi, > > On 2018년 02월 27일 16:11, Andrzej Hajda wrote: >> From: Maciej Purski <m.pur...@samsung.com> >> >> Currently MHL chip must be turned on permanently to detect MHL cable. It >> duplicates micro-USB control

Re: [PATCH v2 10/12] dt-bindings: connector: add properties for typec power delivery

ded typec properties are based on general usb connector bindings[1] > proposed by Andrzej Hajda. > - Use the standard unit suffixes as defined in property-units.txt. > > [1] https://patchwork.kernel.org/patch/10231447/ > > .../bindings/connector/usb-connector.txt | 43

[PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v4: - improved 'type' description (Rob), - improved description of 2nd example (Rob). v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting. v2: -

[PATCH v5 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v5: removed extra parenthesis (kbuild test robot) v4: added missing reg property in connector's port node (Krzysztof) --- .../boot/dts/exynos/exynos54

[PATCH v5 5/6] extcon: add possibility to get extcon device by OF node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v5: func

[PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v5: updated extcon API This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence,

[PATCH v5 0/6] dt-bindings: add bindings for USB physical connector

binding descriptions, added missing reg in dts. v3: Separate binding for Samsung 11-pin connector, added full-blown USB-C example. v2: I have addressed comments by Rob and Laurent, thanks Changes in datail are described in the patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add

[PATCH v5 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Reviewed-by: Rob Herring <r...@kernel.org> --- v4: - removed description of property inherited from usb-connector (Rob), - f

[PATCH v5 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-commo

Re: [PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

On 26.02.2018 16:21, Krzysztof Kozlowski wrote: > On Wed, Feb 21, 2018 at 9:55 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.ha...@samsung.c

Re: [PATCH v4 5/6] extcon: add possibility to get extcon device by OF node

On 21.02.2018 15:27, Andy Shevchenko wrote: > On Wed, Feb 21, 2018 at 10:55 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> Since extcon property is not allowed in DT, extcon subsystem requires >> another way to get extcon device. Lets try the simplest approach - g

[PATCH v4 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v4: - added missing reg property in connector's port node (Krzysztof) --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 32 --

[PATCH v4 1/6] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v4: - improved 'type' description (Rob), - improved description of 2nd example (Rob). v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting. v2: -

[PATCH v4 5/6] extcon: add possibility to get extcon device by OF node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v2: changed label to

[PATCH v4 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[PATCH v4 0/6] dt-bindings: add bindings for USB physical connector

binding for Samsung 11-pin connector, added full-blown USB-C example. v2: I have addressed comments by Rob and Laurent, thanks Changes in datail are described in the patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add bindings for USB physical connector dt-bindings: add bindings

[PATCH v4 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Reviewed-by: Rob Herring <r...@kernel.org> --- v4: - removed description of property inherited from usb-connector (Rob), - f

[PATCH v4 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-commo

Re: [RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

On 19.02.2018 15:28, Rob Herring wrote: > On Thu, Feb 15, 2018 at 11:39:15AM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to

Re: [RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

On 15.02.2018 13:14, Krzysztof Kozlowski wrote: > On Thu, Feb 15, 2018 at 11:39 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> OF graph describes MHL data lanes between MHL and respective USB >> connector. >> >> Signed-off-by: Andrzej Hajda <a.ha...@samsung

[RFC PATCH v2 5/6] extcon: add possibility to get extcon device by OF node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v2: changed label to

[RFC PATCH v2 4/6] arm64: dts: exynos: add OF graph between MHL and USB connector

OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH v2 1/6] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v3: - removed MHL port (samsung connector will have separate bindings), - added 2nd example for USB-C, - improved formatting v2: - moved connector type(A,B,C) to compatible string (Rob), - renamed size property to typ

[RFC PATCH v2 3/6] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-commo

[RFC PATCH v2 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH v2 2/6] dt-bindings: add bindings for Samsung micro-USB 11-pin connector

Samsung micro-USB 11-pin connector beside standard micro-USB pins, has pins dedicated to route MHL traffic. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../connector/samsung,usb-connector-11pin.txt | 51 ++ 1 file changed, 51 insertions(+) create mode

[RFC PATCH v2 0/6] dt-bindings: add bindings for USB physical connector

are also described in patches. Regards Andrzej Andrzej Hajda (5): dt-bindings: add bindings for USB physical connector dt-bindings: add bindings for Samsung micro-USB 11-pin connector arm64: dts: exynos: add micro-USB connector node to TM2 platforms arm64: dts: exynos: add OF graph between MHL

Re: [RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

On 07.02.2018 22:43, Rob Herring wrote: > On Mon, Feb 05, 2018 at 10:06:35AM +0100, Andrzej Hajda wrote: >> On 05.02.2018 07:08, Rob Herring wrote: >>> On Wed, Jan 31, 2018 at 02:44:31PM +0100, Andrzej Hajda wrote: >>>> These bindings allow to describe most

Re: [RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

On 05.02.2018 07:08, Rob Herring wrote: > On Wed, Jan 31, 2018 at 02:44:31PM +0100, Andrzej Hajda wrote: >> These bindings allow to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB connectors, beside USB can be used to

Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

On 01.02.2018 08:50, Krzysztof Kozlowski wrote: > On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete &

[PATCH 0/2] USB: dwc3: get extcon device by OF graph bindings

PHY -> MUIC -> USB-connector ^ MHL-bridge-^ More details and proposition of generic solution in first patch [1]: https://marc.info/?i=20180131134435.12216-1-a.hajda%40samsung.com Regards Andrzej Andrzej Hajda (2): USB: dwc3: get extc

[PATCH 1/2] USB: dwc3: get extcon device by OF graph bindings

extcon device is used to detect host/device connection. Since extcon OF property is deprecated, alternative method should be added. This method uses OF graph bindings to locate extcon. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- Hi all, This patch implements alternative method

[PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

OF graph describes USB data lanes between USB-PHY and respective MUIC. Since graph is present and DWC driver can use it to get extcon, obsolete extcon property can be removed. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dts

[RFC PATCH v2 0/5] dt-bindings: add bindings for USB physical connector

Hi, This patchset introduces USB physical connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. In v2 I have addressed comments by Rob and Laurent, thanks Changes are described in patches. Regards Andrzej Andrzej Hajda (4

[RFC PATCH v2 3/5] arm64: dts: exynos: add OF graph between MHL and USB connector

OF graph describes MHL data lanes between MHL and respective USB connector. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH v2 5/5] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH v2 4/5] extcon: add possibility to get extcon device by OF node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- v2: changed label to

[RFC PATCH v2 1/5] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- v2: - moved connector type(A,B,C) to compatible string (Rob), - renamed size property to type (Rob), - changed type description to be less confusing (Laurent), - removed vendor specific compatibles (implied by grap

[RFC PATCH v2 2/5] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.d

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Laurent, Thank you for the review. On 18.10.2017 17:11, Laurent Pinchart wrote: > Hi Andrzej, > > Thank you for the patch. > > On Thursday, 28 September 2017 16:07:27 EEST Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >>

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

On 06.10.2017 19:23, Rob Herring wrote: > On Fri, Oct 6, 2017 at 6:10 AM, Andrzej Hajda <a.ha...@samsung.com> wrote: >> Hi Rob, >> >> Thanks for review. >> >> On 06.10.2017 01:12, Rob Herring wrote: >>> On Thu, Sep 28, 2017 at 03:07:27PM +0200,

Re: [RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

Hi Rob, Thanks for review. On 06.10.2017 01:12, Rob Herring wrote: > On Thu, Sep 28, 2017 at 03:07:27PM +0200, Andrzej Hajda wrote: >> These bindings allows to describe most known standard USB connectors >> and it should be possible to extend it if necessary. >> USB conne

[RFC PATCH 4/4] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

ed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- This is rework of the patch by Maciej with following changes: - use micro-USB port bindings to get extcon, instead of extcon property, - fixed remove sequence, - fixed extcon get

[RFC PATCH 3/4] extcon: add possibility to get extcon device by of node

Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/extcon/extcon.c | 44 ++-- i

[RFC PATCH 0/4] dt-bindings: add bindings for USB physical connector

Hi, This patchset introduces USB connector bindings, together with working example. I have added comments in relevant patches to describe possible issues. Regards Andrzej Andrzej Hajda (3): dt-bindings: add bindings for USB physical connector arm64: dts: exynos: add micro-USB connector

[RFC PATCH 2/4] arm64: dts: exynos: add micro-USB connector node to TM2 platforms

Since USB connector bindings are available we can describe it on TM2(e). Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- .../boot/dts/exynos/exynos5433-tm2-common.dtsi | 47 -- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/arch/arm64/bo

[RFC PATCH 1/4] dt-bindings: add bindings for USB physical connector

appropriate graph bindings. Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- There are few things for discussion (IMO): 1. vendor specific connectors, I have added them here, but maybe better is to place them in separate files. 2. physical connector description - I have split it to

[PATCH 7/7] usb: gadget: fsl_qe_udc: fix IS_ERR_VALUE usage

-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/usb/gadget/udc/fsl_qe_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c index 53c0692..93d28cb 100644 --- a/drivers/usb/gadget/udc/fsl_qe_udc.c

[PATCH 0/7] fix IS_ERR_VALUE usage

http://permalink.gmane.org/gmane.linux.kernel/2120927 [2]: http://permalink.gmane.org/gmane.linux.kernel/2150581 Regards Andrzej Andrzej Hajda (7): netfilter: fix IS_ERR_VALUE usage MIPS: module: fix incorrect IS_ERR_VALUE macro usages drivers: char: mem: fix IS_ERROR_VALUE usage atmel-isi: fix IS_ERR

Re: [PATCH 00/38] Fixes related to incorrect usage of unsigned types

On 09/21/2015 03:42 PM, David Howells wrote: > Andrzej Hajda <a.hajda-sze3o3uu22jbdgjk7y7...@public.gmane.org> wrote: > >> Semantic patch finds comparisons of types: >> unsigned < 0 >> unsigned >= 0 >> The former is always false, the latter is al

[PATCH 27/38] usbnet: remove invalid check

skb->len is always non-negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/net/usb/

[PATCH 07/38] usb: host: ehci-msm: fix handling platform_get_irq result

The function can return negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> --- drivers/us

Re: [PATCH 00/21] On-demand device registration

On 06/10/2015 12:19 PM, Tomeu Vizoso wrote: On 10 June 2015 at 09:30, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Jun 2, 2015 at 12:14 PM, Tomeu Vizoso tomeu.viz...@collabora.com wrote: On 2 June 2015 at 10:48, Linus Walleij linus.wall...@linaro.org wrote: This is what systemd is