Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/ether.c | 39 ---
2 files changed, 37 insertions(+), 3 deletions(-)
diff --git
-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/g_ffs.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/g_ffs.c b/drivers/usb/gadget/g_ffs.c
index cd168bc..0d6dbee 100644
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_rndis.c | 69 --
drivers/usb
The u_rndis.ko module is used only by f_rndis_usb.ko module, so
the two can be merged.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |6 --
drivers/usb/gadget/Makefile |4 +---
2 files
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/ether.c | 41 -
2 files changed, 37 insertions(+), 5 deletions(-)
diff --git
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/multi.c | 40 ++--
2 files changed, 35 insertions(+), 6 deletions(-)
diff --git
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/nokia.c | 52 ---
2 files changed, 44 insertions(+), 9 deletions(-)
diff --git
of a preprocessor
conditional directives. After all users are converted, the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |3 +
drivers/usb/gadget/Makefile |2
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/multi.c | 41 +++--
2 files changed, 36 insertions(+), 6 deletions(-)
diff --git
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_ecm.c | 73 +-
drivers/usb
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/g_ffs.c | 75 ++-
2 files changed, 67 insertions(+), 9 deletions(-)
diff --git
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/multi.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/multi.c b/drivers/usb/gadget/multi.c
index 2371084..9f63fdf
In order to convert usb functions to the new function interface
they need to be compiled as modules. This patch creates a u_ether
module which will be used by the new functions.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/ether.c | 43 +--
2 files changed, 38 insertions(+), 6 deletions(-)
diff --git
conditional directives. After all users are converted, the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |3 +
drivers/usb/gadget/Makefile |2 +
drivers/usb
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/cdc2.c | 57 +++
2 files changed, 42 insertions(+), 16 deletions(-)
diff --git
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_eem.c | 57 --
drivers/usb
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/ether.c | 44 ++--
2 files changed, 39 insertions(+), 6 deletions(-)
diff --git
module.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |6 ++
drivers/usb/gadget/Makefile |2 ++
drivers/usb/gadget/ether.c |4 +++-
drivers/usb/gadget/g_ffs.c |2 +-
drivers/usb
conditional directives. After all users are converted, the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |3 +
drivers/usb/gadget/Makefile |2 +
drivers/usb
conditional directives. After all users are converted, the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |3 +
drivers/usb/gadget/Makefile |2 +
drivers/usb
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_ncm.c | 81 +-
drivers/usb
has been allocated with kzalloc anyway.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/acm_ms.c | 78 ---
2 files changed, 45 insertions(+), 34 deletions(-)
diff
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 66 ---
1 files
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig|1 +
drivers/usb/gadget/mass_storage.c | 118 +++-
2 files changed, 76 insertions(+), 43 deletions(-)
diff
this module can be eliminated by merging
it with the mass storage function's module.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |6 +
drivers/usb/gadget/Makefile |2 +
drivers
In order to prepare for the new function interface the f_mass_storage.c
needs to be compiled as a module, and so a header file will be required.
This patch factors out some code to a new f_mass_storage.h.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park
On Tuesday, February 26, 2013 6:57 PM Felipe Balbi wrote:
Hi,
On Tue, Feb 26, 2013 at 06:52:17PM +0100, Andrzej Pietrasiewicz wrote:
In order to convert to configfs the USB functions need to be converted
to the new interface from Sebastian, which also requires turning them
into separate
On Tuesday, February 26, 2013 7:28 PM Alan Stern wrote:
On Tue, 26 Feb 2013, Andrzej Pietrasiewicz wrote:
This is a continuation of this thread:
http://www.spinics.net/lists/linux-usb/msg78189.html
The prerequisite for providing the configfs interface for USB gadgets
and all
bige...@linutronix.de
[Andrzej Pietrasiewicz: resolved merge conflict: no acm_strings
in acm_alloc_basic_func and no acm_string_defs in acm_old_unbind;
bMaxPower is now MaxPower and is expressed with different numbers]
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off
bige...@linutronix.de
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
---
drivers/usb/gadget/Kconfig|1 +
drivers/usb/gadget/f_acm.c| 83 +++-
drivers/usb/gadget/nokia.c| 82 +++-
drivers/usb
utiltiy
module)
The series depends on Sebastian's series found here:
http://www.spinics.net/lists/linux-usb/msg76378.html
@Sebastian: Felipe reports that there are problems with applying some of
the patches in your series. Are you willing to fix the problem?
Andrzej Pietrasiewicz (9):
usb/gadget
this module can be eliminated by merging
it with the mass storage function's module.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |6 +
drivers/usb/gadget/Makefile |2 +
drivers/usb
has been allocated with kzalloc anyway.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 14 +++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/acm_ms.c | 78 ---
2 files changed, 45 insertions(+), 34 deletions(-)
diff
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 66 ---
1 files
In order to prepare for the new function interface the f_mass_storage.c
needs to be compiled as a module, and so a header file will be required.
This patch factors out some code to a new f_mass_storage.h.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park
The u_ms.ko utility module is now used only by the f_mass_storage.ko module,
so there is no point in splitting the code into two modules.
This patch merges the two into one while keeping their corresponing source
code files compiled separately.
Signed-off-by: Andrzej Pietrasiewicz andrze
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/multi.c | 69 +++-
2 files changed, 50 insertions(+), 20 deletions(-)
diff --git
by means of a preprocessor conditional
directives. After all users are converted, the old interface can be removed.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |3 +
drivers/usb/gadget
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig|1 +
drivers/usb/gadget/mass_storage.c | 118 +++-
2 files changed, 76 insertions(+), 43 deletions(-)
diff
On Tuesday, January 15, 2013 1:03 PM Sebastian Andrzej Siewior wrote:
snip
usb_function_driver.
I would call the structure in question usb_function_module.
Or even better: usb_function_pool - you get usb_functions from it.
Please see inline for what it looks like.
Not sure I can agree
Hello Sebastian,
On Sunday, December 23, 2012 9:10 PM Sebastian Andrzej Siewior wrote:
Subject: [PATCH 06/30] usb/gadget: add some infracture to
register/unregister functions
This patch provides an infrastructure to register unregister a USB
function. This allows to turn a function into a
Hello Sebastian,
Please see below
On Thursday, January 03, 2013 4:38 PM I wrote:
Subject: RE: [PATCH 06/30] usb/gadget: add some infracture to
register/unregister functions
snip
+#define DECLARE_USB_FUNCTION(_name, _inst_alloc, _func_alloc)
\
+ static struct
Hello Joel,
So you are alive, I'm glad to hear from you ;) Thank you for your response.
On Saturday, December 08, 2012 12:18 AM Joel Becker wrote:
Subject: Re: [RFC][PATCH] fs: configfs: programmatically create config
groups
Hey Guys,
Sorry I missed this for a while. I'll make a
@Joel in particular: please see my comment in the bottom.
On Monday, December 10, 2012 12:57 PM I wrote:
Subject: RE: [RFC][PATCH] fs: configfs: programmatically create config
groups
Hello Joel,
So you are alive, I'm glad to hear from you ;) Thank you for your
response.
On Saturday,
On Monday, December 10, 2012 3:34 PM Felipe Balbi wrote:
Subject: Re: [RFC][PATCH] fs: configfs: programmatically create config
groups
Hi,
On Mon, Dec 10, 2012 at 03:17:34PM +0100, Andrzej Pietrasiewicz wrote:
@Joel in particular: please see my comment in the bottom.
On Monday
On Thursday, November 29, 2012 5:41 PM Sebastian Andrzej Siewior wrote:
Subject: [PATCH] fs/configfs: allow to create groups on demand
This patch adds a function add a group to an existing one and its
counterart. The newly created group behaves as it would be created via
default_groups[]
On Wednesday, November 28, 2012 7:51 PM Sebastian Andrzej Siewior wrote:
Subject: [RFC] usb/gadget: slow start of the configfs interface
|# modprobe dummy_hcd num=2
|# find /sys/kernel/config/ -ls
| 65470 drwxr-xr-x 5 root root0 Nov 28 19:39
/sys/kernel/config/
|
On Tuesday, November 27, 2012 5:00 PM Sebastian Andrzej Siewior wrote:
On 11/27/2012 09:57 AM, Andrzej Pietrasiewicz wrote:
|mkdir -p $FABRIC/naa.6001405c3214b06a/tpgt_1
|mkdir $FABRIC/naa.6001405c3214b06a/tpgt_1/lun/lun_0
|mkdir $FABRIC/naa.6001405c3214b06a/tpgt_1/lun/lun_1
So you
On Wednesday, November 28, 2012 9:39 AM Sebastian Andrzej Siewior wrote:
snip
so that we can create the endpoint directories.
And now what? What names shall the user use for the endpoint
directories? Oh, that's simple: just see what the endpoint
directories' names are. But wait, aren't
can
create_groups at will.
I kindly ask for comments. In particular, I would like to discuss
if this is the right approach. A counterpart to remove config groups
is also required. It is not implemented in this patch, though. What are
your opinions?
Andrzej Pietrasiewicz (1):
fs: configfs: allow
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
fs/configfs/dir.c|5 +++--
include/linux/configfs.h |2 ++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
On Thursday, November 22, 2012 3:37 PM Sebastian Andrzej Siewior wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:54 [+0100]:
My intention is not to add new gadgets, but to promote the use of
usb function modules, e.g. f_mass_storage.ko.
finally.
I don't use the usbf_option stuff, though
On Thursday, November 22, 2012 3:55 PM Sebastian Andrzej Siewior wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:55 [+0100]:
snip
diff --git a/include/linux/usb/composite.h
b/include/linux/usb/composite.h
index e84c754..5bac1f8 100644
--- a/include/linux/usb/composite.h
+++ b/include
Hello Sebastian,
As far as many of your comments are concerned, I agree and do not reply
to them. For others I agree and reply, and for yet others I reply ;)
Please see inline.
On Thursday, November 22, 2012 5:57 PM Sebastian Andrzej Siewior wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:56
On Thursday, November 22, 2012 9:09 PM Michal Nazarewicz wrote:
* Andrzej Pietrasiewicz | 2012-11-22 13:06:54 [+0100]:
During its lifetime, the mass storage can require creating lunX
directories for its luns. And again, with usbf_option
On Thu, Nov 22 2012, Sebastian Andrzej Siewior wrote
Hello Michał,
Thanks for comments, I generally agree.
On Thursday, November 22, 2012 10:00 PM Michal Nazarewicz wrote:
snip
Then specific functions to be run follow, e.g.:
echo MassStorage /cfg/usb-function-gadget/G1/C1/F1/name
Why not
mkdir
On Thursday, November 22, 2012 10:07 PM Michal Nazarewicz wrote:
On Thu, Nov 22 2012, Andrzej Pietrasiewicz wrote:
@@ -45,10 +46,9 @@
#define VLDBG(lun, fmt, args...) do { } while (0) #endif /*
VERBOSE_DEBUG */
-#define LDBG(lun, fmt, args...) dev_dbg ((lun)-dev, fmt, ## args
On Thursday, November 22, 2012 11:00 PM Michal Nazarewicz wrote:
snip
+
+#define UFG_MODULE (UFG_SUBSYSTEM-subsys.su_group.cg_item.ci_type-
ct_owner)
I cannot seem to find UFG_SUBSYSTEM anywhere.
Because it is not here... It is exported from the usb_functions.c.
That's also why it
pre_eject and post_eject are not used by anyone. Removing them.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
drivers/usb/gadget/f_mass_storage.c | 15 +--
drivers
interfaces and endpoints directories in configfs
- added a local header file in drivers/usb/gadget
Andrzej Pietrasiewicz (13):
usb: composite: add make_group and add_function operations
usb: gadget: Add USB Functions Gadget
usb: gadget: example port of mass storage to UFG: create
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 112 ---
1 files changed, 0 insertions(+), 112 deletions(-)
diff --git a/drivers/usb/gadget
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 135 +++
drivers/usb/gadget/f_mass_storage.h |4 +-
2 files changed, 58 insertions(+), 81 deletions
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 215 +-
drivers/usb/gadget/f_mass_storage.h | 110 ++
2 files changed, 117 insertions
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/storage_common.c | 122 +++---
1 files changed, 97 insertions(+), 25 deletions(-)
diff --git a/drivers/usb/gadget/storage_common.c
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 60 --
drivers/usb/gadget/f_mass_storage.h |4 ++-
2 files changed, 52 insertions(+), 12 deletions
pre_eject and post_eject are not used by anyone. Removing them.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 15 +--
drivers/usb/gadget/f_mass_storage.h | 14
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig |4 ++
drivers/usb/gadget/Makefile |3 +
drivers/usb/gadget/f_mass_storage.c | 80 +--
3
functionality.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig|9 +
drivers/usb/gadget/Makefile |4 +
drivers/usb/gadget/ufg_mass_storage.c | 608
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 225 +++
1 files changed, 225 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget
-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig | 12 +
drivers/usb/gadget/Makefile|2 +
drivers/usb/gadget/usb_functions.c | 1067
drivers/usb/gadget
Using configfs to create/configure a usb gadget requires
providing a method to create config group for a usb function
and a wrapper for usb_add_function.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
include/linux/usb
Hello Felipe, Hello Sebastian,
On Tuesday, October 23, 2012 8:55 AM Felipe Balbi wrote:
snip
Hi,
On Mon, Oct 22, 2012 at 04:26:35PM +0200, Sebastian Andrzej Siewior wrote:
after a mkdir config0 you should allocate a struct usb_configuration for
this.
|+-function0
|
On Monday, October 22, 2012 1:03 PM Sebastian Andrzej Siewior wrote:
* Andrzej Pietrasiewicz | 2012-10-18 13:17:18 [+0200]:
Hello Sebastian,
Hi Andrzej,
snip
This should not happen, I should have put the module.
Even if the caller did call usb_put_function, the uf-mod is not set
Hello Sebastian,
Thank you for the patches. By no means am I questioning your work;
I have a question, though. Please see inline.
On Wednesday, October 17, 2012 9:07 PM Sebastian Andrzej Siewior wrote:
snip
+static struct usb_function *try_get_usb_function(const char *name)
+{
+ struct
Hello Sebastian,
Which Linux version does this patch apply to?
On Wednesday, October 17, 2012 9:07 PM Sebastian Andrzej Siewior wrote:
snip
Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de
---
drivers/usb/gadget/f_sourcesink.c | 70
-
Hello Felipe,
On Wednesday, October 17, 2012 3:56 PM Felipe Balbi wrote:
snip
On Wed, Oct 17, 2012 at 11:43:11AM +0200, Andrzej Pietrasiewicz wrote:
Demonstrate a USB gadget configured entirely through configfs.
This is a work in progress.
snip
this is wrong. we don't want *another
the symlinks.
And here is the question: does it sound reasonable?
Andrzej Pietrasiewicz (2):
usb: gadget: Add USB Functions Gadget
usb: gadget: example port of mass storage to UFG
drivers/usb/gadget/Kconfig | 12 +
drivers/usb/gadget/Makefile |2 +
drivers/usb/gadget
Demonstrate a USB gadget configured entirely through configfs.
This is a work in progress.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/Kconfig | 12 +
drivers/usb/gadget/Makefile|2
An example port of a usb function to the USB functions gadget.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 635 +++
drivers/usb/gadget/storage_common.c
Hi Felipe,
On September 19, 2012 2:18 PM Felipe Balbi wrote:
snip
I wouldn't make functionN a directory. I think it's better to:
echo f_mass_storage /cfg/usb-function-gadget/ufg/config0/function0
I'd like to comment a little on your suggestion. In configfs there are
config items, which
On Tuesday, September 18, 2012 6:10 PM Alan Stern wrote:
snip
$ mkdir /cfg/usb-function-gadget/ufg/config1/function1/\
f_mass_storage
Speaking of no purpose, what is the reason
for .../function1/f_mass_storage ? Is there anything besides name and
f_mass_storage under function1?
Hello Sebastian,
On September 17, 2012 6:15 PM Sebastian Andrzej Siewior wrote:
snip
--- a/drivers/usb/gadget/storage_common.c
+++ b/drivers/usb/gadget/storage_common.c
@@ -321,7 +507,7 @@ enum {
#ifndef FSG_NO_OTG
static struct usb_otg_descriptor
fsg_otg_desc = {
-.bLength =
Enable calling usb_remove_config by gadgets.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/composite.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget
Add USB functions gadget configured entirely through configfs.
This is the base for adding USB functions to it. The next patch
in the series demonstrates how to add functions.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
An example port of a usb function to the USB functions gadget.
Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/usb/gadget/f_mass_storage.c | 658 +++
drivers/usb/gadget/storage_common.c
On Wednesday, August 29, 2012 9:35 PM Sebastian Andrzej Siewior wrote:
snip
Okay. Dear ccg gadget submitter: Do you still need that code in staging
tree or is it okay if it gets removed?
Dear Sebastian,
Thank you for asking for my opinion. I would like to say that we need ccg
in the tree.
On Friday, August 31, 2012 12:12 PM Felipe Balbi wrote:
snip
Unless it can be proven that ccg has active users, we should get rid of it
for now before someone starts using it and we need to maintain the ABI for
the next 10 years.
We need a configurable composite gadget in the Tizen platform
Hello Joel,
On Monday, August 20, 2012 8:00 AM Joel Becker wrote:
snip
I think what you want here is a symlink. Create a directory high in
the tree called 'ready' or 'available', and when you want to lock the
device in place, symlink it into that directory. This will pin the item.
Hello Sebastian,
On Monday, August 20, 2012 1:01 PM Sebastian Andrzej Siewior wrote
snip
That would be something like
$ ln -s /cfg/usb-function-gadget/G1 \
/cfg/usb-function-gadget/udcs/udc1/
Where we bind the complete gadget (G1) including the mass storage
configuration
Hello Joel,
Thanks for your reply.
On Monday, August 20, 2012 8:00 AM Joel Becker wrote:
I think what you want here is a symlink. Create a directory
high in the tree called 'ready' or 'available', and when you want to
lock the device in place, symlink it into that directory. This
Hello Sebastian, Hello Joel,
On Friday, August 17, 2012 11:22 AM Sebastian Andrzej Siewior wrote:
snip
There is a separation between setting myself up and seeing that a host
wants to talk to me. You are a woman. And if you not done yet done you
ignore
the host until you are ready. Can also
Dear Joel,
Thank you for your review.
@Sebastian, Alan, Felipe: Thank you, too.
On Monday, July 02, 2012 11:09 AM Joel Becker wrote:
snip
As a prerequisite it adds an operation to configfs. The operation allows
checking if it is ok to remove a pseudo directory corresponding to a
1101 - 1195 of 1195 matches
Mail list logo
