On 5/1/2019 05:55, Doug Anderson wrote:
> Hi,
>
> On Tue, Apr 30, 2019 at 12:11 AM Artur Petrosyan
> wrote:
>>
>> Hi,
>>
>> On 4/29/2019 21:35, Doug Anderson wrote:
>>> Hi,
>>>
>>> On Mon, Apr 29, 2019 at 4:03 AM Artur Petrosy
On 4/30/2019 19:29, Doug Anderson wrote:
> Hi,
>
> On Mon, Apr 29, 2019 at 11:59 PM Artur Petrosyan
> wrote:
>>
>> On 4/29/2019 21:34, Doug Anderson wrote:
>>> Hi,
>>>
>>> On Mon, Apr 29, 2019 at 3:51 AM Artur Petrosyan
>>> wrote:
On 4/30/2019 19:23, Doug Anderson wrote:
> Hi,
>
> On Tue, Apr 30, 2019 at 5:45 AM Artur Petrosyan
> wrote:
>>
>>> If setting "power_down = 0" is wrong then please update your patch to
>>> remove all the mainline code that sets power_down to 0. P
On 4/29/2019 21:43, Doug Anderson wrote:
> Hi,
>
> On Mon, Apr 29, 2019 at 5:01 AM Artur Petrosyan
> wrote:
>>
>> Hi,
>>
>> On 4/27/2019 01:01, Doug Anderson wrote:
>>> Hi,
>>>
>>> On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan
Hi,
On 4/29/2019 21:41, Doug Anderson wrote:
> Hi,
>
> On Mon, Apr 29, 2019 at 4:30 AM Artur Petrosyan
> wrote:
>>
>> Hi,
>>
>> On 4/27/2019 00:46, Doug Anderson wrote:
>>> Hi,
>>>
>>> On Fri, Apr 19, 2019 at 11:53 AM Artur Petros
Hi,
On 4/29/2019 21:35, Doug Anderson wrote:
> Hi,
>
> On Mon, Apr 29, 2019 at 4:03 AM Artur Petrosyan
> wrote:
>>
>> Hi,
>>
>> On 4/27/2019 00:45, Doug Anderson wrote:
>>> Hi,
>>>
>>> On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosya
On 4/29/2019 21:34, Doug Anderson wrote:
> Hi,
>
> On Mon, Apr 29, 2019 at 3:51 AM Artur Petrosyan
> wrote:
>>
>> On 4/27/2019 00:43, Doug Anderson wrote:
>>> Hi,
>>>
>>> On Fri, Apr 12, 2019 at 6:38 AM Artur Petrosyan
>>> wrote:
>
Hi,
On 4/27/2019 01:01, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan
> wrote:
>>
>> Added a new flow of entering and exiting hibernation when PC is
>> hibernated or suspended.
>>
>> Signed-off-by: Artur Petrosyan
On 4/27/2019 00:52, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan
> wrote:
>>
>> To avoid working in two modes (partial power down
>> and hibernation) changed conditions for entering
>> partial power down or hi
Hi,
On 4/27/2019 00:46, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 19, 2019 at 11:53 AM Artur Petrosyan
> wrote:
>>
>> - Added a default param "power_saving" to enable or
>>disable hibernation or partial power down features.
>>
>&g
Hi,
On 4/27/2019 00:45, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan
> wrote:
>>
>> - In dwc2_port_suspend() function added waiting for the
>>HPRT0.PrtSusp register field to be set.
>>
>> - In _dwc2_hcd_suspend
Hi,
On 4/27/2019 00:44, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 19, 2019 at 1:05 PM Artur Petrosyan
> wrote:
>>
>> @@ -426,8 +438,6 @@ static void dwc2_handle_wakeup_detected_intr(struct
>> dwc2_hsotg *hsotg)
>> /* Change to L0 state */
On 4/27/2019 00:43, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 12, 2019 at 6:38 AM Artur Petrosyan
> wrote:
>>
>> - Added backup of DCFG register.
>> - Added Set the Power-On Programming done bit.
>>
>> Signed-off-by: Artur Petrosyan
>> ---
>&
Hi,
On 4/25/2019 16:43, Felipe Balbi wrote:
> Artur Petrosyan writes:
>> This patch set, fixes and improves partial power down and hibernation power
>> saving modes. Also, adds support for entering/exiting hibernation by
>> system issued suspend/resume.
>>
>> T
is restored which is the solution described above.
- Increased the waiting timeout for HPRT0.PrtSusp register field
to be set. Because on HiKey 960 board HPRT0.PrtSusp wasn't
generated with the existing timeout.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
dr
port.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/core_intr.c | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
index 19ae2595f1c3..06f8022b1bdb 100644
--- a/drivers/usb/dwc2/core_i
core.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/core.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
index fb471d18a3de..fbbd6a2f10ad 100644
--- a/drivers/usb/dwc2/core.c
+++ b/drivers/usb/dwc2/core.c
@@ -532,6 +532,12
exits from gadget
hibernation.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/gadget.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index dcb0fbb8bc42..8c3e1f1c1b0f 100644
--- a/drivers/usb/dwc2
Added a new flow of entering and exiting hibernation when PC is
hibernated or suspended.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/hcd.c | 128 +++--
1 file changed, 81 insertions(+), 47 deletions(-)
diff --git a/drivers/usb/dwc2/hcd.c b
: Artur Petrosyan
---
drivers/usb/dwc2/core.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
index 55d5ae2a7ec7..fb471d18a3de 100644
--- a/drivers/usb/dwc2/core.c
+++ b/drivers/usb/dwc2/core.c
@@ -141,6 +141,8 @@ int
Hi,
On 4/18/2019 19:55, Doug Anderson wrote:
> Hi,
>
> On Thu, Apr 18, 2019 at 5:41 AM Minas Harutyunyan
> wrote:
>> Did you consider/reviewed patch series from Artur Petrosyan "[PATCH
>> 00/14] usb: dwc2: Fix and improve power saving modes" (submitted on
>&
- Added backup of DCFG register.
- Added Set the Power-On Programming done bit.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/gadget.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 6812a8a3a98b..dcb0fbb8bc42
partial power down mode).
Because if there is no device connected there would
be no need to enter partial power down mode.
- Added "hsotg->bus_suspended = true" beceuse after
entering partial power down in host mode the
bus_suspended flag must be set.
Signed-off-by: Artur P
ccrue from a soft reset.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/hcd.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 8367902a47eb..54450fa352cf 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/
in dwc2_hsotg_irq
GINTSTS_RESETDET flow without checking if lx_state == DWC2_L2
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/core_intr.c | 2 +-
drivers/usb/dwc2/gadget.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/d
eed02b9fe96 usb: dwc2: Fix wakeup detected and session request
interrupt handlers.
Artur Petrosyan (14):
usb: dwc2: Fix dwc2_restore_device_registers() function.
usb: dwc2: Add descriptive debug messages for Partial Power Down mode.
usb: dwc2: Fix wakeup detected and session request int
Added port connection status checking which prevents exiting from
Partial Power Down mode from _dwc2_hcd_resume() when no entering
to Partial Power Down mode happened.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/hcd.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
- Added a default param "power_saving" to enable or
disable hibernation or partial power down features.
- Printed hibernation param in hw_params_show and
power_saving param in params_show.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/core
is asserted.
To avoid restore done interrupt storm after restore is generated
clear GINTSTS_RESTOREDONE bit in GINTSTS register.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/core.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
Partial Power Down) based on
OTG_EN_PWROPT.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/core_intr.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
index 06f8022b1bdb
Hi Jules,
On 4/12/2019 18:21, Jules Maselbas wrote:
> Hi Artur,
>
> On Fri, Apr 12, 2019 at 01:38:56PM +0000, Artur Petrosyan wrote:
>> In host mode port power must be turned on when wakeup
>> detected or session request interrupt is detected.
>> Because, otherw
ccrue from a soft reset.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/hcd.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 8367902a47eb..54450fa352cf 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/
Added port connection status checking which prevents exiting from
Partial Power Down mode from _dwc2_hcd_resume() when no entering
to Partial Power Down mode happened.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/hcd.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
partial power down mode).
Because if there is no device connected there would
be no need to enter partial power down mode.
- Added "hsotg->bus_suspended = true" beceuse after
entering partial power down in host mode the
bus_suspended flag must be set.
Signed-off-by: Artur P
port.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/core_intr.c | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
index 19ae2595f1c3..ce523fd2b1b4 100644
--- a/drivers/usb/dwc2/core_i
- Added backup of DCFG register.
- Added Set the Power-On Programming done bit.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/gadget.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 6812a8a3a98b..dcb0fbb8bc42
: Artur Petrosyan
---
drivers/usb/dwc2/core.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
index 55d5ae2a7ec7..fb471d18a3de 100644
--- a/drivers/usb/dwc2/core.c
+++ b/drivers/usb/dwc2/core.c
@@ -141,6 +141,8 @@ int
This patch set, fixes and improves partial power down and hibernation power
saving modes. Also, adds support for entering/exiting hibernation from
system issued suspend/resume.
Artur Petrosyan (14):
usb: dwc2: Fix dwc2_restore_device_registers() function.
usb: dwc2: Add descriptive debug
Hi Marek,
On 12/6/2018 18:20, Marek Szyprowski wrote:
> Hi Artur,
>
> On 2018-12-04 15:28, Artur Petrosyan wrote:
>> On 11/20/2018 19:38, Marek Szyprowski wrote:
>>> Power down feature of DWC2 module integrated in Samsung SoCs doesn't work
>>> properly or ne
Hi Marek,
On 11/20/2018 19:38, Marek Szyprowski wrote:
> Power down feature of DWC2 module integrated in Samsung SoCs doesn't work
> properly or needs some additional handling in PHY or SoC glue layer, so
> disable it for now. Without disabling power down, DWC2 causes random memory
> trashes and f
GLPMCFG_LPM_ACCEPT_CTRL_ISOC.
GLPMCFG_LPM_ACCEPT_CTRL_CONTROL is defined for further use.
- Added setting GLPMCFG_LPM_ACCEPT_CTRL_ISOC bit in GLPMCFG
register in dwc2_gadget_init_lpm function.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/gadget.c | 1 +
drivers
According to the databook DCTL_RMTWKUPSIG bit
is defined in DCTL register not in DCFG.
Updated setting DCTL_RMTWKUPSIG bit to DCTL
register.
Fixes: 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas H
RETRY_CNT_1 22
#define GLPMCFG_RETRY_CNT_2 23
to
#define GLPMCFG_LPM_ACCEPT_CTRL_CONTROLBIT(21)
#define GLPMCFG_LPM_ACCEPT_CTRL_ISOC BIT(22)
- Set GLPMCFG_LPM_ACCEPT_CTRL_ISOC bit in GLPMCFG
register in dwc2_gadget_init_lpm function
Hi Sergei,
On 10/30/2018 19:02, Sergei Shtylyov wrote:
> Hello!
>
> On 10/30/2018 03:26 PM, Artur Petrosyan wrote:
>
>> To accept LPM token during ISOC transfers when TxFIFO
>> is not empty.
>>
>> Signed-off-by: Artur Petrosyan
>> Signed-off-by: Minas
Hi Balbi,
On 10/30/2018 16:33, Felipe Balbi wrote:
>
> Hi,
>
> Artur Petrosyan writes:
>
>> 1. This patch set fixes WkupAlert interrupt handler.
>> 2. Adds support to accept LPM token when TxFIFO
>> is not empty.
>>
>> NOTE: Request to add th
Hi Balbi,
On 10/30/2018 16:35, Felipe Balbi wrote:
>
> Hi,
>
> Artur Petrosyan writes:
>> To accept LPM token during ISOC transfers when TxFIFO
>> is not empty.
>
> this commit log tells me nothing. Why do you need this patch? Why CNT1
> and not CNT0 or CNT
Hi Balbi,
On 10/30/2018 16:34, Felipe Balbi wrote:
>
> Hi,
>
> Artur Petrosyan writes:
>> According to the databook DCTL_RMTWKUPSIG bit
>> is defined in DCTL register not in DCFG.
>>
>> Updated setting DCTL_RMTWKUPSIG bit to DCTL
>> register.
>>
To accept LPM token during ISOC transfers when TxFIFO
is not empty.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/gadget.c | 1 +
drivers/usb/dwc2/hw.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb
1. This patch set fixes WkupAlert interrupt handler.
2. Adds support to accept LPM token when TxFIFO
is not empty.
NOTE: Request to add this patch set on "tag: usb-for-v4.20"
Artur Petrosyan (2):
usb: dwc2: gadget: Fix WkupAlert interrupt handler.
usb: dwc2: gadget: Accept LPM
According to the databook DCTL_RMTWKUPSIG bit
is defined in DCTL register not in DCFG.
Updated setting DCTL_RMTWKUPSIG bit to DCTL
register.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hi John,
On 9/28/2018 22:33, John Stultz wrote:
> On Thu, Sep 27, 2018 at 5:33 AM, Artur Petrosyan
> wrote:
>> We would like to buy the HiKey board to perform testes.
>> We found this HiKey LeMaker to have USB 2.0 ports
>> https://urldefense.proof
Hi John,
On 9/28/2018 22:30, John Stultz wrote:
> On Tue, Sep 25, 2018 at 11:02 PM, Artur Petrosyan
> mailto:arthur.petros...@synopsys.com>>
> wrote:
> > On 9/25/2018 21:59, John Stultz wrote:
> >> On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan
> >>
Hi John,
On 9/25/2018 21:59, John Stultz wrote:
> On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan
> wrote:
>> Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey
>> regression caused by power_down feature"
>> https://urldefense.proofpoint.com
Hi John,
On 9/25/2018 21:59, John Stultz wrote:
> On Tue, Sep 25, 2018 at 3:04 AM, Artur Petrosyan
> wrote:
>> Just a clarification by this commit "[PATCH] usb: dwc2: Fix HiKey
>> regression caused by power_down feature"
>> https://urldefense.proofpoint.com
Hi John,
On 9/24/2018 22:52, John Stultz wrote:
> On Sun, Sep 23, 2018 at 10:57 PM, Artur Petrosyan
> wrote:
>> Hi John,
>>
>> On 9/21/2018 05:05, John Stultz wrote:
>>> On Thu, Sep 20, 2018 at 7:17 AM, Artur Petrosyan
>>> wrote:
>>>>
Hi John,
On 9/21/2018 05:05, John Stultz wrote:
> On Thu, Sep 20, 2018 at 7:17 AM, Artur Petrosyan
> wrote:
>> On 5/23/2018 01:57, John Stultz wrote:
>>> Its done automatically, when the OTG cable is detected it the host
>>> ports are disabled and when the OTG po
Hi John,
On 5/23/2018 01:57, John Stultz wrote:
> On Tue, May 22, 2018 at 7:24 AM, Minas Harutyunyan
> wrote:
>> Hi John,
>>
>> Please provide log with debug enabled configuration.
>
> Ok. Attached.
> For dmesg-broken.log: OTG removed at 77, and OTG plugged in at 82
> For dmesg-with-patch.log:
- Added a default param "power_saving" to enable or
disable hibernation or partial power down features.
- Printed hibernation param in hw_params_show and
power_saving param in params_show.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/core
Partial Power Down) based on
OTG_EN_PWROPT.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2/core_intr.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
index 19ae2595f1c3
This patch set, fixes and improves hibernation flow. Mainly, fixes
hibernation for switching between host and device modes.
Adds enabling/disabling of power optimization parameter.
Artur Petrosyan (3):
usb: dwc2: Add default param to control power optimization.
usb: dwc2: Update
other hand, if there is device hibernation
and changed to host, then exiting hibernation
for device mode with remote wake up.
- Removed workaround for ignore suspend interrupt before
enumeration.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
---
drivers/usb/dwc2
external vbus-supply
>
> drivers/usb/dwc2/hcd.c | 45
> ++---
> drivers/usb/dwc2/platform.c | 8
> 2 files changed, 42 insertions(+), 11 deletions(-)
>
Tested-by: Artur Petrosyan
The patchset has been tested on Synopsys HAPS-DX platform.
Thanks,
Artur
Martin,
On 7/4/2018 17:13, Martin Blumenstingl wrote:
> Hello Arthur, Hello Minas,
>
> On Wed, Jul 4, 2018 at 1:43 PM Artur Petrosyan
> wrote:
>>
>> Hello Martin,
>>
>> On 7/4/2018 01:39, Martin Blumenstingl wrote:
>>> Hello Minas,
>>>
&g
Hello Martin,
On 7/4/2018 01:39, Martin Blumenstingl wrote:
> Hello Minas,
>
> On Thu, May 10, 2018 at 11:44 AM Martin Blumenstingl
> wrote:
>>
>> Hello Minas,
>>
>> On Mon, May 7, 2018 at 3:27 PM, Minas Harutyunyan
>> wrote:
>>> Hi Martin,
>>>
>>> On 5/7/2018 12:28 AM, Martin Blumenstingl wrot
ni
>
> On Thu, May 17, 2018 at 04:04:01PM +0530, Manivannan Sadhasivam wrote:
>> Hi Artur,
>>
>> Thanks for the reply!
>>
>> On Thu, May 17, 2018 at 09:10:06AM +, Artur Petrosyan wrote:
>>> Hi Mani,
>>>
>>> We need some detailed information
suspend bit to be set.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/hcd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 1faefea16cec..736dcc816abf 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
Hi Mani,
We need some detailed information to perform debugging.
1. Could you please share the documentation of "96Boards HiKey" board, at least
dwc core configuration parameters. Or dump of GHWCFG1-4.
2. Could you please share with us full debug log of dwc2 loading and plug the
USB device.
3.
tored frame_number instead of
reading frame number.
In cases when target frame value is incremented
the frame_number is required to read again.
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/core.h | 7 ---
drivers/usb/dwc2/core_intr.c | 8
drivers/usb/dwc2/gadget.c
Crash caused by going out of "eps_out" array range.
Iteration on "eps_out" changed to less than "num_of_eps".
Signed-off-by: Artur Petrosyan
---
drivers/usb/dwc2/gadget.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dw
By clearing NAK status of EP, core will send ZLP
to IN token and assert NAK interrupt relying
on TxFIFO status only.
The WA applies only to core versions from 2.72a
to 4.00a (including both). Also for FS_IOT_1.00a
and HS_IOT_1.00a.
Signed-off-by: Artur Petrosyan
Signed-off-by: Minas Harutyunyan
70 matches
Mail list logo
