Hi Marcin,
On Mon, 9 Apr 2018 20:16:49 -0400
Marcin Ziemianowicz wrote:
> When a USB device is connected to the USB host port on the SAM9N12 then
> you get "-62" error which seems to indicate USB replies from the device
> are timing out. Looking around, I saw the USB bus was running at half
> sp
Hi Marcin,
On Mon, 9 Apr 2018 20:16:21 -0400
Marcin Ziemianowicz wrote:
> I noticed that when debugging some USB clocking issue that there weren't
> many ways to tell what the state of the USB clocking system was. This
> adds a few logging statements to see what the relevant code is trying to
>
Hi Marcin
On Mon, 9 Apr 2018 20:15:51 -0400
Marcin Ziemianowicz wrote:
> This is a series of patches which resolves set_rate() for the PLL not
> having any effect and therefore the USB Host port not working. Also, a
> few messages were added which may be helpful in the future when others
> are w
o take the mtd patches through the MTD
tree. As you've probably noticed, nand code has been moved around and
it's easier for me to carry those 2 simple changes in my tree than
creating an immutable branch.
Let me know if this is a problem.
Regards,
Boris
--
Boris Brezillon, B
On Thu, 28 Sep 2017 11:46:23 +0200
Romain Izard wrote:
> During backup mode, the contents of all registers will be cleared as the
> SoC will be completely powered down. For a product that boots on NAND
> Flash memory, the bootloader will obviously use the related controller
> to read the Flash an
On Wed, 27 Sep 2017 10:35:51 +0200
Romain Izard wrote:
> During backup mode, the contents of all registers will be cleared as the
> SoC will be completely powered down. For a product that boots on NAND
> Flash memory, the bootloader will obviously use the related controller
> to read the Flash an
Hi Romain,
On Fri, 15 Sep 2017 16:04:07 +0200
Romain Izard wrote:
> It is not normal for the PMECC to fail when trying to fix ECC errors.
> Report these cases as errors.
I'm not sure we want to have ECC error messages at this level. ECC
errors are rather unusual but not impossible, and sometime
Hi Romain,
On Fri, 15 Sep 2017 16:04:06 +0200
Romain Izard wrote:
> During backup mode, the contents of all registers will be cleared as the
> SoC will be completely powered down. For a product that boots on NAND
> Flash memory, the bootloader will obviously use the related controller
> to read
Le Sat, 19 Aug 2017 13:52:17 +0530,
Bhumika Goyal a écrit :
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
>
Applied to l2-mtd/master.
Thanks,
Boris
> Signed-off-by: Bhumika Goyal
> ---
> drivers/mtd/mtdcore.c | 2
On Tue, 6 Dec 2016 22:59:43 +0100
Boris Brezillon wrote:
> desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK is not necessarily
> equal to ep->index and that's perfectly fine. The usba endpoint index is
> just an internal identifier used by the driver to know which regi
Hi Felipe,
I realize I sent this patch to your old @ti.com email address. Do you
want me to resend it?
Regards,
Boris
On Tue, 6 Dec 2016 22:59:43 +0100
Boris Brezillon wrote:
> desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK is not necessarily
> equal to ep->index and
seless, but can also lead to
errors since nothing guarantees that the endpoint number and index are
matching when an endpoint is selected for a specific descriptor, thus
leading to errors at ->enable() time when it's already too late to choose
another endpoint.
Signed-off-by: Bori
worked
(but probably at a lower speed than it should have).
Signed-of-by: Douglas Gilbert
Reviewed-by: Boris Brezillon
Cc: #4.0+
Fixes: 9870d895ad87 ("usb: atmel_usba_udc: Mask status with enabled irqs")
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
1 file changed, 1 insertion(+),
Hi Felipe,
On Mon, 16 Nov 2015 11:17:56 -0600
Felipe Balbi wrote:
>
> Hi,
>
> Boris Brezillon writes:
> > Hi Douglas,
> >
> > On Sat, 14 Nov 2015 14:15:30 -0500
> > Douglas Gilbert wrote:
> >
> >> On 15-11-12 05:18 PM, Alan Stern wrote
r the inconvenience.
>
> If I don't hear anything on this issue then I can produce
> a patch. Does it go through the ARM or USB (or both) trees?
You can go ahead and send a patch to the ARM and USB MLs (+
appropriate maintainers), unless you want me to do it.
>
> If m
Hi Jiri,
On Tue, 16 Jun 2015 10:51:55 +0200
Jiří Prchal wrote:
>
>
> On 13.6.2015 13:13, Boris Brezillon wrote:
> > On Sat, 13 Jun 2015 13:09:56 +0200
> > Boris Brezillon wrote:
> >
> >> Hi Jiri,
> >>
> >> On Fri, 12 Jun 2015 11:30:20 +0
On Sat, 13 Jun 2015 13:09:56 +0200
Boris Brezillon wrote:
> Hi Jiri,
>
> On Fri, 12 Jun 2015 11:30:20 +0200
> Jiří Prchal wrote:
>
> >
> >
> > On 11.6.2015 15:53, Alan Stern wrote:
> > > On Thu, 11 Jun 2015, Jiří Prchal wrote:
> > >
> &
the ->determine_rate() has also changed between 3.18 and
3.19. Hopefully this patch will definitely fix the prototype mismatch
for 3.18.
Signed-off-by: Boris Brezillon
---
drivers/clk/at91/clk-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/at91/c
Now that the system clock driver is forwarding set_rate request to the
parent clock, we can safely call clk_set_rate on the system clk and get
rid of the uclk field.
Signed-off-by: Boris Brezillon
---
drivers/usb/host/ohci-at91.c | 18 +++---
1 file changed, 3 insertions(+), 15
Hello,
This series reworks clock handling in atmel USB host drivers, and while
doing so fixes a regression introduced by 3440ef1 (ARM: at91/dt: fix USB
high-speed clock to select UTMI).
Best Regards,
Boris
Boris Brezillon (5):
USB: ehci-atmel: rework clk handling
USB: host: ohci-at91
CLK_SET_RATE_GATE flag, which means the rate
cannot be changed once the clock is prepared
2/ The EHCI driver was retrieving and preparing/enabling the uhpck
clock which was in turn preparing its parent clock (the usb clock),
thus preventing any rate change because of 1/
Signed-off-by: Boris
Add documentation for the missing clocks, clock-names, reg and interrupts
properties.
Signed-off-by: Boris Brezillon
---
.../devicetree/bindings/usb/atmel-usb.txt | 25 ++
1 file changed, 25 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/atmel
The uhpck is useless for High-Speed communications, remove the reference
to this clock in all ehci definitions.
Signed-off-by: Boris Brezillon
---
arch/arm/boot/dts/at91sam9g45.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9x5.dtsi | 4 ++--
arch/arm/boot/dts/sama5d3.dtsi | 4 ++--
arch/arm/boot
The ohci driver now calls clk_set_rate on the uhpck clock (which forwards
set_rate requests to its parent: the usb clock).
Remove useless references to usb clocks from ohci definitions.
Signed-off-by: Boris Brezillon
---
arch/arm/boot/dts/at91rm9200.dtsi | 4 ++--
arch/arm/boot/dts/at91sam9260
ake it clearer ?
depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
And I wonder why you need that. I though this option was selected by all
at91 platforms ?
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To
On Sat, 7 Feb 2015 20:37:23 +0100
Sylvain Rochet wrote:
> Hello Nicolas,
>
>
> On Thu, Feb 05, 2015 at 06:19:55PM +0100, Nicolas Ferre wrote:
> > Le 22/01/2015 18:14, Boris Brezillon a écrit :
> > > On Thu, 22 Jan 2015 17:56:44 +0100
> > > Sylvain Rochet
olean,
> set to true if the board supports IRQ_TYPE_EDGE_FALLING and
> IRQ_TYPE_EDGE_RISING, otherwise set to false.
>
> Signed-off-by: Sylvain Rochet
Acked-by: Boris Brezillon
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 25 +++--
> drivers/
y:
Acked-by: Boris Brezillon
to the whole series.
Thanks for your patience.
Best Regards,
Boris
>
> Changes since v4:
> * Now using IRQ_NOAUTOEN flag to remove the unused check for
> udc->driver is not NULL in the Vbus IRQ.
> * Reworked the start/stop of clock
on a at91sam9x5 platform. Be careful,
this driver is used by older SoCs (at91sam9rl and avr32 SoCs) which do
not support configuring the interrupt on a specific edge (they trigger
on both edges).
This leaves two solutions here:
1) keep the IRQ_TYPE_EDGE_BOTH setting.
2) add new compatible stri
previously did. Naively copying IRQ flags
> currently set by the AIC looked like error-prone if defaults flags
> change at some point in the future.
>
> Signed-off-by: Sylvain Rochet
> Suggested-by: Boris Brezillon
> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 64
> +++
d) and MEM(wake-up
> disabled) sleep targets.
To the whole series:
Acked-by: Boris Brezillon
>
> Changes since v5:
> * Don't overwrite device wakeup flag with device_init_wakeup(),
> now using a private wakeup bool instead.
>
> Changes since v4:
> * Re-add at91_
ion of driver,
>
> Moreover the spinlock is (and was) unlocked in VBUS interrupt just
> before calling udc->driver->disconnect, which makes udc->driver actually
> not locked anywere.
>
> If the previous sequence possible ? If no, udc->driver does not n
in),
> - usba_vbus_irq, 0,
> + ret = devm_request_threaded_irq(&pdev->dev,
> + gpio_to_irq(udc->vbus_pin), NULL,
> + usba_vbus_irq_thread, IRQF_NO_SUSPEND |
> IRQF_ONE
int vbus;
> + int ret;
>
> /* debounce */
> udelay(10);
>
> - spin_lock(&udc->lock);
> + mutex_lock(&udc->vbus_mutex);
>
> /* May happen if Vbus pin toggles during probe() */
> - if (!udc->driver)
> + spin_l
Hi Lee,
On Sun, 18 Jan 2015 12:52:59 +
Lee Jones wrote:
> On Wed, 14 Jan 2015, Alexandre Belloni wrote:
>
> > From: Boris Brezillon
> >
> > AT91 SoCs have a memory range reserved for internal bus configuration.
> > Expose those registers so that drivers can
.pm = &ehci_atmel_pm_ops,
> }
> (...)
>
>
> Should I send a v4 or can I send this change separately on top of the
> previous change ?
I think it's better to send a v4 reworking this patch (you'll have to
change your commit subject anyway ;-)).
that this series
depends on another one: [1].
Anyway, thanks for removing these global variables.
>
> Signed-off-by: Sylvain Rochet
To the whole series:
Acked-by: Boris Brezillon
[1]https://www.mail-archive.com/linux-usb@vger.kernel.org/msg54675.html
--
Boris Brezillon, Free Ele
er save induced by this
> PLL deactivation. The resume penalty is about 500 us, which is not
> negligible but acceptable considering the amount of power we are saving.
>
> Signed-off-by: Sylvain Rochet
> Reported-by: Boris Brezillon
Acked-by: Boris Brezillon
> ---
>
On Sat, 17 Jan 2015 16:36:34 +0100
Sylvain Rochet wrote:
> This patch add suspend/resume support for Atmel EHCI, mostly
> about disabling and unpreparing clocks so USB PLL is stopped
> before entering sleep state.
>
> Signed-off-by: Sylvain Rochet
Acked-by: Boris Brezillon
&
On Mon, 12 Jan 2015 13:31:26 -0600
Felipe Balbi wrote:
> On Mon, Jan 12, 2015 at 08:18:16PM +0100, Boris Brezillon wrote:
> > Hi Felipe,
> >
> > On Mon, 12 Jan 2015 12:23:49 -0600
> > Felipe Balbi wrote:
> >
> > > On Mon, Jan 12, 2015
Hi Felipe,
On Mon, 12 Jan 2015 12:23:49 -0600
Felipe Balbi wrote:
> On Mon, Jan 12, 2015 at 11:57:56AM +0100, Boris Brezillon wrote:
> > at91sam9g45, at91sam9x5 and sama5 SoCs should not use
> > "atmel,at91sam9rl-udc" for their USB device compatible property sin
oggle_bias implementation to attach it to the "at91sam9rl-udc"
compatible string.
Add new compatible strings to avoid executing at91sam9rl erratum handling
on other SoCs.
Reported-by: Paul Bolle
Signed-off-by: Boris Brezillon
Acked-by: Alexandre Belloni
Acked-by: Nicolas Ferre
---
Change
Hi Paul,
On Mon, 12 Jan 2015 13:15:58 +0100
Paul Bolle wrote:
> On Mon, 2015-01-12 at 11:57 +0100, Boris Brezillon wrote:
> > at91sam9rl SoC has an erratum forcing us to toggle the BIAS on USB
> > suspend/resume events.
> >
> > This specific hand
at91sam9g45, at91sam9x5 and sama5 SoCs should not use
"atmel,at91sam9rl-udc" for their USB device compatible property since
this compatible is attached to a specific hardware bug fix.
Signed-off-by: Boris Brezillon
Acked-by: Alexandre Belloni
---
arch/arm/boot/dts/at91sam9g45.dtsi |
at91sam9g45 and at91sam9x5 SoCs have an hardware bug forcing us to
generate a pulse on the BIAS signal on "USB end of reset" and
"USB end of resume" events.
Reported-by: Patrice VILCHEZ
Signed-off-by: Boris Brezillon
Acked-by: Alexandre Belloni
---
drivers/usb/gadget/udc/a
Avoid interpreting useless status flags when we're not waiting for such
events by masking the status variable with the interrupt enabled register
value.
Reported-by: Patrice VILCHEZ
Signed-off-by: Boris Brezillon
Acked-by: Alexandre Belloni
---
drivers/usb/gadget/udc/atmel_usba_udc.
Cache INT_ENB register value in order to avoid uncached iomem access, and
thus improve access time to INT_ENB value.
Signed-off-by: Boris Brezillon
Acked-by: Alexandre Belloni
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 52 ++---
drivers/usb/gadget/udc
apply cleanly on those stable branches.
I'll send a backport of this series once it is merged in mainline.
Regards,
Boris
Changes since v2:
- remove UTF8 character in commit message of patch 2
Changes since v1:
- cache INT_ENB value to speedup INT_ENB read operations
Boris Brezillon (5):
removed.
Rework the toggle_bias implementation to attach it to the "at91sam9rl-udc"
compatible string.
Add new compatible strings to avoid executing at91sam9rl erratum handling
on other SoCs.
Signed-off-by: Boris Brezillon
Acked-by: Alexandre Belloni
---
.../devicetree/bindings/usb/atm
at91sam9g45, at91sam9x5 and sama5 SoCs should not use
"atmel,at91sam9rl-udc" for their USB device compatible property since
this compatible is attached to a specific hardware bug fix.
Signed-off-by: Boris Brezillon
---
arch/arm/boot/dts/at91sam9g45.dtsi | 2 +-
arch/arm/boot/dts/at91s
Avoid interpreting useless status flags when we're not waiting for such
events by masking the status variable with the interrupt enabled register
value.
Reported-by: Patrice VILCHEZ
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +-
1 file chang
at91sam9g45 and at91sam9x5 SoCs have an hardware bug forcing us to
generate a pulse on the BIAS signal on "USB end of reset” and
“USB end of resume" events.
Reported-by: Patrice VILCHEZ
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/atmel_usba_
removed.
Rework the toggle_bias implementation to attach it to the "at91sam9rl-udc"
compatible string.
Add new compatible strings to avoid executing at91sam9rl erratum handling
on other SoCs.
Signed-off-by: Boris Brezillon
---
.../devicetree/bindings/usb/atmel-usb.txt | 5 +
Cache INT_ENB register value in order to avoid uncached iomem access, and
thus improve access time to INT_ENB value.
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 52 ++---
drivers/usb/gadget/udc/atmel_usba_udc.h | 2 ++
2 files
apply cleanly on those stable branches.
I'll send a backport of this series once it is merged in mainline.
Regards,
Boris
Changes since v1:
- cache INT_ENB value to speedup INT_ENB read operations
Boris Brezillon (5):
usb: atmel_usba_udc: Rework at91sam9rl errata handling
usb: atmel_usb
On Mon, 15 Dec 2014 17:22:04 +
David Laight wrote:
> From: Boris Brezillon
> > Hi David,
> >
> > On Mon, 15 Dec 2014 13:34:56 +
> > David Laight wrote:
> >
> > > From: Sergei Shtylyov
> > > > Hello.
> > > >
> > &
Hi David,
On Mon, 15 Dec 2014 13:34:56 +
David Laight wrote:
> From: Sergei Shtylyov
> > Hello.
> >
> > On 12/15/2014 4:03 PM, Boris Brezillon wrote:
> >
> > > Avoid interpreting useless status flags when we're not waiting for such
> > &
On Mon, 15 Dec 2014 13:34:56 +
David Laight wrote:
> From: Sergei Shtylyov
> > Hello.
> >
> > On 12/15/2014 4:03 PM, Boris Brezillon wrote:
> >
> > > Avoid interpreting useless status flags when we're not waiting for such
> > > events
at91sam9g45, at91sam9x5 and sama5 SoCs should not use
"atmel,at91sam9rl-udc" for their USB device compatible property since
this compatible is attached to a specific hardware bug fix.
Signed-off-by: Boris Brezillon
---
arch/arm/boot/dts/at91sam9g45.dtsi | 2 +-
arch/arm/boot/dts/at91s
Avoid interpreting useless status flags when we're not waiting for such
events by masking the status variable with the interrupt enabled register
value.
Reported-by: Patrice VILCHEZ
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +-
1 file chang
at91sam9g45 and at91sam9x5 SoCs have an hardware bug forcing us to
generate a pulse on the BIAS signal on "USB end of reset” and
“USB end of resume" events.
Reported-by: Patrice VILCHEZ
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/atmel_usba_
apply cleanly on those stable branches.
I'll send a backport of this series once it is merged in mainline.
Regards,
Boris
Boris Brezillon (4):
usb: atmel_usba_udc: Rework at91sam9rl errata handling
usb: atmel_usba_udc: Add at91sam9g45 and at91sam9x5 errata handling
ARM: at91/dt: updat
removed.
Rework the toggle_bias implementation to attach it to the "at91sam9rl-udc"
compatible string.
Add new compatible strings to avoid executing at91sam9rl erratum handling
on other SoCs.
Signed-off-by: Boris Brezillon
---
.../devicetree/bindings/usb/atmel-usb.txt | 5 +
The driver is requesting clock by their global name (those declared in the
clk_lookup list), but this only works with !CCF kernels.
Now that all SoCs have moved to CCF, fix the driver to use local names
(hclk and pclk).
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/at91_udc.c | 4
The at91_udc driver request 2 clocks, and thus need them to be defined in
the device tree.
Document the clocks and clock-names properties so that everybody use the
correct names.
Signed-off-by: Boris Brezillon
---
Documentation/devicetree/bindings/usb/atmel-usb.txt | 4
1 file changed, 4
Now that at91 system clocks forward set_rate request to their parent we
can remove the uclk clock and directly call clk_set_rate on fclk.
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/at91_udc.c | 27 +++
drivers/usb/gadget/udc/at91_udc.h | 2 +-
2 files
Make use of devm_ functions to simplify probe and remove code.
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/at91_udc.c | 116 +-
1 file changed, 39 insertions(+), 77 deletions(-)
diff --git a/drivers/usb/gadget/udc/at91_udc.c
b/drivers/usb
Peripheral clock is named pclk and system clock is named hclk (those are
the names expected by the at91_udc driver).
Drop the deprecated usb_clk (formerly used to configure the usb clock rate
which is now directly configurable through hclk).
Signed-off-by: Boris Brezillon
---
arch/arm/boot/dts
Since non-DT board support has been removed from the at91 architecture we
can safely remove non-DT handling code.
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/Kconfig| 1 +
drivers/usb/gadget/udc/at91_udc.c | 16 ++--
2 files changed, 3 insertions(+), 14 deletions
/lkml/2014/12/3/230
Boris Brezillon (11):
usb: gadget: at91_udc: Fix clock names
usb: gadget: at91_udc: Drop uclk clock
usb: gadget: at91_udc: Document DT clocks and clock-names property
ARM: at91/dt: at91sam9261: fix clocks and clock-names in udc
definition
usb: gadget: at91_udc
cpu_is_at91xxx are a set of macros defined in mach/cpu.h and are here used
to detect the SoC we are booting on.
Use compatible string + a caps structure to replace those cpu_is_xxx tests.
Remove all mach and asm headers (which are now unused).
Signed-off-by: Boris Brezillon
---
drivers/usb
Allocate udc structure instead of relying on the statically declared
object.
Signed-off-by: Boris Brezillon
---
drivers/usb/gadget/udc/at91_udc.c | 101 ++
1 file changed, 27 insertions(+), 74 deletions(-)
diff --git a/drivers/usb/gadget/udc/at91_udc.c
b
Three compatible strings have been added to the at91_udc driver.
Update the documentation accordingly.
Signed-off-by: Boris Brezillon
---
Documentation/devicetree/bindings/usb/atmel-usb.txt | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree
Signed-off-by: Boris Brezillon
---
arch/arm/boot/dts/at91sam9261.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91sam9261.dtsi
b/arch/arm/boot/dts/at91sam9261.dtsi
index 7119f1f..e52ae97 100644
--- a/arch/arm/boot/dts/at91sam9261.dtsi
+++ b/arch/arm
The at91rm9200, at91sam9260, at91sam9261 and at91sam9263 SoCs have slightly
different UDC IPs.
Those differences were previously handled with cpu_is_at91xx macro which
are about to be dropped for multi-platform support, thus we need to
change compatible strings.
Signed-off-by: Boris Brezillon
is unsafe to call from there for the same reason. Move clock
> preparation and setting clock rate into process context (at91udc_probe).
>
> Signed-off-by: Ronald Wahl
Acked-by: Boris Brezillon
> ---
> v3 -> v4:
> - no code changes
> - update commit message
>
On Thu, 07 Aug 2014 14:43:32 +0200
Ronald Wahl wrote:
> On 07.08.2014 09:59, Boris BREZILLON wrote:
> > On Thu, 7 Aug 2014 09:52:31 +0200
> > Boris BREZILLON wrote:
> >> On Wed, 6 Aug 2014 15:11:42 +0200
> >> Ronald Wahl wrote:
> >>
> >>>
Adding USB and Atmel Maintainers in Cc.
On Thu, 7 Aug 2014 09:52:31 +0200
Boris BREZILLON wrote:
> Hi Ronald,
>
> On Wed, 6 Aug 2014 15:11:42 +0200
> Ronald Wahl wrote:
>
> > Commit 7628083227b6bc4a7e33d7c381d7a4e558424b6b added clock preparation in
> > int
is obviously a mismerge between two unrelated changes that
resulted in missing opening braces.
Thanks for fixing this: I was about to propose the same patch to resolve
the issue introduced by this merge (reported by Olof yesterday).
Signed-off-by: Arnd Bergmann
Acked-by: Boris BREZILLON
---
Please ju
Hello Olof,
On 06/01/2014 19:08, Olof Johansson wrote:
Boris,
On Mon, Dec 9, 2013 at 12:51 AM, Boris BREZILLON
wrote:
Replace the request_mem_region + ioremap calls by the
devm_ioremap_resource call which does the same things but with device
managed resources.
Signed-off-by: Boris BREZILLON
platforms.
Best Regards,
Boris
On 08/12/2013 15:59, Boris BREZILLON wrote:
When using dt resources retrieval (interrupts and reg properties) there is
no predefined order for these resources in the platform dev resources
table.
Retrieve resources using platform_get_resource and platform_get_irq
this function)
Changes since v3:
- replace devm_request_and_ioremap call by devm_ioremap_resource
Changes since v2:
- split urgent fix and resource retrieval improvements
Boris BREZILLON (3):
usb: ohci-at91: replace request_mem_region + ioremap by
devm_ioremap_resource
usb: ohci-at91: use
Replace clk_get calls by devm_clk_get calls.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 30 +++---
1 file changed, 7 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/host/ohci-at91.c b
Replace the request_mem_region + ioremap calls by the
devm_ioremap_resource call which does the same things but with device
managed resources.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 27
Make use of the dev variable instead of referencing the dev field of the
pdev struct.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a
Hello,
Le 08/12/2013 19:31, Sergei Shtylyov a écrit :
Hello.
On 12/08/2013 06:02 PM, Boris BREZILLON wrote:
Replace the request_mem_region + ioremap calls by the
devm_ioremap_resource call which does the same things but with device
managed resources.
Signed-off-by: Boris BREZILLON
Acked
mismatch.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
Reviewed-by: Tomasz Figa
---
Changes since v3:
- replace platform_get_resource call with IORESOURCE_IRQ argument by
platform_get_irq
Changes since v2:
- split the patch series to isolate the urgent fix
Make use of the dev variable instead of referencing the dev field of the
pdev struct.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a
Replace clk_get calls by devm_clk_get calls.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 30 +++---
1 file changed, 7 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/host/ohci-at91.c b
Replace the request_mem_region + ioremap calls by the
devm_ioremap_resource call which does the same things but with device
managed resources.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 28
retrieval improvements
Boris BREZILLON (3):
usb: ohci-at91: replace request_mem_region + ioremap by
devm_ioremap_resource
usb: ohci-at91: use dev variable instead of &pdev->dev
usb: ohci-at91: use device managed clk retrieval
drivers/usb/host/ohci-at91.c
Replace clk_get calls by devm_clk_get calls.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 30 +++---
1 file changed, 7 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/host/ohci-at91.c b
Make use of the dev variable instead of referencing the dev field of the
pdev struct.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a
Replace the request_mem_region + ioremap calls by the
devm_request_and_ioremap call which does the same things but with device
managed resources.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
drivers/usb/host/ohci-at91.c | 24
Hello,
This patch series moves the different driver resources (clks and iomem)
retrieval to the device managed versions (devm_ functions).
Best Regards,
Boris
Changes since v2:
- split urgent fix and resource retrieval improvements
Boris BREZILLON (3):
usb: ohci-at91: replace
-by: Boris BREZILLON
Acked-by: Nicolas Ferre
Signed-off-by: Alan Stern
---
Changes since v2:
- split the patch series to isolate the urgent fix provided by this patch
Changes since v1:
- none
drivers/usb/host/ohci-at91.c | 19 +++
1 file changed, 11 insertions(+), 8
Hello Alan,
On 03/12/2013 16:32, Alan Stern wrote:
On Tue, 3 Dec 2013, Nicolas Ferre wrote:
On 03/12/2013 15:07, Boris BREZILLON :
Replace clk_get calls by devm_clk_get calls.
Signed-off-by: Boris BREZILLON
Tested-by: Robert Nelson
Acked-by: Nicolas Ferre
Thanks Boris for these fixes
Replace the request_mem_region + ioremap calls by the
devm_request_and_ioremap call which does the same things but with device
managed resources.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
drivers/usb/host/ohci-at91.c | 24 +---
1 file changed, 5
Replace clk_get calls by devm_clk_get calls.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
drivers/usb/host/ohci-at91.c | 30 +++---
1 file changed, 7 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91
Make use of the dev variable instead of referencing the dev field of the
pdev struct.
Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
---
drivers/usb/host/ohci-at91.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/host/ohci-at91.c b
1 - 100 of 201 matches
Mail list logo
