Hi Felipe,
On Thu, Dec 10, 2015 at 01:09:58PM -0600, Felipe Balbi wrote:
> instead of using:
>
> if (condition) {
> dev_WARN_ONCE(dev, true, "foo");
> return -EINVAL;
> }
>
> let's use:
>
> if (dev_WARN_ONCE(dev, condition, "foo"))
>
Hi Heikki,
On Wed, Dec 02, 2015 at 12:27:10PM +0200, Heikki Krogerus wrote:
> Hi David,
>
>
>
> > > +void intel_usb_mux_unregister(struct intel_usb_mux *mux)
> > > +{
> >
> > There are still 2 pending comments for this unregister function:
> >
> > 1) How about a protection against unbalanced
Hi Heikki,
Follow my comments below.
On Tue, Dec 01, 2015 at 03:32:37PM +0200, Heikki Krogerus wrote:
> Several Intel PCHs and SOCs have an internal mux that is
> used to share one USB port between USB Device Controller and
> xHCI. The mux is normally handled by System FW/BIOS, but not
> always.
Hi Felipe,
On Tue, Dec 01, 2015 at 02:34:34PM -0600, Felipe Balbi wrote:
[snip]
> > +EXPORT_SYMBOL_GPL(intel_usb_mux_register);
> > +
> > +void intel_usb_mux_unregister(struct intel_usb_mux *mux)
> > +{
> > + extcon_unregister_notifier(>edev, EXTCON_USB_HOST, >nb);
> > +
spin_locks when in RT because they're reimplemented as mutexes
>> and can sleep. Converting every single driver to raw_spin_locks
>> defeats the purpose of having everything and their dogs preemptable.
>>
>> Difficult to say. Let's defer this patch until we can come up
>&g
Hi Sudip,
On Fri, Sep 04, 2015 at 05:12:23PM +0530, Sudip Mukherjee wrote:
> We were checking if dev->regs is NULL but it was done after
> dereferencing it. Lets reset the controller and iounmap dev->regs only
> if it is not NULL.
> free_irq() does not need dev->regs, so unmaping it before
On Mon, Aug 17, 2015 at 08:41:19AM -0500, Felipe Balbi wrote:
On Mon, Aug 17, 2015 at 02:32:06PM +0300, Heikki Krogerus wrote:
Sharing the APCI companion with the core platforms device so
ACPI :-)
it has access to all DWC3's resources.
and which resources
Hi Greg,
On Tue, May 26, 2015 at 07:41:18PM -0700, Greg KH wrote:
On Tue, May 26, 2015 at 10:54:01AM -0700, David Cohen wrote:
Hi,
On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote:
Greg KH gre...@linuxfoundation.org writes:
If there are other bus drivers that do
Hi,
On Tue, May 26, 2015 at 07:37:02PM -0700, Greg Kroah-Hartman wrote:
On Wed, May 27, 2015 at 09:45:37AM +0800, Lu Baolu wrote:
Phy drivers and the ulpi interface providers depend on the
registration of the ulpi bus. Ulpi registers the bus in
module_init(). This could cause unnecessary
Hi,
On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote:
Greg KH gre...@linuxfoundation.org writes:
If there are other bus drivers that do this, I'll go fix them up,
pointers to those files would be appreciated.
git grep -E 'if .*\.p\W' found a couple of interesting candidates
Hi,
On Fri, May 22, 2015 at 07:29:15PM +0800, Lu Baolu wrote:
Phy drivers and the ulpi interface providers depend on the
registeration of the ulpi bus. Ulpi registers the bus in
module_init(). This could result in a load order issue, i.e.
It's still not an issue :(
I'd say unnecessary probe
On Fri, May 22, 2015 at 03:50:47PM +0800, Lu, Baolu wrote:
On 05/22/2015 02:46 PM, Lu, Baolu wrote:
On 05/22/2015 11:11 AM, David Cohen wrote:
On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote:
Hi,
On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote:
Many drivers
Hi,
On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote:
Many drivers and modules depend on ULPI bus registeration to
register ULPI interfaces and drivers. It's more appropriate
to register ULPI bus in subsys_initcall instead of module_init.
Kernel panic has been reported with some
On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote:
Hi,
On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote:
Many drivers and modules depend on ULPI bus registeration to
register ULPI interfaces and drivers. It's more appropriate
to register ULPI bus in subsys_initcall
for that checking :)
Anyway,
Reviewed-by: David Cohen david.a.co...@linux.intel.com
drv-driver.bus = ulpi_bus;
return driver_register(drv-driver);
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
On Sat, Apr 25, 2015 at 10:47:42AM -0500, Felipe Balbi wrote:
Hi,
Hi Felipe,
On Fri, Apr 24, 2015 at 01:56:25PM -0700, David Cohen wrote:
When going into bus suspend/resume we _must_
call gadget driver's -suspend/-resume callbacks
accordingly. This patch implements
On Fri, Apr 24, 2015 at 02:48:27PM -0500, Felipe Balbi wrote:
Hi,
Hi Felipe,
On Thu, Apr 23, 2015 at 03:37:48PM -0700, David Cohen wrote:
On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote:
On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote:
From: Felipe Balbi ba
Hi Greg,
On Fri, Apr 17, 2015 at 09:42:57PM +0200, Greg KH wrote:
On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote:
From: Felipe Balbi ba...@ti.com
When going into bus suspend/resume we _must_
call gadget driver's -suspend/-resume callbacks
accordingly. This patch
Hi,
The following patches were merged on kernel = v3.15 but the issue they fix
exists on v3.14 too.
We are currently seeing BC1.2 compliance test failure on some Intel devices
supported by v3.14 LTS kernel. The issue is fixed by this series.
So, I propose to add these to stable.
Br, David
---
Hi Felipe,
On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote:
On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote:
From: Felipe Balbi ba...@ti.com
missing the required:
[ Upstream commit bc5ba2e0b829c9397f96df1191c7d2319ebc36d9 ]
When going into bus suspend
Hi,
Please ignore this patch. It was sent by mistake :(
My apologies.
Br, David
On Thu, Apr 23, 2015 at 04:00:52PM -0700, David Cohen wrote:
From: Dan Carpenter dan.carpen...@oracle.com
commit 73a30bfc0d526db899033165db6f95c427e70505 upstream.
These were cut and paste from
# 3.14
Signed-off-by: Felipe Balbi ba...@ti.com
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/dwc3/gadget.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 8f6738d46b14
-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Felipe Balbi ba...@ti.com
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/dwc3/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index
And this one too :(
Please, consider only the X/2 patches.
BR, David
On Thu, Apr 23, 2015 at 03:59:26PM -0700, David Cohen wrote:
From: Dan Carpenter dan.carpen...@oracle.com
commit 73a30bfc0d526db899033165db6f95c427e70505 upstream.
These were cut and paste from the -disconnect function
-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Felipe Balbi ba...@ti.com
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/dwc3/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index
-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Felipe Balbi ba...@ti.com
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/dwc3/gadget.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index
-by: David Cohen david.a.co...@linux.intel.com
---
Hi,
This patch was introduced on v3.15.
But the issue it fixes already existed on v3.14 and v3.14 is a long term
support version.
I propose to backport it over there as well.
BR, David
---
drivers/usb/dwc3/gadget.c | 35
On Mon, Mar 16, 2015 at 09:46:00AM -0700, David Cohen wrote:
Adding Mika to CC list.
Grrr :(
Adding for real now.
Br, David
On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote:
Hi Linus,
On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote:
On Sat, Mar 07, 2015
Adding Mika to CC list.
Br, David
On Mon, Mar 09, 2015 at 12:10:51PM -0700, David Cohen wrote:
Hi Linus,
On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote:
On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote:
On Fri, Feb 20, 2015 at 8:17 PM, David Cohen
On Wed, Mar 11, 2015 at 04:13:28PM +0530, Anjana V Kumar wrote:
Hi David,
Hi Anjana,
I'd be nice to bottom post your replies. That's the standard here on
community :)
Its a single phy for both host and device modes.
Just a brainstorm:
AFAIU your phy is responsible for the ID detection, so
Hi Anjana,
On Tue, Mar 03, 2015 at 09:27:09AM +0800, Peter Chen wrote:
On Mon, Mar 02, 2015 at 11:47:31AM +0530, Anjana V Kumar wrote:
Hi Peter,
I will need to configure both the phy and the controller.
Thanks
Anjana
On Mon, Mar 2, 2015 at 11:24 AM, Peter Chen
Hi Linus,
On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote:
On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote:
On Fri, Feb 20, 2015 at 8:17 PM, David Cohen
david.a.co...@linux.intel.com wrote:
On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote:
I
Hi,
[snip]
Felipe suggested to divide to conquer instead of having a single
extcon driver to handle all these functions:
- The mux functions would be controlled by a possible new pinctrl-gpio
driver (Linus, your input here would be nice :)
- The VBUS would be a fixed regulator
- The USB
On Fri, Feb 20, 2015 at 02:00:26PM -0600, Felipe Balbi wrote:
On Fri, Feb 20, 2015 at 11:59:27AM -0800, David Cohen wrote:
On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote:
On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote:
Hi Linus and Robert,
CC'ing
On Fri, Feb 20, 2015 at 01:09:00PM -0600, Felipe Balbi wrote:
On Fri, Feb 20, 2015 at 11:02:26AM -0800, David Cohen wrote:
Hi,
On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
As always, comments are welcome
On Fri, Feb 20, 2015 at 08:10:34PM +0100, Paul Bolle wrote:
On Fri, 2015-02-20 at 11:02 -0800, David Cohen wrote:
On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
As always, comments are welcome.
Are nits welcome too
Hi,
On Thu, Feb 19, 2015 at 11:39:06PM +0100, Paul Bolle wrote:
On Thu, 2015-02-19 at 11:59 -0800, David Cohen wrote:
As always, comments are welcome.
Are nits welcome too?
+MODULE_LICENSE(GPLv2);
You probably meant
MODULE_LICENSE(GPL v2)
Didn't that trigger a warning
Hi Linus and Robert,
CC'ing Heikki as it involves a RFC from him.
On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote:
On Fri, Feb 20, 2015 at 7:41 AM, Robert Baldyga r.bald...@samsung.com wrote:
Hi David,
On 02/19/2015 08:59 PM, David Cohen wrote:
Some Intel platforms have
On Fri, Feb 20, 2015 at 01:36:06PM -0600, Felipe Balbi wrote:
On Fri, Feb 20, 2015 at 11:17:00AM -0800, David Cohen wrote:
Hi Linus and Robert,
CC'ing Heikki as it involves a RFC from him.
On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote:
On Fri, Feb 20, 2015 at 7:41
is high, by standard, the OTG port is
configured for device role by not sourcing VBUS and switching D+/- to
device controller.
Signed-off-by: David Cohen david.a.co...@linux.intel.com
---
Hi,
Since splitting this driver into smaller pieces would result in ugly fixes WRT
ACPI, I'm resending
Hi,
On Wed, Feb 18, 2015 at 12:17:06PM +0200, Mika Westerberg wrote:
On Tue, Feb 17, 2015 at 11:35:23AM -0800, David Cohen wrote:
Hi,
Adding Mika.
On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote:
Hi,
On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote
Hi,
Adding Mika.
On Tue, Feb 17, 2015 at 01:25:00PM -0600, Felipe Balbi wrote:
Hi,
On Tue, Feb 17, 2015 at 11:18:44AM -0800, David Cohen wrote:
(3) Platform has 2 USB controllers connected to same port: one for
device and one for host role. D+/- are switched between phys
Hi Felipe and Linus,
On Thu, Dec 25, 2014 at 10:49:29PM -0600, Felipe Balbi wrote:
Hi,
On Wed, Dec 24, 2014 at 02:43:27PM -0800, David Cohen wrote:
Hi Felipe,
Thanks replying.
On Tue, Dec 23, 2014 at 06:29:04PM -0600, Felipe Balbi wrote:
Hi,
On Mon, Dec 22, 2014 at 02:43
Hi Linus,
Thanks for reviewing.
On Thu, Jan 08, 2015 at 08:23:03PM +0100, Linus Walleij wrote:
On Mon, Dec 22, 2014 at 11:43 PM, David Cohen
david.a.co...@linux.intel.com wrote:
Some platforms have an USB OTG port fully (or partially) controlled by
GPIOs:
(1) USB ID is connected
Hi Felipe,
[snip]
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 8d95056..53902ea 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
+++ b/drivers/usb/dwc3/dwc3-pci.c
@@ -21,6 +21,7 @@
#include linux/slab.h
#include linux/pci.h
#include linux/platform_device.h
Hi Heikki,
On Fri, Feb 13, 2015 at 03:16:40PM +0200, Heikki Krogerus wrote:
On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote:
On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote:
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index a8c9062
On Fri, Feb 13, 2015 at 04:03:57PM -0600, Felipe Balbi wrote:
On Fri, Feb 13, 2015 at 02:02:11PM -0800, David Cohen wrote:
Hi Felipe,
[snip]
diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c
index 8d95056..53902ea 100644
--- a/drivers/usb/dwc3/dwc3-pci.c
Hi Felipe, et al,
Is there any on going discussion regarding to USB phy for type C connectors?
We'd like to know the community's preferable direction for handling
(still unsupported) cases like USB3.1 PD, Accessories and Alternate
modes as a new layer or an extension of current USB phy layer.
On Thu, Feb 12, 2015 at 12:45:53PM -0600, Felipe Balbi wrote:
Hi,
On Thu, Feb 12, 2015 at 10:41:37AM -0800, David Cohen wrote:
Hi Felipe, et al,
Is there any on going discussion regarding to USB phy for type C connectors?
We'd like to know the community's preferable direction
On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote:
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index a8c9062..66cbf38 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -879,6 +879,10 @@ static int dwc3_probe(struct platform_device
Hi Heikki,
Sorry I am starting a new branch on this thread.
I need to go back to another topic on this same patch.
On Fri, Jan 23, 2015 at 05:12:58PM +0200, Heikki Krogerus wrote:
TUSB1210 ULPI PHY has vendor specific register for eye
diagram tuning. On some platforms the system firmware has
On Thu, Feb 12, 2015 at 05:41:30PM -0800, David Cohen wrote:
On Thu, Feb 12, 2015 at 02:12:14PM +0200, Heikki Krogerus wrote:
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index a8c9062..66cbf38 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
Hi Heikki,
On Fri, Jan 23, 2015 at 05:12:56PM +0200, Heikki Krogerus wrote:
Registers DWC3's ULPI interface with the ULPI bus when it's
available.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
---
drivers/usb/dwc3/Kconfig | 7 +++
drivers/usb/dwc3/Makefile | 4 ++
On Wed, Feb 11, 2015 at 03:12:55PM +0200, Heikki Krogerus wrote:
Hi David,
Hi Heikki,
In order for phy to be functional, it does not depend only on toggling
GPIOs. It depends on DWC3 going to reset state, then phy executes
power
on sequence, then DWC3 going out of reset
we for PCI, we support Baytrail,
Merrifield, SPTLP, SPTH, BSW (whatever these last three are) and AMD NL.
However Baytrail is reported as 0x0f37, not 0x0f35. If you have a
micro-AB and then it ought to support peripheral mode.
I have a feeling the problem you're having is the same David Cohen
On Tue, Feb 03, 2015 at 01:37:39PM +0200, Heikki Krogerus wrote:
Hi David, Felipe,
Hi Heikki,
why would you have dwc3 mess around with the PHY's gpios ? Doesn't
look
very good.
..but unfortunately we can't use the bus without it :(. We depend on
being able to read
Hi Joseph,
Interesting mix of top and bottom post.
On Tue, Feb 10, 2015 at 10:07:04AM -0700, Joseph Kogut wrote:
Why they use uAB connector I can only assume is because of the smaller
size then standard-A, and because they are not interested in standards.
That actually sounds remarkably
On Tue, Feb 10, 2015 at 11:05:31AM -0800, David Cohen wrote:
On Mon, Feb 02, 2015 at 02:59:59PM +0200, Heikki Krogerus wrote:
You can't really compare a bus like i2c, which can't enumerate
devices
natively, to ULPI which can.
why not ? The BIOS might not need to use
On Mon, Feb 02, 2015 at 02:59:59PM +0200, Heikki Krogerus wrote:
You can't really compare a bus like i2c, which can't enumerate devices
natively, to ULPI which can.
why not ? The BIOS might not need to use the PHY (or USB) at all, it can
very well decide to never turn it on,
On Tue, Feb 10, 2015 at 12:26:53PM -0700, Joseph Kogut wrote:
Sorry, David, I'm using Gmail, and still new to the LKML. I guess it
hid the part that was quoted, I'll have to figure out how to turn that
off.
NP. Take your time :)
Thanks for the information!
You're welcome.
Br, David
--
To
On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote:
Hi,
You can't really compare a bus like i2c, which can't enumerate devices
natively, to ULPI which can.
why not ? The BIOS might not need to use the PHY (or USB) at all, it can
very well decide to never turn it on,
On Fri, Jan 30, 2015 at 10:14:12AM -0600, Felipe Balbi wrote:
On Fri, Jan 30, 2015 at 11:29:56AM +0200, Heikki Krogerus wrote:
Hi,
You can't really compare a bus like i2c, which can't enumerate devices
natively, to ULPI which can.
why not ? The BIOS might not need to use the
On Fri, Jan 30, 2015 at 02:18:42PM +0200, Heikki Krogerus wrote:
Hi,
What exactly are we breaking here? The USB on BYT-CR does not work yet
with the mainline kernel, or does it? To enable it, I already
suggested the BYT quirk (attached again).
It used to work with mainline with
Hi Heikki, Felipe,
On Thu, Jan 29, 2015 at 10:20:23AM -0600, Felipe Balbi wrote:
Hi
On Thu, Jan 29, 2015 at 04:14:12PM +0200, Heikki Krogerus wrote:
Can you share how tusb1210 is connected on the platform you're
using as
test for this patch? I don't think this driver
On Thu, Jan 29, 2015 at 10:04:16AM -0800, David Cohen wrote:
On Thu, Jan 29, 2015 at 10:20:49AM -0600, Felipe Balbi wrote:
On Thu, Jan 29, 2015 at 04:30:53PM +0200, Heikki Krogerus wrote:
Also, I was chatting in private with David and, apparently, there's a
way to request for eye
On Thu, Jan 29, 2015 at 10:20:49AM -0600, Felipe Balbi wrote:
On Thu, Jan 29, 2015 at 04:30:53PM +0200, Heikki Krogerus wrote:
Also, I was chatting in private with David and, apparently, there's a
way to request for eye diagram data from BIOS straight. That's more
in-line with what we
On Thu, Jan 29, 2015 at 10:25:38AM -0800, David Cohen wrote:
On Thu, Jan 29, 2015 at 10:04:16AM -0800, David Cohen wrote:
On Thu, Jan 29, 2015 at 10:20:49AM -0600, Felipe Balbi wrote:
On Thu, Jan 29, 2015 at 04:30:53PM +0200, Heikki Krogerus wrote:
Also, I was chatting in private
On Wed, Jan 28, 2015 at 04:20:25PM +0200, Heikki Krogerus wrote:
Hi,
Can you share how tusb1210 is connected on the platform you're using as
test for this patch? I don't think this driver would work reliably with
this device:
On Tue, Jan 27, 2015 at 11:28:56AM +0200, Heikki Krogerus wrote:
On Mon, Jan 26, 2015 at 11:23:37AM -0800, David Cohen wrote:
On Mon, Jan 26, 2015 at 02:55:03PM +0200, Heikki Krogerus wrote:
On Sat, Jan 24, 2015 at 03:58:11PM -0800, David Cohen wrote:
+static int tusb1210_power_on
Hi Heikki,
On Mon, Jan 26, 2015 at 02:55:03PM +0200, Heikki Krogerus wrote:
Hi David,
On Sat, Jan 24, 2015 at 03:58:11PM -0800, David Cohen wrote:
+static int tusb1210_power_on(struct phy *phy)
+{
+ struct tusb1210 *tusb = phy_get_drvdata(phy);
+
+ gpiod_set_value_cansleep(tusb
Hi Heikki,
On Fri, Jan 23, 2015 at 05:12:58PM +0200, Heikki Krogerus wrote:
TUSB1210 ULPI PHY has vendor specific register for eye
diagram tuning. On some platforms the system firmware has
set optimized value to it. In order to not loose the
optimized value, the driver stores it during probe
Hi Felipe,
Thanks replying.
On Tue, Dec 23, 2014 at 06:29:04PM -0600, Felipe Balbi wrote:
Hi,
On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote:
Some platforms have an USB OTG port fully (or partially) controlled by
GPIOs:
(1) USB ID is connected directly to GPIO
On Wed, Dec 24, 2014 at 11:08:52AM +0800, Peter Chen wrote:
On Tue, Dec 23, 2014 at 11:40:23AM -0800, David Cohen wrote:
Hi Peter,
Thanks for the review.
On Tue, Dec 23, 2014 at 09:25:18AM +0800, Peter Chen wrote:
On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote
Hi Peter,
Thanks for the review.
On Tue, Dec 23, 2014 at 09:25:18AM +0800, Peter Chen wrote:
On Mon, Dec 22, 2014 at 02:43:37PM -0800, David Cohen wrote:
Some platforms have an USB OTG port fully (or partially) controlled by
GPIOs:
(1) USB ID is connected directly to GPIO
Hi Sergei,
On Tue, Dec 23, 2014 at 04:10:44PM +0300, Sergei Shtylyov wrote:
Hello.
On 12/23/2014 1:43 AM, David Cohen wrote:
Some platforms have an USB OTG port fully (or partially) controlled by
GPIOs:
(1) USB ID is connected directly to GPIO
Optionally:
(2) VBUS is enabled
On Tue, Dec 23, 2014 at 11:09:44PM +0300, Sergei Shtylyov wrote:
Hello.
On 12/23/2014 10:57 PM, David Cohen wrote:
Some platforms have an USB OTG port fully (or partially) controlled by
GPIOs:
(1) USB ID is connected directly to GPIO
Optionally:
(2) VBUS is enabled by a GPIO (when
it with your setup ?
Works fine on my side.
Tested-by: David Cohen david.a.co...@linux.intel.com
cheers
--
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
+/- are switched between phys
by GPIO.
As per initial version, this driver has the duty to control whether
USB-Host cable is plugged in or not:
- If yes, OTG port is configured for host role
- If no, by standard, the OTG port is configured for device role
Signed-off-by: David Cohen david.a.co
On Wed, Oct 15, 2014 at 12:00:22AM -0500, Felipe Balbi wrote:
Hi,
On Tue, Oct 14, 2014 at 01:15:05PM -0700, David Cohen wrote:
ERRATIC_ERROR interrupt is an event that needs more attention from
developers than currently implemented, since this indicates a serious
stability issue
On Wed, Oct 15, 2014 at 09:57:18AM -0700, David Cohen wrote:
On Wed, Oct 15, 2014 at 12:00:22AM -0500, Felipe Balbi wrote:
Hi,
On Tue, Oct 14, 2014 at 01:15:05PM -0700, David Cohen wrote:
ERRATIC_ERROR interrupt is an event that needs more attention from
developers than currently
On Wed, Oct 15, 2014 at 12:06:10PM -0500, Felipe Balbi wrote:
On Wed, Oct 15, 2014 at 10:01:45AM -0700, David Cohen wrote:
On Wed, Oct 15, 2014 at 09:57:18AM -0700, David Cohen wrote:
On Wed, Oct 15, 2014 at 12:00:22AM -0500, Felipe Balbi wrote:
Hi,
On Tue, Oct 14, 2014 at 01:15
-off-by: David Cohen david.a.co...@linux.intel.com
---
drivers/usb/dwc3/gadget.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 3818b26bfc05..132e761d62e4 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3
On Mon, Oct 13, 2014 at 10:32:12AM -0500, Felipe Balbi wrote:
On Wed, Oct 08, 2014 at 02:12:18PM -0700, David Cohen wrote:
The commit '2e4c7553cd usb: gadget: f_fs: add aio support' broke the
quirk implemented to align buffer size to maxpacketsize on out endpoint.
As result, functionfs does
on a previous Qiuxu's patch.
Fixes: 2e4c7553cd (usb: gadget: f_fs: add aio support)
Cc: sta...@vger.kernel.org # v3.16+
Signed-off-by: David Cohen david.a.co...@linux.intel.com
Signed-off-by: Qiuxu Zhuo qiuxu.z...@intel.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
Hi,
Since
On Tue, Oct 07, 2014 at 07:31:44PM -0500, Felipe Balbi wrote:
Hi,
Hi Felipe,
On Tue, Oct 07, 2014 at 05:18:06PM -0700, David Cohen wrote:
The commit '2e4c7553cd usb: gadget: f_fs: add aio support' broke the
did that commit non-aio or is only aio broken ?
That commit broke the quirk
On Tue, Oct 07, 2014 at 07:32:56PM -0500, Felipe Balbi wrote:
Hi again,
On Tue, Oct 07, 2014 at 05:18:06PM -0700, David Cohen wrote:
The commit '2e4c7553cd usb: gadget: f_fs: add aio support' broke the
quirk implemented to align buffer size to maxpacketsize on out endpoint.
As result
on a previous Qiuxu's patch.
Fixes: 2e4c7553cd (usb: gadget: f_fs: add aio support)
Cc: sta...@vger.kernel.org # v3.16+
Signed-off-by: David Cohen david.a.co...@linux.intel.com
Signed-off-by: Qiuxu Zhuo qiuxu.z...@intel.com
Acked-by: Michal Nazarewicz min...@mina86.com
---
Hi,
Since
on a previous Qiuxu's patch.
Signed-off-by: David Cohen david.a.co...@linux.intel.com
Signed-off-by: Qiuxu Zhuo qiuxu.z...@intel.com
---
Hi,
Since this is a feature that worked in past, this patch is meant for 3.17
kernel. If/when we pass review and accept it on 3.17, I'll send a version for
stable
On Wed, Apr 09, 2014 at 02:08:32PM +0800, Wang, Yu wrote:
Hi Balbi,
Glad to see the OTG mode is prepare to support in your dwc3-role-switch
branch. But it is not fit for intel Merrfield/Moorfield platforms. :(
The reason is we implemented DRD mode instead of OTG mode. So the
On Wed, Apr 09, 2014 at 10:57:10PM +0800, Xiao Jin wrote:
Thanks all for the review. We meet with the problems when developing
product. I would like to explain my understanding.
On 04/08/2014 11:05 AM, Xiao Jin wrote:
We find two problems on acm tty write delayed mechanism.
(1) When acm
Hi Mathias,
On Tue, Feb 18, 2014 at 11:04:12AM -0800, David Cohen wrote:
On Tue, Feb 18, 2014 at 12:47:41PM -0600, Felipe Balbi wrote:
On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote:
Hi Sarah,
On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote:
When
On Thu, Feb 27, 2014 at 11:03:24AM -0800, Greg Kroah-Hartman wrote:
On Tue, Feb 25, 2014 at 12:33:36PM -0600, Felipe Balbi wrote:
Hi,
On Mon, Feb 24, 2014 at 11:08:27AM -0600, Josh Cartwright wrote:
Use ASSIGN_SYSTEM_SLEEP_PM_OPS and ASSIGN_RUNTIME_PM_OPS in the
initializer for
, ret, len) to limit the
size in case of user data buffer overflow.
But we need return the min_t(size_t, ret, len) to tell the user
space rightly also.
Signed-off-by: Chuansheng Liu chuansheng@intel.com
Acked-by: Michal Nazarewicz min...@mina86.com
Reviewed-by: David Cohen
On Thu, Feb 27, 2014 at 03:44:25PM -0800, Greg Kroah-Hartman wrote:
On Thu, Feb 27, 2014 at 03:41:31PM -0800, David Cohen wrote:
On Thu, Feb 27, 2014 at 11:03:24AM -0800, Greg Kroah-Hartman wrote:
On Tue, Feb 25, 2014 at 12:33:36PM -0600, Felipe Balbi wrote:
Hi,
On Mon, Feb 24
Hi Sarah,
On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote:
When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this
warning:
drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined
but not used [-Wunused-function]
It happens due to lack of __maybe_unused
On Tue, Feb 18, 2014 at 12:47:41PM -0600, Felipe Balbi wrote:
On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote:
Hi Sarah,
On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote:
When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this
warning:
drivers/usb
On Tue, Jan 14, 2014 at 02:42:11PM -0800, David Cohen wrote:
On Fri, Dec 20, 2013 at 12:23:36PM -0800, David Cohen wrote:
On Fri, Dec 20, 2013 at 08:55:27PM +0100, Pavel Machek wrote:
On Sun 2013-12-15 11:25:08, David Cohen wrote:
On Sun, Dec 15, 2013 at 06:51:12PM +0100, Pavel Machek
to.
Br, David Cohen
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 20, 2013 at 12:23:36PM -0800, David Cohen wrote:
On Fri, Dec 20, 2013 at 08:55:27PM +0100, Pavel Machek wrote:
On Sun 2013-12-15 11:25:08, David Cohen wrote:
On Sun, Dec 15, 2013 at 06:51:12PM +0100, Pavel Machek wrote:
On Thu 2013-12-12 21:18:23, David Cohen wrote
On Wed, Jan 08, 2014 at 09:25:42AM +, David Laight wrote:
From: 'David Cohen'
...
The new kmalloc is going to be n * sizeof(struct) - n *
sizeof(pointer)
bigger. I don't know what is the usual range of values for n, but my
experience with android devices with non-abundant
1 - 100 of 214 matches
Mail list logo
