Goede
> Cc: Guenter Roeck
> Acked-by: Hans de Goede
> Acked-by: Guenter Roeck
FWIW, the series:
Reviewed-by: Heikki Krogerus
> ---
> drivers/platform/x86/intel_cht_int33fe.c | 2 +-
> drivers/usb/typec/tcpm/fusb302.c | 2 +-
> 2 files changed, 2 insertions(+)
On Thu, Nov 15, 2018 at 09:46:26AM +0200, Felipe Balbi wrote:
>
> Hi Heikki,
>
> kbuild test robot writes:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
> > testing/next
> > head: bad6c1502dac79c80ad5a7149fa308849c0191dd
> > commit:
On Fri, Oct 26, 2018 at 09:36:59AM -0700, Ajay Gupta wrote:
> Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller
> over I2C interface.
>
> This UCSI I2C driver uses I2C bus driver interface for communicating
> with Type-C controller.
>
> Signed-off-by: Ajay Gup
The Type-C drivers use USB role switch API to inform the
system about the negotiated data role, so registering a role
switch in the DRD code in order to support platforms with
USB Type-C connectors.
Signed-off-by: Heikki Krogerus
---
Hi Chen Yu,
This is related to your Hikey960 USB patches
On Thu, Oct 25, 2018 at 09:55:47PM +, Ajay Gupta wrote:
> Hi Heikki and Andy
> [...]
> > > > Shouldn't you return -ETIMEDOUT if count == 0?
> > > Yes. Good catch. Does the below fix looks ok?
> > >
> > > do {
> > > status = ccg_write(uc, CCGX_RAB_INTR_REG, ,
> > >
Hi Peter,
> > I still didn't understand why can't this just be taken care of in your
> > I2C host driver? Why can't you just read 4 bytes at a time in your
> > master_xfer hook until you have received as much as the message is
> > asking, and only after that return?
>
> The I2C host hardware
Hi,
On Tue, Oct 23, 2018 at 06:56:59PM +, Ajay Gupta wrote:
> > > + /* i2c adapter (ccgx-ucsi) can read 4 byte max */
> >
> > By "i2c adapter" do you mean this Cypress CCGx controller, or the NVIDIA I2C
> > host adapter?
> It mean NVIDIA I2C host adapter with name "ccgx-ucsi"
>
> > > +
Hi guys,
On Tue, Oct 23, 2018 at 03:49:03PM +0200, Heiko Stuebner wrote:
> > True, the graph parsing is indeed missing from that API. I'll see if I
> > can propose something for that at one point (soon hopefully).
>
> as I'm just sitting next to Guenter at ELCE talking about that type-c
> stuff,
pe-C controller.
>
> Signed-off-by: Ajay Gupta
> Reviewed-by: Andy Shevchenko
> Acked-by: Heikki Krogerus
> ---
> Changes from v1 -> v2
> Fixed identation in drivers/usb/typec/ucsi/Kconfig
> Changes from v2 -> v3
> Fixed most of comments from He
+Andy
These have changed a bit since Andy gave his review.
On Fri, Oct 12, 2018 at 06:00:50PM +, Ajay Gupta wrote:
> Hi Heikki and Wolfram
> Do you have any comments on these changes?
Let me take one more look at the UCSI driver, just in case. Nothing's
probable going to happen for a while
ole switched successful or not.
>
> So the SW_IDPIN and SW_VBUS_VALID bits can't determine the current
> acting role.
>
> This patch changes the logic for getting role logic.
>
> Signed-off-by: Yu Wang
Acked-by: Heikki Krogerus
> ---
> drivers/usb/
Intel Apollo Lake has the same internal USB role mux as
Intel Cherry Trail.
Cc:
Signed-off-by: Heikki Krogerus
---
Hi,
The patch with the topic fixed.
Thanks,
---
drivers/usb/host/xhci-pci.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-pci.c
On Mon, Oct 01, 2018 at 06:44:51PM +0300, Heikki Krogerus wrote:
> Hi,
>
> Not a biggie, but why was the topic for this patch changed?
>
> I'm not sure Apollo lakes even have Type-C connectors. The mux is
> needed with the uAB connectors.
My bad. The topic was wrong a
Hi,
Not a biggie, but why was the topic for this patch changed?
I'm not sure Apollo lakes even have Type-C connectors. The mux is
needed with the uAB connectors.
On Mon, Oct 01, 2018 at 06:36:09PM +0300, Mathias Nyman wrote:
> From: Heikki Krogerus
>
> Intel Apollo Lake has the same
On Mon, Oct 01, 2018 at 04:23:31PM +0200, Hans de Goede wrote:
> On 29-09-18 16:26, Yu Wang wrote:
> > The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI
> > controller state. The role can't be switched if related states haven't
> > satisfied. That is why we need to poll the
+Mika, Mathias
On Sat, Sep 29, 2018 at 08:51:43AM +0200, Ondrej Holy wrote:
> Hi,
>
> I recently got new Lenovo Thinkpad T480s with the ThinkPad Thunderbolt
> 3 Dock. The USB ports (but probably also audio and ethernet) on the
> dock always don't work after resume from suspend on up-to-date
Hi Michael,
On Fri, Sep 21, 2018 at 11:49:23AM +0200, Michael Gebhard wrote:
> This reverts commit c9359f416207 ("usb: typec: fusb302: Fix debugfs issue")
>
> Removing debugfs directory leaves pointing at
> freed memory. The next subsequent call to fusb302_probe() causes a
> NULL pointer
Moving all the drivers that depend on the Port Controller
Manager under a new directory drivers/usb/typec/tcpm/ and
making Guenter Roeck the designated reviewer of that code.
Acked-by: Guenter Roeck
Signed-off-by: Heikki Krogerus
---
MAINTAINERS | 6
On Thu, Sep 20, 2018 at 01:20:03PM +0200, Greg KH wrote:
> On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote:
> > Functions typec_mux_get() and typec_switch_get() already
> > make sure that the mux device reference count is
> > incremented, but the same must
for that.
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/fusb302/fusb302.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/typec/fusb302/fusb302.c
b/drivers/usb/typec/fusb302/fusb302.c
instead to achieve the required port
config.
Signed-off-by: Adam Thomson
Reviewed-by: Rob Herring
Signed-off-by: Heikki Krogerus
---
.../devicetree/bindings/usb/fcs,fusb302.txt | 32 +++
1 file changed, 25 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings
Shevchenko
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c
b/drivers/platform/x86
.
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 38 +++---
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index c202975f8097
The connections create clear dependency on the muxes.
fusb302 fails to probe unless we have the mux drivers
available.
Acked-by: Andy Shevchenko
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/Kconfig | 2 ++
1 file changed, 2
From: Adam Thomson
This update populates the tcpc handle's fwnode pointer with the
child usb-connector node, if it exists, so that TCPM can perform
generic property handling to define the ports capabilities.
Signed-off-by: Adam Thomson
Reviewed-by: Guenter Roeck
Signed-off-by: Heikki Krogerus
USB Type-C class driver now expects the muxes to be always
assigned to the ports and not controllers, so the
connections for the mux and fusb302 can be removed.
Acked-by: Andy Shevchenko
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86
Introducing helpers for adding and removing multiple device
connection descriptions at once.
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
include/linux/device.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/linux
We can register all device connection descriptors with a
single call to device_connections_add().
Acked-by: Andy Shevchenko
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 14 --
1 file changed, 4
to change.
Thanks,
--
heikki
Adam Thomson (3):
dt-bindings: connector: Add support for USB-PD PPS APDOs to bindings
dt-bindings: usb: fusb302: Use usb-connector bindings for
configuration
usb: typec: fusb302: Populate tcpc fwnode for TCPM property handling
Heikki Krogerus (9):
platform
, the
connections between the mux and fusb302 can be dropped.
Acked-by: Andy Shevchenko
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers
From: Adam Thomson
Add support for PPS APDOs to connector bindings so a port controller
can specify support for PPS, as per existing FIXED/BATT/VAR PDOs.
Signed-off-by: Adam Thomson
Reviewed-by: Rob Herring
Signed-off-by: Heikki Krogerus
---
.../bindings/connector/usb-connector.txt
On Thu, Sep 20, 2018 at 12:52:35PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 11, 2018 at 05:51:36PM +0300, Heikki Krogerus wrote:
> > On Mon, Sep 10, 2018 at 06:21:04AM -0700, Guenter Roeck wrote:
> > > On 09/10/2018 04:58 AM, Heikki Krogerus wrote:
> > > > Movi
On Fri, Sep 14, 2018 at 02:59:49PM -0700, Rob Weber wrote:
> On Fri, Sep 14, 2018 at 11:09:15AM +0300, Heikki Krogerus wrote:
> > Adding Hans. Hans has become something of a Cherry Trail expert.
>
> Hello Hans. Yesterday I was reading through your blog posts that descr
This fixes potential "BUG: unable to handle kernel paging
request at ..." from happening.
Fixes: fde0aa6c175a ("usb: common: Small class for USB role switches")
Cc:
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/usb
ernel paging
request at ..." from happening.
Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function
parameter")
Cc:
Acked-by: Hans de Goede
Tested-by: Hans de Goede
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/mux.c | 17 +
1 file ch
Hi Greg,
These two patches will fix module reference counting problems we had
in our mux handling code.
Thanks,
Heikki Krogerus (2):
usb: typec: mux: Take care of driver module reference counting
usb: roles: Take care of driver module reference counting
drivers/usb/common/roles.c | 15
Hi Rob,
Adding Hans. Hans has become something of a Cherry Trail expert.
On Thu, Sep 13, 2018 at 03:40:12PM -0700, Rob Weber wrote:
> Hi linux-usb,
>
> I'm currently bringing up a custom board that uses a CherryTrail
> processor and I'm having quite a bit of trouble accessing the dual-role
>
Hi,
On Thu, Sep 13, 2018 at 09:36:58AM +0200, Peter Rosin wrote:
> On 2018-09-13 00:22, Ajay Gupta wrote:
> > Hi Peter,
> > Can we get the working set in while the issues is being debugged?
>
> I'm not the one making the decision, and I don't even know if this
> is going through the i2c or the
Hi,
On Tue, Sep 11, 2018 at 07:36:34PM +0200, Hans de Goede wrote:
> On 11-09-18 12:10, Heikki Krogerus wrote:
> > This is fourth version of this series. There was one bug in patch 2/10
> > that Hans noticed. It should be fixed now.
> >
> > The commit message from
On Mon, Sep 10, 2018 at 06:21:04AM -0700, Guenter Roeck wrote:
> On 09/10/2018 04:58 AM, Heikki Krogerus wrote:
> > Moving all the drivers that depend on the Port Controller
> > Manager under a new directory drivers/usb/typec/tcpm/ and
> > making Guenter Roeck the designated
devices.
The origin thread can be read here:
https://www.spinics.net/lists/linux-usb/msg172033.html
Heikki Krogerus (10):
usb: typec: Take care of driver module reference counting
usb: roles: Handle driver reference counting
platform: x86: intel_cht_int33fe: Add dependency on muxes
USB Type-C class driver now expects the muxes to be always
assigned to the ports and not controllers, so the
connections for the mux and fusb302 can be removed.
Signed-off-by: Heikki Krogerus
Acked-by: Andy Shevchenko
---
drivers/platform/x86/intel_cht_int33fe.c | 18 --
1 file
.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 38 +++---
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index e61dffb27a0c..00141e05bc72 100644
--- a/drivers/usb/typec/class.c
for that.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/fusb302/fusb302.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/typec/fusb302/fusb302.c
b/drivers/usb/typec/fusb302/fusb302.c
index 82bed9810be6..5f5864273e16 100644
--- a/drivers
, the
connections between the mux and fusb302 can be dropped.
Signed-off-by: Heikki Krogerus
Acked-by: Andy Shevchenko
---
drivers/platform/x86/intel_cht_int33fe.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c
b/drivers
ernel paging
request at ..." from happening.
Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function
parameter")
Cc:
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/mux.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git
This fixes potential "BUG: unable to handle kernel paging
request at ..." from happening.
Fixes: fde0aa6c175a ("usb: common: Small class for USB role switches")
Cc:
Signed-off-by: Heikki Krogerus
---
drivers/usb/common/roles.c | 15 ---
1 file changed, 12 insert
-by: Heikki Krogerus
Acked-by: Andy Shevchenko
---
drivers/platform/x86/intel_cht_int33fe.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c
b/drivers/platform/x86/intel_cht_int33fe.c
index b0cef48f77af..424064187124 100644
We can register all device connection descriptors with a
single call to device_connections_add().
Signed-off-by: Heikki Krogerus
Acked-by: Andy Shevchenko
---
drivers/platform/x86/intel_cht_int33fe.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers
Introducing helpers for adding and removing multiple device
connection descriptions at once.
Signed-off-by: Heikki Krogerus
---
include/linux/device.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8f882549edee
The connections create clear dependency on the muxes.
fusb302 fails to probe unless we have the mux drivers
available.
Signed-off-by: Heikki Krogerus
Acked-by: Andy Shevchenko
---
drivers/platform/x86/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/Kconfig b
Intel Apollo Lake has the same internal USB role mux as
Intel Cherry Trail.
Signed-off-by: Heikki Krogerus
---
drivers/usb/host/xhci-pci.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 6372edf339d9
Moving all the drivers that depend on the Port Controller
Manager under a new directory drivers/usb/typec/tcpm/ and
making Guenter Roeck the designated reviewer of that code.
Signed-off-by: Heikki Krogerus
---
Changes since v1:
- Naming the directory tcpm instead of tcpci
- Port controller
On Mon, Sep 10, 2018 at 12:17:56PM +0200, Hans de Goede wrote:
> Hi,
>
> On 10-09-18 12:13, Heikki Krogerus wrote:
> > On Sun, Sep 09, 2018 at 01:18:45PM +0200, Hans de Goede wrote:
> > > Hi Saranya, Heikki,
> > >
> > > On 07-09-18 1
On Sun, Sep 09, 2018 at 01:18:45PM +0200, Hans de Goede wrote:
> Hi Saranya, Heikki,
>
> On 07-09-18 10:18, Heikki Krogerus wrote:
> > +Hans
> >
> > On Fri, Sep 07, 2018 at 12:32:01PM +0530, saranya.go...@intel.com wrote:
> > > From: Saranya Gopal
> >
On Sat, Sep 08, 2018 at 06:37:12AM -0700, Guenter Roeck wrote:
> On 09/08/2018 04:12 AM, Hans de Goede wrote:
> > HI,
> >
> > On 07-09-18 18:19, Guenter Roeck wrote:
> > > On Fri, Sep 07, 2018 at 05:06:12PM +0300, Heikki Krogerus wrote:
> > > > On Fri,
On Fri, Sep 07, 2018 at 06:35:12AM -0700, Guenter Roeck wrote:
> On 09/07/2018 05:56 AM, Heikki Krogerus wrote:
> > Moving all the drivers that depend on the Port Controller
> > Manager under a new a new directory drivers/usb/typec/tcpci/
> > and making Guenter Roeck as th
Moving all the drivers that depend on the Port Controller
Manager under a new a new directory drivers/usb/typec/tcpci/
and making Guenter Roeck as the designated reviewer of that
code.
Signed-off-by: Heikki Krogerus
---
Hi guys,
This should be fairly trivial change. There is no functional
On Thu, Sep 06, 2018 at 10:59:34PM +0200, Hans de Goede wrote:
> HI,
>
> On 04-09-18 13:22, Heikki Krogerus wrote:
> > This fixes potential "BUG: unable to handle kernel paging
> > request at ..." from happening.
> >
> > Fixes: fde0aa6c175a (&quo
ector.
>
> Signed-off-by: Saranya Gopal
> Signed-off-by: M Balaji
> Reviewed-by: Heikki Krogerus
> Reviewed-by: Kuppuswamy Sathyanarayanan
>
> ---
> changes since V5: Corrected the name format in From and Signed-off-by
> changes since V4: Removed change-Id
> cha
On Wed, Sep 05, 2018 at 03:20:22PM -0700, Ajay Gupta wrote:
> Latest NVIDIA GPU cards have a Cypress CCGx Type-C controller
> over I2C interface.
>
> This UCSI I2C driver uses I2C bus driver interface for communicating
> with Type-C controller.
>
> Signed-off-by: Ajay Gup
t of USB Type-C UCSI driver.
>
> Signed-off-by: Ajay Gupta
FWIW:
Reviewed-by: Heikki Krogerus
> ---
> Changes from v1 -> v2
> None
> Changes from v2 -> v3
> Fixed review comments from Andy and Thierry
> Rename i2c-gpu.c -> i2c-nvidia-gpu.c
>
We can register all device connection descriptors with a
single call to device_connections_add().
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86
USB Type-C class driver now expects the muxes to be always
assigned to the ports and not controllers, so the
connections for the mux and fusb302 can be removed.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 18 --
1 file changed, 4 insertions
Introducing helpers for adding and removing multiple device
connection descriptions at once.
Signed-off-by: Heikki Krogerus
---
include/linux/device.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8f882549edee
.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 38 +++---
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index c202975f8097..5b969339d1b3 100644
--- a/drivers/usb/typec/class.c
, the
connections between the mux and fusb302 can be dropped.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c
b/drivers/platform/x86/intel_cht_int33fe.c
for that.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/fusb302/fusb302.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/typec/fusb302/fusb302.c
b/drivers/usb/typec/fusb302/fusb302.c
index 82bed9810be6..5f5864273e16 100644
--- a/drivers
-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c
b/drivers/platform/x86/intel_cht_int33fe.c
index b0cef48f77af..424064187124 100644
--- a/drivers/platform/x86
The connections create clear dependency on the muxes.
fusb302 fails to probe unless we have the mux drivers
available.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86
all the existing connections and add a new one for the
alternate mode device. That way USB3 devices continue to be enumerated
as USB3 devices instead of USB2 devices.
The origin thread can be read here:
https://www.spinics.net/lists/linux-usb/msg172033.html
Heikki Krogerus (10):
usb: typec: Take
ernel paging
request at ..." from happening.
Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function
parameter")
Cc:
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/mux.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git
This fixes potential "BUG: unable to handle kernel paging
request at ..." from happening.
Fixes: fde0aa6c175a ("usb: common: Small class for USB role switches")
Cc:
Signed-off-by: Heikki Krogerus
---
drivers/usb/common/roles.c | 15 ---
1 file changed, 12 insert
On Tue, Sep 04, 2018 at 09:40:35AM +0200, Hans de Goede wrote:
> HI,
>
> On 04-09-18 09:37, Heikki Krogerus wrote:
> > Hi Hans,
> >
> > On Mon, Sep 03, 2018 at 04:59:51PM +0200, Hans de Goede wrote:
> > > Hi,
> > >
> > > On 03-09-18 15:
Hi Hans,
On Mon, Sep 03, 2018 at 04:59:51PM +0200, Hans de Goede wrote:
> Hi,
>
> On 03-09-18 15:36, Heikki Krogerus wrote:
> > PI3USB30532 is used for muxing the port to DisplayPort on
> > CHT platforms, so changing the connection ID so that the
> > mux will get ass
altmode'
>
> Also fix typos for same function documentation.
>
> Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes")
>
> Signed-off-by: Randy Dunlap
> Cc: Heikki Krogerus
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/bus.c |7
USB Type-C class driver now expects the muxes to be always
assigned to the ports and not controllers, so the
connections for the mux and fusb302 can be removed.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 11 ++-
1 file changed, 2 insertions(+), 9
We can register all device connection descriptors with a
single call to device_connections_add().
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86
Introducing helpers for adding and removing multiple device
connection descriptions at once.
Signed-off-by: Heikki Krogerus
---
include/linux/device.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8f882549edee
This fixes potential "BUG: unable to handle kernel paging
request at ..." from happening.
Fixes: fde0aa6c175a ("usb: common: Small class for USB role switches")
Cc:
Signed-off-by: Heikki Krogerus
---
drivers/usb/common/roles.c | 15 ---
1 file changed, 12 insert
The connections create clear dependency on the muxes.
fusb302 fails to probe unless we have the mux drivers
available.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86
, and also a few fixes (1/10 and 2/10) to the mux handling.
The origin thread can be read here:
https://www.spinics.net/lists/linux-usb/msg172033.html
Heikki Krogerus (10):
usb: typec: Take care of driver module reference counting
usb: roles: Handle driver reference counting
platform: x86
, the
connections between the mux and fusb302 can be dropped.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c
b/drivers/platform/x86/intel_cht_int33fe.c
index
.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 38 +++---
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index c202975f8097..5b969339d1b3 100644
--- a/drivers/usb/typec/class.c
ernel paging
request at ..." from happening.
Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function
parameter")
Cc:
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/mux.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git
PI3USB30532 is used for muxing the port to DisplayPort on
CHT platforms, so changing the connection ID so that the
mux will get assigned to the alternate mode device and not
the port device. Connection ID "typec-mux" is now reserved
for Accessory Modes.
Signed-off-by: Heikk
for that.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/fusb302/fusb302.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/typec/fusb302/fusb302.c
b/drivers/usb/typec/fusb302/fusb302.c
index 82bed9810be6..5f5864273e16 100644
--- a/drivers
On Mon, Sep 03, 2018 at 03:08:46PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 3, 2018 at 10:19 AM Heikki Krogerus
> wrote:
> >
> > On Mon, Sep 03, 2018 at 09:17:13AM +0300, Andy Shevchenko wrote:
> > > On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus
>
Hi,
On Mon, Sep 03, 2018 at 10:01:52AM +0200, Hans de Goede wrote:
> Besides my comments on patches 3 and 4, one small nitpick,
> platform is spelled wrong (as plarform) in the subject of
> a number of the patches.
Thanks Hans. I'll fix them.
Cheers,
--
heikki
On Mon, Sep 03, 2018 at 10:01:01AM +0200, Hans de Goede wrote:
> This patch and "[PATCH 3/8] plarform: x86: intel_cht_int33fe: Use the USB
> role switch conditionally"
> both assume that the mux will be in host mode when Linux boots, so we do not
> need to
> touch it. I'm not sure that is a
On Mon, Sep 03, 2018 at 09:17:13AM +0300, Andy Shevchenko wrote:
> On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus
> wrote:
> >
> > Hi,
> >
> > The second last patch in this series will make it possible to use
> > multiport USB Type-C and PD controllers wit
On Mon, Sep 03, 2018 at 09:01:47AM +0300, Andy Shevchenko wrote:
> On Fri, Aug 31, 2018 at 5:21 PM Heikki Krogerus
> wrote:
> >
> > Only create thre Intel role mux device if the platform has
> > USB peripheral controller PCI device.
> >
> > While here, enable t
USB Type-C class driver now expects the muxes to be always
assigned to the ports and not controllers, so the
connections for the mux and fusb302 can be removed.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 19 ++-
1 file changed, 6 insertions
.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 38 +++---
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
index c202975f8097..5b969339d1b3 100644
--- a/drivers/usb/typec/class.c
Only create thre Intel role mux device if the platform has
USB peripheral controller PCI device.
While here, enable the role mux on Apollo Lake platforms.
Signed-off-by: Heikki Krogerus
Cc: Mathias Nyman
---
drivers/usb/host/xhci-pci.c | 20 +---
1 file changed, 17 insertions
, the
connections between the mux and fusb302 can be dropped.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/intel_cht_int33fe.c
b/drivers/platform/x86
PI3USB30532 is used for muxing the port to DisplayPort on
CHT platforms, so changing the connection ID so that the
mux will get assigned to the alternate mode device and not
the port device. Connection ID "typec-mux" is now reserved
for Accessory Modes.
Signed-off-by: Heikk
Introducing helpers for adding and removing multiple device
connection descriptions at once.
Signed-off-by: Heikki Krogerus
---
include/linux/device.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/linux/device.h b/include/linux/device.h
index 8f882549edee
Only adding connection between the USB role switch and
FUSB302 when the board has USB Device Controller (UDC).
Several CHT based products do not enable the UDC PCI device
by default.
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 14 +++---
1 file changed
We can register all device connection descriptors with a
single call to device_connections_add().
Signed-off-by: Heikki Krogerus
---
drivers/platform/x86/intel_cht_int33fe.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86
1 - 100 of 937 matches
Mail list logo
