Fix the following checkpatch warning.
WARNING: break is not useful after a goto or return
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/dwc3/ep0.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index 711b230..1d91c93
, the 'dwc3-exynos.h' file is removed, because
it is not used anymore.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/dwc3/Kconfig |2 +-
drivers/usb/dwc3/dwc3-exynos.c|5 +
include/linux/platform_data/dwc3-exynos.h | 24
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/dwc2/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/Kconfig b/drivers/usb/dwc2/Kconfig
index f93807b..4d02718 100644
--- a/drivers/usb/dwc2/Kconfig
+++ b/drivers
/usb/host/imx21-hcd.c:1175:2: warning: format '%X' expects argument of
type 'unsigned int', but argument 10 has type
'dma_addr_t' [-Wformat]
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/imx21-hcd.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
...@tiscali.nl
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/Kconfig |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
in SoC documentation.
Signed-off-by: Anton Tikhomirov av.tikhomi...@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/phy/phy-exynos5-usbdrd.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/phy/phy
On Friday, September 19, 2014 4:36 PM, Anton Tikhomirov wrote:
According to user manual, pcs_tx_deemph_3p5db field in PHYPARAM1
register is 6bits wide, so mask value should be 0x3f instead
of 0x1f.
Signed-off-by: Anton Tikhomirov av.tikhomi...@samsung.com
Reviewed-by: Jingoo Han jg1
-off-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/ehci-exynos.c | 81
1 file changed, 23 insertions(+), 58 deletions(-)
diff --git a/drivers/usb/host/ehci
-off-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/ohci-exynos.c | 89
+++-
1 file changed, 24 insertions(+), 65 deletions(-)
diff --git a/drivers/usb/host/ohci
Transceiver Driver. So, usb_phy_generic can be
removed from Exynos dwc3 driver.
Is there any reason to support 'usb_phy_generic' for Exynos dwc3?
If so, please let me know. Thank you.
Best regards,
Jingoo Han
Cc: Olof Johansson o...@lixom.net
Cc: Kukjin Kim kgene@samsung.com
Cc: Vivek
Address */
+ writel(EXYNOS5_DRD_PHYREG0_CR_DATA_IN(addr),
+ phy_drd-reg_phy + EXYNOS5_DRD_PHYREG0);
+ crport_handshake(phy_drd, EXYNOS5_DRD_PHYREG0_CR_DATA_IN(addr),
+EXYNOS5_DRD_PHYREG0_CR_CAP_ADDR);
Best regards,
Jingoo Han
+
+ /* Write
this driver completely and use the new generic
PHY based driver
once that comes (from Tomasz).
I agree with this opinion.
I shall drop the patches for cleaning up the usb-phy drivers from my series.
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line unsubscribe linux
usb: phy: samsung: remove old USB 2.0 PHY driver
usb: phy: samsung: remove old USB 3.0 PHY driver
usb: phy: samsung: remove old common USB PHY code
Reviewed-by: Vivek Gautam gautam.vi...@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
On Tuesday, August 19, 2014 8:08 AM, Paul Zimmerman wrote:
From: Paul Zimmerman
Sent: Monday, August 18, 2014 11:03 AM
From: Jingoo Han [mailto:jg1@samsung.com]
Sent: Monday, August 18, 2014 2:17 AM
On Monday, August 18, 2014 5:32 PM, Peter Chen wrote:
linux-2.6
mean is as follows:
- int ep0_mps = 0, ep_mps;
+ int ep0_mps = 0, ep_mps = 8;
Best regards,
Jingoo Han
/*
* This should signal the finish of the enumeration phase
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
Set the default EP max packet value as 8 bytes, because in the case
of low-speed, 'ep_mps' is not set. Thus, the default value of 'ep_mps'
should be considered for the case of low-speed.
Signed-off-by: Jingoo Han jg1@samsung.com
---
- Based on the latest 'usb-linus' branch.
drivers/usb/dwc2
On Thursday, August 14, 2014 11:24 PM, Vivek Gautam wrote:
Removing this older USB 3.0 DRD controller PHY driver, since
a new driver based on generic phy framework is now available.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
Best
...@samsung.com
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/ehci-exynos.c | 53
++--
1 file changed, 8 insertions(+), 45 deletions(-)
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci
Signed-off-by: Himangi Saraogi himangi...@gmail.com
Acked-by: Julia Lawall julia.law...@lip6.fr
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/phy/phy-gpio-vbus-usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb
According to the datasheet, PHYPARAM1_PCS_TXDEEMPH is set as
6 bits [5:0]. Thus, the bit mask should be set as 0x3f, instead
of 0x1f.
Signed-off-by: Jingoo Han jg1@samsung.com
---
These patches have a dependency on the patch ([PATCH] usb: phy:
samsung: Remove unnecessary lines of register bit
are
used in this way.
Signed-off-by: Jingoo Han jg1@samsung.com
---
These patches have a dependency on the patch ([PATCH] usb: phy:
samsung: Remove unnecessary lines of register bit definitions). [1]
[1] http://www.spinics.net/lists/linux-usb/msg111437.html
drivers/usb/phy/phy-samsung-usb.h
: Alan Stern st...@rowland.harvard.edu
Cc: Jingoo Han jg1@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Right, we would get the generic PHYs first, then get the older
usb-phys. Then, the older one will be removed from the kernel.
Thank you.
Best regards,
Jingoo Han
---
Based
Remove unnecessary lines of register bit definitions in order
to enhance the readability. In this case, there are lines
per register offset definitions. There is no functional change.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/phy/phy-samsung-usb.h | 36
pin.
Best regards,
Jingoo Han
Signed-off-by: Kever Yang kever.y...@rock-chips.com
---
Changes in v2:
- put spaces around '+' operator
- expand the comment for dr_mode
- handle dr_mode is USB_DR_MODE_OTG
drivers/usb/dwc2/core.c | 18 ++
drivers/usb/dwc2
On Wednesday, July 23, 2014 4:38 PM, Kiran Padwal wrote:
Make of_device_id array const, because all OF functions handle it as const.
Hi Kiran Padwal,
The same patch was already submitted and merged to USB tree.
Thank you.
Best regards,
Jingoo Han
Signed-off-by: Kiran Padwal kiran.pad
mean. I agree with Paul Zimmerman's opinion.
It looks better to add more detailed commit message, because
it allows people to know the reason more easily. :-)
Thank you.
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
(dwc3_qcom_driver);
+
+MODULE_ALIAS(platform:qcom-dwc3);
How about adding the module author as Ivan T. Ivanov and you?
MODULE_AUTHOR(Ivan T. Ivanov iiva...@mm-sol.com);
MODULE_AUTHOR(Andy Gross agr...@codeaurora.org);
Best regards,
Jingoo Han
+MODULE_LICENSE(GPL v2);
+MODULE_DESCRIPTION
completely separate functions
and request the irq line with IRQF_SHARED. The only extra overhead would
be a mode check at the begining of irq handler.
I am also in agreement with this opinion. Personally, it looks better
to use IRQF_SHARED with completely separate functions.
Best regards,
Jingoo
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/dwc3/core.c|9 +++--
drivers/usb/dwc3/dwc3-exynos.c |4 +---
drivers/usb/dwc3/dwc3-omap.c |4
Use SIMPLE_DEV_PM_OPS macro and remove DEV_PM_OPS macro, in order
to make the code simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/phy/phy-am335x.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb
.
+ .of_match_table = st_dwc3_match,
Best regards,
Jingoo Han
+ .pm = st_dwc3_dev_pm_ops,
+ },
+};
+
+module_platform_driver(st_dwc3_driver);
+
+MODULE_AUTHOR(Giuseppe Cavallaro peppe.cavall...@st.com);
+MODULE_DESCRIPTION(DesignWare USB3 STi Glue Layer
Remove 'start_new' variable from dwc3_endpoint_transfer_complete(),
since this variable has not been used.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/dwc3/gadget.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers
...@rowland.harvard.edu
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
There's one error in the style...
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index 3e86bf4..429434d 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
err.h: IS_ERR() can accept __user pointers
In addition, the Sparse should be upgraded to v0.4.5-rc1 or later.
Thank you.
Best regards,
Jingoo Han
--
Paul
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo
(clk)
Signed-off-by: Colin Ian King colin.k...@canonical.com
It looks good!
Reviewed-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/misc/usb3503.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb
On Friday, June 27, 2014 8:25 PM, Alvin Chen wrote:
From: Bryan O'Donoghue bryan.odonog...@intel.com
The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000
USB host
controller, and the default value is 0x20 dwords. The in/out threshold can be
programmed
to 0x80
On Friday, June 27, 2014 1:33 PM, Jingoo Han wrote:
On Friday, June 27, 2014 8:25 PM, Alvin Chen wrote:
From: Bryan O'Donoghue bryan.odonog...@intel.com
The EHCI packet buffer in/out threshold is programmable for Intel Quark
X1000 USB host
controller, and the default value is 0x20
[...]
+
+MODULE_DESCRIPTION(Generic ChipIdea HDRC USB binding);
+MODULE_AUTHOR(Antoine Ténart antoine.ten...@free-electrons.com);
+MODULE_LICENSE(GPL);
How about GPL v2?
Best regards,
Jingoo Han
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
, INSNREG01 is 0x%08x\n, val);
As Alan Stern said, These INFO message are noisy.
DEBUG level looks better.
Best regards,
Jingoo Han
+
+ iounmap(base);
+
+}
+EXPORT_SYMBOL_GPL(usb_set_qrk_bulk_thresh);
+
/*
* Intel's Panther Point chipset has two host controllers (EHCI and xHCI
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ehci-msm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c
index 982c09b
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ehci-spear.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-spear.c b/drivers/usb/host/ehci-spear.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ehci-tegra.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ohci-spear.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/gr_udc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/gr_udc.c b/drivers/usb/gadget/gr_udc.c
index 99a37ed
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/lpc32xx_udc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/phy/phy-msm-usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index
Make of_device_id array const, because all OF functions handle
it as const.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/phy/phy-tegra-usb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
() instead?
I agree with Alan's suggestion. This warning message is not
proper, when USB controllers that don't need a VDD regulator
are used. The devm_regulator_get_optional() looks better.
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
are ignoring these patches. I think that it's the time to remove it.
So, I will sent single patch to Greg KH in order to remove all usages
of devm_request_and_ioremap() from the kernel.
Best regards,
Jingoo Han
Could you give me a pointer ?
Only to the patches replacing the former
/usb/pxa-udc.h'?
In this case, it enhances build coverage. So, regardless of the
machine dependency, this driver file 'pxa27x_udc.c' can be built.
Best regards,
Jingoo Han
#include pxa27x_udc.h
@@ -1508,16 +1511,16 @@ static struct usb_ep_ops pxa_ep_ops = {
static void dplus_pullup(struct
On Friday, June 06, 2014 5:44 PM, Sachin Kamat wrote:
The third argument of devm_of_phy_get expects a pointer.
Hence use NULL instead of 0.
Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/ohci
sachin.ka...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
---
drivers/usb/host/ehci-exynos.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index d1c76216350f..cda0a2f5c467
Fix checkpatch errors as belows.
ERROR: open brace '{' following function declarations go on the next line
ERROR: space required before the open parenthesis '('
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/dwc2/gadget.c |5 +++--
1 file changed, 3 insertions(+), 2
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/dwc2/gadget.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers
The file and folder movements resulted in the incorrect reference.
So for better code maintainability, let's remove it.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/dwc2/gadget.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/f_uac2.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/f_uac2.c b
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/fotg210-udc.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/fsl_udc_core.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/fusb300_udc.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadget
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/m66592-udc.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/m66592-udc.c b/drivers/usb
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/mv_u3d_core.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/gadget
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/r8a66597-udc.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/r8a66597-udc.c
b/drivers/usb
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/tcm_usb_gadget.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/usb
On Monday, April 28, 2014 6:25 PM, Vivek Gautam wrote:
Change to use struct device instead of struct platform_device
for some static functions.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards
On Monday, April 28, 2014 6:26 PM, Vivek Gautam wrote:
Change to use struct device instead of struct platform_device
for some static functions.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best regards
On Thursday, April 24, 2014 3:40 PM, Vivek Gautam wrote:
On Thu, Apr 24, 2014 at 6:56 AM, Jingoo Han jg1@samsung.com wrote:
On Thursday, April 24, 2014 9:33 AM, Jingoo Han wrote:
On Thursday, April 24, 2014 9:18 AM, Anton Tikhomirov wrote:
On Monday, April 21, 2014 9:17 PM, Vivek
in this series.
Oh, I see. Thank you for your explanation.
I shall be sending the dt patch for this soon.
OK, I will wait for your patch.
Best regards,
Jingoo Han
--
Best Regards
Vivek Gautam
Samsung RD Institute, Bangalore
India
--
To unsubscribe from this list: send the line
for smdk5250,
certain perripherals will now need to ensure that,
they request VDD regulators in their drivers, and enable
them so as to make them working.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best
for smdk5250,
certain perripherals will now need to ensure that,
they request VDD regulators in their drivers, and enable
them so as to make them working.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Best
entries to smdk5420
275dcd2 ARM: dts: add max77686 pmic node for smdk5250,
certain perripherals will now need to ensure that,
they request VDD regulators in their drivers, and enable
them so as to make them working.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han
On Thursday, April 24, 2014 9:33 AM, Jingoo Han wrote:
On Thursday, April 24, 2014 9:18 AM, Anton Tikhomirov wrote:
On Monday, April 21, 2014 9:17 PM, Vivek Gautam wrote:
Facilitate getting required 3.3V and 1.0V VDD supply for
OHCI controller on Exynos.
With patches
regards,
Jingoo Han
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
driver currently does not
look to turn on a clock yet. A patch to fix that will be coming
soon.
Signed-off-by: Dinh Nguyen dingu...@altera.com
[ jh,rb - For gadget part only: ]
Tested-by: Jingoo Han jg1@samsung.com
Tested-by: Robert Baldyga r.bald...@samsung.com
[ pz: Folded Kconfig
: Jingoo Han jg1@samsung.com
---
Based on 'usb-next' branch of Greg's usb tree.
drivers/usb/host/ehci-exynos.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index d1d8c47..a4550eb 100644
.
Right, this spin_lock/unlock is unnecessary, because it is
already used in ohci_suspend().
Acked-by: Jingoo Han jg1@samsung.com
Best regards,
Jingoo Han
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Manjunath Goudar csmanjuvi...@gmail.com
Cc: Alan Stern st
controller should not proceed further with
its suspend callback, rather should return immediately to avoid
powering down the essential things, like phy.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Jingoo Han jg1@samsung.com
Acked-by: Jingoo
or dwc2_pci.ko.
- Split out the patch to have 4 patches instead of 3. Patch 4 contains edits
to the Makefile(s) and Kconfig(s) only.
- Addressed comments from Felipe Balbi.
I don't think I can add the Tested-by: Jingoo Han jg1@samsung.com to
this
version as I have made changes on how
Use SIMPLE_DEV_PM_OPS macro and remove DEV_PM_OPS macro, in order
to make the code simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
---
Changes since v1:
- Move SIMPLE_DEV_PM_OPS outside the #ifdef CONFIG_PM_SLEEP condition
and remove DEV_PM_OPS macro, per Roger Quadros
drivers/usb/phy
: Felipe Balbi ba...@ti.com
Cc: Ben Dooks ben-li...@fluff.org
Cc: Matt Porter mpor...@linaro.org
Cc: Kukjin Kim kgene@samsung.com
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: Matthijs Kooijman matth...@stdin.nl
Cc: Jingoo Han jg1@samsung.com
Tested-by: Jingoo Han jg1@samsung.com
I
Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/phy/phy-am335x.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-am335x.c b/drivers/usb/phy/phy-am335x.c
index 12fc346
On Thursday, February 27, 2014 11:41 PM, Roger Quadros wrote:
On 02/27/2014 01:47 PM, Jingoo Han wrote:
Use SIMPLE_DEV_PM_OPS macro in order to make the code simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/phy/phy-am335x.c |4 +---
1 file changed, 1
/pipermail/linux-arm-kernel/2013-June/179920.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/179921.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-June/179922.html
The last one should be modified for your machine.
Best regards,
Jingoo Han
Best regards
Robert
On Monday, February 17, 2014 10:56 AM, Stephen Warren wrote:
On 02/16/2014 05:37 PM, Jingoo Han wrote:
On Friday, February 14, 2014 6:44 PM, Robert Baldyga wrote:
On 02/13/2014 10:10 PM, dingu...@altera.com wrote:
From: Dinh Nguyen dingu...@altera.com
Hello,
This patch series combines
e3a2 e5845168 e5141008 (e59330dc)
[ 302.80] ---[ end trace 88559040f8f26448 ]---
Best regards,
Jingoo Han
drivers/usb/dwc2/Kconfig | 28 +
drivers/usb/dwc2/Makefile| 17 +-
drivers/usb/dwc2/core.c |1 +
drivers/usb/dwc2/core.h
'
looks good.
Best regards,
Jingoo Han
Peter
The patch series moves the s3c-hsotg files into the /dwc2 folder, so this is
the final location of the driver. When the driver is built as a kernel
module,
it will be dwc2.ko and dwc2_platform.ko.
patch 1/7 : Edit the defines in dwc2
CONFIG_USB_GADGET=n. 's3c-hsotg.c'
supports only gadget mode. In the case of USB_DWC2_HOST mode,
CONFIG_USB_GADGET is NOT enabled. I don't know how to solve it.
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
On Friday, February 07, 2014 11:36 AM, Peter Chen wrote:
On Wed, Feb 05, 2014 at 10:30:35AM +0900, Jingoo Han wrote:
Use the wrapper function for retrieving the platform data instead
of accessing dev-platform_data directly. This is a cosmetic change
to make the code simpler and enhance
will test
the patches with Samsung hardware. Thank you.
Best regards,
Jingoo Han
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Use the wrapper function for retrieving the platform data instead
of accessing dev-platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/chipidea/core.c |4 ++--
1 file changed, 2
/usb/gadget/s3c-hsotg.c:792:3: warning: format '%x' expects argument of
type 'unsigned int' but argument 5 has type
'dma_addr_t' [-Wformat]
Signed-off-by: Jingoo Han jg1@samsung.com
---
Compile-tested only.
drivers/usb/gadget/s3c-hsotg.c |8
1 file changed, 4 insertions(+), 4
On Thursday, December 19, 2013 8:44 AM, Jingoo Han wrote:
On 12/10/2013 11:20 PM, Jingoo Han wrote:
Use devm_ioremap_resource() to make cleanup paths simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
This patch doesn't apply cleanly against Linus' branch. However, I was
able
. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/f_loopback.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/f_loopback.c b/drivers/usb/gadget/f_loopback.c
index c35bb40..4557cd0 100644
--- a/drivers/usb/gadget
Use NULL instead of 0 when returning pointer, to fix the following
sparse warnings.
drivers/usb/gadget/f_mass_storage.c:3114:60: warning: Using plain integer as
NULL pointer
drivers/usb/gadget/f_mass_storage.c:3114:63: warning: Using plain integer as
NULL pointer
Signed-off-by: Jingoo Han jg1
Make local symbol static in order to fix the following sparse
warning.
drivers/usb/gadget/f_serial.c:357:21: warning: symbol 'gser_alloc' was not
declared. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/f_serial.c |2 +-
1 file changed, 1
Make local symbol static in order to fix the following sparse
warning.
drivers/usb/gadget/f_obex.c:502:21: warning: symbol 'obex_alloc' was not
declared. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/f_obex.c |2 +-
1 file changed, 1 insertion
it be static?
drivers/usb/gadget/f_sourcesink.c:240:34: warning: symbol
'ss_iso_source_comp_desc' was not declared. Should it be static?
drivers/usb/gadget/f_sourcesink.c:258:34: warning: symbol
'ss_iso_sink_comp_desc' was not declared. Should it be static?
Signed-off-by: Jingoo Han jg1
Use devm_*() functions to make cleanup paths simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget/atmel_usba_udc.c | 64 ++-
1 file changed, 17 insertions(+), 47 deletions(-)
diff --git a/drivers/usb/gadget/atmel_usba_udc.c
b/drivers
'usba_gadget_template' is used only in this file. Thus, make
'usba_gadget_template' static, in order to fix the following
sparse warning.
warning: symbol 'usba_gadget_template' was not declared. Should it be static?
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/gadget
On Wednesday, December 11, 2013 5:13 PM, Nicolas Ferre wrote:
On 11/12/2013 08:31, Jingoo Han :
Use devm_*() functions to make cleanup paths simpler.
Signed-off-by: Jingoo Han jg1@samsung.com
Jingoo,
Well, these modifications are already addressed by a series written by
Boris
Use dev_warn() instead of printk() to provide a better message
to userspace.
Signed-off-by: Jingoo Han jg1@samsung.com
---
drivers/usb/host/ehci-fsl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
index
1 - 100 of 236 matches
Mail list logo
