Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

d, but I didn't wait long enough for the reset to complete and the mouse to be detected before re-plugging in the OTG port. > On 5/21/2018 11:41 PM, John Stultz wrote: >> On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan >> <minas.harutyun...@synopsys.com> wrote: >>>

[PATCH v2] usb: dwc2: Fix HiKey regression caused by power_down feature

gets thing working again. Cc: John Youn <johny...@synopsys.com> Cc: Minas Harutyunyan <minas.harutyun...@synopsys.com> Cc: Artur Petrosyan <art...@synopsys.com> Cc: Grigor Tovmasyan <tovma...@synopsys.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: linux-usb@vg

Re: [PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

On Mon, May 21, 2018 at 1:45 AM, Minas Harutyunyan <minas.harutyun...@synopsys.com> wrote: > Hi John, > > On 5/19/2018 4:49 AM, John Stultz wrote: >> In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down") >> caused the HiKey board to not correctly h

[PATCH] usb: dwc2: Fix HiKey regression caused by power_down feature

gets thing working again. Cc: John Youn <johny...@synopsys.com> Cc: Vardan Mikayelyan <mvar...@synopsys.com> Cc: Artur Petrosyan <art...@synopsys.com> Cc: Grigor Tovmasyan <tovma...@synopsys.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: linux-usb@vger.kernel.

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

On Mon, Oct 23, 2017 at 1:41 PM, John Stultz <john.stu...@linaro.org> wrote: > On Mon, Oct 23, 2017 at 2:19 AM, Minas Harutyunyan > <minas.harutyun...@synopsys.com> wrote: >> Could you please verify on your setup follow patches: >> 1. Vardan's patch. >> 2

[PATCH 3/3 v2] usb: dwc2: Fix UDC state tracking

ipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Tested by: Minas Harutyunyan <hmi...@synopsys.com> Reported-by: Amit Pundir <amit.pun...@linaro.org> Signed-off-by: John Stultz <john.stu...@linaro.or

[PATCH v2 0/3] dwc2 fixes for edge cases on hikey

.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org John Stultz (3): usb: dwc2: Improve gadget state disconnection handling usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode usb: dwc2: Fix UDC state tracking d

[PATCH 1/3 v2] usb: dwc2: Improve gadget state disconnection handling

hn Youn <johny...@synopsys.com> Cc: Minas Harutyunyan <minas.harutyun...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org&

[PATCH 2/3 v2] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

bi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Tested by: Minas Harutyunyan <hmi...@synopsys.com> Reported-by: YongQin Liu <yongqin@linaro.org> Signed-off-by: John Stultz <john.stu...@linaro.org> -

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

On Mon, Oct 23, 2017 at 2:19 AM, Minas Harutyunyan wrote: > Could you please verify on your setup follow patches: > 1. Vardan's patch. > 2. Patch for TOUTCAL programming (new version see below). > 4. Your patch 2/3 to avoid "Mode Mismatch" interrupts. > 5. Your

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

On Wed, Oct 18, 2017 at 11:46 PM, Minas Harutyunyan wrote: > Could you please apply this patch. Please not apply your patch series > "[PATCH 0/3] dwc2 fixes for edge cases on hikey" to check only below patch. > If you confirm that this patch fix your issue with

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

On Tue, Oct 17, 2017 at 1:41 AM, Minas Harutyunyan <minas.harutyun...@synopsys.com> wrote: > On 10/17/2017 1:34 AM, John Stultz wrote: >> On Mon, Oct 16, 2017 at 1:36 AM, Minas Harutyunyan >> <minas.harutyun...@synopsys.com> wrote: >>> On b-plug disconne

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

On Mon, Oct 16, 2017 at 1:36 AM, Minas Harutyunyan wrote: > On b-plug disconnect should asserted GOTGINT.SesEndDet interrupt. > According previously sent by you register dump (GHWCFG2 = 0x23affc70) > your core OTG_MODE=0. > Bellow fragment from programming guide on

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

On Thu, Oct 12, 2017 at 12:59 AM, Minas Harutyunyan wrote: > > 1. Vardan's patch fixing issue when dwc2 switched from host to device > mode. It's allow to make functional device after reconnecting without > tracking UDC state. While I'm sure Vardan's patch is

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

On Tue, Oct 3, 2017 at 2:58 AM, Minas Harutyunyan wrote: > > Could you please apply patch from Vardan Mikayelyan "usb: dwc2: Fix > dwc2_hsotg_core_init_disconnected()" submitted at 02/25/2017 > (https://marc.info/?l=linux-usb=148801589931039=2) instead of your >

[RESEND x2][PATCH 3/3] usb: dwc2: Fix UDC state tracking

nyan <minas.harutyun...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Reported-by: Ami

[RESEND x2][PATCH 2/3] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Reported-by: YongQin Liu <yongqin@linaro.org> Signed-off-by: John

[RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

and...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org John Stultz (3): usb: dwc2: Improve gadget state disconnection handling usb: dwc2: Error out of dw

[RESEND x2][PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

t; Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c

[RESEND][PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

t; Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c

[RESEND][PATCH 0/3] dwc2 fixes for edge cases on hikey

and...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org John Stultz (3): usb: dwc2: Improve gadget state disconnection handling usb: dwc2: Error out of dw

[RESEND][PATCH 2/3] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Reported-by: YongQin Liu <yongqin@linaro.org> Signed-off-by: John

[RESEND][PATCH 3/3] usb: dwc2: Fix UDC state tracking

nyan <minas.harutyun...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Reported-by: Ami

Re: [PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

On Thu, Aug 17, 2017 at 12:03 PM, John Stultz <john.stu...@linaro.org> wrote: > In the earlier commit dad3f793f20f ("usb: dwc2: Make sure we > disconnect the gadget state"), I was trying to fix up the > fact that we somehow weren't disconnecting the gadget state, &g

[PATCH 3/3] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Reported-by: YongQin Liu <yongqin@linaro.org> Signed-off-by: John

[PATCH 2/3] usb: dwc2: Fix UDC state tracking

nyan <minas.harutyun...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Reported-by: Ami

[PATCH 1/3] usb: dwc2: Improve gadget state disconnection handling

t; Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Fri, Aug 11, 2017 at 5:31 PM, John Stultz <john.stu...@linaro.org> wrote: > On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang <wei...@google.com> wrote: >>> If after Cong's fix, the issue still happens, could you help try the >>> patch attached and collect al

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Fri, Aug 11, 2017 at 5:10 PM, Wei Wang wrote: >> If after Cong's fix, the issue still happens, could you help try the >> patch attached and collect all logs when you try the reproduce the >> issue? It would be great to have logs for both success case and the >> failure case.

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Wed, Aug 9, 2017 at 10:41 PM, Wei Wang wrote: > Hi John, > > Is it possible to try the attached patch? Thanks so much for the quick turn around! So I dropped all the reverts you suggested, and applied this one against 4.13-rc4, but I'm still seeing the problematic

[RFC][PATCH] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

glas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Reported-by: YongQin Liu <yongqin@linaro.org> Signed-off-by: J

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang <wei...@google.com> wrote: > On Wed, Aug 9, 2017 at 4:44 PM, John Stultz <john.stu...@linaro.org> wrote: >> On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >>> (Cc'ing Wei whose commit was blam

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Wed, Aug 9, 2017 at 5:36 PM, Wei Wang wrote: > > Does your USB adapter get an IPv6 address? Yes, it does. > If you see the problem starts to happen on commit > 9514528d92d4cbe086499322370155ed69f5d06c, could you try reverting all > the following commits: > (from new to

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Wed, Aug 9, 2017 at 4:34 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > (Cc'ing Wei whose commit was blamed) > > On Mon, Aug 7, 2017 at 2:15 PM, John Stultz <john.stu...@linaro.org> wrote: >> On Mon, Aug 7, 2017 at 2:05 PM, John Stultz <john.stu...@linaro.o

Re: [PATCH] arm64: dts: hi6220: improve g-tx-fifo-size setting for usb device

obviously >invalid either, because even fifo entries for one EP exceeds the >total entries 1920. That's why we see the following fat warning from >function dwc2_hsotg_init_fifo(). The new g-tx-fifo-size settings >help to remove the warning as well. Nice! This has bee

Re: unregister_netdevice: waiting for eth0 to become free. Usage count = 1

On Mon, Aug 7, 2017 at 2:05 PM, John Stultz <john.stu...@linaro.org> wrote: > So, with recent testing with my HiKey board, I've been noticing some > quirky behavior with my USB eth adapter. > > Basically, pluging the usb eth adapter in and then removing it, when > plugging it

unregister_netdevice: waiting for eth0 to become free. Usage count = 1

So, with recent testing with my HiKey board, I've been noticing some quirky behavior with my USB eth adapter. Basically, pluging the usb eth adapter in and then removing it, when plugging it back in I often find that its not detected, and the system slowly spits out the following message over and

[RFC][PATCH 1/2] usb: dwc2: Improve gadget state disconnection handling

; Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --

[RFC][PATCH 2/2] usb: dwc2: Fix UDC state tracking

hn Youn <johny...@synopsys.com> Cc: Minas Harutyunyan <minas.harutyun...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org&

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

On Tue, Apr 4, 2017 at 12:38 AM, Felipe Balbi wrote: > > Hi, > > Minas Harutyunyan writes: >>> We've noticed that when using usb ethernet adapters on HiKey, we >>> occasionally see errors like: >>> >>> dwc2

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

On Mon, Apr 3, 2017 at 5:54 AM, Minas Harutyunyan <minas.harutyun...@synopsys.com> wrote: > On 4/3/2017 9:23 AM, John Youn wrote: >> On 03/31/2017 04:04 PM, John Stultz wrote: >>> On Thu, Mar 2, 2017 at 12:00 PM, John Stultz <john.stu...@linaro.org> wrote: >&

[PATCH v2] usb: dwc2: Make sure we disconnect the gadget state

gt; Cc: John Youn <johny...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Acked-by: John Y

[PATCH] usb: dwc2: Make sure we disconnect the gadget state

gt; Cc: John Youn <johny...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Acked-by: John Youn <jo

[RFC][PATCH] usb: dwc2: Make sure we disconnect the gadget state

t; Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- driver

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

On Mon, Jan 16, 2017 at 12:57 PM, John Youn <john.y...@synopsys.com> wrote: > > >> On Jan 16, 2017, at 12:37 PM, John Stultz <john.stu...@linaro.org> wrote: >> >> On Mon, Jan 16, 2017 at 2:36 AM, Felipe Balbi >> <felipe.ba...@linux.intel.com>

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

On Mon, Jan 16, 2017 at 2:36 AM, Felipe Balbi <felipe.ba...@linux.intel.com> wrote: > > Hi, > > John Stultz <john.stu...@linaro.org> writes: >> Basically when plugging in various cables in different orders, I'm >> occasionally seeing the following BUG splat:

Re: [RFC][PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On Mon, Jan 16, 2017 at 2:29 AM, Felipe Balbi <felipe.ba...@linux.intel.com> wrote: > > Hi, > > John Stultz <john.stu...@linaro.org> writes: >> I just wanted to re-send my current queue of patches for dwc2 >> controller on the HiKey board, as my last patchset

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

On Thu, Jan 12, 2017 at 12:05 AM, Felipe Balbi <felipe.ba...@linux.intel.com> wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >> On 1/11/2017 4:22 PM, John Stultz wrote: >>> Just wanted to resend my patches for dwc2 controller on the >>

[PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

..@huawei.com> Cc: Vardan Mikayelyan <mvar...@synopsys.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org&

[PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Chen Yu (2): usb: dwc2: Force port resume on switching to device mode usb: dwc2: Add a quirk to allow speed neg

[PATCH 2/4 v3] usb: dwc2: Workaround case where GOTGCTL state is wrong

l.org Acked-by: John Youn <johny...@synopsys.com> Reviewed-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: Rework goto logic suggested by Vardan, and add a comment v3: * Rebased to synopsys-usb/next branch --- drivers/usb/dwc2/hcd.

[PATCH 4/4 v3] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

inuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu <cheny...@huawei.com> [jstultz: Reworked to simplify the patch, and made commit log to be more specific about the issue] Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: * Fix build issue reported by k

[PATCH 3/4 v3] usb: dwc2: Force port resume on switching to device mode

> Cc: Vardan Mikayelyan <mvar...@synopsys.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu <cheny...@huawei.com> Sig

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On Wed, Jan 11, 2017 at 2:58 PM, John Youn <john.y...@synopsys.com> wrote: > On 1/11/2017 2:39 PM, John Stultz wrote: >> On Wed, Jan 11, 2017 at 2:08 PM, John Youn <john.y...@synopsys.com> wrote: >>> On 1/3/2017 11:52 AM, John Stultz wrote: >>>> Hope e

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On Wed, Jan 11, 2017 at 2:08 PM, John Youn <john.y...@synopsys.com> wrote: > On 1/3/2017 11:52 AM, John Stultz wrote: >> Hope everyone had a happy new years! >> >> I just wanted to send out my current queue of patches for dwc2 >> controller on the HiKey boa

Re: [PATCH 2/3] usb: dwc2: gadget: Fix DMA memory freeing

On Mon, Jan 9, 2017 at 1:10 PM, John Youn <john.y...@synopsys.com> wrote: > From: Vardan Mikayelyan <mvar...@synopsys.com> > > Remove DMA memory free from EP disable flow by replacing > dma_alloc_coherent with dmam_alloc_coherent. > > Cc: John Stultz <joh

Re: [PATCH] usb: dwc2: gadget: Fix DMA memory freeing

On Thu, Jan 5, 2017 at 6:01 PM, John Youn <john.y...@synopsys.com> wrote: > From: Vardan Mikayelyan <mvar...@synopsys.com> > > Remove DMA memory free from EP disable flow by replacing > dma_alloc_coherent with dmam_alloc_coherent. > > Cc: John Stultz <joh

Re: [PATCH] usb: dwc2: use u32 for DT binding parameters

o, does the patch need a respin, or is it against Linus' HEAD and my tree is stale? Anyway, after re-applying it to my tree: Tested-by: John Stultz <john.stu...@linaro.org> thanks -john -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: dwc2: fix panic for coherent memory allocation

On Thu, Jan 5, 2017 at 6:50 PM, Leo Yan wrote: > When use configfs to configure USB port as as ethernet gadget, the > kernel has panic with below backtrace; it clearly indicates the > coherent memory allocation is happened in the interrupt context, > but the function

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On Tue, Jan 3, 2017 at 4:31 PM, John Youn <john.y...@synopsys.com> wrote: > On 1/3/2017 12:05 PM, John Stultz wrote: >> On Tue, Jan 3, 2017 at 11:52 AM, John Stultz <john.stu...@linaro.org> wrote: >>> Hope everyone had a happy new years! >>> >>

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On Tue, Jan 3, 2017 at 11:52 AM, John Stultz <john.stu...@linaro.org> wrote: > Hope everyone had a happy new years! > > I just wanted to send out my current queue of patches for dwc2 > controller on the HiKey board for consideration for the 4.11 > merge window. > > This

[PATCH 4/5 v2] usb: dwc2: Avoid suspending if we're in gadget mode

am I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Suggested-by: Chen Yu <cheny...@huawei.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c |

[PATCH 3/5 v2] usb: dwc2: Force port resume on switching to device mode

> Cc: Vardan Mikayelyan <mvar...@synopsys.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu <cheny...@huawei.com> Signe

[PATCH 5/5 v2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

inuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu <cheny...@huawei.com> [jstultz: Reworked to simplify the patch, and made commit log to be more specific about the issue] Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: * Reworked to adapt around

[PATCH 1/5 v2] usb: dwc2: Avoid sleeping while holding hsotg->lock

..@huawei.com> Cc: Vardan Mikayelyan <mvar...@synopsys.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro

[PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

am I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Chen Yu (2): usb: dwc2: Force port resume on switching to device mode usb: dwc2: Add a quirk to allow speed negotiation for Hi

[PATCH 2/5 v2] usb: dwc2: Workaround case where GOTGCTL state is wrong

l.org Acked-by: John Youn <johny...@synopsys.com> Reviewed-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: Rework goto logic suggested by Vardan, and add a comment drivers/usb/dwc2/hcd.c | 9 + 1 file changed, 9 i

[RFC][PATCH 2/5 v2] usb: dwc2: Workaround case where GOTGCTL state is wrong

l.org Acked-by: John Youn <johny...@synopsys.com> Reviewed-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: Rework goto logic suggested by Vardan, and add a comment --- drivers/usb/dwc2/hcd.c | 9 + 1 file changed, 9 i

[RFC][PATCH 4/5 v2] usb: dwc2: Avoid suspending if we're in gadget mode

am I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Suggested-by: Chen Yu <cheny...@huawei.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c |

[RFC][PATCH 1/5 v2] usb: dwc2: Avoid sleeping while holding hsotg->lock

..@huawei.com> Cc: Vardan Mikayelyan <mvar...@synopsys.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro

[RFC][PATCH 3/5 v2] usb: dwc2: Force port resume on switching to device mode

> Cc: Vardan Mikayelyan <mvar...@synopsys.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu <cheny...@huawei.com> Signe

[RFC][PATCH 5/5 v2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

inuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu <cheny...@huawei.com> [jstultz: Reworked to simplify the patch, and made commit log to be more specific about the issue] Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: * Fix build issue reported by k

[RFC][PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

x-usb@vger.kernel.org Chen Yu (2): usb: dwc2: Force port resume on switching to device mode usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220 John Stultz (3): usb: dwc2: Avoid sleeping while holding hsotg->lock usb: dwc2: Workaround case where GOTGCTL state is wrong u

Re: [REGRESSION] dwc2: 5f54c54b0ba8 Add DDMA chain pointers to dwc2_hsotg_ep structure

On Tue, Dec 13, 2016 at 3:51 PM, John Youn <john.y...@synopsys.com> wrote: > On 12/13/2016 3:23 PM, John Stultz wrote: >> I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the >> following WARNINGS/panics, which I bisected down to being introduced >> w

Re: [REGRESSION] dwc2: 5f54c54b0ba8 Add DDMA chain pointers to dwc2_hsotg_ep structure

On Tue, Dec 13, 2016 at 3:51 PM, John Youn <john.y...@synopsys.com> wrote: > On 12/13/2016 3:23 PM, John Stultz wrote: >> I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the >> following WARNINGS/panics, which I bisected down to being introduced >> w

[REGRESSION?] 05ee799f2021 dwc2: Move gadget settings into core_params

Hey John, Wanted to let you know I'm seeing a new WARNING with HiKey as of 05ee799f2021 ("dwc2: Move gadget settings into core_params"). It doesn't seem to kill the system, but seems odd since that patch seems to be just moving code around and not changing logic. Any thoughts? thanks -john [

[REGRESSION] dwc2: 5f54c54b0ba8 Add DDMA chain pointers to dwc2_hsotg_ep structure

I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the following WARNINGS/panics, which I bisected down to being introduced with 5f54c54b0ba8 ("Add DDMA chain pointers to dwc2_hsotg_ep structure"). It seems the issue is calling dma_alloc_coherent() in dwc2_hsotg_ep_enable() isn't

Re: [RFC][PATCH 2/5] usb: dwc2: Workaround case where GOTGCTL state is wrong

On Tue, Dec 13, 2016 at 4:28 AM, Vardan Mikayelyan <vardan.mikayel...@synopsys.com> wrote: > On 12/13/2016 11:12 AM, John Stultz wrote: >> When removing a USB-A to USB-otg adapter cable, we get a change >> status irq, and then in dwc2_conn_id_status_change,

Re: [RFC][PATCH 5/5] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

On Tue, Dec 13, 2016 at 5:24 AM, Alan Stern <st...@rowland.harvard.edu> wrote: > On Mon, 12 Dec 2016, John Stultz wrote: > >> From: Chen Yu <cheny...@huawei.com> >> >> The Hi6220's usb controller is limited in that it does not >> support "Split Tran

[RFC][PATCH 0/5] Fixes and workarounds for dwc2 on HiKey board

.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Chen Yu (2): usb: dwc2: Force port resume on switching to device mode usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220 John Stultz (3): usb: dwc2: Avoid sleeping

[RFC][PATCH 1/5] usb: dwc2: Avoid sleeping while holding hsotg->lock

gt; Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/core.c | 6 +++---

[RFC][PATCH 2/5] usb: dwc2: Workaround case where GOTGCTL state is wrong

..@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Acked-by: John Youn <johny...@synopsys.com&g

[RFC][PATCH 4/5] usb: dwc2: Avoid suspending if we're in gadget mode

.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Suggested-by: Chen Yu <cheny...@huawei.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c | 3 +++ 1 file changed, 3 insertions(+) di

[RFC][PATCH 3/5] usb: dwc2: Force port resume on switching to device mode

; Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu <cheny...@huawei.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c | 7 +++ 1 file

[RFC][PATCH 5/5] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

Signed-off-by: Chen Yu <cheny...@huawei.com> [jstultz: Reworked to simplify the patch, and made commit log to be more specific about the issue] Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: * Fix build issue reported by kbuildbot * Rework to avoid using new dts entry sug

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

On Thu, Dec 8, 2016 at 11:09 PM, Chen Yu <cheny...@huawei.com> wrote: > On 2016/12/9 7:29, John Youn wrote: >> On 12/8/2016 2:43 PM, John Stultz wrote: >>> On Tue, Dec 6, 2016 at 7:52 PM, John Youn <john.y...@synopsys.com> wrote: >>>> On 12/6/2016 5:48 PM,

[RFC][PATCH] usb: dwc2: Avoid sleeping while holding hsotg->lock

gt; Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/core.c | 6 +++---

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

On Thu, Dec 8, 2016 at 4:31 PM, John Youn <john.y...@synopsys.com> wrote: > On 12/8/2016 4:25 PM, John Stultz wrote: >> On Thu, Dec 8, 2016 at 4:17 PM, John Youn <john.y...@synopsys.com> wrote: >>> On 12/8/2016 3:12 PM, John Stultz wrote: >>>> Hey J

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

On Thu, Dec 8, 2016 at 4:17 PM, John Youn <john.y...@synopsys.com> wrote: > On 12/8/2016 3:12 PM, John Stultz wrote: >> Hey John, >> In my testing I've come across another issue in the dwc2 driver. >> >> Basically when plugging in various cables in different o

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

On Thu, Dec 8, 2016 at 3:12 PM, John Stultz <john.stu...@linaro.org> wrote: > Hey John, > In my testing I've come across another issue in the dwc2 driver. > > Basically when plugging in various cables in different orders, I'm > occasionally seeing the following BUG splat: &

BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

Hey John, In my testing I've come across another issue in the dwc2 driver. Basically when plugging in various cables in different orders, I'm occasionally seeing the following BUG splat: [ 86.215403] BUG: scheduling while atomic: kworker/u16:2/53/0x0002 [ 86.219164] usb 1-1: USB

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

On Tue, Dec 6, 2016 at 7:52 PM, John Youn <john.y...@synopsys.com> wrote: > On 12/6/2016 5:48 PM, John Stultz wrote: >> Hey John, >> Just wanted to send this by you, as it seems something is >> slightly off with the GOTGCTL state when removing a otg adapter >> c

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

On Tue, Dec 6, 2016 at 7:54 PM, Chanwoo Choi wrote: > Hi John, > > I give a some guide for extcon API. > This patch uses the deprecated extcon API (extcon_get_cable_state_). > So, I recommend that you better to use following extcon API: > - extcon_get_cable_state_() ->

[RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

.@huawei.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c | 5

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

On Tue, Dec 6, 2016 at 4:35 PM, John Stultz <john.stu...@linaro.org> wrote: > On Tue, Dec 6, 2016 at 4:26 PM, John Youn <john.y...@synopsys.com> wrote: >> On 12/6/2016 4:05 PM, John Stultz wrote: >>> On Tue, Dec 6, 2016 at 3:17 PM, John Youn <john.y...@synopsys.com

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

On Tue, Dec 6, 2016 at 4:26 PM, John Youn <john.y...@synopsys.com> wrote: > On 12/6/2016 4:05 PM, John Stultz wrote: >> On Tue, Dec 6, 2016 at 3:17 PM, John Youn <john.y...@synopsys.com> wrote: >>> Also, do you really need this at all? Wasn't your system previously

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

On Tue, Dec 6, 2016 at 3:17 PM, John Youn <john.y...@synopsys.com> wrote: > On 12/6/2016 12:06 AM, John Stultz wrote: >> This patch wires up extcon support to the dwc2 driver >> so that devices that use a modern generic phy driver >> and don't use the usb-phy infrast

[RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: * Move extcon logic from generic phy to dwc2 driver, as suggested by Kishon. --- arch/arm64/boot/dts/hisilicon/hi6220.d

[RFC][PATCH 3/3 v2] usb: dwc2: Force port resume on switching to device mode

; Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Signed-off-by: Chen Yu <cheny...@huawei.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- drivers/usb/dwc2/hcd.c | 8

[RFC][PATCH 0/3 v2] Try to connect HiKey's usb extcon to dwc2 driver

s Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com> Cc: Kishon Vijay Abraham I <kis...@ti.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: linux-usb@vger.kernel.org Chen Yu (1): usb: dwc2

  1   2   >