[PATCH v2 02/28] usb: dwc2: Add identifier in prototypes

Fixes checkpatch warning: WARNING: function definition argument 'struct dwc2_hsotg *' should also have an identifier name Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/us

[PATCH v2 19/28] usb: dwc2: Add debugfs file to show params

Show the core params and hardware params. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debugfs.c | 127 + 1 file changed, 127 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c

[PATCH v2 24/28] usb: dwc2: Force port resume on switching to device mode

Wei Xu <xuw...@hisilicon.com> Cc: Guodong Xu <guodong...@linaro.org> Cc: Amit Pundir <amit.pun...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: John Youn <johny...@synopsys.com> Cc: Douglas Anderson <diand...@chromium.org> Cc: Chen Yu <cheny...@huawei.com

[PATCH v2 25/28] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

op the usb speed when low/full-speed are attached, and bump back to high speed when they are removed. Cc: Wei Xu <xuw...@hisilicon.com> Cc: Guodong Xu <guodong...@linaro.org> Cc: Amit Pundir <amit.pun...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: John Youn <johny..

[PATCH v2 27/28] usb: dwc2: host: use true/false for boolean

From: Nicholas Mc Guire <hof...@osadl.org> For boolean variables true/false is preferred over 1/0 for readability. [johnyoun: minor rebase] Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/hcd.c | 10

[PATCH v2 23/28] usb: dwc2: Workaround case where GOTGCTL state is wrong

is isn't the best solution, but it seems to work well for me. Feedback would be greatly appreciated! Cc: Wei Xu <xuw...@hisilicon.com> Cc: Guodong Xu <guodong...@linaro.org> Cc: Amit Pundir <amit.pun...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: John Youn <johny...@syno

[PATCH v2 20/28] usb: dwc2: Remove debug prints in params.c

Remove debugging prints to show params. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 56 --- 1 file changed, 56 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 0e7f0f

[PATCH v2 26/28] usb: dwc2: host: use msleep() for long delay

g/lkml/2017/1/11/377 Fixes: commit 2938fc63e0c2 ("usb: dwc2: Properly account for the force mode delays") Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 06/28] usb: dwc2: Fix lines over 80 characters

Fix lines over 80 characters. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 13 + drivers/usb/dwc2/gadget.c | 14 +- drivers/usb/dwc2/hcd.c | 4 ++-- drivers/usb/dwc2/hcd_intr.c | 13 +++-- drivers/usb/dwc2/pa

[PATCH v2 28/28] usb: dwc2: host: use msleep() for long delays

base] Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/hcd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index de24c3e8f5c7..6d399

[PATCH v2 21/28] usb: dwc2: Show dr_mode via debugfs

Show the value of dr_mode via a debufs file. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debugfs.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index 57747b0df595..794b95

[PATCH v2 18/28] usb: dwc2: Remove unnecessary parameters

Further reduce the set of parameters set by platforms. Many of them are unnecessary as they should be reported by hardware. They should only need to be overridden if there is a problem. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 11 ---

[PATCH v2 14/28] usb: dwc2: Rearrange param structure members

Group the members by global, host, and gadget params. Formatting and organizational change only. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 51 ++--- 1 file changed, 23 insertions(+), 28 deletions(-) diff

[PATCH v2 13/28] usb: dwc2: Update parameter types

Update the param types to appropriately sized ints and bools. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/usb/dwc2/core.h b/drive

[PATCH v2 04/28] usb: dwc2: Fix logical continuations

Fix the formatting of logical statements to end the line with the logical operator. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core_intr.c | 5 ++--- drivers/usb/dwc2/hcd_ddma.c | 8 drivers/usb/dwc2/hcd_queue.c | 5 ++--- 3 files changed, 8 insertions(

[PATCH v2 16/28] usb: dwc2: Remove platform static params

Remove the platform-specific static param structs and set only those params that are necessary for each platform. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 262 +++--- 1 file changed, 108 insertions(+), 154 del

[PATCH v2 15/28] usb: dwc2: Check core parameters

Check that core parameters have valid values and adjust them if they aren't. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 185 ++ 1 file changed, 185 insertions(+) diff --git a/drivers/usb/dwc2/params.c b/d

[PATCH v2 17/28] usb: dwc2: Fix usage of bool params

Check these parameters only for true or false. There is no need to check for greater or less than 0. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 4 +- drivers/usb/dwc2/core.h | 5 -- drivers/usb/dwc2/core_intr.c | 2 +- drivers/usb/dwc2/ga

[PATCH v2 01/28] usb: dwc2: Cleanup some checkpatch issues

() with kcalloc(). * Concatenate multi-line strings. * Use the BIT() macro. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 22 +- drivers/usb/dwc2/core.h | 69 ++--- drivers/usb/dwc2/core_intr.c | 6 +- drivers/usb/dwc2/debug.h | 4 +- drivers/us

[PATCH v2 03/28] usb: dwc2: Fix comment alignment and format

Fix misaligned and over 80-character comments. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 19 ++- drivers/usb/dwc2/gadget.c | 43 +++ drivers/usb/dwc2/hcd.c | 2 +- drivers/usb/dwc2/hcd_

[PATCH v2 12/28] usb: dwc2: Get device properties

After setting the default core parameter values, read in the device properties and modify core parameter values if needed. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 35 +++ 1 file changed, 35 insertions(+) diff

[PATCH v2 10/28] usb: dwc2: Remove unused otg_ver parameter

The otg_ver parameter only controls the SRP pulsing method and defaults to the 1.3 behavior. It is unused and can be removed. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 5 - drivers/usb/dwc2/core.h | 9 - drivers/usb/dwc2/hcd.c

[PATCH v2 08/28] usb: dwc2: Remove 'return' from void function

The function returns void so a return is unnecessary. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/hcd_queue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c index faf45dfbf652..b1fc9fed6ebe

[PATCH v2 11/28] usb: dwc2: Set core parameters to default values

ter commit. This allows us to change only those parameters that won't work with default settings. It also allows us to use non-int parameters. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 4 - drivers/usb/dwc2/params.c | 990 ---

[PATCH v2 07/28] usb: dwc2: Fix code indentation after conditionals

The indent should be only one tab. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 09fadc26023f..559c01e591dc 100644 --- a/d

[PATCH v2 09/28] usb: dwc2: Fix sizeof in kzalloc

Take the sizeof '*req' instead of 'struct dwc2_hsotg_req'. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 559c01e591dc..b45752

Re: [PATCH] usb: dwc2: fix "iomem 0x00000000" message by setting iomem parameters in usb_hcd

On 1/17/2017 12:13 AM, Felipe Balbi wrote: > > Hi, > > Heiner Kallweit writes: >> Am 16.01.2017 um 15:05 schrieb Felipe Balbi: >>> >>> Hi, >>> >>> Heiner Kallweit writes: Set the iomem parameters in the usb_hcd to fix this misleading message

Re: [PATCH 1/4 v3] usb: dwc2: Avoid sleeping while holding hsotg->lock

2_conn_id_status_change+0x130/0x250 >>> [ 86.335254] [] process_one_work+0x118/0x370 >>> [ 86.341035] [] worker_thread+0x48/0x498 >>> [ 86.346473] [] kthread+0xd0/0xe8 >>> [ 86.351299] [] ret_from_fork+0x10/0x50 >>> >>> This seems to be

Re: [PATCH] usb: dwc2: host: use true/false for boolean

0); > - hsotg->bus_suspended = 0; > + hsotg->bus_suspended = false; > spin_unlock_irqrestore(>lock, flags); > } > > @@ -5000,7 +5000,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq) > hsotg->dev->dma_mask == NULL) { > dev_warn(

Re: [PATCH] usb: dwc2: host: use msleep() for long delays

000, 4); > + msleep(20); > spin_lock_irqsave(>lock, flags); > } > > @@ -3691,7 +3691,7 @@ static int dwc2_hcd_hub_control(struct dwc2_hsotg > *hsotg, u16 typereq, > } > > /* Clear reset bit in 10ms

Re: [PATCH RFC] usb: dwc2: host: use msleep() for long delay

rs/usb/dwc2/core.c > +++ b/drivers/usb/dwc2/core.c > @@ -455,7 +455,7 @@ void dwc2_clear_force_mode(struct dwc2_hsotg *hsotg) > dwc2_writel(gusbcfg, hsotg->regs + GUSBCFG); > > if (dwc2_iddig_filter_enabled(hsotg)) > - usleep_range(10, 11); >

Re: [PATCH V2] usb: dwc2: host: fix Wmaybe-uninitialized warning

peed = NULL; > > dev_vdbg(hsotg->dev, "%s, urb %p\n", fn_name, urb); > dev_vdbg(hsotg->dev, " Device address: %d\n", > +Felipe Acked-by: John Youn <johny...@synopsys.com> John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: dwc2: gadget: Fix GUSBCFG.USBTRDTIM value

On 1/12/2017 7:41 AM, Amelie DELAUNAY wrote: > Hi all, > Sorry, I did not see Pengcheng Li patch which is exactly the same: >

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

On 1/11/2017 11:51 PM, Felipe Balbi wrote: > > Hi, > > Baolin Wang writes: >>> Baolin Wang writes: When dwc3 controller acts as host role with attaching slow speed device (like mouse or keypad). Then if we plugged out the slow speed

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

On 1/12/2017 12:07 AM, Felipe Balbi wrote: > > Hi, > > John Youn <john.y...@synopsys.com> writes: >> On 1/11/2017 4:22 PM, John Stultz wrote: >>> Just wanted to resend my patches for dwc2 controller on the >>> HiKey board for consideration for th

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

exclude my patchset[1] to add extcon support to > dwc2, which John Youn suspects a pending rework of the dwc2 fifo > init logic might make unnecssary. > > thanks > -john > > [1] > https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2016_12_6_69=Dg

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On 1/11/2017 3:10 PM, John Stultz wrote: > On Wed, Jan 11, 2017 at 2:58 PM, John Youn <john.y...@synopsys.com> wrote: >> On 1/11/2017 2:39 PM, John Stultz wrote: >>> On Wed, Jan 11, 2017 at 2:08 PM, John Youn <john.y...@synopsys.com> wrote: >>>> On 1/3/20

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

On 1/11/2017 2:39 PM, John Stultz wrote: > On Wed, Jan 11, 2017 at 2:08 PM, John Youn <john.y...@synopsys.com> wrote: >> On 1/3/2017 11:52 AM, John Stultz wrote: >>> Hope everyone had a happy new years! >>> >>> I just wanted to send out my curren

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

xtcon support to dwc2, > which John Youn suspects a pending rework of the dwc2 fifo init > logic might make unnecssary. > > Any feedback would be greatly appreciated! > Hi John, Do you need these in 4.10-rc or is 4.11 ok? John -- To unsubscribe from this list: send the line

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

On 1/10/2017 3:03 PM, Christian Lamparter wrote: > On Tuesday, January 10, 2017 1:46:56 PM CET John Youn wrote: >> On 12/19/2016 6:49 AM, Christian Lamparter wrote: >>> (Lot's of old stuff, that doesn't matter anymore) > > Hello John, > >> This should be fi

Re: [PATCH v2 2/4] usb: dwc2: Add binding for AHB burst

On 12/19/2016 6:49 AM, Christian Lamparter wrote: > Hello John, hello Felipe > > On Monday, November 28, 2016 7:32:20 PM CET John Youn wrote: >> On 11/22/2016 12:51 PM, Christian Lamparter wrote: >>> On Monday, November 21, 2016 7:32:30 PM CET John Youn wrote: &g

Re: [PATCH 13/21] usb: dwc2: Update parameter types

On 1/10/2017 3:24 AM, Sergei Shtylyov wrote: > On 01/10/2017 05:24 AM, John Youn wrote: > >> Update the param types to appropriately sized ints and bools. >> >> Signed-off-by: John Youn <johny...@synopsys.com> >>

[PATCH 17/21] usb: dwc2: Fix usage of bool params

Check these parameters only for true or false. There is no need to check for greater or less than 0. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 4 +- drivers/usb/dwc2/core.h | 5 -- drivers/usb/dwc2/core_intr.c | 2 +- drivers/usb/dwc2/ga

[PATCH 21/21] usb: dwc2: Show dr_mode via debugfs

Show the value of dr_mode via a debufs file. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debugfs.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index 57747b0df595..794b95

[PATCH 20/21] usb: dwc2: Remove debug prints in params.c

Remove debugging prints to show params. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 56 --- 1 file changed, 56 deletions(-) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 0e7f0f

[PATCH 19/21] usb: dwc2: Add debugfs file to show params

Show the core params and hardware params. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debugfs.c | 127 + 1 file changed, 127 insertions(+) diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c

[PATCH 14/21] usb: dwc2: Rearrange param structure members

Group the members by global, host, and gadget params. Formatting and organizational change only. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 51 ++--- 1 file changed, 23 insertions(+), 28 deletions(-) diff

[PATCH 05/21] usb: dwc2: Fix brace usage

* Remove braces for one-line statements * Add missing braces where another arm in if-statement uses braces Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 10 -- drivers/usb/dwc2/platform.c | 12 ++-- 2 files changed, 10 insertions(

[PATCH 18/21] usb: dwc2: Remove unnecessary parameters

Further reduce the set of parameters set by platforms. Many of them are unnecessary as they should be reported by hardware. They should only need to be overridden if there is a problem. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 11 ---

[PATCH 16/21] usb: dwc2: Remove platform static params

Remove the platform-specific static param structs and set only those params that are necessary for each platform. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 262 +++--- 1 file changed, 108 insertions(+), 154 del

[PATCH 08/21] usb: dwc2: Remove 'return' from void function

The function returns void so a return is unnecessary. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/hcd_queue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c index faf45dfbf652..b1fc9fed6ebe

[PATCH 13/21] usb: dwc2: Update parameter types

Update the param types to appropriately sized ints and bools. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 52 - 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/usb/dwc2/core.h b/drive

[PATCH 10/21] usb: dwc2: Remove unused otg_ver parameter

The otg_ver parameter only controls the SRP pulsing method and defaults to the 1.3 behavior. It is unused and can be removed. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 5 - drivers/usb/dwc2/core.h | 9 - drivers/usb/dwc2/hcd.c

[PATCH 15/21] usb: dwc2: Check core parameters

Check that core parameters have valid values and adjust them if they aren't. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 185 ++ 1 file changed, 185 insertions(+) diff --git a/drivers/usb/dwc2/params.c b/d

[PATCH 12/21] usb: dwc2: Get device properties

After setting the default core parameter values, read in the device properties and modify core parameter values if needed. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/params.c | 35 +++ 1 file changed, 35 insertions(+) diff

[PATCH 11/21] usb: dwc2: Set core parameters to default values

ter commit. This allows us to change only those parameters that won't work with default settings. It also allows us to use non-int parameters. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 4 - drivers/usb/dwc2/params.c | 990 ---

[PATCH 09/21] usb: dwc2: Fix sizeof in kzalloc

Take the sizeof '*req' instead of 'struct dwc2_hsotg_req'. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index d3fe990f6539..f2c8ef

[PATCH 06/21] usb: dwc2: Fix lines over 80 characters

Fix lines over 80 characters. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 13 + drivers/usb/dwc2/gadget.c | 14 +- drivers/usb/dwc2/hcd.c | 4 ++-- drivers/usb/dwc2/hcd_intr.c | 13 +++-- drivers/usb/dwc2/pa

[PATCH 07/21] usb: dwc2: Fix code indentation after conditionals

The indent should be only one tab. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 227f27dbadd0..d3fe990f6539 100644 --- a/d

[PATCH 03/21] usb: dwc2: Fix comment alignment and format

Fix misaligned and over 80-character comments. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 19 ++- drivers/usb/dwc2/gadget.c | 43 +++ drivers/usb/dwc2/hcd.c | 2 +- drivers/usb/dwc2/hcd_

[PATCH 04/21] usb: dwc2: Fix logical continuations

Fix the formatting of logical statements to end the line with the logical operator. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core_intr.c | 5 ++--- drivers/usb/dwc2/hcd_ddma.c | 8 drivers/usb/dwc2/hcd_queue.c | 5 ++--- 3 files changed, 8 insertions(

[PATCH 00/21] usb: dwc2: Rework core parameters

rc.info/?l=linux-usb=148046010906392=2 John Youn (21): usb: dwc2: Cleanup some checkpatch issues usb: dwc2: Add identifier in prototypes usb: dwc2: Fix comment alignment and format usb: dwc2: Fix logical continuations usb: dwc2: Fix brace usage usb: dwc2: Fix lines over 80 characters usb:

[PATCH 02/21] usb: dwc2: Add identifier in prototypes

Fixes checkpatch warning: WARNING: function definition argument 'struct dwc2_hsotg *' should also have an identifier name Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/us

[PATCH 01/21] usb: dwc2: Cleanup some checkpatch issues

() with kcalloc(). * Concatenate multi-line strings. * Use the BIT() macro. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 22 +- drivers/usb/dwc2/core.h | 69 ++--- drivers/usb/dwc2/core_intr.c | 6 +- drivers/usb/dwc2/debug.h | 4 +- drivers/us

[PATCH 3/3] usb: dwc2: Avoid suspending if we're in gadget mode

Chen Yu suggested this patch to avoid suspending if we're in device mode, and it avoids the problem. Cc: Wei Xu <xuw...@hisilicon.com> Cc: Guodong Xu <guodong...@linaro.org> Cc: Amit Pundir <amit.pun...@linaro.org> Cc: Rob Herring <robh...@kernel.org> Cc: John Youn <j

[PATCH 1/3] usb: dwc2: use u32 for DT binding parameters

t two parameters cannot be passed successfully with wrong data format. This is found the data transferring broken on 96boards Hikey. This patch is to change all parameters to u32 type, and verified on Hikey board the DT parameters can pass successfully. [johnyoun: minor rebase] Signed-off-by: Leo Yan

[PATCH 0/3] usb: dwc2: fixes for 4.10-rc4

Hi Felipe, These are a few dwc2 fixes from the list that are missing in your tree. Can you queue for the next -rc? Thanks, John John Stultz (1): usb: dwc2: Avoid suspending if we're in gadget mode Leo Yan (1): usb: dwc2: use u32 for DT binding parameters Vardan Mikayelyan (1): usb:

[PATCH 2/3] usb: dwc2: gadget: Fix DMA memory freeing

From: Vardan Mikayelyan <mvar...@synopsys.com> Remove DMA memory free from EP disable flow by replacing dma_alloc_coherent with dmam_alloc_coherent. Cc: John Stultz <john.stu...@linaro.org> Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <

Re: [PATCH] usb: dwc2: use u32 for DT binding parameters

On 1/6/2017 1:52 PM, John Stultz wrote: > On Fri, Jan 6, 2017 at 4:45 AM, Leo Yan wrote: >> Commit 05ee799f2021 ("usb: dwc2: Move gadget settings into core_params") >> changes to type u16 for DT binding "g-rx-fifo-size" and >> "g-np-tx-fifo-size" but use type u32 for

[PATCH] usb: dwc2: use u32 for DT binding parameters

t two parameters cannot be passed successfully with wrong data format. This is found the data transferring broken on 96boards Hikey. This patch is to change all parameters to u32 type, and verified on Hikey board the DT parameters can pass successfully. [johnyoun: minor rebase] Signed-off-by: Leo Yan

Re: [PATCH] usb: dwc2: gadget: Fix DMA memory freeing

On 1/6/2017 3:10 PM, John Stultz wrote: > On Thu, Jan 5, 2017 at 6:01 PM, John Youn <john.y...@synopsys.com> wrote: >> From: Vardan Mikayelyan <mvar...@synopsys.com> >> >> Remove DMA memory free from EP disable flow by replacing >> dma_alloc_coherent with dma

[PATCH] usb: dwc2: gadget: Fix DMA memory freeing

From: Vardan Mikayelyan <mvar...@synopsys.com> Remove DMA memory free from EP disable flow by replacing dma_alloc_coherent with dmam_alloc_coherent. Cc: John Stultz <john.stu...@linaro.org> Signed-off-by: Vardan Mikayelyan <mvar...@synopsys.com> Signed-off-by: John Youn <

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

On 12/28/2016 5:29 PM, John Youn wrote: > > >> Janusz Dziedzic <janusz.dzied...@gmail.com> writes: >>>>>> On some platfroms(like x86 platform), when one core is running the >> USB gadget >>>>>> irq thread handler by dwc3_thread_interrup

Re: [PATCH 0/5 v2] Fixes and workarounds for dwc2 on HiKey board

rd for consideration for the 4.11 >> merge window. >> >> This does exclude my patchset[1] to add extcon support to dwc2, >> which John Youn suspects a pending rework of the dwc2 fifo init >> logic might make unnecssary. > > John/Vardan: Just as a heads up, al

RE: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Wednesday, December 28, 2016 8:19 AM > To: Janusz Dziedzic > Cc: Lu Baolu ; Baolin Wang >

RE: [PATCH 0/9] usb: dwc2: Fix checkpatch issues

> -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Tuesday, December 27, 2016 3:37 AM > To: John Youn <john.y...@synopsys.com>; John Youn > <john.y...@synopsys.com>; linux-usb@vger.kernel.org > Subject: Re: [PATCH 0/9] usb: dwc2: Fi

RE: [PATCH v2] usb: dwc3: pci: Add "linux,sysdev_is_parent" property

> -Original Message- > From: Felipe Balbi [mailto:ba...@kernel.org] > Sent: Tuesday, December 27, 2016 3:33 AM > To: John Youn <john.y...@synopsys.com>; linux-usb@vger.kernel.org > Cc: John Youn <john.y...@synopsys.com>; Sriram Dash > <sriram.d..

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

On 12/7/2016 7:06 PM, John Youn wrote: > On 12/7/2016 4:44 AM, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros <rog...@ti.com> writes: >>>>> Roger Quadros <rog...@ti.com> writes: >>>>>> DCFG.DEVSPD == 0x3 is no

Re: [REGRESSION] dwc2: 5f54c54b0ba8 Add DDMA chain pointers to dwc2_hsotg_ep structure

On 12/13/2016 3:23 PM, John Stultz wrote: > I've found trying to boot Linus' HEAD today on HiKey, I'm hitting the > following WARNINGS/panics, which I bisected down to being introduced > with 5f54c54b0ba8 ("Add DDMA chain pointers to dwc2_hsotg_ep > structure"). > > It seems the issue is calling

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

On 12/8/2016 4:25 PM, John Stultz wrote: > On Thu, Dec 8, 2016 at 4:17 PM, John Youn <john.y...@synopsys.com> wrote: >> On 12/8/2016 3:12 PM, John Stultz wrote: >>> Hey John, >>> In my testing I've come across another issue in the dwc2 driver. >>> >

Re: BUG: scheduling while atomic from dwc2_hsotg_core_init_disconnected

On 12/8/2016 3:12 PM, John Stultz wrote: > Hey John, > In my testing I've come across another issue in the dwc2 driver. > > Basically when plugging in various cables in different orders, I'm > occasionally seeing the following BUG splat: > > [ 86.215403] BUG: scheduling while atomic:

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

On 12/8/2016 2:43 PM, John Stultz wrote: > On Tue, Dec 6, 2016 at 7:52 PM, John Youn <john.y...@synopsys.com> wrote: >> On 12/6/2016 5:48 PM, John Stultz wrote: >>> Hey John, >>> Just wanted to send this by you, as it seems something is >>> slightly off

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

On 12/7/2016 4:44 AM, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: Roger Quadros writes: > DCFG.DEVSPD == 0x3 is not valid and we need to set > DCFG.DEVSPD to 0x1 for full speed mode. seems like it has been made invalid somewhere

Re: [RFC][PATCH] HACK: usb: dwc2: Workaround case where GOTGCTL state is wrong

d host modes? > > I suspect this isn't the best solution, but it seems to work > well for me. > The workaround seems fine, but still, this indicates that something wrong is going on somwhere. You can add my ack: Acked-by: John Youn <johny...@synopsys.com> Regards, John > Fe

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

On 12/6/2016 4:05 PM, John Stultz wrote: > On Tue, Dec 6, 2016 at 3:17 PM, John Youn <john.y...@synopsys.com> wrote: >> On 12/6/2016 12:06 AM, John Stultz wrote: >>> This patch wires up extcon support to the dwc2 driver >>> so that devices that use a modern gen

Re: [RFC][PATCH 1/3 v2] usb: dwc2: Add extcon support to dwc2 driver

com> > Cc: Guodong Xu <guodong...@linaro.org> > Cc: Amit Pundir <amit.pun...@linaro.org> > Cc: Rob Herring <robh...@kernel.org> > Cc: John Youn <johny...@synopsys.com> > Cc: Douglas Anderson <diand...@chromium.org> > Cc: Chen Yu <cheny...@

Re: [PATCH v9 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

On 12/6/2016 4:00 AM, Ayaka wrote: > Hello John > I still waiting them be merged, but I still can't find it at next-20161206. > Can you resubmit this fixing the checkpatch issues? You can add my ack: Acked-by: John Youn <johny...@synopsys.com> Regards, John > 從我的 iPad

Re: [PATCH] usb: dwc2: fix flags for DMA descriptor allocation in dwc2_hsotg_ep_enable

ev, > MAX_DMA_DESC_NUM_GENERIC * > sizeof(struct dwc2_dma_desc), > - _ep->desc_list_dma, GFP_KERNEL); > + _ep->desc_list_dma, GFP_ATOMIC); > if (!hs_ep->desc_list) { >

Re: [RFC][PATCH 1/3] phy: phy-hi6220-usb: Wire up extconn support to hikey's phy driver

ong...@linaro.org> >>> Cc: Amit Pundir <amit.pun...@linaro.org> >>> Cc: Rob Herring <robh...@kernel.org> >>> Cc: John Youn <johny...@synopsys.com> >>> Cc: Douglas Anderson <diand...@chromium.org> >>> Cc: Chen Yu <cheny..

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

On 11/30/2016 4:47 AM, Felipe Balbi wrote: > > Hi, > > Raviteja Garimella writes: >> Hi Balbi, >> >> On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Raviteja Garimella writes:

[PATCH 3/9] usb: dwc2: Fix comment alignment and format

Fix misaligned and over 80-character comments. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 19 ++- drivers/usb/dwc2/gadget.c | 43 +++ drivers/usb/dwc2/hcd.c | 2 +- drivers/usb/dwc2/hcd_

[PATCH 4/9] usb: dwc2: Fix logical continuations

Fix the formatting of logical statements to end the line with the logical operator. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core_intr.c | 5 ++--- drivers/usb/dwc2/hcd_ddma.c | 8 drivers/usb/dwc2/hcd_queue.c | 5 ++--- 3 files changed, 8 insertions(

[PATCH 7/9] usb: dwc2: Fix code indentation after conditionals

The indent should be only one tab. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 4fc115e..01c87e8 100644 --- a/drivers/us

[PATCH 6/9] usb: dwc2: Fix lines over 80 characters

Fix lines over 80 characters. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.h | 13 + drivers/usb/dwc2/gadget.c | 14 +- drivers/usb/dwc2/hcd.c | 4 ++-- drivers/usb/dwc2/hcd_intr.c | 13 +++-- drivers/usb/dwc2/pa

[PATCH 2/9] usb: dwc2: Add identifier in prototypes

Fixes checkpatch warning: WARNING: function definition argument 'struct dwc2_hsotg *' should also have an identifier name Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/us

[PATCH 8/9] usb: dwc2: Remove 'return' from void function

The function returns void so a return is unnecessary. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/hcd_queue.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c index faf45df..b1fc9fe 100644 --- a/drive

[PATCH 0/9] usb: dwc2: Fix checkpatch issues

for correctness. Regards, John John Youn (9): usb: dwc2: Cleanup some checkpatch issues usb: dwc2: Add identifier in prototypes usb: dwc2: Fix comment alignment and format usb: dwc2: Fix logical continuations usb: dwc2: Fix brace usage usb: dwc2: Fix lines over 80 characters usb: dwc2

[PATCH 9/9] usb: dwc2: Fix sizeof in kzalloc

Take the sizeof '*req' instead of 'struct dwc2_hsotg_req'. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 01c87e8..d867cb5

[PATCH 5/9] usb: dwc2: Fix brace usage

* Remove braces for one-line statements * Add missing braces where another arm in if-statement uses braces Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/gadget.c | 10 -- drivers/usb/dwc2/platform.c | 12 ++-- 2 files changed, 10 insertions(

[PATCH 1/9] usb: dwc2: Cleanup some checkpatch issues

() with kcalloc(). * Concatenate multi-line strings. * Use the BIT() macro. Signed-off-by: John Youn <johny...@synopsys.com> --- drivers/usb/dwc2/core.c | 22 +- drivers/usb/dwc2/core.h | 69 ++--- drivers/usb/dwc2/core_intr.c | 6 +- drivers/usb/dwc2/debug.h | 4 +- drivers/us

<    1   2   3   4   5   6   7   8   9   10   >