On 9/24/2015 10:28 AM, Roman Bacik wrote:
>> -Original Message-
>> From: John Youn [mailto:john.y...@synopsys.com]
>> Sent: September-23-15 9:21 PM
>> To: Scott Branden; John Youn; Greg Kroah-Hartman; linux-
>> u...@vger.kernel.org; Roman Bacik
>> C
On 9/23/2015 8:39 AM, Scott Branden wrote:
> On 15-09-23 01:18 AM, John Youn wrote:
>> On 9/23/2015 1:11 AM, John Youn wrote:
>>> On 9/23/2015 12:36 AM, Scott Branden wrote:
>>>> Hi John,
>>>>
>>>> Could you please review the v3 Patch
On 9/23/2015 12:36 AM, Scott Branden wrote:
> Hi John,
>
> Could you please review the v3 Patch. I believe we have address all of
> your comments?
>
Yes I've been meaning to test it on our platforms. I should be
able to get to it tomorrow.
Regards,
John
--
To unsubscribe from this list:
On 9/23/2015 1:11 AM, John Youn wrote:
> On 9/23/2015 12:36 AM, Scott Branden wrote:
>> Hi John,
>>
>> Could you please review the v3 Patch. I believe we have address all of
>> your comments?
>>
>
> Yes I've been meaning to test it on our platforms. I
On 9/10/2015 6:14 PM, Scott Branden wrote:
> This patch contains a fix for a real world interop problem found
> when using the Synopsis DWC2 USB controller with isochronous audio as
> detailed in the commit message.
>
> Changes from v2:
> - created s2c_hsotg_chage_ep_iso_parity function to call
On 9/18/2015 11:50 AM, Felipe Balbi wrote:
> On Thu, Aug 27, 2015 at 12:10:24AM +0000, John Youn wrote:
>> On 8/20/2015 11:43 AM, Antti Seppälä wrote:
>>> This patch switches calls to readl/writel to their
>>> dwc2_readl/dwc2_writel equivalents which p
ome files were then hand-edited to fix checkpatch.pl warnings about
too long lines.
Signed-off-by: Antti Seppälä <a.sepp...@gmail.com>
Signed-off-by: Vincent Pelletier <plr.vinc...@gmail.com>
Signed-off-by: John Youn <johny...@synopsys.com>
---
Resend of previous patch from A
On 9/9/2015 3:21 AM, Mian Yousaf Kaukab wrote:
> Make sure there are no requests pending on ep0 before reinitializing
> core. Otherwise, dwc2_hsotg_enqueue_setup will fail afterwards.
>
> Signed-off-by: Mian Yousaf Kaukab
> Tested-by: Robert Baldyga
On 9/9/2015 3:20 AM, Mian Yousaf Kaukab wrote:
> From: Gregory Herrero
>
> lx_state must be used to reflect controller power state only and not
> bus state. Thus add a flag to track state during bus suspend.
>
> Signed-off-by: Gregory Herrero
On 9/9/2015 3:21 AM, Mian Yousaf Kaukab wrote:
> From: Gregory Herrero
>
> No point of continue with initialization if core is not in a sane
> state.
>
> Signed-off-by: Gregory Herrero
> Signed-off-by: Mian Yousaf Kaukab
On 9/9/2015 3:20 AM, Mian Yousaf Kaukab wrote:
> Hi,
> This series consists of various bug fixes for both host and gadget
> sides. All patches are verified on dwc2 v3.0a with dedicated fifos.
> It would be good to get some Tested-bys for other platforms.
>
> It is based on testing/next branch in
On 9/10/2015 10:56 AM, Roman Bacik wrote:
>> -Original Message-
>> From: Roman Bacik
>> Sent: September-09-15 7:59 PM
>> To: 'John Youn'; Scott Branden; 'Greg Kroah-Hartman'; 'linux-
>> u...@vger.kernel.org'
>> Cc: 'linux-ker...@vger.kernel.org'; bcm
On 9/9/2015 11:16 AM, Roman Bacik wrote:
>> -Original Message-
>> From: John Youn [mailto:john.y...@synopsys.com]
>> Sent: September-03-15 11:53 PM
>> To: Scott Branden; John Youn; Greg Kroah-Hartman; linux-
>> u...@vger.kernel.org; Roman Bacik
>> C
On 9/9/2015 7:16 PM, Roman Bacik wrote:
>> -Original Message-
>> From: John Youn [mailto:john.y...@synopsys.com]
>> Sent: September-09-15 7:11 PM
>> To: Roman Bacik; John Youn; Scott Branden; Greg Kroah-Hartman; linux-
>> u...@vger.kernel.org
>> Cc: linu
On 9/4/2015 3:58 AM, Joao Pinto wrote:
> When testing the Synopsys DWC USB 3.0 Device IP, Compliant Tests are run
> for USB 3.0 and USB 2.0. An issue was found regarding the USB 2.0 CV
> Chapter 9 test: LPM L1 Suspend Resume Test. For it to be successful it
> is necessary to add besl support to
On 8/31/2015 9:17 AM, Scott Branden wrote:
> From: Roman Bacik
>
> USB OTG driver in isochronous mode has to set the parity of the receiving
> microframe. The parity is set to even by default. This causes problems for
> an audio gadget, if the host starts transmitting on odd
On 8/21/2015 5:39 AM, Marek Szyprowski wrote:
> DWC2 module on some platforms needs three additional hardware
> resources: phy controller, clock and power supply. All of them must be
> enabled/activated to properly initialize and operate. This was initially
> handled in s3c-hsotg driver, which has
-by: John Youn johny...@synopsys.com
Hi Felipe,
Can you queue this for 4.4? I can remind you after the merge
window.
Regards,
John
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On 8/18/2015 8:45 AM, Scott Branden wrote:
From: Roman Bacik rba...@broadcom.com
USB OTG driver in isochronous mode has to set the parity of the receiving
microframe. The parity is set to even by default. This causes problems for
an audio gadget, if the host starts transmitting on odd
On 8/25/2015 3:00 PM, Roman Bacik wrote:
-Original Message-
From: John Youn [mailto:john.y...@synopsys.com]
Sent: August-25-15 2:52 PM
To: Scott Branden; John Youn; Greg Kroah-Hartman; linux-
u...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org; bcm-kernel-feedback-list; Roman Bacik
/dwc2/gadget.c | 696
drivers/usb/dwc2/hcd.c | 4 +-
drivers/usb/dwc2/platform.c | 8 +-
include/linux/platform_data/s3c-hsotg.h | 10 +-
Hi Felipe,
For dwc2/*:
Acked-by: John Youn johny...@synopsys.com
Tested
On 8/19/2015 5:22 AM, Yunzhi Li wrote:
We initiate dwc2 usb controller in BIOS, dwc2_core_reset() should
be called before dwc2_get_hwparams() to reset core registers to
default value. Without this the FIFO setting might be incorrect
because calculating FIFO size need power-on value of
On 8/18/2015 2:41 AM, Yunzhi Li wrote:
We initiate dwc2 usb controller in BIOS, dwc2_core_reset() should
be called before dwc2_get_hwparams() to reset core registers to
default value. Without this the FIFO setting might be incorrect
because calculating FIFO size need power-on value of
On 8/13/2015 8:29 PM, Yunzhi Li wrote:
在 2015/8/14 8:09, John Youn 写道:
On 8/11/2015 12:57 AM, Yunzhi Li wrote:
We initiate dwc2 usb controller in BIOS, when kernel driver
start-up we should reset AHB hclk domain to reset all AHB
interface registers to default. Without this the FIFO value
On 8/12/2015 12:33 PM, Felipe Balbi wrote:
On Wed, Aug 12, 2015 at 07:06:09PM +0800, Yunzhi Li wrote:
Hi ,
在 2015/8/11 22:12, Felipe Balbi 写道:
Hi,
On Tue, Aug 11, 2015 at 10:27:42AM +0800, Yunzhi Li wrote:
We initiate dwc2 usb controller in BIOS, when kernel driver
start-up we should reset
On 8/11/2015 12:57 AM, Yunzhi Li wrote:
We initiate dwc2 usb controller in BIOS, when kernel driver
start-up we should reset AHB hclk domain to reset all AHB
interface registers to default. Without this the FIFO value
setting might be incorrect because calculating FIFO size need the
power-on
.
Signed-off-by: John Youn johny...@synopsys.com
---
drivers/usb/dwc3/ep0.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c
index 2ef3c8d..69e769c 100644
--- a/drivers/usb/dwc3/ep0.c
+++ b/drivers/usb/dwc3/ep0.c
@@ -727,6 +727,10 @@ static int
On 7/20/2015 10:51 AM, Felipe Balbi wrote:
Hi,
On Wed, Jul 15, 2015 at 09:49:05AM +, Subbaraya Sundeep Bhatta wrote:
Hi John,
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Tuesday, July 14, 2015 12:29 AM
To: John Youn
Cc: ba...@ti.com; Subbaraya Sundeep
On 7/1/2015 8:00 PM, Felipe Balbi wrote:
On Thu, Jul 02, 2015 at 02:03:14AM +, John Youn wrote:
On 6/29/2015 2:48 PM, Felipe Balbi wrote:
Hi again,
On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
We
On 6/29/2015 2:48 PM, Felipe Balbi wrote:
Hi again,
On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
We need to return error to caller if command is not sent to
controller succesfully.
Signed-off-by:
On 6/29/2015 2:04 AM, Mian Yousaf Kaukab wrote:
This series fixes 3 sources of sleep while atomic bugs. Including
the one reported by Heiko Stuebner here:
http://www.spinics.net/lists/linux-usb/msg125186.html
Please review.
Thank you,
Best regards,
Yousaf
History:
v2:
- Fixed
On 6/29/2015 2:48 PM, Felipe Balbi wrote:
Hi again,
On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
We need to return error to caller if command is not sent to
controller succesfully.
Signed-off-by:
On 6/22/2015 4:00 PM, Doug Anderson wrote:
Hi,
On Thu, Jun 4, 2015 at 6:12 AM, Kaukab, Yousaf yousaf.kau...@intel.com
wrote:
Tested-by: Heiko Stuebner he...@sntech.de
-- 8 --
[ 19.799200] BUG: sleeping function called from invalid context at
mm/slab.c:2863
On 6/10/2015 6:27 AM, Kaukab, Yousaf wrote:
-Original Message-
From: John Youn [mailto:john.y...@synopsys.com]
Sent: Wednesday, June 10, 2015 1:06 AM
To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com;
john.y...@synopsys.com
Cc: Herrero, Gregory; he...@sntech.de; Holmberg
the
* request tries to queue more work for this endpoint.
Acked-by: John Youn johny...@synopsys.com
John
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
dwc2_hcd_urb *urb = qtd-urb;
- int allocated = 0;
int retval;
/*
* Get the QH which holds the QTD-list to insert to. Create QH if it
* doesn't exist.
*/
This comment doesn't apply anymore. Otherwise the series looks ok.
Acked-by: John Youn johny
Hi Dinh,
Responding again to the proper message to add linux-usb. And also
added more comments.
On 5/26/2015 7:32 PM, dingu...@opensource.altera.com wrote:
From: Dinh Nguyen dingu...@opensource.altera.com
For platforms that use a ULPI phy, we should enable the external VbusValid
signal
Youn and Julius Werner
- Fixed regression, found by John, when switching to gadget mode
after running host mode
- Added patch to add core parameter for enabling/disabling
hibernation
- Added patch to build dwc2_pci.ko independent from dwc2.ko
v1:
- Fixed comments from John Youn
;
- s3c_hsotg_of_probe(hsotg);
-
/* Initialize to legacy fifo configuration values */
hsotg-g_rx_fifo_sz = 2048;
hsotg-g_np_g_tx_fifo_sz = 1024;
Acked-by: John Youn johny...@synopsys.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb
On 4/28/2015 3:50 PM, John Youn wrote:
On 4/26/2015 12:36 AM, Yunzhi Li wrote:
dwc2 gadget driver s3c_hsotg_of_probe() run twice in
dwc2_gadget_init() and the first one is useless, so remove it.
Signed-off-by: Yunzhi Li l...@rock-chips.com
---
drivers/usb/dwc2/gadget.c | 2 --
1 file
is
statically linked
due to http://marc.info/?l=linux-usbm=142661773703793w=2
- usb: dwc2: host: ensure qtb exists before dereferencing it is added
to fix a NULL pointer dereferencing bug
v2:
- Fixed comments from John Youn and Julius Werner
- Fixed regression, found by John, when switching
On 3/20/2015 8:35 AM, Mian Yousaf Kaukab wrote:
Hi,
This patchset consists of some bug fixes and feature enhancements for
the dwc2 driver. All the patches are verified on dwc2 v3.0a with
dedicated fifos. Main focus of testing was with dma enabled. Although
basic testing without dma was also
On 3/16/2015 6:43 AM, Kaukab, Yousaf wrote:
-Original Message-
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Saturday, March 14, 2015 6:11 PM
To: John Youn
Cc: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com; Herrero,
Gregory; r.bald...@samsung.com; dingu
.
Acked-by: John Youn johny...@synopsys.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The dwc2-pci driver requires the generic PHY. This fixes undefined
reference issues when it is not selected.
Reported-by: kbuild test robot fengguang...@intel.com
Signed-off-by: John Youn johny...@synopsys.com
---
This fixes issue with commit 9024c495 on -next.
John
drivers/usb/dwc2/Kconfig
;
+ }
platform_set_drvdata(dev, hsotg);
Acked-by: John Youn johny...@synopsys.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
has the effect of adding device and DRD mode to
the pci driver. Tested on the Synopsys HAPS PCIe platform.
Signed-off-by: John Youn johny...@synopsys.com
---
drivers/usb/dwc2/Kconfig | 7 ++-
drivers/usb/dwc2/pci.c | 159 +--
2 files changed, 76
On 3/9/2015 8:04 AM, Mian Yousaf Kaukab wrote:
+
+int dwc2_debugfs_init(struct dwc2_hsotg *hsotg)
+{
+ int ret;
+
+ hsotg-debug_root = debugfs_create_dir(dev_name(hsotg-dev), NULL);
+ if (!hsotg-debug_root) {
+ ret = -ENOMEM;
+ goto
On 3/9/2015 8:04 AM, Mian Yousaf Kaukab wrote:
From: Gregory Herrero gregory.herr...@intel.com
When suspending usb bus, phy driver may disable controller power.
In this case, registers need to be saved on suspend and restored
on resume.
Signed-off-by: Gregory Herrero
On 3/9/2015 8:04 AM, Mian Yousaf Kaukab wrote:
So the parameters can be used in both host and gadget modes.
Signed-off-by: Mian Yousaf Kaukab yousaf.kau...@intel.com
---
drivers/usb/dwc2/core.h | 3 +--
drivers/usb/dwc2/hcd.c | 18 +-
drivers/usb/dwc2/hcd.h
On 3/9/2015 8:05 AM, Mian Yousaf Kaukab wrote:
From: Gregory Herrero gregory.herr...@intel.com
During urb_enqueue, if the urb can't be queued to the endpoint,
the urb is freed without any spinlock protection.
This leads to memory corruption when concurrent urb_dequeue try to free
same
On 2/20/2015 7:26 PM, zhangfei wrote:
Hi, John
On 02/21/2015 08:35 AM, John Youn wrote:
On 2/15/2015 5:50 AM, Zhangfei Gao wrote:
Reuse ahbcfg if assigned from platform
Input from John:
AHB_SINGLE, NOTI_ALL_DMA_WRIT, REM_MEM_SUPP, HBSTLEN,
and INV_DESC_ENDIANNESS only apply in DMA mode
On 2/15/2015 5:50 AM, Zhangfei Gao wrote:
Reuse ahbcfg if assigned from platform
Input from John:
AHB_SINGLE, NOTI_ALL_DMA_WRIT, REM_MEM_SUPP, HBSTLEN,
and INV_DESC_ENDIANNESS only apply in DMA mode and are
ignored in slave mode operation.
Signed-off-by: Zhangfei Gao
On 2/6/2015 8:50 AM, Romain Perier wrote:
Don't register interrupt handler before usb gadget is correctly initialized.
For some embedded platforms which don't have a usb-phy, it crashes the driver
because an interrupt is emitted with non-initialized hardware.
According to devm_request_irq
On 2/12/2015 1:04 AM, Kaukab, Yousaf wrote:
-Original Message-
From: John Youn [mailto:john.y...@synopsys.com]
Sent: Wednesday, February 11, 2015 11:00 PM
To: Zhangfei Gao; Kaukab, Yousaf
Cc: ba...@ti.com; john.y...@synopsys.com; linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb
On 2/12/2015 4:42 AM, Romain Perier wrote:
ping
2015-02-06 17:50 GMT+01:00 Romain Perier romain.per...@gmail.com:
Don't register interrupt handler before usb gadget is correctly initialized.
For some embedded platforms which don't have a usb-phy, it crashes the driver
because an interrupt
On 2/6/2015 2:23 PM, John Youn wrote:
On 2/6/2015 6:02 AM, Zhangfei Gao wrote:
On 6 February 2015 at 16:07, Kaukab, Yousaf yousaf.kau...@intel.com wrote:
GAHBCFG_HBSTLEN_INCR4 diff --git a/drivers/usb/dwc2/gadget.c
b/drivers/usb/dwc2/gadget.c index 15aa578..20085de 100644
--- a/drivers/usb
On 2/11/2015 3:42 AM, Roy wrote:
Hi John Youn:
Could you please give some suggestions from your point of view,
about this probe time issue ?
Thanks a lot.
at 2015/2/11 2:23, Julius Werner wrote:
@@ -2703,7 +2703,7 @@ int dwc2_get_hwparams(struct dwc2_hsotg *hsotg
On 2/6/2015 6:02 AM, Zhangfei Gao wrote:
On 6 February 2015 at 16:07, Kaukab, Yousaf yousaf.kau...@intel.com wrote:
GAHBCFG_HBSTLEN_INCR4 diff --git a/drivers/usb/dwc2/gadget.c
b/drivers/usb/dwc2/gadget.c index 15aa578..20085de 100644
--- a/drivers/usb/dwc2/gadget.c
+++
;
/* Direction in or both */
if (!(ep_type 2)) {
Good catch on this.
Acked-by: John Youn johny...@synopsys.com
Hi Felipe,
Any chance you'll accept this into your 3.20 queue?
It affects any DWC2 core instance that has unidirectional endpoints defined.
Regards,
John
On 01/28/2015 11:26 PM, Kaukab, Yousaf wrote:
-Original Message-
From: John Youn [mailto:john.y...@synopsys.com]
Sent: Thursday, January 29, 2015 3:25 AM
To: Kaukab, Yousaf; linux-usb@vger.kernel.org; ba...@ti.com;
john.y...@synopsys.com
Cc: Herrero, Gregory; r.bald...@samsung.com
-by: John Youn johny...@synopsys.com
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/28/2015 02:02 AM, Antti Seppälä wrote:
On 27 January 2015 at 04:18, John Youn john.y...@synopsys.com wrote:
From: Vincent Pelletier [mailto:plr.vinc...@gmail.com]
Sent: Friday, January 23, 2015 12:19 AM
On Fri, 23 Jan 2015 02:38:37 +, John Youn john.y...@synopsys.com
wrote:
Having
From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com]
Sent: Wednesday, January 21, 2015 6:37 AM
From: Gregory Herrero gregory.herr...@intel.com
If phy driver is present, register hcd handle to it and let it take
care of calling usb_add_hcd. Otherwise, add hcd here.
Moreover, save
From: Vincent Pelletier [mailto:plr.vinc...@gmail.com]
Sent: Friday, January 23, 2015 12:19 AM
On Fri, 23 Jan 2015 02:38:37 +, John Youn john.y...@synopsys.com
wrote:
Having the __raw functions everywhere is not pretty and probably not a
good idea either.
I would rather have
From: Antti Seppälä [mailto:a.sepp...@gmail.com]
Sent: Wednesday, January 21, 2015 10:28 AM
This patch switches calls to readl/writel to their
__raw_readl/__raw_writel equivalents which preserve platform endianness.
This patch is necessary to access dwc2 registers correctly on big endian
From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com]
Sent: Wednesday, January 21, 2015 6:37 AM
Hi,
This patchset consists of some bug fixes, feature enhancements and
cosmetic changes for the dwc2 driver. All the patches are verified on
dwc2 v3.0a with dedicated fifos. Main focus
From: Mian Yousaf Kaukab [mailto:yousaf.kau...@intel.com]
Sent: Wednesday, January 21, 2015 6:37 AM
Hi,
This patchset consists of some bug fixes, feature enhancements and
cosmetic changes for the dwc2 driver. All the patches are verified on
dwc2 v3.0a with dedicated fifos. Main focus of
901 - 968 of 968 matches
Mail list logo