Re: [PATCH v3 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

Hi Felipe, On 1 December 2014 at 11:09, Kiran Raparthy kiran.ku...@linaro.org wrote: Hi Felipe, On 25 November 2014 at 20:15, Felipe Balbi ba...@ti.com wrote: On Tue, Nov 25, 2014 at 07:06:18AM +, Peter Chen wrote: usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

Re: [PATCH v3 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

Hi Felipe, On 25 November 2014 at 20:15, Felipe Balbi ba...@ti.com wrote: On Tue, Nov 25, 2014 at 07:06:18AM +, Peter Chen wrote: usb: phy: hold wakeupsource when USB is enumerated in peripheral mode Some systems require a mechanism to prevent system to enter into suspend state

[PATCH v3 1/3] usb: phy: introduce usb_phy_set_event interface

-off-by: Kiran Raparthy kiran.ku...@linaro.org Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/phy/phy.c | 12 include/linux/usb/phy.h | 5 + 2 files changed, 17 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index e6bf801..b4066a0 100644

[PATCH v3 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

a...@android.com Cc: Benoit Goby ben...@android.com [Original patch in Android from Todd] Cc: Todd Poynor toddpoy...@google.com Signed-off-by: Kiran Raparthy kiran.ku...@linaro.org --- drivers/usb/phy/phy.c | 29 +++-- include/linux/usb/phy.h | 5 + 2 files changed, 32

[PATCH v3 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

: Todd Poynor toddpoy...@google.com Signed-off-by: Kiran Raparthy kiran.ku...@linaro.org --- drivers/usb/phy/phy-ab8500-usb.c| 15 +++ drivers/usb/phy/phy-gpio-vbus-usb.c | 2 ++ drivers/usb/phy/phy-mv-usb.c| 2 ++ drivers/usb/phy/phy-tahvo.c | 2 ++ 4 files changed

Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

On 21 November 2014 20:41, Felipe Balbi ba...@ti.com wrote: On Fri, Nov 21, 2014 at 11:31:21AM +0530, Kiran Raparthy wrote: usb: phy: Handle per-PHY event for connnect and disconnect events When usb is connected and enumerated in device mode or when usb is disconnected,call usb_phy_set_event

[PATCH v2 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

a...@android.com Cc: Benoit Goby ben...@android.com [Original patch in Android from Todd] Cc: Todd Poynor toddpoy...@google.com Signed-off-by: Kiran Raparthy kiran.ku...@linaro.org --- drivers/usb/phy/phy.c | 29 +++-- include/linux/usb/phy.h | 5 + 2 files changed, 32

[PATCH v2 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

: Todd Poynor toddpoy...@google.com Signed-off-by: Kiran Raparthy kiran.ku...@linaro.org --- drivers/usb/phy/phy-ab8500-usb.c| 15 +++ drivers/usb/phy/phy-gpio-vbus-usb.c | 2 ++ drivers/usb/phy/phy-mv-usb.c| 2 ++ drivers/usb/phy/phy-tahvo.c | 2 ++ 4 files changed

[PATCH v2 1/3] usb: phy: introduce usb_phy_set_event interface

-off-by: Kiran Raparthy kiran.ku...@linaro.org Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/usb/phy/phy.c | 12 include/linux/usb/phy.h | 5 + 2 files changed, 17 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index e6bf801..b4066a0 100644

Re: [PATCH 1/3] usb: phy: introduce usb_phy_set_event interface

Hi Felipe, On 21 November 2014 01:24, Felipe Balbi ba...@ti.com wrote: On Wed, Nov 19, 2014 at 08:36:22AM -0800, Todd Poynor wrote: On Wed, Nov 19, 2014 at 2:43 AM, Kiran Kumar Raparthy kiran.ku...@linaro.org wrote: From: Todd Poynor toddpoy...@google.com usb: phy: introduce

[PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

: Todd Poynor toddpoy...@google.com Signed-off-by: Kiran Raparthy kiran.ku...@linaro.org --- drivers/usb/phy/phy-ab8500-usb.c| 15 +++ drivers/usb/phy/phy-gpio-vbus-usb.c | 2 ++ drivers/usb/phy/phy-mv-usb.c| 2 ++ drivers/usb/phy/phy-tahvo.c | 2 ++ 4 files changed

[PATCH v1 1/3] usb: phy: introduce usb_phy_set_event interface

Todd] Cc: Todd Poynor toddpoy...@google.com Signed-off-by: Kiran Raparthy kiran.ku...@linaro.org --- drivers/usb/phy/phy.c | 12 include/linux/usb/phy.h | 5 + 2 files changed, 17 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index 045cd30..2b1039e

[PATCH v1 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

a...@android.com Cc: Benoit Goby ben...@android.com [Original patch in Android from Todd] Cc: Todd Poynor toddpoy...@google.com Signed-off-by: Kiran Raparthy kiran.ku...@linaro.org --- drivers/usb/phy/phy.c | 29 +++-- include/linux/usb/phy.h | 5 + 2 files changed, 32

Re: [RFC v6 3/3] usb: phy: hold wakeupsource when USB is enumerated in peripheral mode

: Added context to commit message, squished build fixes from Benoit Goby and Arve Hjønnevåg, changed wakelocks usage to wakeupsource, merged Todd's refactoring logic and simplified the structures and code and addressed community feedback] Signed-off-by: Kiran Raparthy kiran.ku...@linaro.org

Re: [RFC v5] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode

Hi Felipe, On 10 November 2014 20:56, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Nov 04, 2014 at 03:30:54PM +0530, Kiran Kumar Raparthy wrote: @@ -1469,6 +1484,7 @@ static int ab8500_usb_probe(struct platform_device *pdev) abx500_usb_link_status_update(ab); +

Re: [RFC v5] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode

-by: Kiran Raparthy kiran.ku...@linaro.org you still didn't get this right. I asked that you introduce usb_phy_set_event() as a separate patch, then make PHY drivers use it and only on a third patch should you hold a wakeupsource. Thanks for your time. Sure,I'll resend the patches as per your

Re: [RFC v4] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode

HI Felipe, On 27 October 2014 15:06, Kiran Raparthy kiran.ku...@linaro.org wrote: Hi Felipe, On 10 October 2014 20:50, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Oct 10, 2014 at 11:37:31AM +0530, Kiran Raparthy wrote: Hi Felipe, Thank you very much for taking time in reviewing the patch

Re: [RFC v4] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode

On 10 October 2014 20:50, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Oct 10, 2014 at 11:37:31AM +0530, Kiran Raparthy wrote: Hi Felipe, Thank you very much for taking time in reviewing the patch. I will try to improve the patch as per your suggestions. however,i have few queries which i

Re: [RFC v4] usb: phy: Hold wakeupsource when USB is enumerated in peripheral mode

Hi Felipe, Thank you very much for taking time in reviewing the patch. I will try to improve the patch as per your suggestions. however,i have few queries which i wanted to understand from you. On 7 October 2014 19:55, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Oct 07, 2014 at 02:45:44PM