On Mon, Sep 29 2014, Robert Baldyga wrote:
Hi,
On 09/24/2014 10:43 PM, Michal Sojka wrote:
Use the recently introduced usb_gadget_giveback_request() in favor of
direct invocation of the completion routine.
All places in drivers/usb/ matching [-.]complete( were replaced with a
call
All USB peripheral controller drivers call completion routines directly.
This patch adds usb_gadget_giveback_request() which will be used instead
of direct invocation in the next patch. The goal here is to have a place
where common functionality can be added.
Signed-off-by: Michal Sojka so
-common.o comprises only common.o.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/common/Makefile | 4 +-
drivers/usb/common/common.c | 144
drivers/usb/common/usb-common.c | 144
3 files changed, 147
in usb/common/ (Felipe
Balbi).
- UDC drivers refactored so that LED trigger works for all of them.
Changes from v1:
- Moved from drivers/leds/ to drivers/usb/.
- Improved Kconfig help.
- Linked with other modules rather than being standalone modules.
Michal Sojka (4):
usb: gadget: Introduce
to the trigger):
- __usb_hcd_giveback_urb():10 - 25 µs
- usb_gadget_giveback_request(): 2 - 6 µs
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/Kconfig | 10 +++
drivers/usb/common/Makefile | 1 +
drivers/usb/common/led.c | 57
for musb.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/chipidea/udc.c | 6 +++---
drivers/usb/dwc2/gadget.c | 6 +++---
drivers/usb/dwc3/gadget.c | 2 +-
drivers/usb/gadget/udc/amd5536udc.c | 2 +-
drivers/usb/gadget/udc/at91_udc.c
Dear Felipe,
On Wed, Sep 17 2014, Felipe Balbi wrote:
On Wed, Sep 17, 2014 at 09:21:11AM +0200, Michal Sojka wrote:
All USB peripheral controller drivers called completion routines
directly. This patch moves the completion call from drivers to
usb_gadget_giveback_request(), in order to have
-common.o comprises only common.o.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/common/Makefile | 4 +++-
drivers/usb/common/{usb-common.c = common.c} | 0
2 files changed, 3 insertions(+), 1 deletion(-)
rename drivers/usb/common/{usb-common.c = common.c} (100%)
diff
to the trigger):
- __usb_hcd_giveback_urb():10 - 25 µs
- usb_gadget_giveback_request(): 2 - 6 µs
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/Kconfig | 10 +++
drivers/usb/common/Makefile | 1 +
drivers/usb/common/led.c | 57
:
- Moved from drivers/leds/ to drivers/usb/.
- Improved Kconfig help.
- Linked with other modules rather than being standalone modules.
Michal Sojka (3):
usb: gadget: Refactor request completion
usb: Rename usb-common.c
usb: Add LED triggers for USB activity
drivers/usb/Kconfig
with a
call to usb_gadget_giveback_request(). This was compile-tested with all
ARM drivers enabled and runtime-tested for musb.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/chipidea/udc.c | 6 +++---
drivers/usb/dwc2/gadget.c | 6 +++---
drivers/usb/dwc3
On Wed, Aug 27 2014, Greg Kroah-Hartman wrote:
On Wed, Aug 27, 2014 at 10:58:00PM +0200, Michal Sojka wrote:
With this patch, USB activity can be signaled by blinking a LED. There
are two triggers, one for activity on USB host and one for USB gadget.
Both trigger should work with all host
to the trigger):
- __usb_hcd_giveback_urb():10 - 25 µs
- usb_gadget_giveback_request(): 2 - 6 µs
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/Kconfig | 10 +++
drivers/usb/common/Makefile | 1 +
drivers/usb/common/led.c | 57
Kconfig help.
- Linked with other modules rather than being standalone modules.
Michal Sojka (3):
usb: gadget: Refactor request completion
usb: Rename usb-common.c
usb: Add LED triggers for USB activity
drivers/usb/Kconfig | 10 +
drivers/usb/chipidea/udc.c
with a
call to usb_gadget_giveback_request(). This was compile-tested with all
ARM drivers enabled and runtime-tested for musb.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/chipidea/udc.c | 6 +++---
drivers/usb/dwc2/gadget.c | 6 +++---
drivers/usb/dwc3
-common.o comprises only common.o.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/common/Makefile | 4 +++-
drivers/usb/common/{usb-common.c = common.c} | 0
2 files changed, 3 insertions(+), 1 deletion(-)
rename drivers/usb/common/{usb-common.c = common.c} (100%)
diff
with a
call to usb_gadget_giveback_request(). This was compile-tested with all
ARM drivers enabled and runtime-tested for musb.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/chipidea/udc.c | 6 +++---
drivers/usb/dwc2/gadget.c | 6 +++---
drivers/usb/dwc3
Changes from v1:
- Moved from drivers/leds/ to drivers/usb/
- Improved Kconfig help
- Linked with other modules rather than being standalone modules
Michal Sojka (2):
usb: gadget: Refactor request completion
usb: Add LED triggers for USB activity
drivers/usb/Kconfig | 11
With this patch, USB activity can be signaled by blinking a LED. There
are two triggers, one for activity on USB host and one for USB gadget.
Both trigger should work with all host/device controllers. Tested only
with musb.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/Kconfig
On Wed, Aug 27 2014, Michal Sojka wrote:
All USB peripheral controller drivers called completion routines
directly. This patch moves the completion call from drivers to
usb_gadget_giveback_request(), in order to have a place where common
functionality can be added.
All places in drivers/usb
-common.o comprises only common.o.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/common/Makefile | 4 +++-
drivers/usb/common/{usb-common.c = common.c} | 0
2 files changed, 3 insertions(+), 1 deletion(-)
rename drivers/usb/common/{usb-common.c = common.c} (100%)
diff
With this patch, USB activity can be signaled by blinking a LED. There
are two triggers, one for activity on USB host and one for USB gadget.
Both trigger should work with all host/device controllers. Tested only
with musb.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/Kconfig
with a
call to usb_gadget_giveback_request(). This was compile-tested with all
ARM drivers enabled and runtime-tested for musb.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/chipidea/udc.c | 6 +++---
drivers/usb/dwc2/gadget.c | 6 +++---
drivers/usb/dwc3
in usb/common/ (Felipe
Balbi).
- UDC drivers refactored so that LED trigger works for all of them.
Changes from v1:
- Moved from drivers/leds/ to drivers/usb/.
- Improved Kconfig help.
- Linked with other modules rather than being standalone modules.
Michal Sojka (2):
usb: gadget: Refactor request
Hi Bryan,
thanks for the review. See some comments below.
On Sat, Aug 23 2014, Bryan Wu wrote:
On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka so...@merica.cz wrote:
With this patch, USB host activity can be signaled by blinking a LED.
This should work with all host controllers. Tested only
-off-by: Michal Sojka so...@merica.cz
---
drivers/leds/trigger/Kconfig | 8 ++
drivers/leds/trigger/Makefile| 1 +
drivers/leds/trigger/ledtrig-usbgadget.c | 45
drivers/usb/musb/musb_gadget.c | 6 +++--
include/linux/leds.h
On Fri, Aug 22 2014, Greg Kroah-Hartman wrote:
On Fri, Aug 22, 2014 at 10:39:03AM -0700, Bryan Wu wrote:
On Fri, Aug 22, 2014 at 4:53 AM, Michal Sojka so...@merica.cz wrote:
With this patch, USB gadget activity can be signaled by blinking a LED.
Since there is no generic code where to put
Hi Felipe,
On Fri, Aug 22 2014, Felipe Balbi wrote:
Hi,
On Fri, Aug 22, 2014 at 01:53:12PM +0200, Michal Sojka wrote:
With this patch, USB gadget activity can be signaled by blinking a LED.
Since there is no generic code where to put the trigger for all USB
controllers, each USB
This adds LED triggers for USB host and device.
Changes from v1:
- Moved from drivers/leds/ to drivers/usb/
- Improved Kconfig help
- Linked with other modules rather than being standalone modules
Michal Sojka (3):
usb: Add missing #include
usb: Add LED trigger for USB host activity
usb
With this patch, USB host activity can be signaled by blinking a LED.
This should work with all host controllers. Tested only with musb.
Signed-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/core/Kconfig | 9 +
drivers/usb/core/Makefile | 1 +
drivers/usb/core/hcd.c| 2
linux/usb/hcd.h needs the definition of struct usb_bus.
Signed-off-by: Michal Sojka so...@merica.cz
---
include/linux/usb/hcd.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index 485cd5e..b43f0fe 100644
--- a/include/linux/usb/hcd.h
+++ b
-off-by: Michal Sojka so...@merica.cz
---
drivers/usb/gadget/Kconfig | 12
drivers/usb/gadget/udc/Makefile | 5 -
drivers/usb/gadget/udc/led.c| 38 ++
drivers/usb/musb/musb_gadget.c | 5 +++--
include/linux/usb/gadget.h | 10
/starter-kit-tc1798/channel.html?channel=db3a304333b8a7ca0133cfa3d73e4268
[2]
http://www.infineon.com/dgdl/TriBoardManual-TC1798-V10.pdf?folderId=db3a304412b407950112b409ae7c0343fileId=db3a304333b8a7ca0133cfae99fe426a
Signed-off-by: Michal Sojka sojk...@fel.cvut.cz
---
drivers/usb/serial/ftdi_sio.c
33 matches
Mail list logo
