Complete() will be run with interrupt enabled, so change to
read_lock_irqsave().
Cc: Marcel Holtmann mar...@holtmann.org
Cc: Gustavo Padovan gust...@padovan.org
Cc: Johan Hedberg johan.hedb...@gmail.com
Cc: linux-blueto...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: linux-in...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/input/misc/cm109.c | 10 ++
1 file changed, 6 insertions(+), 4
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/cdc-phonet.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/cdc-phonet.c b
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/kaweth.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/kaweth.c b/drivers
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/hso.c | 38 ++
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Karsten Keil i...@linux-pingi.de
Cc: David S. Miller da...@davemloft.net
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/isdn/hardware/mISDN/hfcsusb.c | 36
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/rtl8150.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/rtl8150.c b/drivers
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Luis R. Rodriguez mcg...@qca.qualcomm.com
Cc: John W. Linville linvi...@tuxdriver.com
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: John W. Linville linvi...@tuxdriver.com
Cc: libertas-...@lists.infradead.org
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/wireless
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Christian Lamparter chunk...@googlemail.com
Cc: John W. Linville linvi...@tuxdriver.com
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Daniel Drake d...@gentoo.org
Cc: Ulrich Kunitz k...@deine-taler.de
Cc: John W. Linville linvi...@tuxdriver.com
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: linux-me...@vger.kernel.org
Reviewed-by: Devin Heitmueller dheitmuel...@kernellabs.com
Tested-by: Devin Heitmueller dheitmuel...@kernellabs.com
Signed-off-by: Ming Lei
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Jaroslav Kysela pe...@perex.cz
Cc: Takashi Iwai ti...@suse.de
Cc: alsa-de...@alsa-project.org
Acked-by: Daniel Mack zon...@gmail.com
Signed-off-by: Ming Lei ming@canonical.com
---
sound/usb/caiaq/audio.c
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/media/usb/sn9c102/sn9c102_core.c |7 +--
1 file changed, 5 insertions
Complete() will be run with interrupt enabled, so add local_irq_save()
before acquiring the lock without irqsave().
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/media/usb/em28xx/em28xx-audio.c |5
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/media/usb/cx231xx/cx231xx-audio.c
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/staging/btmtk_usb/btmtk_usb.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/btmtk_usb/btmtk_usb.c
b/drivers
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
These functions may be called inside URB-complete(), so use
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: John W. Linville linvi...@tuxdriver.com
Cc: libertas-...@lists.infradead.org
Cc: linux-wirel...@vger.kernel.org
Cc: net...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/wireless
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/media/usb/tm6000/tm6000-video.c |5 +++--
1 file changed, 3 insertions
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Jaroslav Kysela pe...@perex.cz
Cc: Takashi Iwai ti...@suse.de
Cc: Clemens Ladisch clem...@ladisch.de
Cc: alsa-de...@alsa-project.org
Signed-off-by: Ming Lei ming@canonical.com
---
sound/usb/midi.c |5
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: linux-me...@vger.kernel.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/media/usb/tlg2300/pd-alsa.c |5 +++--
drivers/media/usb/tlg2300/pd-video.c
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/staging/ced1401/usb1401.c | 35 +++
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/staging
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/staging/bcm/InterfaceRx.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceRx.c
b/drivers/staging
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/staging/vt6656/usbpipe.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging
/core/urb.c |3 ++-
drivers/usb/host/xhci.c|4
include/linux/usb.h|8 ++-
include/linux/usb/usbnet.h |1 +
6 files changed, 64 insertions(+), 5 deletions(-)
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe
This patch marks all xHCI controllers as no_sg_constraint
since xHCI supports building packet from discontinuous buffers.
Cc: Alan Stern st...@rowland.harvard.edu
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/host/xhci.c |4
Hutchings bhutchi...@solarflare.com
Cc: Grant Grundler grund...@google.com
Cc: Freddy Xin fre...@asix.com.tw
Cc: Alan Stern st...@rowland.harvard.edu
Acked-by: Oliver Neukum oneu...@suse.de
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/usbnet.c | 45
...@rowland.harvard.edu
Cc: Freddy Xin fre...@asix.com.tw
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/ax88179_178a.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index fb0caa2..3569293 100644
--- a/drivers
...@rowland.harvard.edu
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/core/urb.c |3 ++-
include/linux/usb.h|8 +++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index e75115a..c77ec78 100644
--- a/drivers
be mapped to userspace.
This patch fixes one kernel panic when CONFIG_DEBUG_VM is set.
Cc: Catalin Marinas catalin.mari...@arm.com
Tested-by: Christoffer Dall christoffer.d...@linaro.org
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/host/isp1760-hcd.c |4 +++-
1 file changed, 3
On Fri, Aug 9, 2013 at 8:18 AM, Grant Grundler grund...@google.com wrote:
Ming,
We are splitting hairs now. :) I want to be clear I think your changes
are good and the rest of this conversation is just to learn something
new.
On Thu, Aug 8, 2013 at 4:48 PM, Ming Lei ming@canonical.com
);
+ if (PageSlab(page))
+ break;
+ flush_dcache_page(page);
+ }
}
/* complete() can reenter this HCD */
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message
On Tue, Aug 6, 2013 at 8:22 PM, Eric Dumazet eric.duma...@gmail.com wrote:
On Tue, 2013-08-06 at 08:52 +0800, Ming Lei wrote:
This patch enables 'can_dma_sg' flag for ax88179_178a device
if the attached host controller supports building packet from
discontinuous buffers(DMA SG is possible), so
usbnet devices may have random MAC address assigned in every
probe().
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Greg,
On Fri, Aug 2, 2013 at 9:19 AM, Ming Lei tom.leim...@gmail.com wrote:
Hi Greg,
On Sat, Jul 27, 2013 at 5:17 AM, Greg KH gre...@linuxfoundation.org wrote:
Hi all,
I've now caught up on all pending USB patches that were sent to me, with
the exception of Ming's EHCI patches, which I
...@rowland.harvard.edu
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/core/urb.c |3 ++-
include/linux/usb.h| 11 ++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index e75115a..c77ec78 100644
--- a/drivers/usb
+--
drivers/usb/core/urb.c |3 ++-
drivers/usb/host/xhci.c|4
include/linux/usb.h| 11 ++-
include/linux/usb/usbnet.h |1 +
6 files changed, 66 insertions(+), 4 deletions(-)
Thanks,
--
Ming Lei
This patch marks all xHCI controllers as no_sg_constraint
since xHCI supports building packet from discontinuous buffers.
Cc: Alan Stern st...@rowland.harvard.edu
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/host/xhci.c |4
Hutchings bhutchi...@solarflare.com
Cc: Grant Grundler grund...@google.com
Cc: Freddy Xin fre...@asix.com.tw
Cc: Oliver Neukum oneu...@suse.de
Cc: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/usbnet.c | 39
...@rowland.harvard.edu
Cc: Freddy Xin fre...@asix.com.tw
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/ax88179_178a.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index fb0caa2..7a96326 100644
On Mon, Aug 5, 2013 at 5:14 PM, Oliver Neukum oneu...@suse.de wrote:
On Mon, 2013-08-05 at 16:47 +0800, Ming Lei wrote:
@@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb,
entry = (struct skb_data *) skb-cb;
entry-urb = urb;
entry-dev = dev
On Mon, Aug 5, 2013 at 10:07 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 5 Aug 2013, Ming Lei wrote:
Some host controllers(such as xHCI) can support building
packet from discontinuous buffers, so introduce one flag
and helper for this kind of host controllers, then the
feature
++-
include/linux/usb/usbnet.h |1 +
6 files changed, 68 insertions(+), 5 deletions(-)
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
...@rowland.harvard.edu
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/core/urb.c |3 ++-
include/linux/usb.h|8 +++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index e75115a..c77ec78 100644
--- a/drivers
...@rowland.harvard.edu
Cc: Freddy Xin fre...@asix.com.tw
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/ax88179_178a.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index fb0caa2..7a96326 100644
This patch marks all xHCI controllers as no_sg_constraint
since xHCI supports building packet from discontinuous buffers.
Cc: Alan Stern st...@rowland.harvard.edu
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/host/xhci.c |4
Hutchings bhutchi...@solarflare.com
Cc: Grant Grundler grund...@google.com
Cc: Freddy Xin fre...@asix.com.tw
Cc: Oliver Neukum oneu...@suse.de
Cc: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/usbnet.c | 45
On Sun, Aug 4, 2013 at 3:07 AM, David Miller da...@davemloft.net wrote:
From: Oliver Neukum oneu...@suse.de
Date: Sat, 03 Aug 2013 07:56:53 +0200
On Sat, 2013-08-03 at 10:46 +0800, Ming Lei wrote:
@@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb,
entry
On Sat, Aug 3, 2013 at 11:53 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Sat, 3 Aug 2013, Ming Lei wrote:
Some host controllers(such as xHCI) can support building
packet from discontinuous buffers, so introduce one flag
and helper for this kind of host controllers, then the
feature
On Sat, Aug 3, 2013 at 10:46 AM, Ming Lei ming@canonical.com wrote:
Hi,
This patchset allows drivers to pass sg buffers which size can't be divided
by max packet size of endpoint if the host controllers(such ax xHCI) support
this kind of sg buffers.
Previously we added check[1
/xhci.c|4
include/linux/usb.h| 11 ++-
include/linux/usb/usbnet.h |1 +
6 files changed, 65 insertions(+), 4 deletions(-)
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
...@rowland.harvard.edu
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/core/urb.c |3 ++-
include/linux/usb.h| 11 ++-
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index e75115a..7a88ae8 100644
--- a/drivers/usb
From: Ming Lei tom.leim...@gmail.com
This patch enables 'can_dma_sg' flag for ax88179_178a device
if the attached host controller supports building packet from
discontinuous buffers(DMA SG is possible), so TSO can be enabled
and skb fragment buffers can be passed to usb stack via urb-sg
directly
This patch marks all xHCI controllers as no_sg_limit since
xHCI supports building packet from discontinuous buffers.
Cc: Alan Stern st...@rowland.harvard.edu
Acked-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/host/xhci.c |4
Hutchings bhutchi...@solarflare.com
Cc: Grant Grundler grund...@google.com
Cc: Freddy Xin fre...@asix.com.tw
Cc: Oliver Neukum oneu...@suse.de
Cc: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/usbnet.c | 38
On Thu, Aug 1, 2013 at 1:04 PM, Eric Dumazet eric.duma...@gmail.com wrote:
On Thu, 2013-08-01 at 12:41 +0800, Ming Lei wrote:
From my trace result, lots of linear SKBs are cloned or header-cloned, so
it needs skb copy too.
Is it normal in xmit path to see cloned SKBs for driver? If not, I
,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 2, 2013 at 11:28 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Wed, Jul 03, 2013 at 10:53:07PM +0800, Ming Lei wrote:
1), for drivers, they don't care if the complete() is called in hard irq
context or softirq context
What about those 50+ patches you had that changed
call during high memory pressure can fail.
I'd rather the potential failure happen at one time, probe time.
In any event, Ming Lei has suggested using usbnet_{read,write}_cmd()
instead, which sounds like a good solution to this problem.
Those do per-call allocs too.
Sigh... Ok I won't fight
deletions(-)
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
avoid move or copy data over the whole skb.
Secondaly, the patch supports passing the skb fragment buffers to
usb stack directly via urb-sg.
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/usbnet.c | 48 ++--
include/linux/usb
This patch marks all xHCI controllers as no_sg_limit since
xHCI supports building packet from discontinuous buffers.
Cc: Sarah Sharp sarah.a.sh...@linux.intel.com
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/host/xhci.c |4
1 file changed, 4 insertions(+)
diff --git
, CPU utilization decreased much in iperf test at
client mode.
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/ax88179_178a.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index
On Wed, Jul 31, 2013 at 7:12 PM, Oliver Neukum oneu...@suse.de wrote:
On Wed, 2013-07-31 at 18:51 +0800, Ming Lei wrote:
Hi,
This patchset allows drivers to pass sg buffers which size can't be divided
by max packet size of endpoint if the host controllers support this kind
of sg buffers
On Wed, Jul 31, 2013 at 8:47 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Wed, Jul 31, 2013 at 06:51:49PM +0800, Ming Lei wrote:
This patch enables 'can_dma_sg' flag for ax88179_178a device
if the attached host controller supports building packet from
discontinuous buffers(DMA
On Wed, Jul 31, 2013 at 11:15 PM, Eric Dumazet eric.duma...@gmail.com wrote:
On Wed, 2013-07-31 at 16:02 +0200, Oliver Neukum wrote:
On Wed, 2013-07-31 at 21:50 +0800, Ming Lei wrote:
In the usbnet case, the driver already supports non-sg well. Actually,
all current drivers should support
/show_bug.cgi?id=60662
Thanks for the report.
Looks you didn't provide any debug info, could you apply the attachment
patch and post the 'dmesg' info when you reproduce the bug.
Thanks,
--
Ming Lei
usbnet-link-dgb.patch
Description: Binary data
On Wed, Jul 31, 2013 at 11:49 PM, Ming Lei ming@canonical.com wrote:
On Wed, Jul 31, 2013 at 5:56 PM, Till Schmalmack t...@schmalmack.net wrote:
Hello Ming,
I am experiencing issues with the usbnet commits you did for the 3.10
kernel, in particular with
4be74c13 usbnet: mcs7830: apply
or 1024 bytes.
Now Sarah Sharp(xHCD maintainer) has Acked patch 2/4, and confirmed
SG is supported on xHCD, so I appreciate that you network guys may
review the network related changes in patch 3/4 and 4/4, then we
can move on, :-)
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line
is
you can avoid to access runtime-suspended device from ethtool.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 26, 2013 at 10:28 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On 07/11/2013 11:05 AM, Ming Lei wrote:
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: linux
urb of desc-response.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On Thu, Jul 25, 2013 at 3:38 PM, Oliver Neukum oneu...@suse.de wrote:
On Thu, 2013-07-25 at 13:47 +0800, Ming Lei wrote:
Hi,
There are two patches on computing max rx/tx qlen, and fix one
performance problem on USB3 NIC.
I am afraid bisectability on SS is impaired. Otherwise
On Thu, Jul 25, 2013 at 7:01 PM, Eric Dumazet eric.duma...@gmail.com wrote:
On Thu, 2013-07-25 at 13:25 +0800, Ming Lei wrote:
On Thu, Jul 25, 2013 at 1:10 PM, Eric Dumazet eric.duma...@gmail.com wrote:
On Thu, 2013-07-25 at 10:28 +0800, Ming Lei wrote:
It depends if size of sg buffer
Hi Greg,
On Fri, Jul 26, 2013 at 3:48 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote:
On Wed, Jul 03, 2013 at 10:53:09PM +0800, Ming Lei wrote:
The patch does the below improvement:
- think QH_STATE_COMPLETING as unlinking state since all
On Fri, Jul 26, 2013 at 4:55 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Fri, Jul 26, 2013 at 04:52:36AM +0800, Ming Lei wrote:
Hi Greg,
On Fri, Jul 26, 2013 at 3:48 AM, Alan Stern st...@rowland.harvard.edu
wrote:
On Thu, 25 Jul 2013, Greg Kroah-Hartman wrote:
On Wed
that, and driver may have
to support SG and non-SG at the same time for working well on all HCs.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Thu, Jul 25, 2013 at 1:10 PM, Eric Dumazet eric.duma...@gmail.com wrote:
On Thu, 2013-07-25 at 10:28 +0800, Ming Lei wrote:
It depends if size of sg buffer(except for last one) in the sg list can be
divided by usb endpoint's max packet size(512 or 1024), at least there
is the constraint
.
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/usbnet.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index d74de07..e4811d7 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -355,6
|3 +++
4 files changed, 55 insertions(+), 8 deletions(-)
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
of usbnet_update_max_qlen(), and calls
it in above path.
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/net/usb/asix_devices.c |3 +++
drivers/net/usb/ax88179_178a.c |3 +++
drivers/net/usb/usbnet.c | 45 +---
include/linux/usb/usbnet.h |3 +++
4
On Sun, Jul 21, 2013 at 11:28 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Sun, 21 Jul 2013, Ming Lei wrote:
On Sun, Jul 21, 2013 at 2:00 AM, Alan Stern st...@rowland.harvard.edu
wrote:
On Sat, 20 Jul 2013, Ming Lei wrote:
No, we don't have to change every driver using
On Mon, Jul 22, 2013 at 11:09 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 22 Jul 2013, Ming Lei wrote:
Not exactly. The HCD has to keep track of the next available time slot
for the endpoint. Some special value, like -1, will indicate that no
stream is running yet. So
On Sun, Jul 21, 2013 at 2:00 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Sat, 20 Jul 2013, Ming Lei wrote:
No, we don't have to change every driver using isochronous URBs. Many
of them set URB_ISO_ASAP on every URB -- in fact, AFAIK snd-usb-audio
is the only one that has been fixed
On Fri, Jul 19, 2013 at 1:44 AM, Clemens Ladisch clem...@ladisch.de wrote:
Alan Stern wrote:
On Thu, 18 Jul 2013, Ming Lei wrote:
On Thu, Jul 18, 2013 at 3:24 AM, Alan Stern st...@rowland.harvard.edu
wrote:
On Thu, 4 Jul 2013, Alan Stern wrote:
On Thu, 4 Jul 2013, Ming Lei wrote:
I had
On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote:
Ming Lei wrote:
On Fri, Jul 19, 2013 at 1:44 AM, Clemens Ladisch clem...@ladisch.de wrote:
In any case, there must be _some_ mechanism to explicitly restart
a stream. I do not really care if this is some URB flag
On Fri, Jul 19, 2013 at 6:30 PM, Clemens Ladisch clem...@ladisch.de wrote:
Ming Lei wrote:
On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote:
Ming Lei wrote:
if (list_empty (stream-td_list)) {
if (running from hcd interrupt or tasklet context)
underrun
On Fri, Jul 19, 2013 at 6:36 PM, Ming Lei tom.leim...@gmail.com wrote:
On Fri, Jul 19, 2013 at 6:30 PM, Clemens Ladisch clem...@ladisch.de wrote:
Ming Lei wrote:
On Fri, Jul 19, 2013 at 5:06 PM, Clemens Ladisch clem...@ladisch.de wrote:
Ming Lei wrote:
if (list_empty (stream-td_list
On Fri, Jul 19, 2013 at 11:50 AM, Ming Lei tom.leim...@gmail.com wrote:
On Thu, Jul 18, 2013 at 10:08 PM, Alan Stern st...@rowland.harvard.edu
wrote:
On Thu, 18 Jul 2013, Ming Lei wrote:
I guess that HC could have a use-after-free problem like following
situation.
1. A qtd which
On Fri, Jul 19, 2013 at 10:53 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Fri, 19 Jul 2013, Ming Lei wrote:
Even we can introduce one flag of 'completing' in 'struct urb' to check if
the USB's submit is called inside its own complete(), by which we can
check if resubmission
On Sat, Jul 20, 2013 at 11:57 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Sat, 20 Jul 2013, Ming Lei wrote:
Trying to check the context of an URB submission strikes me as not
robust at all. Who knows what tricks drivers will get up to in the
future?
Firstly, it shouldn't
On Thu, Jul 18, 2013 at 9:30 AM, Gioh Kim gioh@lge.com wrote:
Thanks for your reply.
-Original Message-
From: Ming Lei [mailto:tom.leim...@gmail.com]
Sent: Wednesday, July 17, 2013 5:52 PM
To: 김기오
Cc: Alan Stern; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org;
Mark
because it
is HCD-independent function, so it is better to provide the information
from usbcore and let HCD use it if HCD needs the flag.
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo
On Thu, Jul 18, 2013 at 10:08 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 18 Jul 2013, Ming Lei wrote:
I guess that HC could have a use-after-free problem like following
situation.
1. A qtd which is not at the queue head should be removed in
qh_completions().
2
Hi Chen Gang,
On Fri, Jul 19, 2013 at 12:21 PM, Chen Gang gang.c...@asianux.com wrote:
Hello Maintainers:
Please help check this patch when you have time.
Looks your patch is correct, and I think Greg will handle
your patch when usb-next tree is open.
Thanks,
--
Ming Lei
--
To unsubscribe
://vger.kernel.org/majordomo-info.html
Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 18, 2013 at 3:24 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Thu, 4 Jul 2013, Alan Stern wrote:
On Thu, 4 Jul 2013, Ming Lei wrote:
If so, your coming change may break ABI because as you described
that the flag should be set in the first URB of a new stream
On Sun, Jul 14, 2013 at 9:17 PM, Andy Walls awa...@md.metrocast.net wrote:
On Thu, 2013-07-11 at 17:05 +0800, Ming Lei wrote:
Hi,
As we are going to run URB-complete() in tasklet context[1][2],
Hi,
Please pardon my naivete, but why was it decided to use tasklets to
defer work, as opposed
Complete() will be run with interrupt enabled, so change to
spin_lock_irqsave().
Cc: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Ming Lei ming@canonical.com
---
drivers/usb/core/devio.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/core
101 - 200 of 754 matches
Mail list logo
