[PATCH v9 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-11-07 Thread Peter Chen
Add binding doc for generic power sequence library. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++

[PATCH v9 0/8] power: add power sequence library

2016-11-07 Thread Peter Chen
robe Joshua Clayton (2): ARM: dts: imx6qdl: Enable usb node children with ARM: dts: imx6q-evi: Fix onboard hub reset line Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add power sequence library binding-doc: usb: usb-

[PATCH v2 1/1] usb: gadget: f_uac2: fix error handling at afunc_bind

2016-11-07 Thread Peter Chen
The current error handling flow uses incorrect goto label, fix it Cc: <sta...@vger.kernel.org> Fixes: d12a8727171c ("usb: gadget: function: Remove redundant usb_free_all_descriptors") Signed-off-by: Peter Chen <peter.c...@nxp.com> --- Changes for v2: - Delete chang

[PATCH v2 1/1] usb: gadget: fix request length error for isoc transfer

2016-11-07 Thread Peter Chen
felipetonello.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Fixes: 16b114a6d797 ("usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_aligna") Signed-off-by: Peter Chen <peter.c...@nxp.com> --- Changes for v2: - Using "&" instead of &q

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-07 Thread Peter Chen
On Mon, Nov 07, 2016 at 02:36:51PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > >> Peter Chen <hzpeterc...@gmail.com> writes: > >> >> > Peter Chen <hzpeterc...@gmail.com> writes: > >> &

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-11-06 Thread Peter Chen
On Fri, Nov 04, 2016 at 01:51:34PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-24 18:16:32) > > On Mon, Oct 24, 2016 at 12:48:24PM -0700, Stephen Boyd wrote: > > > Quoting Chen-Yu Tsai (2016-10-24 05:19:05) > > > > Hi, > > > > > > &

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 12:48:08PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > >> > Peter Chen <hzpeterc...@gmail.com> writes: > >> > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote

Re: [PATCH 1/1] usb: gadget: fix request length error for isoc transfer

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 12:50:43PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > > On Thu, Nov 03, 2016 at 11:27:40AM +0200, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Peter Chen <hzpete

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 12:42:11PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > >> Peter Chen <hzpeterc...@gmail.com> writes: > >> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > >> &g

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 12:42:11PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > >> Peter Chen <hzpeterc...@gmail.com> writes: > >> > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > >> &g

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 05:03:10PM +0800, Peter Chen wrote: > On Thu, Nov 03, 2016 at 09:04:54AM +0200, Felipe Balbi wrote: > > > > Hi, > > > > Peter Chen <hzpeterc...@gmail.com> writes: > > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Mille

Re: [PATCH 1/1] usb: gadget: fix request length error for isoc transfer

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 11:27:40AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > >> Peter Chen <peter.c...@nxp.com> writes: > >> > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet &

Re: [PATCH 1/1] usb: gadget: f_uac2: fix error handling at afunc_bind

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 10:50:23AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <peter.c...@nxp.com> writes: > > The current error handling flow uses incorrect goto label, fix it > > > > Cc: <sta...@vger.kernel.org> > > Fixes: d12a8727171c (

Re: [PATCH 1/1] usb: gadget: fix request length error for isoc transfer

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 10:47:58AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <peter.c...@nxp.com> writes: > > For isoc endpoint descriptor, the wMaxPacketSize is not real max packet > > size (see Table 9-13. Standard Endpoint Descriptor, USB 2.0 spe

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-03 Thread Peter Chen
On Thu, Nov 03, 2016 at 09:04:54AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > > On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > >> From: Peter Chen <hzpeterc...@gmail.com> > >> Date: We

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Peter Chen
On Wed, Nov 02, 2016 at 01:02:59PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > >> >> diff --git a/drivers/usb/gadget/function/u_ether.c > >> >> b/drivers/usb/gadget/function/u_ether.c > >> >>

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Peter Chen
On Wed, Nov 02, 2016 at 11:22:54AM -0400, David Miller wrote: > From: Peter Chen <hzpeterc...@gmail.com> > Date: Wed, 2 Nov 2016 14:02:02 +0800 > > > Felipe, it may increase cpu utilization since more interrupts will be there, > > it may affect the SoC which has low

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Peter Chen
On Wed, Nov 02, 2016 at 09:55:44AM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > > On Tue, Nov 01, 2016 at 01:29:59PM +0200, Felipe Balbi wrote: > >> According to Dave Miller "the networking stack has a >

Re: [PATCH v2 2/6] usb: chipidea: use bus->sysdev for DMA configuration

2016-11-02 Thread Peter Chen
ent, > sizeof(struct ci_hw_qh), > 64, CI_HDRC_PAGE_SIZE); > if (ci->qh_pool == NULL) > return -ENOMEM; > > - ci->td_pool = dma_pool_create("ci_hw_td", de

Re: [PATCH] usb: gadget: u_ether: remove interrupt throttling

2016-11-02 Thread Peter Chen
t; retval = usb_ep_queue(in, req, GFP_ATOMIC); > switch (retval) { > default: > -- Felipe, it may increase cpu utilization since more interrupts will be there, it may affect the SoC which has lower cpu frequency. This code existed many years, why this problem has only rep

Re: [PATCH v2] phy: rcar-gen3-usb2: add sysfs for usb role swap

2016-11-01 Thread Peter Chen
ice_create_file(dev, _attr_otg_inputs); > + if (ret < 0) > + return ret; > + } > > return PTR_ERR_OR_ZERO(provider); > } > > +static int rcar_gen3_phy_usb2_remove(struct platform_device *pdev) > +{ > + struct rcar_gen3_cha

Re: [RFC/PATCH 15/45] usb: chipidea: udc: make use of new usb_endpoint_maxp_mult()

2016-11-01 Thread Peter Chen
On Tue, Nov 01, 2016 at 12:45:25PM +0200, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > > On Wed, Sep 28, 2016 at 04:05:24PM +0300, Felipe Balbi wrote: > >> We have introduced a helper to calculate multiplier > >&

Re: [PATCH 00/82] usb: patch bomb

2016-11-01 Thread Peter Chen
seems you missed my comments in the RFC set, basically the set breaks > MUSB and other controllers. > Yes, you may miss my comment for chipidea too. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to maj

[PATCH 1/1] usb: phy: phy-generic: add the implementation of .set_suspend

2016-10-30 Thread Peter Chen
Add clock operation at .set_suspend if the PHY has suspend requirement, it can be benefit of power saving for phy and the whole system (parent clock may also be disabled). Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/phy/phy-generic.c | 9 + 1 file changed, 9 inse

[PATCH 1/1] usb: chipidea: move the lock initialization to core file

2016-10-30 Thread Peter Chen
[] (ret_fast_syscall+0x0/0x1c) [ 930.181041] r7:0003[ 930.183419] r6:b6dd1000 r5:0002[ 930.187051] r4:0002 [ 930.189611] mode = 0 Cc: <sta...@vger.kernel.org> #v4.1+ Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/chipidea/core.c | 1 + drivers/usb/ch

Re: [dmesg] usb 2-1.5:1.0: rebind failed: -517

2016-10-30 Thread Peter Chen
t means some resources for this device are not ready. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] usb: core: correct usb_get_dev() documentation

2016-10-27 Thread Peter Chen
eference counter. > > */ > > -- > > 2.8.0.rc3.226.g39d4020 > > > > -- > Dmitry > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] usb: gadget: f_uac2: fix error handling at afunc_bind

2016-10-26 Thread Peter Chen
The current error handling flow uses incorrect goto label, fix it Cc: <sta...@vger.kernel.org> Fixes: d12a8727171c ("usb: gadget: function: Remove redundant usb_free_all_descriptors") Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/gadget/

Re: [PATCH 1/3] usb: dwc3: host: inherit dma configuration from parent dev

2016-10-25 Thread Peter Chen
iro Shimoda <yoshihiro.shimoda...@renesas.com> > Cc: Stephen Boyd <sb...@codeaurora.org> > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Cc: Ming Lei <tom.leim...@gmail.com> > Cc: Jon Masters <j...@redhat.com> > Cc: Dann Frazier <dann.fraz.

[GIT PULL] usb: chipidea: fixes for v4.9

2016-10-25 Thread Peter Chen
boards Stefan Wahren (1): usb: chipidea: host: fix NULL ptr dereference during shutdown drivers/usb/chipidea/host.c | 2 ++ 1 file changed, 2 insertions(+) -- Best Regards, Peter Chen -- To unsubscribe from this list: send

Re: [PATCH v8 0/8] power: add power sequence library

2016-10-25 Thread Peter Chen
On Tue, Oct 18, 2016 at 02:35:38AM +0200, Rafael J. Wysocki wrote: > On Monday, October 17, 2016 09:30:59 AM Peter Chen wrote: > > On Fri, Oct 14, 2016 at 02:09:31PM +0200, Rafael J. Wysocki wrote: > > > On Friday, October 14, 2016 10:59:47 AM Peter Chen wro

Re: [PATCH v5 02/23] of: device: Export of_device_{get_modalias, uvent_modalias} to modules

2016-10-24 Thread Peter Chen
> > > } > > > mutex_unlock(_mutex); > > > } > > > +EXPORT_SYMBOL_GPL(of_device_uevent_modalias); > > > > This is trailing the wrong function. > > > > Good catch. Must have been some bad rebase. > > Peter, can you fix it while apply

[PATCH 1/1] usb: gadget: fix request length error for isoc transfer

2016-10-24 Thread Peter Chen
felipetonello.com> Cc: Felipe Balbi <felipe.ba...@linux.intel.com> Fixes: 16b114a6d797 ("usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_aligna") Signed-off-by: Peter Chen <peter.c...@nxp.com> --- include/linux/usb/gadget.h | 5 - 1 file changed,

Re: [PATCH v5 23/23] phy: Add support for Qualcomm's USB HS phy

2016-10-23 Thread Peter Chen
On Fri, Oct 21, 2016 at 12:33:43PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-20 19:20:30) > > On Thu, Oct 20, 2016 at 04:20:38PM -0700, Stephen Boyd wrote: > > > Quoting Stephen Boyd (2016-10-17 18:56:36) > > > > + > > > > +static int >

Re: [PATCH v5 23/23] phy: Add support for Qualcomm's USB HS phy

2016-10-20 Thread Peter Chen
be duplicating work sometimes, but that's pretty much the best solution > I can come up with. Otherwise it's racy. > Why you need to care id status? If EXTCON_USB event has happened, and event is true, you can set, otherwise, it is clear operation, that's to say you may not need have

Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable path

2016-10-20 Thread Peter Chen
On Thu, Oct 20, 2016 at 01:36:30PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-20 03:10:18) > > On Wed, Oct 19, 2016 at 11:55:29PM -0700, Stephen Boyd wrote: > > > Quoting Peter Chen (2016-10-19 01:02:11) > > > > On Tue, Oct 18, 2016 at 06:53:

Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable path

2016-10-20 Thread Peter Chen
On Wed, Oct 19, 2016 at 11:55:29PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-19 01:02:11) > > On Tue, Oct 18, 2016 at 06:53:07PM -0700, Stephen Boyd wrote: > > > If you're asking if I've made modifications to extcon-usb-gpio, then the > > > answer is no. T

Re: [PATCH] ARM: dts: imx50: fix USB nodes

2016-10-19 Thread Peter Chen
> }; > > + usbmisc: usbmisc@53fc4800 { > + #index-cells = <1>; > + compatible = "fsl,imx53-usbmisc"; > + reg = <0x53fc4800 0x200>; > +

Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable path

2016-10-19 Thread Peter Chen
On Tue, Oct 18, 2016 at 06:53:07PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-10-18 18:15:35) > > On Mon, Oct 17, 2016 at 06:56:24PM -0700, Stephen Boyd wrote: > > > In the case of an extcon-usb-gpio device being used with the > > > chipidea driver we'll som

Re: [PATCH v5 11/23] usb: chipidea: Emulate OTGSC interrupt enable path

2016-10-18 Thread Peter Chen
e, we see timeout messages like: > > timeout waiting for 800 in OTGSC > > Let's workaround this by skiping the wait for BSV when we're > using an extcon for the vbus notification and let's properly > emulate the BSVIS event that would happen when we enable the > vbus interr

Re: [PATCH v5 00/23] Support qcom's HSIC USB and rewrite USB2 HS support

2016-10-18 Thread Peter Chen
es changed, 1292 insertions(+), 140 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt > create mode 100644 > Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.txt > create mode 100644 Documentation/devicetree/bindings/usb/ulpi.txt >

Re: usb_ep_{dis,en}able() calling context (was: Re: [PATCH 2/3] usb: dwc3: gadget: wait for End Transfer to complete)

2016-10-18 Thread Peter Chen
;> need to wait for an Interrupt. > >> > >> In fact, we know of two controllers that need this: dwc3 and dwc3.1. > > > > It's not clear that this should be the deciding factor. That is, does > > usb_ep_disable() need to wait until all the endpoint's out

Re: [PATCH v8 0/8] power: add power sequence library

2016-10-17 Thread Peter Chen
On Tue, Oct 18, 2016 at 02:35:38AM +0200, Rafael J. Wysocki wrote: > On Monday, October 17, 2016 09:30:59 AM Peter Chen wrote: > > On Fri, Oct 14, 2016 at 02:09:31PM +0200, Rafael J. Wysocki wrote: > > > On Friday, October 14, 2016 10:59:47 AM Peter Chen wro

Re: usb_ep_{dis,en}able() calling context (was: Re: [PATCH 2/3] usb: dwc3: gadget: wait for End Transfer to complete)

2016-10-17 Thread Peter Chen
On Mon, Oct 17, 2016 at 12:51:48PM +0300, Felipe Balbi wrote: > > Hi, > > Peter Chen <hzpeterc...@gmail.com> writes: > > On Mon, Oct 17, 2016 at 11:06:49AM +0300, Felipe Balbi wrote: > >> > >> Hi Baolin, > >> > >> Baolin Wang <

Re: usb_ep_{dis,en}able() calling context (was: Re: [PATCH 2/3] usb: dwc3: gadget: wait for End Transfer to complete)

2016-10-17 Thread Peter Chen
e go ahead with this, it'll mean a rather large series (again) to > fix all the calling semantics in every single gadget driver for both > usb_ep_enable() and usb_ep_disable(). Then, making sure all UDC drivers > respect the requirement, then we update documentation about the > functions and a

Re: USB GADGET: have a question about usb2eth

2016-10-16 Thread Peter Chen
pe's email has changed, please check MAINTAINERS. Besides, would you wrap up line to 75 characters please? -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v8 0/8] power: add power sequence library

2016-10-16 Thread Peter Chen
On Fri, Oct 14, 2016 at 02:09:31PM +0200, Rafael J. Wysocki wrote: > On Friday, October 14, 2016 10:59:47 AM Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hanss

[PATCH v8 4/8] usb: core: add power sequence handling for USB devices

2016-10-13 Thread Peter Chen
-off-by: Peter Chen <peter.c...@nxp.com> Tested-by Joshua Clayton <stillcompil...@gmail.com> --- drivers/usb/core/hub.c | 41 ++--- drivers/usb/core/hub.h | 1 + 2 files changed, 39 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/hub.c b

[PATCH v8 5/8] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

2016-10-13 Thread Peter Chen
From: Peter Chen <peter.c...@freescale.com> At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node,

[PATCH v8 6/8] ARM: dts: imx6qdl: Enable usb node children with

2016-10-13 Thread Peter Chen
From: Joshua Clayton <stillcompil...@gmail.com> Give usb nodes #address and #size attributes, so that a child node representing a permanently connected device such as an onboard hub may be addressed with a attribute Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> Signed-o

[PATCH v8 3/8] binding-doc: usb: usb-device: add optional properties for power sequence

2016-10-13 Thread Peter Chen
Add optional properties for power sequence. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentatio

[PATCH v8 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-10-13 Thread Peter Chen
Add binding doc for generic power sequence library. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++

[PATCH v8 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line

2016-10-13 Thread Peter Chen
layton <stillcompil...@gmail.com> Signed-off-by: Peter Chen <peter.c...@nxp.com> --- arch/arm/boot/dts/imx6q-evi.dts | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts index 4fa56

[PATCH v8 2/8] power: add power sequence library

2016-10-13 Thread Peter Chen
instead (eg, USB hub driver). For new power sequence library, it can add its compatible string to pwrseq_of_match_table, then the pwrseq core will match it with DT's, and choose this library at runtime. Signed-off-by: Peter Chen <peter.c...@nxp.com> Tested-by Joshua Clayton <stillcompil...@

[PATCH v8 7/8] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2016-10-13 Thread Peter Chen
t;m...@maciej.szmigiero.name> Signed-off-by: Peter Chen <peter.c...@nxp.com> Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl

[PATCH v8 0/8] power: add power sequence library

2016-10-13 Thread Peter Chen
dts: imx6q-evi: Fix onboard hub reset line Peter Chen (6): binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library power: add power sequence library binding-doc: usb: usb-device: add optional properties for power sequence usb: core: add power seque

Re: [PATCH v7 2/8] power: add power sequence library

2016-10-13 Thread Peter Chen
st driver doesn't know which pwrseq type > > for its child node, then doesn't know which pwrseq instance needs to be > > allocated. From dts, we don't know which pwrseq type for the node. > > yes, that is why I was suggesting allocating one (or two) here in > pwrseq_generic_register() and every time pwrseq_generic_get() grabs the last > free sequence instance, you allocate a new free spare one in that function. Good idea. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v7 2/8] power: add power sequence library

2016-10-12 Thread Peter Chen
On Wed, Oct 12, 2016 at 12:30:29PM +0200, Heiko Stuebner wrote: > Hi, > > Am Dienstag, 20. September 2016, 11:36:41 CEST schrieb Peter Chen: > > We have an well-known problem that the device needs to do some power > > sequence before it can be recognized by related host, th

Re: [PATCH v7 0/8] power: add power sequence library

2016-10-08 Thread Peter Chen
On Mon, Sep 26, 2016 at 02:26:49PM +0800, Peter Chen wrote: > On Tue, Sep 20, 2016 at 11:36:39AM +0800, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hansson's comments

RE: [LINUX PATCH] usb: gadget: Configure data verification through module parameter in gadget zero

2016-09-29 Thread Peter Chen
> >This patch adds support to configure data verification through module >parameter. >This parameter can be used to disable data verification in case if one wants to >measure peak Bulk/Isoc-IN/OUT performance > Would configfs parameter 'pattern' can't satisfy you? Peter >Signed-off-by:

Re: [RFC/PATCH 15/45] usb: chipidea: udc: make use of new usb_endpoint_maxp_mult()

2016-09-29 Thread Peter Chen
On Wed, Sep 28, 2016 at 04:05:24PM +0300, Felipe Balbi wrote: > We have introduced a helper to calculate multiplier > value from wMaxPacketSize. Start using it. > > Cc: Peter Chen <peter.c...@nxp.com> > Cc: <linux-usb@vger.kernel.org> > Signed-off-by: Felipe Balbi

Re: [RFC/PATCH 31/45] usb: chipidea: udc: remove unnecessary & operation

2016-09-29 Thread Peter Chen
On Wed, Sep 28, 2016 at 04:05:40PM +0300, Felipe Balbi wrote: > Now that usb_endpoint_maxp() only returns the lowest > 11 bits from wMaxPacketSize, we can remove the & > operation from this driver. > > Cc: Peter Chen <peter.c...@nxp.com> > Cc: <linux-usb@vger.kern

Re: [RFC/PATCH 01/45] usb: add helper to extract bits 12:11 of wMaxPacketSize

2016-09-28 Thread Peter Chen
int_maxp_mult(const struct usb_endpoint_descriptor *epd) > +{ > + int maxp = __le16_to_cpu(epd->wMaxPacketSize); > + > + return USB_EP_MAXP_MULT(maxp) + 1; > +} > + You may update kernel-doc for entry mult at struct usb_ep, it is the transaction number now, not the

Re: [PATCH v7 0/8] power: add power sequence library

2016-09-27 Thread Peter Chen
On Wed, Sep 28, 2016 at 01:30:17AM +0200, Maciej S. Szmigiero wrote: > On 20.09.2016 05:36, Peter Chen wrote: > > Hi all, > > > > This is a follow-up for my last power sequence framework patch set [1]. > > According to Rob Herring and Ulf Hansson's comments[2]. The

Re: [PATCH] extcon: usb-gpio: Add VBUS detection support

2016-09-26 Thread Peter Chen
fter this point >* as GPIOs used behind I2C subsystem might not be >* accessible until resume completes. So disable IRQ. >*/ > - disable_irq(info->id_irq); > + if (info->id_gpiod) > + disable_irq(info->id_irq); > + if (info->vbus_gpiod) >

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-26 Thread Peter Chen
On Mon, Sep 26, 2016 at 11:44:50AM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-25 20:29:27) > > On Thu, Sep 22, 2016 at 11:51:02AM -0700, Stephen Boyd wrote: > > > Quoting Peter Chen (2016-09-16 18:16:05) > > > > On Wed, Sep 14, 2016 at 01:55:

Re: [PATCH v6 0/2] Add USB configuration for imx53

2016-09-26 Thread Peter Chen
Disable internal 60Mhz clock with ULPI PHY > > drivers/usb/chipidea/ci_hdrc_imx.c | 4 ++ > drivers/usb/chipidea/ci_hdrc_imx.h | 1 + > drivers/usb/chipidea/usbmisc_imx.c | 86 > +++--- > 3 files changed, 77 insertions(+), 14 deletions(-) &

Re: [PATCH v7 0/8] power: add power sequence library

2016-09-26 Thread Peter Chen
On Tue, Sep 20, 2016 at 11:36:39AM +0800, Peter Chen wrote: > Hi all, > > This is a follow-up for my last power sequence framework patch set [1]. > According to Rob Herring and Ulf Hansson's comments[2]. The kinds of > power sequence instances will be added at postcore_init

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-25 Thread Peter Chen
On Thu, Sep 22, 2016 at 11:51:02AM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-16 18:16:05) > > On Wed, Sep 14, 2016 at 01:55:02AM -0700, Stephen Boyd wrote: > > > Quoting Stephen Boyd (2016-09-13 18:42:46) > > > > On the db410c 96boards p

Re: [PATCH v4 3/3] usb: chipidea: imx: Add binding to disable USB 60Mhz clock

2016-09-21 Thread Peter Chen
X53_BM_OVER_CUR_DIS_UHx; > -- > 2.1.4 > Like I commented before, you need to have binding-doc update (ocumentation/devicetree/bindings/usb/ci-hdrc-usb2.txt) Besides, try to run ./scripts/get_maintainer.pl to get the necessary maintainers and reviewers. You may get some useful tips for reading Documentation/SubmittingPatches -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 2/3] usb: chipidea: imx: configure imx for ULPI phy

2016-09-21 Thread Peter Chen
> + reg = usbmisc->base + MX53_USB_UH3_CTRL_OFFSET; > + val = readl(reg) | MX53_USB_UHx_CTRL_WAKE_UP_EN > + | MX53_USB_UHx_CTRL_ULPI_INT_EN; > + writel(val, reg); > + } > if (data->disable_oc) { > reg = usbmisc->base + MX53_USB_UH3_CTRL_OFFSET; > val = readl(reg) | MX53_BM_OVER_CUR_DIS_UHx; > -- > 2.1.4 > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/3] usb: chipidea: imx: Change switch order

2016-09-21 Thread Peter Chen
&& val) > writel(val, reg); > - spin_unlock_irqrestore(>lock, flags); > + } > + break; > } > > + spin_unlock_irqrestore(>lock, flags); > + > return 0; > } > > -- > 2.1.4 > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] usb: chipidea: otg: fix reading otgsc register

2016-09-21 Thread Peter Chen
+ "timeout waiting for VBUS disappear\n"); > + break; > + } > + msleep(20); > + } > + } > > ci_role_start(ci, role); > } > -- >

[PATCH v7 5/8] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node

2016-09-19 Thread Peter Chen
From: Peter Chen <peter.c...@freescale.com> At device tree, we have no device node for chipidea core, the glue layer's node is the parent node for host and udc device. But in related driver, the parent device is chipidea core. So, in order to let the common driver get parent's node,

[PATCH v7 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line

2016-09-19 Thread Peter Chen
layton <stillcompil...@gmail.com> Signed-off-by: Peter Chen <peter.c...@nxp.com> --- arch/arm/boot/dts/imx6q-evi.dts | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/arch/arm/boot/dts/imx6q-evi.dts b/arch/arm/boot/dts/imx6q-evi.dts index 4fa56

[PATCH v7 6/8] ARM: dts: imx6qdl: Enable usb node children with

2016-09-19 Thread Peter Chen
From: Joshua Clayton <stillcompil...@gmail.com> Give usb nodes #address and #size attributes, so that a child node representing a permanently connected device such as an onboard hub may be addressed with a attribute Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> Signed-o

[PATCH v7 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-09-19 Thread Peter Chen
Add binding doc for generic power sequence library. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++

[PATCH v7 2/8] power: add power sequence library

2016-09-19 Thread Peter Chen
and clocks currently, and can cover regulator and pinctrl in future. The host driver just needs to call of_pwrseq_on/of_pwrseq_off if only one power sequence is needed, else call of_pwrseq_on_list /of_pwrseq_off_list instead (eg, USB hub driver). Signed-off-by: Peter Chen <peter.c...@nxp.com>

[PATCH v7 4/8] usb: core: add power sequence handling for USB devices

2016-09-19 Thread Peter Chen
-off-by: Peter Chen <peter.c...@nxp.com> Tested-by Joshua Clayton <stillcompil...@gmail.com> --- drivers/usb/core/hub.c | 41 ++--- drivers/usb/core/hub.h | 1 + 2 files changed, 39 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/hub.c b

[PATCH v7 7/8] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2016-09-19 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller, and power sequence properties are under it. Besides, using gpio pinctrl setting for USB2415's reset pin. Signed-off-by: Peter Chen <peter.c...@nxp.

[PATCH v7 3/8] binding-doc: usb: usb-device: add optional properties for power sequence

2016-09-19 Thread Peter Chen
Add optional properties for power sequence. Signed-off-by: Peter Chen <peter.c...@nxp.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/usb/usb-device.txt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentatio

[PATCH v7 0/8] power: add power sequence library

2016-09-19 Thread Peter Chen
not but its pointer for kzalloc - Since chipidea core has no of_node, let core's of_node equals glue layer's at core's probe Joshua Clayton (2): ARM: dts: imx6qdl: Enable usb node children with ARM: dts: imx6q-evi: Fix onboard hub reset line Peter Chen (6): binding-doc: power: pwrseq-gene

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-19 Thread Peter Chen
I am dealing with today, which is more > complex in nature. > > Then the respective drivers can add their drivers (if needed) based on > complexity. > > comments ?? The key point here is DT maintainer (Rob) doesn't agree with adding new node for power sequence at dts. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ARM: imx53: Add binding to disable USB 60Mhz clock

2016-09-17 Thread Peter Chen
} > if (data->disable_oc) { > reg = usbmisc->base + MX53_USB_UH3_CTRL_OFFSET; > val = readl(reg) | MX53_BM_OVER_CUR_DIS_UHx; > -- > 2.1.4 [1] http://www.spinics.net/lists/linux-usb/msg146832.html -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-16 Thread Peter Chen
sb-connector; > port@0 { > #address-cells = <1>; > #size-cells = <0>; > reg = <0>; > usb_a1_connector: endpoint@0 { > reg = <0&

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-16 Thread Peter Chen
rk and I haven't been following along. I'll look into these > patches more. DRD framework is denied by Felipe due to only one user can be benefit from it (chipidea OTG), I don't know the further status of USB MUX, maybe you can ask for it. -- Best Regards, Peter Chen -- To unsubscribe f

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-15 Thread Peter Chen
On Wed, Sep 14, 2016 at 01:45:04AM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-14 01:03:21) > > On Tue, Sep 13, 2016 at 10:58:26PM -0700, Stephen Boyd wrote: > > > Quoting Peter Chen (2016-09-13 20:32:00) > > > > On Tue, Sep 13, 2016 at 06:42:

[GIT PULL] usb: chipidea changes for v4.9-rc1

2016-09-15 Thread Peter Chen
| 22 +--- 7 files changed, 45 insertions(+), 29 deletions(-) -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-14 Thread Peter Chen
ystem, it can work. Like the case [1], without PHY ref_clk, it will hang when configure PHY mode (visit portsc.pts), it has no chance to read id registers. So, I still think the ULPI bus driver needs to do power sequence for its children, unless you have some place to open the ref_clk. > > Ar

Re: ULPI phy issue with

2016-09-14 Thread Peter Chen
l cc on discussion. > > As you ask me earlier maybe he init clock from bootloader. Yes, his PHY input clock is always on. Stephen boyd's ulpi support at chipidea is the correct way. For your case, you can create a generic ULPI PHY driver, and registered it on ulpi bus, but you still

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-14 Thread Peter Chen
On Tue, Sep 13, 2016 at 11:29:12PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-13 19:11:33) > > On Tue, Sep 13, 2016 at 01:41:44PM -0700, Stephen Boyd wrote: > > > Quoting Peter Chen (2016-09-13 00:03:58) > > > > On Wed, Sep 07, 2016 at 02:35:

Re: [PATCH 1/1] usb: Kconfig: using select for USB_COMMON dependency

2016-09-14 Thread Peter Chen
On Wed, Sep 14, 2016 at 09:35:10AM +0200, Arnd Bergmann wrote: > On Wednesday, September 14, 2016 9:49:30 AM CEST Peter Chen wrote: > > According to (badf6d47f8a9 "usb: common: rework CONFIG_USB_COMMON logic") > > we should select USB_COMMON at Kconfig when usb

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-14 Thread Peter Chen
On Tue, Sep 13, 2016 at 10:58:26PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-13 20:32:00) > > On Tue, Sep 13, 2016 at 06:42:46PM -0700, Stephen Boyd wrote: > > > On the db410c 96boards platform we have a TC7USB40MU[1] on the > > > board to mux the D+/D-

Re: [PATCH/REBASED] usb: chipidea: Properly mark little endian descriptors

2016-09-14 Thread Peter Chen
ind new bugs. Let's mark the members of > structures properly and fix the few places where we're missing > conversions. > > Cc: Peter Chen <peter.c...@nxp.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off-by: Stephen Boyd <stephen.b...@linaro.o

Re: [RFC/PATCH] usb: misc: Add a driver for TC7USB40MU

2016-09-13 Thread Peter Chen
ruct of_device_id tc7usb40mu_dt_match[] = { > + { .compatible = "toshiba,tc7usb40mu", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, tc7usb40mu_dt_match); > + > +static struct platform_driver tc7usb40mu_driver = { > + .probe = tc7usb40mu_probe, > + .remove = tc7usb40mu_remove, > + .driver = { > + .name = "tc7usb40mu", > + .of_match_table = tc7usb40mu_dt_match, > + }, > +}; > +module_platform_driver(tc7usb40mu_driver); > + > +MODULE_AUTHOR("Stephen Boyd <stephen.b...@linaro.org>"); > +MODULE_DESCRIPTION("TC7USB40MU USB multiplexer driver"); > +MODULE_LICENSE("GPL"); > -- > 2.9.0.rc2.8.ga28705d > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: chipidea: Properly mark little endian descriptors

2016-09-13 Thread Peter Chen
On Wed, Sep 14, 2016 at 10:37:40AM +0800, Peter Chen wrote: > On Tue, Sep 13, 2016 at 04:06:31PM -0700, Stephen Boyd wrote: > > The DMA descriptors are little endian, and we do a pretty good > > job of handling them with the proper le32_to_cpu() markings, but > > we don

Re: [PATCH] usb: chipidea: Properly mark little endian descriptors

2016-09-13 Thread Peter Chen
ind new bugs. Let's mark the members of > structures properly and fix the few places where we're missing > conversions. > > Cc: Peter Chen <peter.c...@nxp.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off-by: Stephen Boyd <stephen.b...@linaro.

Re: [PATCH v4 22/22] phy: Add support for Qualcomm's USB HS phy

2016-09-13 Thread Peter Chen
On Tue, Sep 13, 2016 at 01:41:44PM -0700, Stephen Boyd wrote: > Quoting Peter Chen (2016-09-13 00:03:58) > > On Wed, Sep 07, 2016 at 02:35:19PM -0700, Stephen Boyd wrote: > > > The high-speed phy on qcom SoCs is controlled via the ULPI > > > viewport. > > >

[PATCH 1/1] usb: Kconfig: using select for USB_COMMON dependency

2016-09-13 Thread Peter Chen
nel.org> Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by: Peter Chen <peter.c...@nxp.com> --- drivers/usb/Kconfig | 5 +++-- drivers/usb/usbip/Kconfig | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/Kconfig b/drivers/usb/Kco

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

2016-09-13 Thread Peter Chen
On Tue, Sep 13, 2016 at 09:36:39AM +0200, Arnd Bergmann wrote: > On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote: > > > > I just see below Kconfig entry at the same Kconfig > > (drivers/usb/Kconfig), and forget your changes. > > > > config USB_L

<    1   2   3   4   5   6   7   8   9   10   >