Re: [PATCH] musb: Kill __init from function that are called at other times as well.

the omap2430 module again. Those functions if marked as much can (and will as I have witnessed) be removed from memory, leading to a crash. What do you think? Regards -- Pantelis On Sep 6, 2012, at 4:04 PM, Felipe Balbi wrote: On Thu, Sep 06, 2012 at 05:01:46PM +0300, Pantelis Antoniou wrote

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

Hi Felipe I see about __devinit. There's no crash because in those logs the __init modifiers are gone. Regards -- Pantelis On Sep 6, 2012, at 8:07 PM, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 05:58:27PM +0300, Pantelis Antoniou wrote: Hi Felipe, A proper answer required some

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

On Sep 6, 2012, at 8:37 PM, Felipe Balbi wrote: Hi, On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote: Hi Felipe I see about __devinit. There's no crash because in those logs the __init modifiers are gone. it'd be cool to see the crash, though ;-) -- balbi Heh

Re: linux 3.6-rc2, undefined reference to omap_musb_mailbox

commit e191e7226099d90ba077719313d4964cf42834ca Author: Pantelis Antoniou pa...@antoniou-consulting.com Date: Fri Aug 10 13:07:43 2012 + musb: Introduce mailbox helper When MUSB_OMAP2 is compiled as a module while the musb mailbox callers are not build fails. Introduce

[PATCH] musb: Kill __init from function that are called at other times as well.

Marking functions as __init or __devinit and calling them at other times leads to predictable crashes (if you're lucky). Remove them for now. Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com --- drivers/usb/musb/musb_core.c| 16 drivers/usb/musb/musb_debugfs.c