[PATCH] usb: core: message: remove extra endianness conversion in usb_set_isoch_delay

2018-05-25 Thread Ruslan Bilovol
linux.intel.com> Cc: stable <sta...@vger.kernel.org> # v4.16+ Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/core/message.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index 0c11d40

Re: [PATCH 0/1] USB Audio Device Class 3.0 Gadget support

2017-12-07 Thread Ruslan Bilovol
Hi Felipe, On Mon, Dec 4, 2017 at 1:36 PM, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Ruslan Bilovol <ruslan.bilo...@gmail.com> writes: >> On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol <ruslan.bilo...@gmail.com> >> wrote: >>> Hi, &g

Re: [PATCH 0/1] USB Audio Device Class 3.0 Gadget support

2017-11-06 Thread Ruslan Bilovol
On Tue, Nov 7, 2017 at 3:52 AM, Ruslan Bilovol <ruslan.bilo...@gmail.com> wrote: > Hi, > > This patch adds USB Audio Device Class 3.0 [1] function > support to gadget subsystem. > I didn't add UAC3 support to legacy gadget as it will > make preprocessor configuration

[PATCH 0/1] USB Audio Device Class 3.0 Gadget support

2017-11-06 Thread Ruslan Bilovol
axPower ln -s functions/uac3.0 configs/c.2 echo 0x0101 > idProduct echo 0x1d6b > idVendor echo my-serial-num > strings/0x409/serialnumber echo my-manufacturer > strings/0x409/manufacturer echo musb-hdrc.0 > UDC [1] http://www.usb.org/developers/docs/devclass_docs/USB_Audio_v3.0.z

[PATCH 1/1] usb: gadget: add USB Audio Device Class 3.0 gadget support

2017-11-06 Thread Ruslan Bilovol
, for example volume, mute and power management handling has dummy implementation in some places Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- Documentation/ABI/testing/configfs-usb-gadget-uac3 | 14 + Documentation/usb/gadget-testing.txt | 41 + drivers/usb/gadget/K

[PATCH 1/3] include: usb: audio: specify exact endiannes of descriptors

2017-06-25 Thread Ruslan Bilovol
USB spec says that multiple byte fields are stored in little-endian order (see chapter 8.1 of USB2.0 spec and chapter 7.1 of USB3.0 spec), thus mark such fields as LE for UAC1 and UAC2 headers Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- include/linux/usb/audio-v2.h

[PATCH 2/3] usb: gadget: f_uac1: endianness fixes.

2017-06-25 Thread Ruslan Bilovol
As per USB spec, multiple-bytes fields are stored in little-endian order. Use CPU<->LE helpers for such fields. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/function/f_uac1.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deleti

[PATCH 0/3] USB Audio gadget endianness fixes

2017-06-25 Thread Ruslan Bilovol
. For big endian case tested only build which also doesn't produce sparse warnings anymore. Ruslan Bilovol (3): include: usb: audio: specify exact endiannes of descriptors usb: gadget: f_uac1: endianness fixes. usb: gadget: f_uac2: endianness fixes. drivers/usb/gadget/function/f_uac1.c | 20

[PATCH 3/3] usb: gadget: f_uac2: endianness fixes.

2017-06-25 Thread Ruslan Bilovol
As per USB spec, multiple-bytes fields are stored in little-endian order. Use CPU<->LE helpers for such fields. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/function/f_uac2.c | 25 ++--- 1 file changed, 14 insertions(+),

[PATCH v5 0/4] USB Audio Gadget refactoring

2017-06-18 Thread Ruslan Bilovol
s: - renamed u_audio exported symbols so they don't conflict with old f_uac1 if both are built-in. v2 changes: - do not touch f_uac1, instead created f_uac1_newapi - added documentation for f_uac1_newapi - rebased on top of v4.8-rc1 [1] https://lkml.org/lkml/2016/5/23/649 Ruslan Bilo

[PATCH v5 1/4] usb: gadget: f_uac2: remove platform driver/device creation

2017-06-18 Thread Ruslan Bilovol
Simplify f_uac2 by removing platform driver/device creation; use composite's usb_gadget device as parent for sound card and for debug prints. This removes extra layer of code without any functional change. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/fu

[PATCH v5 2/4] usb: gadget: f_uac2: split out audio core

2017-06-18 Thread Ruslan Bilovol
ALSA sound card's name configurable - add [in/out]_ep_maxpsize - allocate snd_uac_chip structure during g_audio_setup - add u_audio_[start/stop]_[capture/playback] functions Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/Kconfig| 4 + drive

[PATCH v5 4/4] usb: gadget: add f_uac1 variant based on a new u_audio api

2017-06-18 Thread Ruslan Bilovol
ere is no any reason to keep them in the same file/module, and separate function was created. g_audio can be built using one of existing UAC functions (f_uac1, f_uac1_legacy or f_uac2) Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- Documentation/ABI/testing/configfs-us

[PATCH v5 3/4] usb: gadget: function: make current f_uac1 implementation legacy

2017-06-18 Thread Ruslan Bilovol
Before introducing new f_uac1 function (with virtual ALSA card) make current implementation legacy. This includes renaming of existing files, some variables, config options and documentation Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- ...gadget-uac1 => configfs-u

[PATCH] usb: gadget: function: f_uac1: implement get_alt()

2017-06-17 Thread Ruslan Bilovol
.@samsung.com> Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/function/f_uac1.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

2017-06-06 Thread Ruslan Bilovol
On Tue, Jun 6, 2017 at 12:41 PM, Felipe Balbi wrote: > > Hi, > > Greg KH writes: >>> > I'm OK with dropping legacy f_uac1 implementation. >>> > >>> > Another idea I was thinking about is to implement simple in-kernel >>> > driver which will do the

[PATCH v2 resend] omap: usb: host: remove deprecated flags and structures

2017-06-02 Thread Ruslan Bilovol
From: Ruslan Bilovol <ruslan.bilo...@ti.com> These flags and structures are deprecated and there is no anymore users of them, so it's safe to remove them. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@ti.com> --- Although this patch was acked-by Felipe Balbi and Roger Quadros

Re: [PATCH v4 0/3] USB Audio Gadget refactoring

2017-06-02 Thread Ruslan Bilovol
Hi, On Fri, Jun 2, 2017 at 12:42 PM, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Ruslan Bilovol <ruslan.bilo...@gmail.com> writes: >> I came to this patch series when wanted to do two things: >> - use UAC1 as virtual ALSA sound card on gadget side,

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-06-02 Thread Ruslan Bilovol
Hi Felipe, On Fri, Jun 2, 2017 at 12:34 PM, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Ruslan Bilovol <ruslan.bilo...@gmail.com> writes: >> Abstract the peripheral side ALSA sound card code from >> the f_uac2 function into a component that can b

Re: [PATCH v4 3/3] usb: gadget: add f_uac1 variant based on a new u_audio api

2017-05-29 Thread Ruslan Bilovol
On Fri, May 26, 2017 at 6:52 PM, Julian Scheel <jul...@jusst.de> wrote: > On 18.05.2017 00:37, Ruslan Bilovol wrote: >> >> This patch adds a new function 'f_uac1_acard' >> (f_uac1 with virtual "ALSA card") that >> uses recently created u_audio

Re: [PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-05-29 Thread Ruslan Bilovol
On Mon, May 22, 2017 at 6:58 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: > On Thu, May 18, 2017 at 4:07 AM, Ruslan Bilovol > <ruslan.bilo...@gmail.com> wrote: >> Abstract the peripheral side ALSA sound card code from >> the f_uac2 function into a component th

[PATCH v4 0/3] USB Audio Gadget refactoring

2017-05-17 Thread Ruslan Bilovol
[1] https://lkml.org/lkml/2016/5/23/649 Ruslan Bilovol (3): usb: gadget: f_uac2: remove platform driver/device creation usb: gadget: f_uac2: split out audio core usb: gadget: add f_uac1 variant based on a new u_audio api .../ABI/testing/configfs-usb-gadget-uac1_acard | 14 + Docu

[PATCH v4 2/3] usb: gadget: f_uac2: split out audio core

2017-05-17 Thread Ruslan Bilovol
ALSA sound card's name configurable - add [in/out]_ep_maxpsize - allocate snd_uac_chip structure during g_audio_setup - add u_audio_[start/stop]_[capture/playback] functions Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/Kconfig| 4 + drive

[PATCH v4 3/3] usb: gadget: add f_uac1 variant based on a new u_audio api

2017-05-17 Thread Ruslan Bilovol
ent comparing to legace f_uac1, that there is no any reason to keep them in the same file/module, and separate function was created. g_audio can be built using one of existing UAC functions (f_uac1, f_uac1_acard or f_uac2) Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- .../ABI/t

[PATCH v4 1/3] usb: gadget: f_uac2: remove platform driver/device creation

2017-05-17 Thread Ruslan Bilovol
Simplify f_uac2 by removing platform driver/device creation; use composite's usb_gadget device as parent for sound card and for debug prints. This removes extra layer of code without any functional change. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/fu

Re: [PATCH v3 0/3] USB Audio Gadget refactoring

2017-02-04 Thread Ruslan Bilovol
Hi Felipe, On Mon, Aug 29, 2016 at 11:05 AM, Felipe Balbi <ba...@kernel.org> wrote: > > Hi, > > Ruslan Bilovol <ruslan.bilo...@gmail.com> writes: >> I came to this patch series when wanted to do two things: >> - use UAC1 as virtual ALSA sound card on gadget s

[PATCH v3 0/3] USB Audio Gadget refactoring

2016-08-17 Thread Ruslan Bilovol
conflict with old f_uac1 if both are built-in. v2 changes: - do not touch f_uac1, instead created f_uac1_newapi - added documentation for f_uac1_newapi - rebased on top of v4.8-rc1 [1] https://lkml.org/lkml/2016/5/23/649 Ruslan Bilovol (3): usb: gadget: f_uac2: remove platform driver/d

[PATCH v3 1/3] usb: gadget: f_uac2: remove platform driver/device creation

2016-08-17 Thread Ruslan Bilovol
Simplify f_uac2 by removing platform driver/device creation; use composite's usb_gadget device as parent for sound card and for debug prints. This removes extra layer of code without any functional change. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/fu

[PATCH v3 3/3] usb: gadget: add f_uac1 variant based on new u_audio api

2016-08-17 Thread Ruslan Bilovol
ver had real volume control or mute functionality. g_audio can be built using one of existing uac functions (f_uac1, f_uac1_newapi or f_uac2) Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- .../ABI/testing/configfs-usb-gadget-uac1_newapi| 12 + Documentation/usb/gadget-te

[PATCH v3 2/3] usb: gadget: f_uac2: split out audio core

2016-08-17 Thread Ruslan Bilovol
ALSA sound card's name configurable - add [in/out]_ep_maxpsize - allocate snd_uac_chip structure during g_audio_setup - add u_audio_[start/stop]_[capture/playback] functions Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/Kconfig| 4 + drive

Re: [PATCH v2 2/3] usb: gadget: f_uac2: split out audio core

2016-08-16 Thread Ruslan Bilovol
rove the system] > > url: > https://github.com/0day-ci/linux/commits/Ruslan-Bilovol/USB-Audio-Gadget-refactoring/20160814-185318 > base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next > config: x86_64-randconfig-a0-08162223 (attached as .config) >

Re: [PATCH v2 0/3] USB Audio Gadget refactoring

2016-08-16 Thread Ruslan Bilovol
On Tue, Aug 16, 2016 at 12:16 PM, Peter Chen <hzpeterc...@gmail.com> wrote: > On Sun, Aug 14, 2016 at 01:21:21AM +0300, Ruslan Bilovol wrote: >> I came to this patch series when wanted to do two things: >> - use UAC1 as virtual ALSA sound card on gadget side, >>jus

Re: [PATCH v2 3/3] usb: gadget: add f_uac1 variant based on new u_audio api

2016-08-16 Thread Ruslan Bilovol
On Tue, Aug 16, 2016 at 5:52 AM, Peter Chen <hzpeterc...@gmail.com> wrote: > On Sun, Aug 14, 2016 at 01:21:24AM +0300, Ruslan Bilovol wrote: >> This patch adds new function f_uac1_newapi that >> uses recently created u_audio api. This makes >> f_uac1_newapi

[PATCH v2 1/3] usb: gadget: f_uac2: remove platform driver/device creation

2016-08-14 Thread Ruslan Bilovol
Simplify f_uac2 by removing platform driver/device creation; use composite's usb_gadget device as parent for sound card and for debug prints. This removes extra layer of code without any functional change. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/fu

[PATCH v2 3/3] usb: gadget: add f_uac1 variant based on new u_audio api

2016-08-14 Thread Ruslan Bilovol
ver had real volume control or mute functionality. g_audio can be built using one of existing uac functions (f_uac1, f_uac1_newapi or f_uac2) Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- .../ABI/testing/configfs-usb-gadget-uac1_newapi| 12 + Documentation/usb/gadget-te

[PATCH v2 2/3] usb: gadget: f_uac2: split out audio core

2016-08-14 Thread Ruslan Bilovol
ALSA sound card's name configurable - add [in/out]_ep_maxpsize - allocate snd_uac_chip structure during gaudio_setup - add gaudio_[start/stop]_[capture/playback] functions Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/Kconfig| 4 + drive

[PATCH v2 0/3] USB Audio Gadget refactoring

2016-08-14 Thread Ruslan Bilovol
uac1_newapi - added documentation for f_uac1_newapi - rebased on top of v4.8-rc1 [1] https://lkml.org/lkml/2016/5/23/649 Ruslan Bilovol (3): usb: gadget: f_uac2: remove platform driver/device creation usb: gadget: f_uac2: split out audio core usb: gadget: add f_uac1 variant based on new u_audio a

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Ruslan Bilovol
On Tue, Jul 26, 2016 at 3:02 PM, Krzysztof Opasiak <k.opas...@samsung.com> wrote: > > > On 07/26/2016 10:53 AM, Jassi Brar wrote: >> On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol >> <ruslan.bilo...@gmail.com> wrote: >>> On Fri, Jul 15, 2016 at 10:

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-26 Thread Ruslan Bilovol
On Tue, Jul 26, 2016 at 11:53 AM, Jassi Brar <jassisinghb...@gmail.com> wrote: > On Tue, Jul 26, 2016 at 7:01 AM, Ruslan Bilovol > <ruslan.bilo...@gmail.com> wrote: >> On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch <clem...@ladisch.de> wrote: >>>>

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-25 Thread Ruslan Bilovol
On Fri, Jul 15, 2016 at 10:43 AM, Clemens Ladisch <clem...@ladisch.de> wrote: >>> On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol >>> <ruslan.bilo...@gmail.com> wrote: >>>> it may break current usecase for some people > > And what are the benef

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-07-14 Thread Ruslan Bilovol
Ping? On Wed, Jun 8, 2016 at 11:03 AM, Ruslan Bilovol <ruslan.bilo...@gmail.com> wrote: > Hi guys, > > Any feedback on this patch series? Has anybody had a chance to test it? > > Regards, > Ruslan > > On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol > <ruslan

Re: [RFC PATCH 0/5] USB Audio Gadget refactoring

2016-06-08 Thread Ruslan Bilovol
Hi guys, Any feedback on this patch series? Has anybody had a chance to test it? Regards, Ruslan On Tue, May 24, 2016 at 2:50 AM, Ruslan Bilovol <ruslan.bilo...@gmail.com> wrote: > I came to this patch series when wanted to do two things: > - use UAC1 as virtual ALSA sound card on

[RFC PATCH 3/5] usb: gadget: f_uac1: drop volume/mute functionality

2016-05-23 Thread Ruslan Bilovol
needed handlers Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/function/f_uac1.c | 182 +-- 1 file changed, 5 insertions(+), 177 deletions(-) diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_

[RFC PATCH 2/5] usb: gadget: f_uac2: split out audio core

2016-05-23 Thread Ruslan Bilovol
ALSA sound card's name configurable - add [in/out]_ep_maxpsize - allocate snd_uac_chip structure during gaudio_setup - add gaudio_[start/stop]_[capture/playback] functions Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/Kconfig| 4 + drive

[RFC PATCH 0/5] USB Audio Gadget refactoring

2016-05-23 Thread Ruslan Bilovol
. Comments, testing are welcome. Ruslan Bilovol (5): usb: gadget: f_uac2: remove platform driver/device creation usb: gadget: f_uac2: split out audio core usb: gadget: f_uac1: drop volume/mute functionality usb: gadget: f_uac1: switch to u_audio core utilities usb: gadget: f_uac1: add captu

[RFC PATCH 1/5] usb: gadget: f_uac2: remove platform driver/device creation

2016-05-23 Thread Ruslan Bilovol
Simplify f_uac2 by removing platform driver/device creation; use composite's usb_gadget device as parent for sound card and for debug prints. This removes extra layer of code without any functional change. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/fu

[RFC PATCH 5/5] usb: gadget: f_uac1: add capture support

2016-05-23 Thread Ruslan Bilovol
ame as playback channel has. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/Kconfig | 7 +- drivers/usb/gadget/function/f_uac1.c | 265 --- drivers/usb/gadget/function/u_uac1.h | 6 + drivers/usb/gadget/legacy/audio.c

[RFC PATCH 4/5] usb: gadget: f_uac1: switch to u_audio core utilities

2016-05-23 Thread Ruslan Bilovol
by userspace tools. As a side effect, using u_audio it will be much easier to create gadget -> PC Host audio stream in the future Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/usb/gadget/Kconfig | 8 +- drivers/usb/gadget/function/Makefile | 2 +- dr

Re: [PATCH v4] kconfig/symbol.c: handle choice_values that depend on 'm' symbols

2016-03-30 Thread Ruslan Bilovol
but does not in 3.16, >>> unless I messed up with my test. I will test 3.16 again some time next >>> week. >> >> Hi Bin, >> >> I now also re-tested the initially reported steps to reproduce the >> issue: >> >> >>> in USB gadget menu (that is Device Drivers ---> USB support ---> USB >>> Gadget Support ---> USB Gadget Drivers) I can create a configuration >>> which is "lost". Here is how to reproduce it: >>> >>> - first config two gadgets as M: >>> USB Gadget Drivers >>> Audio Gadget >>> Ethernet Gadget >>> MIDI Gadget >>> >>> save config & leave >>> >>> - now start menu config again and go to the same menu, now select >>> built-in: >>> <*> USB Gadget Drivers (Ethernet Gadget >>> the ethernet gadget is chosen automatically because we can have only >>> one gadget selected. >>> save config & leave >>> >>> - step three, go back to the menu and you will see that everything is >>> as it was (the <*> is ignored). >> >> >> Here, I still see the problem (I was wondering if the issue has been >> solved/gone by a kconfig-file modification). > > This issue was gone since 3.16, but came back again due to commit > 1fd6d08 ARM: omap2plus_defconfig: Enable n900 modem as loadable modules. > I can confirm this issue too, faced it on v4.5 (but didn't try v4.6-rc1 yet) -- Best regards, Ruslan Bilovol -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] phy: twl4030-usb: fix musb-hdrc name for non-dt case

2016-03-24 Thread Ruslan Bilovol
musb device is allocated with PLATFORM_DEVID_AUTO, fix incorrect lookup name in non-dt case. This fixes issue with musb initialization on Nokia N900 in boardfile boot mode. Signed-off-by: Ruslan Bilovol <ruslan.bilo...@gmail.com> --- drivers/phy/phy-twl4030-usb.c | 2 +- 1 file chan

Re: [PATCH v3 1/3] USB: add descriptors from USB Power Delivery spec

2016-03-10 Thread Ruslan Bilovol
On Thu, Mar 10, 2016 at 3:59 PM, Oliver Neukum wrote: > Adding the descriptors of chapter 9.2 of the Power Delivery spec. > > Signed-off-by: Oliver Neukum > --- > include/uapi/linux/usb/ch9.h | 98 > > 1 file

Re: [RFC Patch 1/3] USB: add descriptors from USB Power Delivery spec

2016-03-10 Thread Ruslan Bilovol
Hi, On Thu, Mar 10, 2016 at 12:45 PM, Felipe Balbi wrote: > > Hi, > > Oliver Neukum writes: >> [ text/plain ] >> Adding the descriptors of chapter 9.2 of the Power Delivery spec. >> >> Signed-off-by: Oliver Neukum >> --- >>

Re: gadgetfs regression (NULL ptr deref) since v4.4-rc7

2016-02-08 Thread Ruslan Bilovol
48 b9 00 01 00 00 00 00 ad de 48 8b 57 08 48 89 e5 > 48 39 c8 74 29 48 b9 00 02 00 00 00 00 ad de 48 39 ca 74 3a <4c> 8b 02 4c 39 > c7 75 52 4c 8b 40 08 4c 39 c7 75 66 48 89 50 08 > RIP [] __list_del_entry+0x29/0xc0 > RSP > CR2: > ---[ end trace e6cfe1de6

Re: [PATCH v7 0/4] usb/gadget: independent registration of gadgets and gadget drivers

2015-11-26 Thread Ruslan Bilovol
Hi Marek, On Mon, Nov 23, 2015 at 10:56 AM, Marek Szyprowski <m.szyprow...@samsung.com> wrote: > Hello, > > This is a resurrection of the patches initially submitted by Ruslan > Bilovol in the following thread: https://lkml.org/lkml/2015/6/22/554 > > The changes since the

Re: [PATCH v5 0/5] usb/gadget: independent registration of gadgets and gadget drivers

2015-11-02 Thread Ruslan Bilovol
Hi Maxime, On Mon, Oct 19, 2015 at 11:11 AM, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > Hi, > > On Tue, Jun 23, 2015 at 01:01:09AM +0300, Ruslan Bilovol wrote: >> This patchset adds independent registration of gadgets >> and gadget drivers to ud

Re: [PATCH v5 2/5] usb: gadget: configfs: pass UDC name via usb_gadget_driver struct

2015-06-27 Thread Ruslan Bilovol
Hi Krzysztof, On Tue, Jun 23, 2015 at 9:54 AM, Krzysztof Opasiak k.opas...@samsung.com wrote: Hello, On 06/23/2015 12:01 AM, Ruslan Bilovol wrote: Now when udc-core supports binding to specific UDC by passing its name via 'udc_name' member of usb_gadget_driver struct, switch

Re: [PATCH v5 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-06-27 Thread Ruslan Bilovol
Hi Alan, On Tue, Jun 23, 2015 at 5:08 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 23 Jun 2015, Ruslan Bilovol wrote: Change behavior during registration of gadgets and gadget drivers in udc-core. Instead of previous approach when for successful probe of usb gadget driver

[PATCH v5 4/5] usb: gadget: legacy: don't use __init/__exit attributes for bind/unbind path

2015-06-22 Thread Ruslan Bilovol
In order to prepare to independent gadgets and gadget drivers registration in udc-core, some of the functions can't have __init/__exit attributes (almost only bind/unbind callbacks are affected) Tested-by: Maxime Ripard maxime.rip...@free-electrons.com Signed-off-by: Ruslan Bilovol ruslan.bilo

[PATCH v5 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-06-22 Thread Ruslan Bilovol
to no any UDC added. Also it is useful for modules case - now there is no difference what module to insert first: gadget module or gadget driver one. Tested-by: Maxime Ripard maxime.rip...@free-electrons.com Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc

[PATCH v5 3/5] usb: gadget: udc-core: remove unused usb_udc_attach_driver()

2015-06-22 Thread Ruslan Bilovol
Now when last user of usb_udc_attach_driver() is switched to passing UDC name via usb_gadget_driver struct, it's safe to remove this function Tested-by: Maxime Ripard maxime.rip...@free-electrons.com Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc-core.c

[PATCH v5 2/5] usb: gadget: configfs: pass UDC name via usb_gadget_driver struct

2015-06-22 Thread Ruslan Bilovol
Now when udc-core supports binding to specific UDC by passing its name via 'udc_name' member of usb_gadget_driver struct, switch to this generic approach. Tested-by: Maxime Ripard maxime.rip...@free-electrons.com Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget

[PATCH v5 0/5] usb/gadget: independent registration of gadgets and gadget drivers

2015-06-22 Thread Ruslan Bilovol
'next' branch of Felipe Balbi's tree Ruslan Bilovol (5): usb: gadget: bind UDC by name passed via usb_gadget_driver structure usb: gadget: configfs: pass UDC name via usb_gadget_driver struct usb: gadget: udc-core: remove unused usb_udc_attach_driver() usb: gadget: legacy: don't use __init

[PATCH v5 1/5] usb: gadget: bind UDC by name passed via usb_gadget_driver structure

2015-06-22 Thread Ruslan Bilovol
Introduce new 'udc_name' member to usb_gadget_driver structure. The 'udc_name' is a name of UDC that usb_gadget_driver should be bound to. If udc_name is NULL, it will be bound to any available UDC. Tested-by: Maxime Ripard maxime.rip...@free-electrons.com Signed-off-by: Ruslan Bilovol

Re: [PATCH v4 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-03-15 Thread Ruslan Bilovol
HI Alan, On Fri, Mar 13, 2015 at 4:39 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 12 Mar 2015, Ruslan Bilovol wrote: Change behavior during registration of gadgets and gadget drivers in udc-core. Instead of previous approach when for successful probe of usb gadget driver

[PATCH v4 0/5] usb/gadget: independent registration of gadgets and gadget drivers

2015-03-12 Thread Ruslan Bilovol
will be required) - rebased to latest 'next' branch of Felipe Balbi's tree Ruslan Bilovol (5): usb: gadget: bind UDC by name passed via usb_gadget_driver structure usb: gadget: configfs: pass UDC name via usb_gadget_driver struct usb: gadget: udc-core: remove unused usb_udc_attach_driver

[PATCH v4 3/5] usb: gadget: udc-core: remove unused usb_udc_attach_driver()

2015-03-12 Thread Ruslan Bilovol
Now when last user of usb_udc_attach_driver() is switched to passing UDC name via usb_gadget_driver struct, it's safe to remove this function Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc-core.c | 26 -- include/linux/usb/gadget.h

[PATCH v4 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-03-12 Thread Ruslan Bilovol
to no any UDC added. Also it is useful for modules case - now there is no difference what module to insert first: gadget module or gadget driver one. Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc-core.c | 49 --- include

[PATCH v4 1/5] usb: gadget: bind UDC by name passed via usb_gadget_driver structure

2015-03-12 Thread Ruslan Bilovol
Introduce new 'udc_name' member to usb_gadget_driver structure. The 'udc_name' is a name of UDC that usb_gadget_driver should be bound to. If udc_name is NULL, it will be bound to any available UDC. Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc-core.c | 24

[PATCH v4 2/5] usb: gadget: configfs: pass UDC name via usb_gadget_driver struct

2015-03-12 Thread Ruslan Bilovol
Now when udc-core supports binding to specific UDC by passing its name via 'udc_name' member of usb_gadget_driver struct, switch to this generic approach. Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/configfs.c | 27 ++- 1 file changed, 14

[PATCH v4 4/5] usb: gadget: legacy: don't use __init/__exit attributes for bind/unbind path

2015-03-12 Thread Ruslan Bilovol
In order to prepare to independent gadgets and gadget drivers registration in udc-core, some of the functions can't have __init/__exit attributes (almost only bind/unbind callbacks are affected) Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/legacy/acm_ms.c

Re: [PATCHv3 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-03-10 Thread Ruslan Bilovol
Hi Alan, On Tue, Feb 17, 2015 at 11:51 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 17 Feb 2015, Ruslan Bilovol wrote: Change behavior during registration of gadgets and gadget drivers in udc-core. Instead of previous approach when for successful probe of usb gadget driver

Re: [PATCHv3 1/5] usb: gadget: bind UDC by name passed via usb_gadget_driver structure

2015-03-10 Thread Ruslan Bilovol
Hi Sergei, On Wed, Feb 18, 2015 at 2:05 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 2/18/2015 12:17 AM, Ruslan Bilovol wrote: Introduce new 'udc_name' member to usb_gadget_driver structure. The 'udc_name' is a name of UDC that usb_gadget_driver should be bound

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-17 Thread Ruslan Bilovol
Hi Andrzej, On Mon, Feb 16, 2015 at 10:07 AM, Andrzej Pietrasiewicz andrze...@samsung.com wrote: W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze: snip In my opinion all things which you have described are working out-of-box when you use configfs interface. It's mostly ready so you may

[PATCHv3 0/5] usb/gadget: independent registration of gadgets and gadget drivers

2015-02-17 Thread Ruslan Bilovol
unused and not needed now v2: - changed first patch to have only deferred probe part (because Gadget Bus seems to be better variant when some more complicated behavior will be required) - rebased to latest 'next' branch of Felipe Balbi's tree Ruslan Bilovol (5): usb: gadget: bind UDC

[PATCHv3 2/5] usb: gadge: configfs: pass UDC name via usb_gadget_driver struct

2015-02-17 Thread Ruslan Bilovol
Now when udc-core supports binding to specific UDC by passing its name via 'udc_name' member of usb_gadget_driver struct, switch to this generic approach. Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/configfs.c | 27 ++- 1 file changed, 14

[PATCHv3 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-17 Thread Ruslan Bilovol
to no any UDC added. Also it is useful for modules case - now there is no difference what module to insert first: gadget module or gadget driver one. Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc-core.c | 51 ++- include

[PATCHv3 1/5] usb: gadget: bind UDC by name passed via usb_gadget_driver structure

2015-02-17 Thread Ruslan Bilovol
Introduce new 'udc_name' member to usb_gadget_driver structure. The 'udc_name' is a name of UDC that usb_gadget_driver should be bound to. If udc_name is NULL, it will be bound to any available UDC. Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc-core.c | 25

[PATCHv3 3/5] usb: gadget: udc-core: remove unused usb_udc_attach_driver()

2015-02-17 Thread Ruslan Bilovol
Now when last user of usb_udc_attach_driver() is switched to passing UDC name via usb_gadget_driver struct, it's safe to remove this function Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc-core.c | 26 -- include/linux/usb/gadget.h

[PATCHv3 4/5] usb: gadget: legacy: don't use __init/__exit attributes for bind/unbind path

2015-02-17 Thread Ruslan Bilovol
In order to prepare to independent gadgets and gadget drivers registration in udc-core, some of the functions can't have __init/__exit attributes (almost only bind/unbind callbacks are affected) Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/legacy/acm_ms.c

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-15 Thread Ruslan Bilovol
Hi Alan, On Mon, Feb 9, 2015 at 10:00 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 9 Feb 2015, Krzysztof Opasiak wrote: Why bother matching by name? Why not simply take the first available UDC? Because you may have more than one udc. This would allow to pick one by name

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-15 Thread Ruslan Bilovol
Hi Krzysztof, On Tue, Feb 10, 2015 at 10:47 AM, Krzysztof Opasiak k.opas...@samsung.com wrote: -Original Message- From: Ruslan Bilovol [mailto:ruslan.bilo...@gmail.com] Sent: Tuesday, February 10, 2015 12:46 AM To: Alan Stern Cc: Krzysztof Opasiak; Peter Chen; linux-usb

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-09 Thread Ruslan Bilovol
Hi guys, On Mon, Feb 9, 2015 at 10:00 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 9 Feb 2015, Krzysztof Opasiak wrote: Why bother matching by name? Why not simply take the first available UDC? Because you may have more than one udc. This would allow to pick one by name

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-08 Thread Ruslan Bilovol
Hi Alan, On Thu, Jan 29, 2015 at 5:56 PM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 29 Jan 2015, Ruslan Bilovol wrote: Change behavior during registration of gadgets and gadget drivers in udc-core. Instead of previous approach when for successful probe of usb gadget driver

[PATCH 2/2] usb: gadget: legacy: don't use __init/__exit attributes for bind/unbind path

2015-01-28 Thread Ruslan Bilovol
Since it's possible now to do independent gadget and gadget driver registration in udc-core, some of the functions can't have __init/__exit attributes (almost bind/unbind callbacks are affected) Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/legacy/acm_ms.c

[PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-01-28 Thread Ruslan Bilovol
to no any UDC added. Also it is useful for modules case - now there is no difference what module to insert first: gadget module or gadget driver one. Signed-off-by: Ruslan Bilovol ruslan.bilo...@gmail.com --- drivers/usb/gadget/udc/udc-core.c | 113 +++--- 1 file

[PATCH 0/2] usb/gadget: independent registration of gadgets and gadget

2015-01-28 Thread Ruslan Bilovol
driver) Ruslan Bilovol (2): usb: gadget: udc-core: independent registration of gadgets and gadget drivers usb: gadget: legacy: don't use __init/__exit attributes for bind/unbind path drivers/usb/gadget/legacy/acm_ms.c | 6 +- drivers/usb/gadget/legacy/audio.c| 6

Re: usb media detection issue on USB_MUSB_HDRC on kernel 3.17

2014-10-29 Thread Ruslan Bilovol
Hi Enric On Wed, Oct 29, 2014 at 1:44 PM, Enric Balletbo Serra eballe...@gmail.com wrote: Hi all, 2014-10-26 10:10 GMT+01:00 Angelo Dureghello angel...@gmail.com: Had some progresses: on kernel 3.17, musb controller driver is set to start as OTG mode as default. So as first thing,

Re: omap4 ehci sporadic resume issue

2013-06-27 Thread Ruslan Bilovol
Hello guys, On Thu, Jun 27, 2013 at 8:56 PM, Michael Trimarchi mich...@amarulasolutions.com wrote: Hi Roger On Thu, Jun 27, 2013 at 05:49:41PM +0300, Roger Quadros wrote: +Ruslan On 06/27/2013 05:17 PM, Michael Trimarchi wrote: Hi Roger On Thu, Jun 27, 2013 at 04:59:38PM +0300, Roger

Re: omap4 ehci sporadic resume issue

2013-06-27 Thread Ruslan Bilovol
On Thu, Jun 27, 2013 at 10:24 PM, Michael Trimarchi mich...@amarulasolutions.com wrote: Hi On Thu, Jun 27, 2013 at 09:59:35PM +0300, Ruslan Bilovol wrote: Hello guys, On Thu, Jun 27, 2013 at 8:56 PM, Michael Trimarchi mich...@amarulasolutions.com wrote: Hi Roger On Thu, Jun 27, 2013

Re: musb throughput issues

2013-05-13 Thread Ruslan Bilovol
Hi Frederik, On Fri, May 10, 2013 at 2:22 PM, Frederik Schmid frederik.sch...@rubico.se wrote: Hi Ruslan, Thanks for the tips! A few comments below: On Friday 10 May 2013 13.54.53 Ruslan Bilovol wrote: Hello Frederic, On Fri, May 10, 2013 at 12:54 PM, Frederik Schmid frederik.sch

Re: musb throughput issues

2013-05-10 Thread Ruslan Bilovol
Hello Frederic, On Fri, May 10, 2013 at 12:54 PM, Frederik Schmid frederik.sch...@rubico.se wrote: Well, my conclusion is that this setup, IDS-camera + musb, is horribly sensitive to interrupt latency. If the musb-interrupt is blocked for ~100us the pipe is stalled. Most of the interrupts on

Re: [PATCH] usb: musb: gadget: fix enumeration on heavy-loaded systems

2013-04-17 Thread Ruslan Bilovol
Descriptor Test' will fail The fix consists in checking CSR0L.DataEnd state and assigning the device address in the first ep0 interrupt handling, so delay is as minimal as possible Signed-off-by: Ruslan Bilovol ruslan.bilo...@ti.com --- drivers/usb/musb/musb_gadget_ep0.c | 31

Re: [PATCH] usb: musb: gadget: fix enumeration on heavy-loaded systems

2013-04-17 Thread Ruslan Bilovol
devices Usually 'Addressed state/TD9.1: Device Descriptor Test' will fail The fix consists in checking CSR0L.DataEnd state and assigning the device address in the first ep0 interrupt handling, so delay is as minimal as possible Signed-off-by: Ruslan Bilovol ruslan.bilo...@ti.com

[PATCH] usb: musb: gadget: fix enumeration on heavy-loaded systems

2013-04-16 Thread Ruslan Bilovol
state/TD9.1: Device Descriptor Test' will fail The fix consists in checking CSR0L.DataEnd state and assigning the device address in the first ep0 interrupt handling, so delay is as minimal as possible Signed-off-by: Ruslan Bilovol ruslan.bilo...@ti.com --- drivers/usb/musb/musb_gadget_ep0.c

[PATCH v3 0/1] usb: musb: improve throughput in HOST mode

2013-03-29 Thread Ruslan Bilovol
has been little bit changed to keep MUSB struct hc_driver as 'const' (as per Felipe's comments). Verified on top of 3.9-rc4. Ruslan Bilovol (1): usb: musb: implement (un)map_urb_for_dma hooks drivers/usb/musb/musb_host.c | 117 ++ 1 file changed

[PATCH v3 1/1] usb: musb: implement (un)map_urb_for_dma hooks

2013-03-29 Thread Ruslan Bilovol
mode is slow and it's better to align buffers properly before passing them to MUSB This increased throughput 80-120 MBits/s over musb@omap4 with USB Gigabit Ethernet adapter attached. Some ideas are taken from ehci-tegra.c Signed-off-by: Ruslan Bilovol ruslan.bilo...@ti.com --- drivers/usb/musb

Re: [PATCH RESEND v2 1/1] usb: musb: implement (un)map_urb_for_dma hooks

2013-03-28 Thread Ruslan Bilovol
Hi Felipe, On Wed, Mar 27, 2013 at 3:17 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Thu, Mar 14, 2013 at 08:12:09PM +0200, Ruslan Bilovol wrote: MUSB controller cannot work in DMA mode with misaligned buffers, switching in PIO mode. HCD core has hooks that allow to override the default DMA

[PATCH v2 0/1] omap usb host platform_data cleanup

2013-03-14 Thread Ruslan Bilovol
Hello guys, This is v2 of my patch https://patchwork.kernel.org/patch/1232871/ rebased on v3.9-rc2. Removes deprecated flags and structures and saves few bytes of memory. Regards, Ruslan Ruslan Bilovol (1): omap: usb: host: remove deprecated flags and structures include/linux/platform_data

[PATCH v2 1/1] omap: usb: host: remove deprecated flags and structures

2013-03-14 Thread Ruslan Bilovol
These flags and structures are deprecated and there is no anymore users of them, so it's safe to remove them. Signed-off-by: Ruslan Bilovol ruslan.bilo...@ti.com --- include/linux/platform_data/usb-omap.h | 20 1 file changed, 20 deletions(-) diff --git a/include/linux

[PATCH RESEND v2 0/1] usb: musb: improve throughput in HOST mode

2013-03-14 Thread Ruslan Bilovol
Hi guys, This is a resend of my patch: http://permalink.gmane.org/gmane.linux.usb.general/67238 At this moment it has been successfully tested and used on top of 3.0 and 3.4 kernels on omap4 devices so it would be great to have it in upstream too. Regards, Ruslan Ruslan Bilovol (1): usb

  1   2   >