Re: [PATCH RESEND] usb: ehci/ohci-exynos: Fix PHY getting sequence

2014-08-05 Thread Sachin Kamat
the issue with ehci-exynos and ohci-exynos, wherein in the absence of SAMSUNG_USB2PHY config symbol, we end up getting the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs are not configured properly. Reported-by: Sachin Kamat sachin.ka...@samsung.com Signed-off-by: Vivek Gautam

Re: Re: [PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

2014-07-01 Thread Sachin Kamat
On Tue, Jul 01, 2014 at 08:50:19AM +0530, Sachin Kamat wrote: On Mon, Jun 30, 2014 at 10:19 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Jun 30, 2014 at 02:33:14PM +0530, Sachin Kamat wrote: Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS as this IP is available only on Exynos5

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-30 Thread Sachin Kamat
On Fri, Jun 27, 2014 at 10:23 PM, Olof Johansson o...@lixom.net wrote: On Fri, Jun 27, 2014 at 9:32 AM, Doug Anderson diand...@chromium.org wrote: Felipe, On Fri, Jun 27, 2014 at 8:59 AM, Felipe Balbi ba...@ti.com wrote: I'll admit to not having been involved with the previous discussions,

[PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

2014-06-30 Thread Sachin Kamat
Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS as this IP is available only on Exynos5 platforms. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/usb/dwc3/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/Kconfig b

Re: [PATCH 1/1] usb: dwc3: Kconfig: Fix dependency for Exynos DWC3

2014-06-30 Thread Sachin Kamat
On Mon, Jun 30, 2014 at 10:19 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Jun 30, 2014 at 02:33:14PM +0530, Sachin Kamat wrote: Make the config depend on ARCH_EXYNOS5 instead of ARCH_EXYNOS as this IP is available only on Exynos5 platforms. Signed-off-by: Sachin Kamat sachin.ka

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-26 Thread Sachin Kamat
Hi Vivek, On Thu, Jun 26, 2014 at 1:39 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Hi Sachin, On Thu, Jun 26, 2014 at 11:09 AM, Sachin Kamat sachin.ka...@samsung.com wrote: EHCI and OHCI drivers on Exynos platforms do not work without their corresponding SoC specific phy drivers

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-26 Thread Sachin Kamat
Hi Vivek, On Thu, Jun 26, 2014 at 1:55 PM, Sachin Kamat sachin.ka...@samsung.com wrote: Hi Vivek, On Thu, Jun 26, 2014 at 1:39 PM, Vivek Gautam gautam.vi...@samsung.com wrote: Hi Sachin, On Thu, Jun 26, 2014 at 11:09 AM, Sachin Kamat sachin.ka...@samsung.com wrote: EHCI and OHCI

Re: [PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-26 Thread Sachin Kamat
Hi Kishon, On Thu, Jun 26, 2014 at 2:19 PM, Kishon Vijay Abraham I kis...@ti.com wrote: Hi Sachin, On Thursday 26 June 2014 11:09 AM, Sachin Kamat wrote: EHCI and OHCI drivers on Exynos platforms do not work without their corresponding SoC specific phy drivers. Hence it makes no sense

[PATCH 1/2] usb: host: Kconfig: Select PHY drivers for Exynos EHCI/OHCI

2014-06-25 Thread Sachin Kamat
for Exynos 5420 SoC too. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Kishon Vijay Abraham I kis...@ti.com --- drivers/phy/Kconfig | 37 +++-- drivers/usb/host/Kconfig | 10 ++ 2 files changed, 13 insertions(+), 34 deletions(-) diff

[PATCH 2/2] usb: dwc3: Kconfig: Select PHY drivers for Exynos DWC3

2014-06-25 Thread Sachin Kamat
of ARCH_EXYNOS as this IP is available only on Exynos5 platforms. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Kishon Vijay Abraham I kis...@ti.com --- drivers/phy/Kconfig |8 +--- drivers/usb/dwc3/Kconfig |3 ++- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git

[PATCH 1/2] usb: ohci-exynos: Use NULL instead of 0

2014-06-06 Thread Sachin Kamat
The third argument of devm_of_phy_get expects a pointer. Hence use NULL instead of 0. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/usb/host/ohci-exynos.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host

[PATCH 2/2] usb: ehci-exynos: Use NULL instead of 0

2014-06-06 Thread Sachin Kamat
The third argument of devm_of_phy_get expects a pointer. Hence use NULL instead of 0. Fixes the following warning: drivers/usb/host/ehci-exynos.c:91:51: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat sachin.ka...@samsung.com --- drivers/usb/host/ehci-exynos.c |2

[PATCH 1/1] usb: host: max3421-hcd: Use module_spi_driver

2014-05-29 Thread Sachin Kamat
module_spi_driver simplifies the code by eliminating boilerplate code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/max3421-hcd.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host

Re: [PATCH 2/4] ARM: dts: Add usb2phy to Exynos 5250

2014-04-30 Thread Sachin Kamat
Hi Vivek, On 30 April 2014 14:25, Vivek Gautam gautam.vi...@samsung.com wrote: From: Kamil Debski k.deb...@samsung.com Add support to PHY of USB2 of the Exynos 5250 SoC. Signed-off-by: Kamil Debski k.deb...@samsung.com [gautam.vi...@samsung.com: Split the usb phy entries from syscon

Re: [PATCH 4/4] ARM: dts: Add usb 2.0 support on exynos5420

2014-04-30 Thread Sachin Kamat
On 30 April 2014 14:25, Vivek Gautam gautam.vi...@samsung.com wrote: Add required device node for ehci and ohci controllers to enable USB 2.0 support. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 36 +++- 1

Re: [PATCH Resend 1/2] usb: gadget: s3c2410_udc: Fix build error

2014-02-18 Thread Sachin Kamat
On 18 February 2014 20:58, Felipe Balbi ba...@ti.com wrote: On Mon, Feb 03, 2014 at 01:59:38PM +0530, Sachin Kamat wrote: Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. Fixes the following compilation error introduced by commit e117e742d310 (usb: gadget: add

Re: [PATCH Resend 2/2] usb: gadget: s3c-hsudc: Remove unused label

2014-02-18 Thread Sachin Kamat
On 18 February 2014 20:58, Felipe Balbi ba...@ti.com wrote: On Mon, Feb 03, 2014 at 01:59:39PM +0530, Sachin Kamat wrote: Fixes the following compilation warning: drivers/usb/gadget/s3c-hsudc.c: In function 's3c_hsudc_probe': drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label

Re: [PATCH Resend 1/2] usb: gadget: s3c2410_udc: Fix build error

2014-02-17 Thread Sachin Kamat
On 3 February 2014 13:59, Sachin Kamat sachin.ka...@linaro.org wrote: Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. Fixes the following compilation error introduced by commit e117e742d310 (usb: gadget: add maxpacket_limit field to struct usb_ep): drivers/usb

[PATCH Resend 1/2] usb: gadget: s3c2410_udc: Fix build error

2014-02-03 Thread Sachin Kamat
/s3c2410_udc.c:1632:3: error: cannot take address of bit-field ‘maxpacket’ usb_ep_set_maxpacket_limit(ep-ep, ep-ep.maxpacket); Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Reviewed-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 file changed, 1

[PATCH Resend 2/2] usb: gadget: s3c-hsudc: Remove unused label

2014-02-03 Thread Sachin Kamat
Fixes the following compilation warning: drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’: drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’ defined but not used [-Wunused-label] Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/s3c

Re: [PATCH 1/2] usb: gadget: s3c2410_udc: Fix build error

2014-01-12 Thread Sachin Kamat
On 3 January 2014 10:58, Sachin Kamat sachin.ka...@linaro.org wrote: Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. Fixes the following compilation error introduced by commit e117e742d310 (usb: gadget: add maxpacket_limit field to struct usb_ep): drivers/usb/gadget

[PATCH 2/2] usb: gadget: s3c-hsudc: Remove unused label

2014-01-02 Thread Sachin Kamat
Fixes the following compilation warning: drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’: drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’ defined but not used [-Wunused-label] Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/s3c

[PATCH 1/2] usb: gadget: s3c2410_udc: Fix build error

2014-01-02 Thread Sachin Kamat
/s3c2410_udc.c:1632:3: error: cannot take address of bit-field ‘maxpacket’ usb_ep_set_maxpacket_limit(ep-ep, ep-ep.maxpacket); Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/s3c2410_udc.c |2 +- 1 file changed, 1 insertion

[PATCH] usb: ehci: Cleanup usb-ehci-orion.h header

2013-12-29 Thread Sachin Kamat
Commit c02cecb92ed4 (ARM: orion: move platform_data definitions) moved the file to the current location but forgot to remove the pointer to its previous location. Clean it up. While at it also change the header file protection macros appropriately. Signed-off-by: Sachin Kamat sachin.ka

[PATCH 3/3] usb: phy-twl6030: Add missing braces

2013-12-21 Thread Sachin Kamat
Silences the below warning: WARNING: sizeof *twl should be sizeof(*twl) Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-twl6030-usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy

[PATCH 1/3] usb: phy-keystone: Remove redundant of_match_ptr helper

2013-12-21 Thread Sachin Kamat
'keystone_usbphy_ids' is always compiled in. Hence the helper macro is not needed. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: WingMan Kwok w-kw...@ti.com --- drivers/usb/phy/phy-keystone.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy

[PATCH 2/3] usb: phy-fsm: Staticize local symbols

2013-12-21 Thread Sachin Kamat
Local symbols appearing only in this file are made static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-fsm-usb.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/phy/phy-fsm-usb.c b/drivers/usb/phy/phy-fsm-usb.c index

Re: [PATCH 1/5] usb: gadget: s3c-hsotg: Include linux/of.h header

2013-10-23 Thread Sachin Kamat
On 22 October 2013 11:44, Greg KH gre...@linuxfoundation.org wrote: On Mon, Oct 21, 2013 at 07:23:11AM -0500, Felipe Balbi wrote: Hi, On Sat, Oct 19, 2013 at 02:17:52PM -0700, Greg KH wrote: On Thu, Oct 17, 2013 at 01:55:02PM +0530, Sachin Kamat wrote: 'of_match_ptr' is defined in linux

[PATCH 2/5] usb: ohci-at91: Include linux/of.h header

2013-10-17 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/ohci-at91.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci

[PATCH 1/5] usb: gadget: s3c-hsotg: Include linux/of.h header

2013-10-17 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/s3c-hsotg.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget

[PATCH 4/5] usb: misc: usb3503: Include linux/of.h header

2013-10-17 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/misc/usb3503.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c

[PATCH 5/5] usb: phy: twl6030-usb: Include linux/of.h header

2013-10-17 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-twl6030-usb.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb

[PATCH 3/5] usb: ohci-pxa27x: Include linux/of.h header

2013-10-17 Thread Sachin Kamat
'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid build breakage in the future. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/ohci-pxa27x.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host

Re: [PATCH 3/5] USB: ehci-exynos: Remove non-DT support

2013-10-10 Thread Sachin Kamat
Hi Jingoo, On 10 October 2013 12:01, Jingoo Han jg1@samsung.com wrote: The non-DT for EXYNOS SoCs is not supported from v3.11. Thus, there is no need to support non-DT for Exynos EHCI driver. The 'include/linux/platform_data/usb-ehci-exynos.h' file has been used for non-DT support. Thus,

Re: [PATCH 1/5] usb: musb_am335x: Remove redundant of_match_ptr

2013-10-02 Thread Sachin Kamat
Hi Felipe, On 30 September 2013 09:44, Sachin Kamat sachin.ka...@linaro.org wrote: The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/musb/musb_am335x.c |2 +- 1 file

[PATCH 1/5] usb: musb_am335x: Remove redundant of_match_ptr

2013-09-29 Thread Sachin Kamat
The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/musb/musb_am335x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_am335x.c b

[PATCH 2/5] usb: musb_dsps: Remove redundant of_match_ptr

2013-09-29 Thread Sachin Kamat
The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Ravi B ravib...@ti.com --- drivers/usb/musb/musb_dsps.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH 3/5] usb: phy: am335x-control: Remove redundant of_match_ptr

2013-09-29 Thread Sachin Kamat
The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-am335x-control.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-am335x

[PATCH 5/5] usb: phy: tegra-usb: Remove redundant of_match_ptr

2013-09-29 Thread Sachin Kamat
The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Stephen Warren swar...@wwwdotorg.org Cc: linux-te...@vger.kernel.org --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 file changed, 1

[PATCH 4/5] usb: phy: am335x: Remove redundant of_match_ptr

2013-09-29 Thread Sachin Kamat
The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-am335x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-am335x.c b/drivers

[PATCH 1/1] USB: EHCI: tegra: Remove incorrect clk_put

2013-09-27 Thread Sachin Kamat
tegra-clk is obtained using devm_clk_get(). Hence clk_put should not be used. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Stephen Warren swar...@nvidia.com --- drivers/usb/host/ehci-tegra.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/host

[PATCH 1/1] usb: gadget: Remove redundant pci_set_drvdata

2013-09-20 Thread Sachin Kamat
Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/amd5536udc.c |2 -- drivers/usb/gadget/goku_udc.c |1 - drivers/usb/gadget/net2280.c|1 - drivers/usb/gadget/pch_udc.c|1 - 4 files

[PATCH 1/1] usb: dwc3: Remove redundant pci_set_drvdata

2013-09-20 Thread Sachin Kamat
Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/dwc3/dwc3-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 997ebe4..f41ce36 100644

[PATCH 2/2] usb: gadget: f_eem: Staticize eem_alloc

2013-09-16 Thread Sachin Kamat
'eem_alloc' is local to this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/f_eem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_eem.c b/drivers/usb/gadget/f_eem.c index d00392d..d61c11d 100644

[PATCH 1/2] usb: gadget: f_ecm: Staticize ecm_alloc

2013-09-16 Thread Sachin Kamat
'ecm_alloc' is local to this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/f_ecm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/f_ecm.c b/drivers/usb/gadget/f_ecm.c index edab45d..8d9e6f7 100644

[PATCH 1/1] usb: xhci: Staticize xhci_del_comp_mod_timer

2013-09-16 Thread Sachin Kamat
'xhci_del_comp_mod_timer' is local to this file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/xhci-hub.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index fae697e..2b61700 100644

[PATCH 1/1] usb: host: fsl-mph-dr-of: Staticize local symbols

2013-09-16 Thread Sachin Kamat
Local symbols used in this file are made static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Anatolij Gustschin ag...@denx.de --- drivers/usb/host/fsl-mph-dr-of.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers

[PATCH 1/1] usb: dwc3: Remove duplicate inclusion of otg.h

2013-08-22 Thread Sachin Kamat
otg.h header file was included twice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/dwc3/core.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 577af1b..474162e 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers

[PATCH 1/1] usb: samsung: Update Exynos ehci/ohci bindings documentation

2013-08-01 Thread Sachin Kamat
Updated the document as per the latest implementation. While at it also fixed some trivial typos. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- .../devicetree/bindings/usb/exynos-usb.txt | 38 +++- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git

[PATCH 1/1] usb: phy: samsung: Update usbphy documentation

2013-08-01 Thread Sachin Kamat
Updated the documentation as per the latest driver implementation. While at it also fixed some trivial typos. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- .../devicetree/bindings/usb/samsung-usbphy.txt | 48 ++-- 1 file changed, 23 insertions(+), 25 deletions

[PATCH 1/1] usb: phy: samsung: Fix an error message typo

2013-07-15 Thread Sachin Kamat
The error message is common to both clk_get functions. Update it accordingly. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-samsung-usb2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-samsung-usb2.c b/drivers/usb/phy

Re: [PATCH V2 05/10] USB: OHCI: Properly handle ohci-exynos suspend

2013-06-18 Thread Sachin Kamat
On 18 June 2013 15:24, Manjunath Goudar manjunath.gou...@linaro.org wrote: On 14 June 2013 01:22, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 13 Jun 2013, Tomasz Figa wrote: + rc = ohci_suspend(hcd, do_wakeup); + if (rc == 0 do_wakeup HCD_WAKEUP_PENDING(hcd)) { +

Re: [PATCH 1/1] usb: host: ehci-spear: Fix potential NULL pointer dereferencing

2013-05-22 Thread Sachin Kamat
On 22 May 2013 19:50, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 22 May 2013, Sachin Kamat wrote: 'hcd' is dereferenced before NULL check. Move the assignment after the check to avoid potential NULL pointer dereferencing error. Since the pointer in question can never be NULL, you

[PATCH 1/1] usb: host: ehci-spear: Remove redundant checks

2013-05-22 Thread Sachin Kamat
'hcd' can never be NULL and the spear_ehci_hcd_drv_remove routine will never be called in_interrupt. Hence remove these checks. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Alan Stern st...@rowland.harvard.edu --- Compile tested on linux-next

[PATCH 1/8] usb: host: ehci-omap: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
'omap_ehci_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Series compile tested against linux-next tree (20130521). --- drivers/usb/host/ehci-omap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/8] usb: host: ehci-platform: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
'vt8500_ehci_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/ehci-platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host

[PATCH 3/8] usb: host: ehci-spear: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
'spear_ehci_id_table' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Viresh Kumar viresh.ku...@linaro.org --- drivers/usb/host/ehci-spear.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH 4/8] usb: host: ehci-orion: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
'ehci_orion_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Tzachi Perelstein tza...@marvell.com --- drivers/usb/host/ehci-orion.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH 5/8] usb: host: ohci-omap3: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
'omap_ohci_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/ohci-omap3.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-omap3.c b/drivers/usb/host/ohci

[PATCH 6/8] usb: host: ohci-spear: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
'spear_ohci_id_table' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Viresh Kumar viresh.ku...@linaro.org --- drivers/usb/host/ohci-spear.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH 7/8] usb: host: uhci-platform: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
'platform_uhci_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Tony Prisk li...@prisktech.co.nz --- drivers/usb/host/uhci-platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH 8/8] usb: phy: phy-nop: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
'nop_xceiv_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-nop.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/phy-nop.c b/drivers/usb/phy/phy-nop.c index

Re: [PATCH 1/8] usb: host: ehci-omap: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
On 21 May 2013 20:26, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 21 May 2013, Sergei Shtylyov wrote: Hello. On 21-05-2013 16:05, Ben Dooks wrote: 'omap_ehci_dt_ids' is always compiled in. Hence use of of_match_ptr is unnecessary. Thought it was defined as tristate in the

Re: [PATCH 1/8] usb: host: ehci-omap: Remove redundant use of of_match_ptr

2013-05-21 Thread Sachin Kamat
On 21 May 2013 22:10, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 21 May 2013, Sachin Kamat wrote: On 21 May 2013 20:26, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 21 May 2013, Sergei Shtylyov wrote: Hello. On 21-05-2013 16:05, Ben Dooks wrote: 'omap_ehci_dt_ids

[PATCH 1/2] usb: host: fusbh200-hcd: Remove redundant platform_set_drvdata()

2013-05-20 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Yuan-Hsin Chen yhc...@faraday-tech.com --- drivers/usb/host/fusbh200-hcd.c |1 - 1 file changed, 1

[PATCH 2/2] usb: host: fusbh200-hcd: Staticize local symbols

2013-05-20 Thread Sachin Kamat
Local symbols referenced only in this file are made static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/fusbh200-hcd.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/fusbh200-hcd.c b/drivers/usb/host/fusbh200-hcd.c index

Re: [PATCH 2/2] usb: host: fusbh200-hcd: Staticize local symbols

2013-05-20 Thread Sachin Kamat
Hi, On 20 May 2013 12:13, Yuan-Hsin Chen yuan...@gmail.com wrote: Hi, On Mon, May 20, 2013 at 1:51 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Local symbols referenced only in this file are made static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Thank you. I believe you

[PATCH 01/12] usb: chipidea: ci13xxx_imx: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Marek Vasut ma...@denx.de Cc: Alexander Shishkin alexander.shish...@linux.intel.com --- drivers/usb/chipidea

[PATCH 02/12] usb: gadget: mv_u3d_core: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Yu Xu y...@marvell.com --- drivers/usb/gadget/mv_u3d_core.c |3 --- 1 file changed, 3 deletions(-) diff

[PATCH 03/12] usb: gadget: pxa27x_udc: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Eric Miao eric.y.m...@gmail.com --- drivers/usb/gadget/pxa27x_udc.c |1 - 1 file changed, 1 deletion

[PATCH 04/12] usb: host: ehci-tilegx: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Alan Stern st...@rowland.harvard.edu --- drivers/usb/host/ehci-tilegx.c |1 - 1 file changed, 1 deletion

[PATCH 05/12] usb: host: ohci-da8xx: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/ohci-da8xx.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ohci

[PATCH 06/12] usb: host: ohci-nxp: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Dmitry Chigirev sou...@mvista.com --- drivers/usb/host/ohci-nxp.c |2 -- 1 file changed, 2 deletions

[PATCH 07/12] usb: host: ohci-octeon: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/host/ohci-octeon.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/ohci

[PATCH 08/12] usb: host: ohci-omap: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Tony Lindgren t...@atomide.com --- drivers/usb/host/ohci-omap.c |1 - 1 file changed, 1 deletion(-) diff

[PATCH 12/12] usb: host: uhci-platform: Remove redundant platform_set_drvdata()

2013-05-17 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Tony Prisk li...@prisktech.co.nz --- drivers/usb/host/uhci-platform.c |1 - 1 file changed, 1 deletion

[PATCH Resend 2/2] net/usb: r8152: Use module_usb_driver()

2013-05-16 Thread Sachin Kamat
module_usb_driver() eliminates boilerplate and simplifies the code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Realtek linux nic maintainers nic_s...@realtek.com --- drivers/net/usb/r8152.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers

[PATCH Resend 1/2] net/usb: r8152: Remove redundant version.h header inclusion

2013-05-16 Thread Sachin Kamat
version.h header inclusion is not necessary as detected by checkversion.pl. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- This series compile tested on linux-next (20130516). --- drivers/net/usb/r8152.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b

[PATCH 1/1] USB: quatech2: Staticize local symbol

2013-05-12 Thread Sachin Kamat
'qt2_process_read_urb' is referenced only in this file. Make it static. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/serial/quatech2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c index

[PATCH 1/7] usb: gadget: atmel_usba_udc: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/gadget/atmel_usba_udc.c |2 -- 1 file changed, 2

[PATCH 2/7] usb: gadget: bcm63xx_udc: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Kevin Cernekee cerne...@gmail.com --- drivers/usb/gadget/bcm63xx_udc.c |1 - 1 file changed, 1 deletion

[PATCH 3/7] usb: gadget: dummy_hcd: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Alan Stern st...@rowland.harvard.edu --- drivers/usb/gadget/dummy_hcd.c |1 - 1 file changed, 1 deletion

[PATCH 4/7] usb: gadget: f_uac2: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Jaswinder Singh jaswinder.si...@linaro.org --- drivers/usb/gadget/f_uac2.c |2 -- 1 file changed, 2

[PATCH 5/7] usb: gadget: imx_udc: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Darius Augulis augulis.dar...@gmail.com --- drivers/usb/gadget/imx_udc.c |2 -- 1 file changed, 2

[PATCH 6/7] usb: gadget: pxa25x_udc: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Eric Miao eric.y.m...@gmail.com --- drivers/usb/gadget/pxa25x_udc.c |1 - 1 file changed, 1 deletion

[PATCH 7/7] usb: gadget: s3c2410_udc: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/s3c2410_udc.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/gadget

[PATCH 1/5] usb: phy: ab8500-usb: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-ab8500-usb.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/phy/phy

[PATCH 2/5] usb: phy: gpio-vbus-usb: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Philipp Zabel philipp.za...@gmail.com --- drivers/usb/phy/phy-gpio-vbus-usb.c |2 -- 1 file changed, 2

[PATCH 3/5] usb: phy: mv-usb: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Chao Xie chao@marvell.com --- drivers/usb/phy/phy-mv-usb.c |3 --- 1 file changed, 3 deletions

[PATCH 4/5] usb: phy: mxs-usb: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Marek Vasut ma...@denx.de --- drivers/usb/phy/phy-mxs-usb.c |2 -- 1 file changed, 2 deletions(-) diff

[PATCH 5/5] usb: phy: nop: Remove redundant platform_set_drvdata()

2013-05-06 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/phy/phy-nop.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/phy/phy-nop.c b

[PATCH 1/1] usb: phy: samsung: Convert to devm_ioremap_resource()

2013-03-26 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 1/3] usb: phy: samsung: Convert to devm_ioremap_resource()

2013-03-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 2/3] usb: phy: omap-usb3: Convert to devm_ioremap_resource()

2013-03-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 3/3] usb: phy: omap-control-usb: Convert to devm_ioremap_resource()

2013-03-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 1/1] usb: gadget: fsl_udc_core: Use module_platform_driver_probe macro

2013-03-04 Thread Sachin Kamat
module_platform_driver_probe() eliminates the boilerplate and simplifies the code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Li Yang le...@freescale.com --- drivers/usb/gadget/fsl_udc_core.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git

[PATCH 1/1] usb: gadget: s3c-hsotg: Use devm_regulator_bulk_get API

2013-01-08 Thread Sachin Kamat
devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/gadget/s3c-hsotg.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget

[PATCH 1/1] usb: dwc3: Use devm_kzalloc

2012-12-12 Thread Sachin Kamat
devm_kzalloc is device managed and makes error handling and cleanup simpler. While at it also fixed the return value when platform_device_alloc failed in probe function. Cc: Anton Tikhomirov av.tikhomi...@samsung.com Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- Compile tested on linux

Re: [PATCH 1/1] usb: dwc3: Use devm_kzalloc

2012-12-12 Thread Sachin Kamat
On 12 December 2012 16:51, Felipe Balbi ba...@ti.com wrote: On Wed, Dec 12, 2012 at 04:13:15PM +0530, Sachin Kamat wrote: devm_kzalloc is device managed and makes error handling and cleanup simpler. While at it also fixed the return value when platform_device_alloc failed in probe function

Re: [PATCH 1/1] usb: musb: Remove duplicate inclusion of linux/of.h

2012-11-26 Thread Sachin Kamat
ping On 19 November 2012 17:03, Sachin Kamat sachin.ka...@linaro.org wrote: linux/of.h was included twice. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/usb/musb/musb_dsps.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb

  1   2   >