it for CaveCreek.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
I will take this patch, but will add the note that is on my long-term
to-do list to fix this issue.
Sarah Sharp
Signed-off-by: George Cherian george.cher...@ti.com
---
drivers/usb/host/xhci-plat.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c
in question, but there are separate
EHCI controllers on an add-on PCI card?
They wouldn't be Intel EHCI controllers. We don't make discrete host
controllers. If that changes, we can revisit this, but I don't think
it's an issue.
Sarah Sharp
--
To unsubscribe from this list: send the line
george.cher...@ti.com
very nice catch.
Acked-by: Felipe Balbi ba...@ti.com
You need to resend with:
Cc: sta...@vger.kernel.org # v3.4+
Not sure if Sarah wants to take care of the stable tagging, though.
I'll take care of the stable tagging.
Sarah Sharp
--
To unsubscribe from this list
interface setting changes, which means the toggles get reset.
I would look to see if there is a reset endpoint control transfer in the
EHCI and xHCI usbmon traces.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
-dma_mask pointer, and then call
dma_set_mask and dma_set_coherent_mask?
xhci_dbg(xhci, Calling HCD init\n);
--
1.8.3.1
Sarah Sharp
p.s.
+ if (HCC_64BIT_ADDR(temp)
+ !dma_set_mask(dev, DMA_BIT_MASK(64))) {
Although Greg prefers aligning trailing lines
From: Emil Goode emilgo...@gmail.com
This patch adds missing unlocks on error paths in the
xhci_free_streams and xhci_configure_endpoint functions.
Signed-off-by: Emil Goode emilgo...@gmail.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci.c |2 ++
1
deadlock in one of the
patches you recently added to usb-next. Emil discovered the issue, and
send a patch to fix it. Please pull this patch into usb-next.
Sarah Sharp
Emil Goode (1):
xhci: Add missing unlocks on error paths
.
Sarah Sharp
---
drivers/usb/host/xhci.c | 52
+
1 file changed, 18 insertions(+), 34 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index d8f640b..aa117d1 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb
on? That will
tell me which ports are being switched over.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
just
doesn't expect global suspend. I will ask the hardware engineers I know
about it though.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 14, 2013 at 02:23:36PM -0700, Greg KH wrote:
On Fri, Jun 14, 2013 at 02:16:50PM -0700, Sarah Sharp wrote:
The main thing I'm concerned about is that the patch doesn't handle
Intel xHCI host controller PCI hot-plug. We don't really expect any of
the Intel PCI hosts to be hot
and comment if this is the right approach.
Sarah Sharp
The following changes since commit 976f8bef9cfb5246bc0e8dc781562daa79cb7aaf:
Merge tag 'usb-for-v3.11' of
git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next
(2013-06-12 14:44:13 -0700)
are available in the git
From: Mathias Nyman mathias.ny...@linux.intel.com
If the endpoint type is unknown, set it to 0 and fail gracefully
instead of causing a kernel panic.
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci
and
get rid of one switch statement with BUG() option completely.
[Note: Sarah merged a patch that she wrote that touched the
xhci_setup_addressable_virt_dev function with this patch from Mathias
for clarity.]
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp
It's horrible coding style to panic the kernel when someone passes you
an argument value you didn't expect. In the future, we may want to add
additional context types, so it's better to gracefully handle additional
context types instead of panicking.
Signed-off-by: Sarah Sharp sarah.a.sh
Fail gracefully, instead of causing the kernel to panic, if the input
control context doesn't have the right type (XHCI_CTX_TYPE_INPUT). Push
finding the pointer to the input control context up into functions that
can fail.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: John Youn
:
Support for 64-byte contexts.
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: John Youn johny...@synopsys.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-mem.c |4
1 files changed, 4 insertions(+), 0 deletions
This patchset breaks out the one real bug fix patch from the Klockwork
security issues patchset. It should be applied to usb-linus and
queued for stable, as it handles a real potential NULL pointer
deference.
Sarah Sharp
The following changes since commit
On Mon, Jun 17, 2013 at 10:40:24AM -0700, Greg Kroah-Hartman wrote:
On Mon, Jun 17, 2013 at 09:55:17AM -0700, Sarah Sharp wrote:
This is a revised version of the patchset that was originally sent to
fix security issues identified by the Klockwork static analysis tool.
As discussed
for 3.11.
Sarah Sharp
Mathias Nyman (2):
xhci: Remove BUG in xhci_setup_addressable_virt_dev
xhci: remove BUG() in xhci_get_endpoint_type()
Sarah Sharp (2):
xhci: Remove BUG_ON() in xhci_alloc_container_ctx
On Mon, Jun 17, 2013 at 10:41:56AM -0700, Greg Kroah-Hartman wrote:
On Mon, Jun 17, 2013 at 09:56:30AM -0700, Sarah Sharp wrote:
This patchset breaks out the one real bug fix patch from the Klockwork
security issues patchset. It should be applied to usb-linus and
queued for stable
checked
So you're saying that I should fix them, is that right?
In that case, no, you should be figuring out how to refactor and reuse
the EHCI code instead of copying it straight into your driver.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
On Mon, Jun 17, 2013 at 11:06:15AM -0400, Alan Stern wrote:
On Mon, 17 Jun 2013, Sarah Sharp wrote:
We should be able to handle hotplug if at all possible. I know the
quirk handling issues around PCI hotplug aren't all worked out (or at
least they were not a year or so ago), so maybe
On Wed, Jun 12, 2013 at 03:32:14PM -0700, Greg KH wrote:
Thanks for the explaination, if you are ok with this, I have no
objections. Feel free to queue it up in your next round of patches if
you want to.
So you're fine with the global variable as well?
Sarah Sharp
--
To unsubscribe from
think this approach is better, but I want Alan's opinion on it. Alan?
Sarah Sharp
Mathias Nyman (1):
Intel xhci: refactor EHCI/xHCI port switching
drivers/usb/host/ehci-pci.c | 15 +--
drivers/usb/host/pci-quirks.c | 55 ++--
drivers
assumed that xHCI
device is not removed,
so there's a possibility this pointer can go stale.
Also we can only handle one Intel xHCI host in the system.
All of this should be in the 1/1 patch description as well.
Ok, Mathias will update the description.
Sarah Sharp
--
To unsubscribe from
On Fri, Jun 07, 2013 at 11:37:53PM +0300, Felipe Balbi wrote:
Hi,
On Fri, Jun 07, 2013 at 10:19:23AM -0700, Sarah Sharp wrote:
Adding Felipe.
Xenia, Felipe is the USB gadget maintainer, and also added code for
non-PCI xHCI hosts. Felipe, Xenia is my summer intern through the FOSS
to compress it.
Sarah Sharp
i get oops on this line:
426 static void ring_doorbell_for_active_rings(struct xhci_hcd *xhci,
427 unsigned int slot_id,
428 unsigned int ep_index)
429 {
430 unsigned int stream_id;
431 struct xhci_virt_ep
agree?
It's funny that the code worked before. Perhaps setting the dma_mask
pointer should be a separate patch for stable?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
more
commonly used concepts in USB.
Signed-off-by: Julius Werner jwer...@chromium.org
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-dbg.c |5 -
drivers/usb/host/xhci.c | 10 ++
drivers/usb/host/xhci.h |1 +
3 files changed, 15
From: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-hub.c | 16 +++-
drivers/usb/host/xhci.c |4 ++--
drivers/usb/host/xhci.h
-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-mem.c | 33 +
drivers/usb/host/xhci.c | 27 ++-
drivers/usb/host/xhci.h |3 +++
3 files changed
mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
Documentation/ABI/testing/sysfs-bus-usb | 27 +++
drivers/usb/core/sysfs.c| 54 +++
drivers/usb/host/xhci.c |6 ++-
include/linux
From: Alex Shi alex@intel.com
According to Felipe and Alan's comments the second parameter of irq
handler should be 'void *' not a specific structure pointer.
So change it.
Signed-off-by: Alex Shi alex@intel.com
Acked-by: Felipe Balbi ba...@ti.com
Signed-off-by: Sarah Sharp sarah.a.sh
...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-ext-caps.h |1 +
drivers/usb/host/xhci.c | 204 ++
drivers/usb/host/xhci.h | 21
include/linux/usb.h |2 +
4 files
pretty simple to set dma_coherent_mask and then apply its
address to the dma_mask, because you set the same values anyway.
I'm not quite understanding what you want to do. (I'll blame lack of
sleep, sorry.) Can you write some pseudo code for me?
Sarah Sharp
--
To unsubscribe from this list: send
it by
changing it to an uninterruptible sleep.
The chromium team ran into a similar issue, and we're having a
conversation about the right way to fix it:
http://marc.info/?l=linux-kernelm=136944610123147w=2
We'll try to Cc you on that conversation as it moves forward.
Sarah Sharp
--
To unsubscribe
Ping. Greg, do you want to take this bug fix?
Sarah
On Thu, May 16, 2013 at 02:04:42PM -0700, Sarah Sharp wrote:
The upper bits of the USB 2.0 extended capability BOS descriptor weren't
being shifted into the right byte position. That didn't matter much
before now, but some USB 2.1 devices
by adding a newline after the comma and resubmit?
Thanks,
Sarah Sharp
On Sun, May 26, 2013 at 01:08:14PM +0300, Xenia Ragiadakou wrote:
This patch adds a check on whether the host machine
supports the xHC DMA address mask and sets the DMA
mask for coherent DMA address allocation via
Alan, Greg, any more comments on this patchset?
It looks fine to me, and we've been testing it internally within Intel,
so I'll queue it up for 3.11 if you don't have any more objections.
Sarah Sharp
On Thu, May 23, 2013 at 05:14:27PM +0300, Mathias Nyman wrote:
This series adds usb2 best
On Thu, May 30, 2013 at 07:04:03AM +0900, Greg Kroah-Hartman wrote:
On Wed, May 29, 2013 at 10:45:04AM -0700, Sarah Sharp wrote:
On Wed, May 29, 2013 at 10:27:50AM +0900, Greg Kroah-Hartman wrote:
On Fri, May 24, 2013 at 05:42:52PM -0700, Sarah Sharp wrote:
This patchset address some
On Thu, May 30, 2013 at 06:16:34AM +0200, Alexander Holler wrote:
Am 30.05.2013 00:25, schrieb Sarah Sharp:
On Wed, May 29, 2013 at 11:14:32PM +0200, Alexander Holler wrote:
Current Renesas Electronics XHCI hosts (which were formerly NEC)
do support the same vendor command to show
On Wed, May 29, 2013 at 10:27:50AM +0900, Greg Kroah-Hartman wrote:
On Fri, May 24, 2013 at 05:42:52PM -0700, Sarah Sharp wrote:
This patchset address some (but not all) of the security issues found
with the Klockwork static analysis tool. I have not reviewed these in
detail to see
On Wed, May 29, 2013 at 10:33:26AM +0900, Greg Kroah-Hartman wrote:
On Fri, May 24, 2013 at 05:43:01PM -0700, Sarah Sharp wrote:
From: Mathias Nyman mathias.ny...@linux.intel.com
If the endpoint type is unknown, set it to 0 and fail gracefully
instead of causing a kernel panic.
How
you haven't shared the
details of how the code handles being interrupted, I can't tell whether
this is actually a good solution.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
as appropriate).
Alan, what happens if we set USB_QUIRK_RESET_RESUME on the roothub?
I don't think that currently translates into the host controller's Reset
register getting written, which is what I think Julius is proposing.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe
On Tue, May 28, 2013 at 10:53:56AM +0300, Heikki Krogerus wrote:
Hi Sarah,
On Fri, May 24, 2013 at 09:55:25AM -0700, Sarah Sharp wrote:
At this point the port switchover quirk is getting unwieldy. I know of
at least two more platforms that will need the switchover quirk, and
it's silly
needed to use it for years, and if
Renesas changed their vendor command set, I would rather not submit
random commands to the host.
So, can you redo this patch to just rip out XHCI_NEC_HOST and everything
that uses it?
Sarah Sharp
Signed-off-by: Alexander Holler hol...@ahsoftware.de
in sync with the kernel quirks list.
What if we exposed the xHCI quirks through a new quirks file in
/sys/bus/usb/devices/usbN/? That would mean userspace doesn't need to
keep the quirks list separately.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
On Sat, May 25, 2013 at 03:00:28AM +0400, Sergei Shtylyov wrote:
Hello.
On 05/25/2013 01:54 AM, Sarah Sharp wrote:
From: Chew, Chiau Ee chiau.ee.c...@intel.com
Like the xHCI controller on Intel Panther Point and Lynx Point
chipsets, the xHCI controller on Intel BayTrail has also ports
the switchover.
Sarah Sharp
On Tue, May 21, 2013 at 09:08:16AM +0300, Heikki Krogerus wrote:
From: Chew, Chiau Ee chiau.ee.c...@intel.com
Like the xHCI controller on Intel Panther Point and Lynx Point
chipsets, the xHCI controller on Intel BayTrail has also ports that
can be switched between the EHCI
that
can be switched between the EHCI host controller.
s/between/to/
Sergei, DO NOT REVIEW PATCHES TO THE XHCI DRIVER.
Your grammar comments and complaints about extra parenthesis are not
constructive and cause unnecessary patch churn.
Sarah Sharp
--
To unsubscribe from this list: send
digging around the kernel tree for a driver.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ccing Dan Williams, since Johannes Berg mentioned on IRC that Dan might
know the status of MBIM support.
On Fri, May 24, 2013 at 10:09:15AM -0700, Sarah Sharp wrote:
Do we have support for the new extensions for USB communication devices
that use the Mobile Broadband Interface Model (MBIM) spec
that this change is only relevant when persist_enabled is not set
for USB devices.
Could we at least wrap the call in an ifdef CONFIG_USB_DEFAULT_PERSIST?
That way if people have USB persist turned off in their configuration,
their host will still be able to suspend.
Sarah Sharp
Signed-off-by: Shawn
On Fri, May 24, 2013 at 10:05:01PM +0400, Sergei Shtylyov wrote:
Hello.
On 05/24/2013 08:56 PM, Sarah Sharp wrote:
From: Chew, Chiau Ee chiau.ee.c...@intel.com
Like the xHCI controller on Intel Panther Point and Lynx Point
chipsets, the xHCI controller on Intel BayTrail has also ports
kernel crash on resume from S3 for TI hosts
that have the compliance mode quirk. Tony has confirmed that the patches fix
the issue on the effected systems.
All four patches are marked for stable.
Sarah Sharp
Sarah Sharp (1):
xhci
to kernels as old as 3.2, that contain
the commit 839c817ce67178ca3c7c7ad534c571bba1e69ebe xhci: Store
information about roothubs and TTs.
Reported-by: Sergey Dyasly dse...@gmail.com
Tested-by: Sergey Dyasly dse...@gmail.com
Signed-off-by: Vladimir Murzin murzi...@gmail.com
Signed-off-by: Sarah
-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: Huang Ying ying.hu...@intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-pci.c |8
drivers/usb/host/xhci.c |4 ++--
drivers/usb/host/xhci.h |3 +++
3 files changed, 13 insertions(+), 2 deletions(-)
diff
71c731a296f1b08a3724bd1b514b64f1bda87a23 usb: host:
xhci: Fix Compliance Mode on SN65LVPE502CP Hardware
Signed-off-by: Tony Camuso tcam...@redhat.com
Tested-by: Tony Camuso tcam...@redhat.com
Acked-by: Don Zickus dzic...@redhat.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers
-by: Sergio Aguirre sergio.a.aguirre.rodrig...@intel.com
Acked-by: David Cohen david.a.co...@intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-mem.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
This patchset address some (but not all) of the security issues found
with the Klockwork static analysis tool. I have not reviewed these in
detail to see if these could be used by attackers, so someone with more
security experience may want to look these over.
Sarah Sharp
The following changes
It's horrible coding style to panic the kernel when someone passes you
an argument value you didn't expect.
This patch should be backported to kernels as old as 2.6.31, that
contain the commit d115b04818e57bdbc7ccde4d0660b15e33013dc8 USB: xhci:
Support for 64-byte contexts.
Signed-off-by: Sarah
allocation support
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-mem.c | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host
kernels when CONFIG_USB_SUSPEND
is turned off.
I will have to create separate patches for the older stable kernels.]
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@intel.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: sta...@vger.kernel.org
:
Support for 64-byte contexts.
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: John Youn johny...@synopsys.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-mem.c |4
1 files changed, 4 insertions(+), 0 deletions
3ffbba9511b4148cbe1f6b6238686adaeaca8feb USB: xhci:
Allocate and address USB devices
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-mem.c | 35
, that
contain the commit d115b04818e57bdbc7ccde4d0660b15e33013dc8 USB: xhci:
Support for 64-byte contexts.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: John Youn johny...@synopsys.com
Cc: sta...@vger.kernel.org
---
drivers/usb/host/xhci-dbg.c |5 ++
drivers/usb/host/xhci-mem.c |4
On Thu, May 16, 2013 at 10:11:00AM -0400, Alan Stern wrote:
On Wed, 15 May 2013, Sarah Sharp wrote:
If you're using 64-bit DMA then you almost certainly do want to call
dma_set_coherent_mask(). On the plus side, it is guaranteed that if
dma_set_mask() succeeds with a particular mask
On Wed, May 15, 2013 at 10:37:00AM -0400, Alan Stern wrote:
On Tue, 14 May 2013, Sarah Sharp wrote:
We do allocate memory using DMA pools, and we do want 64-bit context
addresses if the xHCI host controller can handle it.
The xHCI driver calls dma_set_mask, but not dma_set_coherent_mask
On Tue, May 14, 2013 at 03:49:40PM -0400, Tony Camuso wrote:
On 05/09/2013 07:31 PM, Sarah Sharp wrote:
Hi Tony, Don, and Oliver,
Can one of you double check these two patches resolve the resume from S3
issue on effected HP systems with the TI compliance mode quirk?
Oliver has
for that, with your refactoring on top of that. We
need to backport the bug fix to the stable kernels, and queue the
refactoring for 3.11.
Sarah Sharp
This patch moves the XHCI version check into a single, unified (and
slightly simplified) xhci_td_remainder() function, which deduplicates
code
?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
with these emails.
Nope, I want you to ask questions, so don't worry about that.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, then bail out.
Since the DMA setup code is copy-pasted twice in xhci_gen_setup(),
perhaps you want to refactor the DMA setup into its own function as a
separate patch on top of your bug fix?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
Thanks Alan, I will add this to my for-usb-linus queue.
Sarah
On Wed, May 08, 2013 at 11:18:05AM -0400, Alan Stern wrote:
This patch shortens the logic in xhci_endpoint_init() by moving common
calculations involving max_packet and max_burst outside the switch
statement, rather than repeating
On Thu, May 09, 2013 at 01:46:51PM -0700, Sarah Sharp wrote:
Thanks Alan, I will add this to my for-usb-linus queue.
One note though: I've been bitten by this code before, by someone who
refactored code and fixed a bug at the same time. The math was wrong,
and I ended up breaking full-speed
these types of bugs slip by me unless someone Ccs the linux-usb mailing
list or me.
Can you reproduce the bug yourself on 3.9, or should I work with Heinz
to have him test a fix?
Sarah Sharp
Date: Fri, 14 Dec 2012 22:54:28 +0100
From: Heinz Diehl h...@fritha.org
To: linux-ker...@vger.kernel.org
Cc
. Ying,
can you double check that the code to disable D3cold looks sane?
If these patches work on the systems, I will send them out next week to
Greg.
Thanks,
Sarah Sharp
The following changes since commit 9affd6becbfb2c3f0d04e554bb87234761b37aba:
arm: fix mismerge of arch/arm/mach-omap2
. I have a larger plan to fix some isochronous
ring performance issues, and I'd like to implement this change along
with that.
Can you wait for that change to go in? AFAIK no in-kernel drivers don't
set URB_ISO_ASAP, so I didn't think this was an urgent change.
Sarah Sharp
--
To unsubscribe from
On Mon, Apr 29, 2013 at 01:02:19PM +0200, Oliver Neukum wrote:
On Thursday 10 January 2013 10:42:07 Sarah Sharp wrote:
The new debugging shows that the host is giving *two* short status
completions for a TD. This only happens when the isoc TD is split into
two TRBs because the buffer
the debug code. It does not effect any other part of
the xHCI driver.
Please disregard the HW died, polling stopped messages in dmesg.
Sarah Sharp
On Wed, May 01, 2013 at 01:07:48AM +0200, Martin Mokrejs wrote:
Hi,
I just tried 3.9 kernel with pcie_aspm=off and in another attempt
Ccing Dave Jiang.
Dave, can you please take a look at this resume from suspend failure?
Tony bisected it to one of your patches.
On Thu, Apr 25, 2013 at 11:43:00PM -0400, Tony Camuso wrote:
On 04/23/2013 05:14 PM, Sarah Sharp wrote:
On Tue, Apr 23, 2013 at 04:18:00PM -0400, Tony Camuso wrote
On Mon, Apr 22, 2013 at 02:38:57PM -0400, Tony Camuso wrote:
On 04/18/2013 05:12 PM, Sarah Sharp wrote:
On Thu, Apr 18, 2013 at 02:45:40PM -0400, Tony Camuso wrote:
Sarah,
This patch works with RHEL6.4+ kernel, but hangs with 3.9-rc7.
I can attach the S3_Suspend_message.log, if you like
On Tue, Apr 23, 2013 at 04:18:00PM -0400, Tony Camuso wrote:
On 04/18/2013 05:12 PM, Sarah Sharp wrote:
On Thu, Apr 18, 2013 at 02:45:40PM -0400, Tony Camuso wrote:
Sarah,
This patch works with RHEL6.4+ kernel, but hangs with 3.9-rc7.
= snip =
Is it hanging on suspend or on resume
On Thu, Apr 18, 2013 at 02:45:40PM -0400, Tony Camuso wrote:
On 04/17/2013 08:27 PM, Sarah Sharp wrote:
[Sarah reworked this patch to cover the case where the xHCI restore
register operation fails, and (temp STS_SRE) is true (and we re-init
the host, including re-init for the compliance
that userspace
can't re-enable it?
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, and (temp STS_SRE) is true (and we re-init
the host, including re-init for the compliance mode), but hibernate is
false. The original patch would have caused list corruption in this
case.]
Signed-off-by: Tony Camuso tcam...@redhat.com
Acked-by: Don Zickus dzic...@redhat.com
Signed-off-by: Sarah Sharp
understanding?
As for the other warnings, I think the PCI maintainer (Bjorn) is going
to have to address those, as I'm not a PCI expert.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info
instead of Endpoint 0x80 OUT Context? There are input
contexts and output contexts in xHCI, and I want to imply the endpoint
is either IN or OUT, not the context.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
=b3a559901d23b9c391699c23f0d37f205baedb88
It probably won't make it into Linus' tree until a couple weeks from
now when 3.10-rc2 comes out, since the merge window is coming up and
everyone's trees are frozen.
Sarah Sharp
On Tue, Apr 09, 2013 at 10:33:31PM +0400, Vladimir Murzin wrote:
If for whatever reason we fall into fail path
the EHCI interfaces.
Sarah Sharp
On Tue, Apr 09, 2013 at 09:38:17AM +0530, Puneet Sharma wrote:
Hello Sarah,
Thanks a lot for the information. For your information i am successfully
able to enumerate USB device(USB keyboard) over XHCI port by the help of
XHCI Stack patch provided in u-boot and also
the USB formatted endpoint numbers. Having macros for later use
would be helpful.
Also, this patch is too late for the 3.10 merge window, so it will
have to wait for 3.11.
Sarah Sharp
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord
Applied, thanks!
On Fri, Apr 05, 2013 at 02:27:07PM -0400, Tony Camuso wrote:
There are no functional changes in this patch. However, because the
compliance mode timer can be deleted in more than one function, it
seemed expedient to include the function name in the debug strings.
Also
On Fri, Apr 05, 2013 at 08:01:03PM +0300, Petko Manolov wrote:
On Wed, 27 Mar 2013, Petko Manolov wrote:
On Tue, 26 Mar 2013, Sarah Sharp wrote:
The new driver actually compiles and runs fine with Pegasus-II based
device. Please let me know if you run into problems.
I'm away for a week, so I
On Mon, Apr 08, 2013 at 06:29:36AM -0700, Greg KH wrote:
On Mon, Apr 08, 2013 at 08:58:09PM +0800, Lan Tianyu wrote:
On 2013/3/30 4:24, Alan Stern wrote:
On Fri, 29 Mar 2013, Sarah Sharp wrote:
Also, bear in mind that the proposed patch does not give userspace a
way to power off ports
If the xHCI spec is contradictory, please contact xhcisupp...@intel.com.
Sarah Sharp
On Mon, Apr 01, 2013 at 10:48:35AM +, Ankit wrote:
With respect to latest xHCI spec :
Revision 1.0
with errata to 8/14/12
Page 114:
Note: Consider the case where there are multiple TDs posted
applying to older
kernels.
Signed-off-by: Vivek gautam gautam.vi...@samsung.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: sta...@vger.kernel.org
Either that, or the xHCI host is giving back completely bogus
untransferred lengths.
stk1160: allocating urbs
On Mon, Apr 08, 2013 at 09:01:44AM -0700, Greg KH wrote:
On Mon, Apr 08, 2013 at 08:57:43AM -0700, Sarah Sharp wrote:
On Mon, Apr 08, 2013 at 06:29:36AM -0700, Greg KH wrote:
On Mon, Apr 08, 2013 at 08:58:09PM +0800, Lan Tianyu wrote:
Hi Alan Sarah:
I just recall why I put
701 - 800 of 1281 matches
Mail list logo
