Re: [PATCH 1/2] power: supply: Add fwnode pointer to power_supply_config struct

2018-05-22 Thread Sebastian Reichel
without the need to change calling code which > already provides the fwnode handle in this manner. > > Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> > Suggested-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> > --- Reviewed-by: Sebastian Rei

Re: [PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-26 Thread Sebastian Reichel
Hi, On Thu, Apr 26, 2018 at 09:33:26AM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 25, 2018 at 02:30:45PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Apr 25, 2018 at 01:26:33AM +0200, Sebastian Reichel wrote: > > > Hi Greg, > > > > > > On Tue, Apr 24,

Re: [PATCH v8 0/6] typec: tcpm: Add sink side support for PPS

2018-04-24 Thread Sebastian Reichel
there is at least one pending driver which could directly use the newly introduced usb_type. I can either provide an immutable branch with a signed tag, or you can merged it and provide me an immutable branch. If you merge it via the USB tree patch 2-4 are Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> -- Sebastian signature.asc Description: PGP signature

Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-03-23 Thread Sebastian Reichel
Hi, On Fri, Mar 23, 2018 at 11:54:55AM +0100, Pavel Machek wrote: > Hi! > > > > > Do you have the related dts patches picked from next? > > > > > > > > fdd192037fce ("ARM: dts: omap4-droid4: Fix USB PHY port naming") > > > > e5b9fd7bdeb5 ("ARM: dts: omap4-droid4: Configure MDM6600 USB PHY") > >

Re: [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4

2018-02-17 Thread Sebastian Reichel
ling even with it's > radio turned off, but that's something that is beyond the control of > this USB PHY driver. > > Cc: devicet...@vger.kernel.org > Cc: Mark Rutland <mark.rutl...@arm.com> > Cc: Marcel Partap <mpar...@gmx.net> > Cc: Michael Scott <michael.sc...@linaro

Re: [PATCH v4 5/7] power: supply: Add 'connected_type' property and supporting code

2018-02-09 Thread Sebastian Reichel
Hi, On Fri, Feb 09, 2018 at 11:28:42AM +, Adam Thomson wrote: > On 08 February 2018 21:31, Sebastian Reichel wrote: > > On Tue, Jan 02, 2018 at 03:50:53PM +, Adam Thomson wrote: > > > This commit adds the 'connected_type' property to represent supplies > > >

Re: [PATCH v4 5/7] power: supply: Add 'connected_type' property and supporting code

2018-02-08 Thread Sebastian Reichel
od idea to provide the subtype in its own property and just set the type property to "USB". I would prefer to name this "usb_type". Otherwise Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> -- Sebastian > --- > drivers/power/supply/power_supply_

Re: [PATCH 2/2] usb: chipidea: imx: Fix ULPI on imx53

2018-02-06 Thread Sebastian Reichel
Hi Peter, On Mon, Jan 29, 2018 at 11:33:15AM +0800, Peter Chen wrote: > On Wed, Jan 24, 2018 at 06:14:39PM +0100, Sebastian Reichel wrote: > > Traditionally, PORTSC should be set before initializing ULPI phys. But > > setting PORTSC before powering on the phy results in

[PATCH 1/2] usb: chipidea: imx: Cleanup ci_hdrc_imx_platform_flag

2018-01-24 Thread Sebastian Reichel
Some trivial cleanups, that do not change functionality. Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/ch

[PATCH 2/2] usb: chipidea: imx: Fix ULPI on imx53

2018-01-24 Thread Sebastian Reichel
-by: Fabien Lahoudere <fabien.lahoud...@collabora.co.uk> Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> --- drivers/usb/chipidea/ci_hdrc_imx.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/

Re: [RFC PATCH 5/7] power: supply: Add type for USB PD PPS chargers

2017-11-06 Thread Sebastian Reichel
Hi, On Wed, Nov 01, 2017 at 05:03:13PM +, Adam Thomson wrote: > This adds a type to represent USB PPS chargers as defined in the > USB Power Delivery Specification Revision 3.0 V1.1 > > Signed-off-by: Adam Thomson <adam.thomson.opensou...@diasemi.com> Reviewed-by:

Re: [PATCH] extcon: Split out extcon header file for consumer and provider device

2017-09-29 Thread Sebastian Reichel
device instance > : Register/unregister extcon device > : Set the state of each external connector > : Set the property value of each external connector > : Set the property capability of each external connector > [...] > drivers/power/supply/qcom_smbb.c |

Re: [PATCH v4 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-27 Thread Sebastian Reichel
opensource.wolfsonmicro.com> > --- Looks ok now. Acked-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> -- Sebastian > Documentation/devicetree/bindings/mfd/wm831x.txt |1 + > drivers/power/supply/wm831x_power.c | 72 > ++

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-26 Thread Sebastian Reichel
Hi, On Wed, Jul 26, 2017 at 11:05:25AM +0800, Baolin Wang wrote: > On 25 July 2017 at 17:59, Sebastian Reichel > <sebastian.reic...@collabora.co.uk> wrote: > > On Tue, Jul 25, 2017 at 04:00:01PM +0800, Baolin Wang wrote: > >> Integrate with the newly added USB

Re: [PATCH v3 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-25 Thread Sebastian Reichel
Hi, On Tue, Jul 25, 2017 at 04:00:01PM +0800, Baolin Wang wrote: > Integrate with the newly added USB charger interface to limit the current > we draw from the USB input based on the input device configuration > identified by the USB stack, allowing us to charge more quickly from high > current

Re: [PATCH v2 3/3] power: wm831x_power: Support USB charger current limit management

2017-07-03 Thread Sebastian Reichel
Hi, On Mon, Jul 03, 2017 at 02:07:15PM +0800, Baolin Wang wrote: > Integrate with the newly added USB charger interface to limit the current > we draw from the USB input based on the input device configuration > identified by the USB stack, allowing us to charge more quickly from high > current

Re: [PATCH] phy: cpcap-usb: Fix missing return statement

2017-06-12 Thread Sebastian Reichel
we just want to return early and not attempt to configure the pins. > > Fixes: 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > Reported-by: Colin Ian King <colin.k...@canonical.com> > Signed-off-by: Tony Lindgren <t...@atomide.com> Reviewed-by: Sebas

Re: [PATCH 3/3] usb: host: ohci-omap3: Remove driver in favor of ohci-platform

2017-05-23 Thread Sebastian Reichel
verified it works just fine with > ohci-platform. > > Cc: Roger Quadros <rog...@ti.com> > Cc: Sebastian Reichel <sebastian.reic...@collabora.co.uk> > Signed-off-by: Tony Lindgren <t...@atomide.com> Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.

Re: [PATCH 3/3] mfd: twl: move header file out of I2C realm

2017-05-22 Thread Sebastian Reichel
pply/twl4030_charger.c | 2 +- > [...] Acked-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 3/4] usb: host: ohci-omap3: Print warning to get people to use ohci-platform

2017-05-18 Thread Sebastian Reichel
Hi, On Thu, May 18, 2017 at 07:08:58AM -0700, Tony Lindgren wrote: > * Sebastian Reichel <s...@kernel.org> [170518 02:18]: > > On Wed, May 17, 2017 at 03:59:21PM -0700, Tony Lindgren wrote: > > > We can't just remove ohci-omap3 as that could make some people's > > &

Re: [PATCH 3/4] usb: host: ohci-omap3: Print warning to get people to use ohci-platform

2017-05-18 Thread Sebastian Reichel
Hi, On Wed, May 17, 2017 at 03:59:21PM -0700, Tony Lindgren wrote: > We can't just remove ohci-omap3 as that could make some people's > systems unusable for keyboard and mouse. Let's print a warning for > now, and then remove the driver in a year or so. > > Cc: Hans de Goede

Re: [PATCH] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-21 Thread Sebastian Reichel
gt; Both peripheral and host mode are working for the USB. The > host mode depends on the cpcap-charger driver for VBUS. > > VBUS and ID pin detection are done using cpcap-adc IIO ADC > driver. I tested UART, USB slave (cdc-ether) & USB host (keyboard & touchpad from Atrix lapdock)

Re: v4.9 to v4.10 regression: oops when USB cable is plugged in.

2017-01-27 Thread Sebastian Reichel
Hi, On Fri, Jan 27, 2017 at 10:55:12PM +0100, Pavel Machek wrote: > Ok, I can try. But so far even -rc1 is a lot of fun. But... I consider > phone calls core feature of a phone. I'd very much like to get that to > work. Unfortunately, that means real-time audio, and a lot of > fun. Plus, as it is

Re: [PATCH 03/12] power_supply: axp288_charger: Replace the extcon API

2016-12-06 Thread Sebastian Reichel
Hi Chanwoo, On Tue, Dec 06, 2016 at 09:26:14AM +0900, Chanwoo Choi wrote: > Could you please review and pick the patch3/4 for power-supply driver? Patches look fine. As I expect the merge window to open next week I would rather not queue this for 4.10 and instead do it once 4.10-rc1 has been

Re: [PATCH v6 2/8] power: add power sequence library

2016-08-22 Thread Sebastian Reichel
Hi Peter, On Mon, Aug 22, 2016 at 02:51:58PM +0800, Peter Chen wrote: > On Mon, Aug 15, 2016 at 05:13:12PM +0800, Peter Chen wrote: > > We have an well-known problem that the device needs to do some power > > sequence before it can be recognized by related host, the typical > > example like

Re: [balbi-usb:testing/next 64/67] otg.c:undefined reference to `usb_gadget_vbus_disconnect'

2016-06-20 Thread Sebastian Reichel
r/Kconfig | 1 + > drivers/usb/gadget/udc/udc-core.c | 573 + > drivers/usb/host/Kconfig | 2 +- > drivers/usb/phy/Kconfig | 11 +- > include/linux/usb/gadget.h| 585 > -- > 6 files cha

Re: [RFC 11/15] power: reset: keystone: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Sebastian Reichel
Hi, On Thu, Mar 03, 2016 at 12:00:14PM +0100, Arnd Bergmann wrote: > On Thursday 03 March 2016 17:03:37 Krzysztof Kozlowski wrote: > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > > index 0a6408a39c66..0f34846ae80d 100644 > > --- a/drivers/power/reset/Kconfig > > +++

Re: [PATCH v6 1/4] gadget: Introduce the usb charger framework

2015-12-05 Thread Sebastian Reichel
Hi, On Mon, Nov 16, 2015 at 02:33:31PM +0800, Baolin Wang wrote: > +static ssize_t cur_limit_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct usb_charger *uchger = dev_to_uchger(dev); > + > +

Re: [PATCH v4 5/5] power: wm831x_power: Support USB charger current limit management

2015-09-22 Thread Sebastian Reichel
.@opensource.wolfsonmicro.com> > Acked-by: Peter Chen <peter.c...@freescale.com> Acked-by: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v4 resend 0/2] power: Add an axp20x-usb-power driver

2015-09-22 Thread Sebastian Reichel
Hi, On Sun, Sep 20, 2015 at 08:39:31AM -0400, Hans de Goede wrote: > This is a resend of v4 of the axp20x-usb-power power-supply driver, > after v4 there have been no further comments, so I assume that this > version is ready for merging, yet for some reason it has not been > merged yet. My

Re: [PATCH 2/2] twl4030_charger: find associated phy by more reliable means.

2015-02-25 Thread Sebastian Reichel
Hi Neil, On Tue, Feb 24, 2015 at 03:01:29PM +1100, NeilBrown wrote: twl4030_charger currently finds the associated phy using usb_get_phy() which will return the first USB2 phy. If your platform has multiple such phys (as mine does), this is not reliable (and reliably fails on the GTA04).

Re: [PATCH 2/9] power/reset: brcmstb: Use the DT compatible string to indicate bit positions

2015-01-21 Thread Sebastian Reichel
Hi, On Tue, Nov 25, 2014 at 04:49:47PM -0800, Kevin Cernekee wrote: Some of the older chips used different bits to arm and trigger the reset. Add the infrastructure needed to specify this through the compatible string. Thanks, applied. -- Sebastian signature.asc Description: Digital

Re: [PATCH 1/9] power/reset: brcmstb: Make the driver buildable on MIPS

2015-01-21 Thread Sebastian Reichel
Hi, On Tue, Nov 25, 2014 at 04:49:46PM -0800, Kevin Cernekee wrote: Now that the driver doesn't use any ARM-specific headers, it is safe to build on MIPS or with COMPILE_TEST. Thanks, applied. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 3/9] power/reset: brcmstb: Add support for old 65nm chips

2015-01-21 Thread Sebastian Reichel
Hi, On Tue, Nov 25, 2014 at 04:49:48PM -0800, Kevin Cernekee wrote: The register bit fields are a little different, so add an entry and a compatible string to accommodate them. Thanks, applied. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Sebastian Reichel
On Wed, Jan 08, 2014 at 11:45:38AM +0530, Roger Quadros wrote: diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt index b381fa6..5635202 100644 --- a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt +++

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Sebastian Reichel
Hi, On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: What about the other clocks acquired in drivers/mfd/omap-usb-host.c? Shouldn't all of those be provided by via the DT phandle? All those clocks are identically named across the OMAP SoCs and are unique for each SoC,

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-26 Thread Sebastian Reichel
On Tue, Nov 26, 2013 at 06:10:22PM +0100, Pali Rohár wrote: On Tuesday 19 November 2013 11:51:12 Pali Rohár wrote: For a long time (since 3.5 or 3.8? - I do not remember) obex subdriver in g_nokia usb gadget module causing kernel panic after module is loaded on Nokia N900. I do not know

Re: [PATCH 0/1] Possibly fix USB OTG on GTA04 and N900

2013-10-08 Thread Sebastian Reichel
to work. Tested-by: Sebastian Reichel s...@debian.org -- Sebastian signature.asc Description: Digital signature

Re: [PATCH 4/4] RX-51: Add platform function and data for bq24150a charger

2013-09-09 Thread Sebastian Reichel
Hi Pali, On Sun, Sep 08, 2013 at 10:50:39AM +0200, Pali Rohár wrote: This patch will register bq24150a charger in RX-51 board data. Patch also adding platform function between isp1704 and bq2415x drivers for detecting charger type. So finally charging battery on Nokia N900 (RX-51) working