Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-20 Thread Srinivas Kandagatla
Overall nvmem side looks good! Minor nits below. On 14/06/18 21:08, Loic Poulain wrote: Most of FTDI's devices have an EEPROM which records FTDI devices configuration setting (e.g. the VID, PID, I/O config...) and user data. FT230R chip integrates a 128-byte eeprom, FT230X a 2048-byte eeprom...

Re: [PATCH] USB: serial: ftdi_sio: Add MTP NVM support

2018-06-18 Thread Srinivas Kandagatla
On 18/06/18 09:46, Johan Hovold wrote: On Thu, Jun 14, 2018 at 10:08:46PM +0200, Loic Poulain wrote: Most of FTDI's devices have an EEPROM which records FTDI devices configuration setting (e.g. the VID, PID, I/O config...) and user data. FT230R chip integrates a 128-byte eeprom, FT230X a

Re: [PATCH] usb: echi-hcd: Add register access check in shutdown

2016-05-18 Thread Srinivas Kandagatla
On 18/05/16 15:56, Alan Stern wrote: This doesn't seem like the right place. What you really should do is skip calling ehci_silence_controller() if the hardware isn't accessible. That's where the hardware gets touched, not in ehci_shutdown(). Just tried this suggestion, this would not work

Re: [PATCH] usb: echi-hcd: Add register access check in shutdown

2016-05-18 Thread Srinivas Kandagatla
On 18/05/16 17:15, Alan Stern wrote: On Wed, 18 May 2016, Srinivas Kandagatla wrote: On 18/05/16 15:56, Alan Stern wrote: On Wed, 18 May 2016, Srinivas Kandagatla wrote: This patch adds a check in ehci_shutdown(), to make sure that the register access is available before accessing

Re: [PATCH] usb: echi-hcd: Add register access check in shutdown

2016-05-18 Thread Srinivas Kandagatla
On 18/05/16 15:56, Alan Stern wrote: On Wed, 18 May 2016, Srinivas Kandagatla wrote: This patch adds a check in ehci_shutdown(), to make sure that the register access is available before accessing registers. The use case is simple, for boards like DB410c where the usb host or device

[PATCH] usb: echi-hcd: Add register access check in shutdown

2016-05-18 Thread Srinivas Kandagatla
[] SyS_reboot+0x110/0x21c [] el0_svc_naked+0x24/0x28 Code: 53001c42 35a2 d5033e9f 91002021 (b922) Signed-off-by: Srinivas Kandagatla <srinivas.kandaga...@linaro.org> --- drivers/usb/host/ehci-hcd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/host/ehci-hcd.c b/drive

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

2016-02-22 Thread Srinivas Kandagatla
On 22/02/16 05:32, Bjorn Andersson wrote: On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set to be able to do DMA allocations, so use the of_dma_configure() helper to populate the dma properties and assign an appropriate dma_ops. Signed-off-by: Bjorn Andersson

[PATCH] usb: phy: msm: Trigger USB state detection work in DRD mode

2016-02-05 Thread Srinivas Kandagatla
aro.org> Signed-off-by: Srinivas Kandagatla <srinivas.kandaga...@linaro.org> --- drivers/usb/phy/phy-msm-usb.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c index 970a30e..72b387d 100644 -

Re: [PATCH v2] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-08-21 Thread Srinivas Kandagatla
Thanks Felipe, On 20/08/14 16:57, Felipe Balbi wrote: On Thu, Jul 17, 2014 at 09:16:40PM +0100, Srinivas Kandagatla wrote: This patch makes the phy reset clk and reset line optional as this clk is not available on boards like IFC6410 with APQ8064. phy-reset clk is only used as argument

[PATCH v3] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-08-21 Thread Srinivas Kandagatla
not have this support. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- Hi Felipe, With this new patch now the error message is only printed if the SOC actually supports the phy reset clk, for SOCs like APQ8064 where there is no phy reset clock or the callback which takes

Re: [RFC PATCH 2/3 ] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-07-17 Thread Srinivas Kandagatla
On 17/07/14 13:54, pramod gurav wrote: Hi Srini, On Thu, Jul 17, 2014 at 6:19 PM, pramod.gurav@gmail.com wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org This patch makes the phy reset clk and reset line optional as this clk is not available on boards like IFC6410

Re: [RFC PATCH 2/3 ] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-07-17 Thread Srinivas Kandagatla
On 17/07/14 15:39, Felipe Balbi wrote: Hi, On Thu, Jul 17, 2014 at 02:14:15PM +0100, Srinivas Kandagatla wrote: On 17/07/14 13:54, pramod gurav wrote: Hi Srini, On Thu, Jul 17, 2014 at 6:19 PM, pramod.gurav@gmail.com wrote: From: Srinivas Kandagatla srinivas.kandaga...@linaro.org

[PATCH v2] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-07-17 Thread Srinivas Kandagatla
not have this support. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- Hi Felipe, With this new patch now the error message is only printed if the SOC actually supports the phy reset clk, for SOCs like APQ8064 where there is no phy reset clock or the callback which takes

Re: [RFC PATCH 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Srinivas Kandagatla
Hi Felipe, On 27/06/14 16:54, Felipe Balbi wrote: Hi, On Wed, Jun 18, 2014 at 06:01:08PM +0100, Srinivas Kandagatla wrote: Use case is when the phy is configured in host mode and a usb device is attached to board before bootup. On bootup, with the existing code and runtime pm enabled

Re: [RFC PATCH 0/3] ehci_msm fixes for APQ8064 USB host support.

2014-06-30 Thread Srinivas Kandagatla
Thanks Felipe, On 30/06/14 18:13, Felipe Balbi wrote: Hi, On Wed, Jun 18, 2014 at 06:00:01PM +0100, Srinivas Kandagatla wrote: While testing usb host on Qualcomm APQ8064, I encountered few issues. These patches fixes those issues. Without these patches USB is not functional on AQ8064. All

[PATCH v1 0/3] ehci_msm fixes for APQ8064 USB host support.

2014-06-30 Thread Srinivas Kandagatla
for next rc, as they are just fixes. Thanks, srini Srinivas Kandagatla (3): usb: Kconfig: make EHCI_MSM selectable for QCOM SOCs usb: phy: msm: Make phy_reset clk and reset line optional. usb: phy: msm: Do not do runtime pm if the phy is not idle drivers/usb/host/Kconfig | 2

[PATCH v1 1/3] usb: Kconfig: make EHCI_MSM selectable for QCOM SOCs

2014-06-30 Thread Srinivas Kandagatla
This patch makes the msm ehci driver available to use on QCOM SOCs, which have the same IP. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/usb/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb

[PATCH v1 2/3] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-06-30 Thread Srinivas Kandagatla
This patch makes the phy reset clk and reset line optional as this clk is not available on boards like IFC6410 with APQ8064. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/usb/phy/phy-msm-usb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v1 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Srinivas Kandagatla
This issue was detected on IFC6410 board. This patch fixes the intial runtime pm trigger by checking the phy state and decrementing the pm use count only when the phy state is IDLE. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/usb/phy/phy-msm-usb.c | 4 +++- 1 file

Re: [PATCH v1 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-30 Thread Srinivas Kandagatla
On 30/06/14 18:56, Felipe Balbi wrote: On Mon, Jun 30, 2014 at 06:29:57PM +0100, Srinivas Kandagatla wrote: Use case is when the phy is configured in host mode and a usb device is attached to board before bootup. On bootup, with the existing code and runtime pm enabled, the driver would

Re: [RFC PATCH 0/3] ehci_msm fixes for APQ8064 USB host support.

2014-06-26 Thread Srinivas Kandagatla
Is it possible to queue these patches for next rc? Thanks, srini On 18/06/14 18:00, Srinivas Kandagatla wrote: While testing usb host on Qualcomm APQ8064, I encountered few issues. These patches fixes those issues. Without these patches USB is not functional on AQ8064. All the patches

[RFC PATCH 0/3] ehci_msm fixes for APQ8064 USB host support.

2014-06-18 Thread Srinivas Kandagatla
While testing usb host on Qualcomm APQ8064, I encountered few issues. These patches fixes those issues. Without these patches USB is not functional on AQ8064. All the patches are tested on IFC6410. Thanks, srini Srinivas Kandagatla (3): usb: Kconfig: make EHCI_MSM selectable for QCOM SOCs

[RFC PATCH 1/3] usb: Kconfig: make EHCI_MSM selectable for QCOM SOCs

2014-06-18 Thread Srinivas Kandagatla
This patch makes the msm ehci driver available to use on QCOM SOCs, which have the same IP. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/usb/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb

[RFC PATCH 2/3] usb: phy: msm: Make phy_reset clk and reset line optional.

2014-06-18 Thread Srinivas Kandagatla
This patch makes the phy reset clk and reset line optional as this clk is not available on boards like IFC6410 with APQ8064. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/usb/phy/phy-msm-usb.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[RFC PATCH 3/3] usb: phy: msm: Do not do runtime pm if the phy is not idle

2014-06-18 Thread Srinivas Kandagatla
This issue was detected on IFC6410 board. This patch fixes the intial runtime pm trigger by checking the phy state and decrementing the pm use count only when the phy state is IDLE. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@linaro.org --- drivers/usb/phy/phy-msm-usb.c | 4 +++- 1 file

Re: [PATCH v3 1/3] usb: chipidea: msm: Add device tree binding information

2014-04-22 Thread Srinivas Kandagatla
On 22/04/14 10:43, Ivan T. Ivanov wrote: +- interrupts: interrupt-specifier for the controller interrupt. +- usb-phy: phandle for the PHY device +- dr_mode: Sould be peripheral s/Sould/Should/ + -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of

[PATCH 3.6.0- 0/7] USB: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla srinivas.kandaga...@st.com Running below Coccinelle lookup pattern like below on the latest kernel showed about 52 hits. This patch series is a subset of those 52 patches, so that it will be easy for maintainers to review. Hopefully these patches will get rid of some

[PATCH 3.6.0- 1/7] usb/am35x: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@st.com --- drivers/usb/musb/am35x.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff

[PATCH 3.6.0- 2/7] usb/blackfin: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@st.com --- drivers/usb/musb/blackfin.c | 13 + 1 files changed, 1 insertions(+), 12 deletions

[PATCH 3.6.0- 4/7] usb/davinci: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@st.com --- drivers/usb/musb/davinci.c | 13 + 1 files changed, 1 insertions(+), 12 deletions

[PATCH 3.6.0- 7/7] usb/mv_otg: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@st.com --- drivers/usb/otg/mv_otg.c | 14 +- 1 files changed, 1 insertions(+), 13 deletions

[PATCH 3.6.0- 5/7] usb/tusb6010: use module_platform_driver macro

2012-10-10 Thread Srinivas KANDAGATLA
From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch removes some code duplication by using module_platform_driver. Signed-off-by: Srinivas Kandagatla srinivas.kandaga...@st.com --- drivers/usb/musb/tusb6010.c | 13 + 1 files changed, 1 insertions(+), 12 deletions